217590 2020-10-11 15:41:36 -0700 -Wreorder in MediaPlayerPrivateRemote.cpp 2020-10-11 17:17:16 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro eric.carlson ews-watchlist glenn jer.noble mcatanzaro philipj sergio stephan.szabo webkit-bug-importer oldest_to_newest 1696717 0 mcatanzaro 2020-10-11 15:41:36 -0700 -Wreorder indicates the constructor's initializer list is misleading: [2116/2435] Building CXX object Source/WebKit/CMakeFiles/...ces/WebKit/unified-sources/UnifiedSource-54928a2b-2.cpp.o In file included from ../../Source/WebKit/WebProcess/GPU/media/AudioTrackPrivateRemote.cpp:32, from DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-2.cpp:7: ../../Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h: In constructor ‘WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote(WebCore::MediaPlayer*, WebCore::MediaPlayerEnums::MediaEngineIdentifier, WebCore::MediaPlayerIdentifier, WebKit::RemoteMediaPlayerManager&)’: ../../Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h:362:27: warning: ‘WebKit::MediaPlayerPrivateRemote::m_player’ will be initialized after [-Wreorder] 362 | WebCore::MediaPlayer* m_player { nullptr }; | ^~~~~~~~ ../../Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h:159:23: warning: ‘WTF::Ref<const WTF::Logger, WTF::DumbPtrTraits<const WTF::Logger> > WebKit::MediaPlayerPrivateRemote::m_logger’ [-Wreorder] 159 | Ref<const Logger> m_logger; | ^~~~~~~~ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-2.cpp:8: ../../Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:94:1: warning: when initialized here [-Wreorder] 94 | MediaPlayerPrivateRemote::MediaPlayerPrivateRemote(MediaPlayer* player, MediaPlayerEnums::MediaEngineIdentifier engineIdentifier, MediaPlayerIdentifier playerIdentifier, RemoteMediaPlayerManager& manager) | ^~~~~~~~~~~~~~~~~~~~~~~~ 1696722 1 411074 mcatanzaro 2020-10-11 15:49:04 -0700 Created attachment 411074 Patch 1696739 2 ews-feeder 2020-10-11 17:16:57 -0700 Committed r268328: <https://trac.webkit.org/changeset/268328> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411074. 1696740 3 webkit-bug-importer 2020-10-11 17:17:16 -0700 <rdar://problem/70188351> 411074 2020-10-11 15:49:04 -0700 2020-10-11 17:16:57 -0700 Patch bug-217590-20201011174903.patch text/plain 2072 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDliMDIxYjY2N2UyOGYzYjNl OWRhNzcxY2ZhZDliYzJmYWU3YzQwMDEuLjkwMWJiNWNmZGFmN2Y1NDkxNGNlMjhiYTIzNGI3YTdh MGJiODQwMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMTAtMTEgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgLVdyZW9yZGVyIGlu IE1lZGlhUGxheWVyUHJpdmF0ZVJlbW90ZS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzU5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlb3JkZXIgaW5pdGlhbGl6ZXIgbGlzdCB0byBhdm9pZCBt aXNsZWFkaW5nIGluaXRpYWxpemF0aW9uIG9yZGVyLgorCisgICAgICAgIEl0IG1pZ2h0IGJlIG5p Y2VyIHRvIGFjdHVhbGx5IHJlb3JkZXIgdGhlIG1lbWJlciB2YXJpYWJsZXMgaW4gdGhlIGNsYXNz IGl0c2VsZiwgd2hpY2ggd291bGQKKyAgICAgICAgcHJvYmFibHkgYmUgc2FmZSwgYnV0IHRoYXQg d291bGQgYmUgYSBiZWhhdmlvciBjaGFuZ2UgYW5kIEknZCByYXRoZXIgYXZvaWQgY2hhbmdpbmcK KyAgICAgICAgYmVoYXZpb3IuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQVS9tZWRpYS9NZWRp YVBsYXllclByaXZhdGVSZW1vdGUuY3BwOgorICAgICAgICAoV2ViS2l0OjpNZWRpYVBsYXllclBy aXZhdGVSZW1vdGU6Ok1lZGlhUGxheWVyUHJpdmF0ZVJlbW90ZSk6CisKIDIwMjAtMTAtMTAgIFNh bSBXZWluaWcgIDx3ZWluaWdAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBXZWJQcmVmZXJlbmNl IGRlZmluaXRpb25zIGZyb20gc2hhcmVkIGNvbmZpZ3VyYXRpb24gZmlsZXMgaW4gV2ViQ29yZSAo UGFydCAxKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9tZWRpYS9N ZWRpYVBsYXllclByaXZhdGVSZW1vdGUuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQ VS9tZWRpYS9NZWRpYVBsYXllclByaXZhdGVSZW1vdGUuY3BwCmluZGV4IDA5ZDE0ZDFiM2IwYzA4 M2RiOTEyZGY0MjI4MzRhMzRiMjkwZWU4ZDMuLjg5ZDZmZTlhOGZiMzIzODRhMjdlNDI0Zjc5OTky ZTRkYzQ0YzE5NzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvbWVk aWEvTWVkaWFQbGF5ZXJQcml2YXRlUmVtb3RlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvR1BVL21lZGlhL01lZGlhUGxheWVyUHJpdmF0ZVJlbW90ZS5jcHAKQEAgLTkyLDExICs5 MiwxMyBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogI2lmICFQTEFURk9STShDT0NPQSkK IE1lZGlhUGxheWVyUHJpdmF0ZVJlbW90ZTo6TWVkaWFQbGF5ZXJQcml2YXRlUmVtb3RlKE1lZGlh UGxheWVyKiBwbGF5ZXIsIE1lZGlhUGxheWVyRW51bXM6Ok1lZGlhRW5naW5lSWRlbnRpZmllciBl bmdpbmVJZGVudGlmaWVyLCBNZWRpYVBsYXllcklkZW50aWZpZXIgcGxheWVySWRlbnRpZmllciwg UmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyJiBtYW5hZ2VyKQotICAgIDogbV9wbGF5ZXIocGxheWVy KQorICAgIDoKICNpZiAhUkVMRUFTRV9MT0dfRElTQUJMRUQKLSAgICAsIG1fbG9nZ2VyKHBsYXll ci0+bWVkaWFQbGF5ZXJMb2dnZXIoKSkKKyAgICAgIG1fbG9nZ2VyKHBsYXllci0+bWVkaWFQbGF5 ZXJMb2dnZXIoKSkKICAgICAsIG1fbG9nSWRlbnRpZmllcihwbGF5ZXItPm1lZGlhUGxheWVyTG9n SWRlbnRpZmllcigpKQorICAgICwKICNlbmRpZgorICAgICAgbV9wbGF5ZXIocGxheWVyKQogICAg ICwgbV9tZWRpYVJlc291cmNlTG9hZGVyKCpwbGF5ZXItPmNyZWF0ZVJlc291cmNlTG9hZGVyKCkp CiAgICAgLCBtX21hbmFnZXIobWFuYWdlcikKICAgICAsIG1fcmVtb3RlRW5naW5lSWRlbnRpZmll cihlbmdpbmVJZGVudGlmaWVyKQo=