21758 2008-10-20 13:02:41 -0700 A little more PLATFORM(CHROMIUM) in WebCore 2008-10-22 00:57:33 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd alp oldest_to_newest 96031 0 fishd 2008-10-20 13:02:41 -0700 A little more PLATFORM(CHROMIUM) in WebCore This change covers: platform/graphics/Icon.h page/AccessibilityObject.h 96032 1 24529 fishd 2008-10-20 13:04:10 -0700 Created attachment 24529 v1 patch Simple PLATFORM(CHROMIUM) change. 96047 2 24529 alp 2008-10-20 16:30:14 -0700 Comment on attachment 24529 v1 patch >Index: ChangeLog >=================================================================== >--- ChangeLog (revision 37744) >+++ ChangeLog (working copy) >@@ -1,3 +1,13 @@ >+2008-10-20 Darin Fisher <darin@chromium.org> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ A little more PLATFORM(CHROMIUM) in WebCore >+ https://bugs.webkit.org/show_bug.cgi?id=21758 >+ >+ * page/AccessibilityObject.h: >+ * platform/graphics/Icon.h: >+ > 2008-10-20 Alp Toker <alp@nuanti.com> > > Fix autotools dist build target by listing recently added header >Index: page/AccessibilityObject.h >=================================================================== >--- page/AccessibilityObject.h (revision 37733) >+++ page/AccessibilityObject.h (working copy) >@@ -40,6 +40,8 @@ > #elif PLATFORM(WIN) > #include "AccessibilityObjectWrapperWin.h" > #include "COMPtr.h" >+#elif PLATFORM(CHROMIUM) >+#include "AccessibilityObjectWrapper.h" > #endif > > typedef struct _NSRange NSRange; >@@ -407,6 +409,8 @@ protected: > COMPtr<AccessibilityObjectWrapper> m_wrapper; > #elif PLATFORM(GTK) > AtkObject* m_wrapper; >+#elif PLATFORM(CHROMIUM) >+ RefPtr<AccessibilityObjectWrapper> m_wrapper; > #endif > }; > It's difficult to review this patch without context. Wouldn't PLATFORM(CHROMIUM) re-use one of the existing accessibility implementations depending on the platform (MSAA, ATK etc.)? If this patch is simply a build fix, you may be better served by looking for a way to disable accessibility in your port for now, for example using ENABLE(ACCESSIBILITY). Not marking r- but this one needs some clarification from the submitter. 96048 3 fishd 2008-10-20 17:03:18 -0700 Hi Alp. Thanks for the great question. It turns out that using traditional a11y APIs directly from the sandboxed chromium renderer simply doesn't work. We have to marshal everything out of the sandbox. This is best accomplished using platform independent code, so for us the AccessibilityObjectWrapper really shouldn't be COM or ATK or any other platform specific technology. Does that make sense? 96110 4 24529 eric 2008-10-21 14:53:51 -0700 Comment on attachment 24529 v1 patch Looks sane enough. 96149 5 fishd 2008-10-22 00:57:33 -0700 http://trac.webkit.org/changeset/37776 24529 2008-10-20 13:04:10 -0700 2008-10-21 14:53:51 -0700 v1 patch platform_chromium_1.diff text/plain 1771 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3NzQ0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTAt MjAgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIGxpdHRsZSBtb3JlIFBMQVRGT1JNKENI Uk9NSVVNKSBpbiBXZWJDb3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTc1OAorCisgICAgICAgICogcGFnZS9BY2Nlc3NpYmlsaXR5T2JqZWN0Lmg6 CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvSWNvbi5oOgorCiAyMDA4LTEwLTIwICBBbHAg VG9rZXIgIDxhbHBAbnVhbnRpLmNvbT4KIAogICAgICAgICBGaXggYXV0b3Rvb2xzIGRpc3QgYnVp bGQgdGFyZ2V0IGJ5IGxpc3RpbmcgcmVjZW50bHkgYWRkZWQgaGVhZGVyCkluZGV4OiBwYWdlL0Fj Y2Vzc2liaWxpdHlPYmplY3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBwYWdlL0FjY2Vzc2liaWxpdHlPYmpl Y3QuaAkocmV2aXNpb24gMzc3MzMpCisrKyBwYWdlL0FjY2Vzc2liaWxpdHlPYmplY3QuaAkod29y a2luZyBjb3B5KQpAQCAtNDAsNiArNDAsOCBAQAogI2VsaWYgUExBVEZPUk0oV0lOKQogI2luY2x1 ZGUgIkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyV2luLmgiCiAjaW5jbHVkZSAiQ09NUHRyLmgi CisjZWxpZiBQTEFURk9STShDSFJPTUlVTSkKKyNpbmNsdWRlICJBY2Nlc3NpYmlsaXR5T2JqZWN0 V3JhcHBlci5oIgogI2VuZGlmCiAKIHR5cGVkZWYgc3RydWN0IF9OU1JhbmdlIE5TUmFuZ2U7CkBA IC00MDcsNiArNDA5LDggQEAgcHJvdGVjdGVkOgogICAgIENPTVB0cjxBY2Nlc3NpYmlsaXR5T2Jq ZWN0V3JhcHBlcj4gbV93cmFwcGVyOwogI2VsaWYgUExBVEZPUk0oR1RLKQogICAgIEF0a09iamVj dCogbV93cmFwcGVyOworI2VsaWYgUExBVEZPUk0oQ0hST01JVU0pCisgICAgUmVmUHRyPEFjY2Vz c2liaWxpdHlPYmplY3RXcmFwcGVyPiBtX3dyYXBwZXI7CiAjZW5kaWYKIH07CiAKSW5kZXg6IHBs YXRmb3JtL2dyYXBoaWNzL0ljb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBwbGF0Zm9ybS9ncmFwaGljcy9J Y29uLmgJKHJldmlzaW9uIDM3NzMzKQorKysgcGxhdGZvcm0vZ3JhcGhpY3MvSWNvbi5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0zOCw2ICszOCw4IEBAIHR5cGVkZWYgc3RydWN0IEhJQ09OX18qIEhJQ09O OwogI2luY2x1ZGUgPFFJY29uPgogI2VsaWYgUExBVEZPUk0oR1RLKQogdHlwZWRlZiBzdHJ1Y3Qg X0dka1BpeGJ1ZiBHZGtQaXhidWY7CisjZWxpZiBQTEFURk9STShDSFJPTUlVTSkKKyNpbmNsdWRl ICJQbGF0Zm9ybUljb24uaCIKICNlbmRpZgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC03MCw2 ICs3Miw5IEBAIHByaXZhdGU6CiAjZWxpZiBQTEFURk9STShHVEspCiAgICAgSWNvbigpOwogICAg IEdka1BpeGJ1ZiogbV9pY29uOworI2VsaWYgUExBVEZPUk0oQ0hST01JVU0pCisgICAgSWNvbihj b25zdCBQbGF0Zm9ybUljb24mKTsKKyAgICBQbGF0Zm9ybUljb24gbV9pY29uOwogI2VuZGlmCiB9 OwogCg==