21757 2008-10-20 12:58:29 -0700 Should not define PLATFORM(WIN,MAC,GTK) when PLATFORM(CHROMIUM) is defined 2008-10-22 09:47:46 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd oldest_to_newest 96029 0 fishd 2008-10-20 12:58:29 -0700 Should not define PLATFORM(WIN,MAC,GTK) when PLATFORM(CHROMIUM) is defined PLATFORM(CHROMIUM) also implies HAVE_ACCESSIBILITY. 96030 1 24528 fishd 2008-10-20 13:00:57 -0700 Created attachment 24528 v1 patch Simple PLATFORM(CHROMIUM) change. 96107 2 24528 eric 2008-10-21 14:45:49 -0700 Comment on attachment 24528 v1 patch The platform.h changes look wrong. I see an added #if w/o any #endif 96148 3 24553 fishd 2008-10-22 00:52:46 -0700 Created attachment 24553 v1.1 patch Yes, that's unfortunate. I uploaded the wrong version of the patch :( Now, with glorious #elif goodness. 96171 4 24553 eric 2008-10-22 08:15:46 -0700 Comment on attachment 24553 v1.1 patch Looks fine. I think eventually much of this HAVE_* goop needs to move out of Platform.h, but that's not really relevant to this patch. 96189 5 fishd 2008-10-22 09:47:46 -0700 http://trac.webkit.org/changeset/37783 24528 2008-10-20 13:00:57 -0700 2008-10-22 00:52:46 -0700 v1 patch platform_1.diff text/plain 1388 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3NzQ0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTAt MjAgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaG91bGQgbm90IGRlZmluZSBQTEFURk9S TShXSU4sTUFDLEdUSykgd2hlbiBQTEFURk9STShDSFJPTUlVTSkgaXMgZGVmaW5lZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3NTcKKworICAgICAg ICBQTEFURk9STShDSFJPTUlVTSkgaW1wbGllcyBIQVZFX0FDQ0VTU0lCSUxJVFkKKworICAgICAg ICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDA4LTEwLTIwICBBbHAgVG9rZXIgIDxhbHBAbnVhbnRp LmNvbT4KIAogICAgICAgICBGaXggYXV0b3Rvb2xzIGRpc3QgYnVpbGQgdGFyZ2V0IGJ5IGxpc3Rp bmcgcmVjZW50bHkgYWRkZWQgaGVhZGVyCkluZGV4OiB3dGYvUGxhdGZvcm0uaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSB3dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gMzc3MzMpCisrKyB3dGYvUGxhdGZvcm0uaAko d29ya2luZyBjb3B5KQpAQCAtOTEsMTcgKzkxLDE1IEBACiAjZGVmaW5lIFdURl9QTEFURk9STV9V TklYIDEKICNlbmRpZgogCi0vKiBQTEFURk9STShDSFJPTUlVTSkgKi8KLSNpZiBkZWZpbmVkKEJV SUxESU5HX0NIUk9NSVVNX18pCi0jZGVmaW5lIFdURl9QTEFURk9STV9DSFJPTUlVTSAxCi0jZW5k aWYKLQogLyogT3BlcmF0aW5nIGVudmlyb25tZW50cyAqLwogCisvKiBQTEFURk9STShDSFJPTUlV TSkgKi8KIC8qIFBMQVRGT1JNKFFUKSAqLwogLyogUExBVEZPUk0oR1RLKSAqLwogLyogUExBVEZP Uk0oTUFDKSAqLwogLyogUExBVEZPUk0oV0lOKSAqLworI2lmIGRlZmluZWQoQlVJTERJTkdfQ0hS T01JVU1fXykKKyNkZWZpbmUgV1RGX1BMQVRGT1JNX0NIUk9NSVVNIDEKICNpZiBkZWZpbmVkKEJV SUxESU5HX1FUX18pCiAjZGVmaW5lIFdURl9QTEFURk9STV9RVCAxCiAKQEAgLTI4MSw3ICsyNzks NyBAQAogI2VuZGlmCiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oV0lO KSB8fCBQTEFURk9STShHVEspCisjaWYgUExBVEZPUk0oTUFDKSB8fCBQTEFURk9STShXSU4pIHx8 IFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oQ0hST01JVU0pCiAjZGVmaW5lIEhBVkVfQUNDRVNT SUJJTElUWSAxCiAjZW5kaWYKIAo= 24553 2008-10-22 00:52:46 -0700 2008-10-22 08:15:46 -0700 v1.1 patch platform_1.1.diff text/plain 1439 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3NzQ0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTAt MjAgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaG91bGQgbm90IGRlZmluZSBQTEFURk9S TShXSU4sTUFDLEdUSykgd2hlbiBQTEFURk9STShDSFJPTUlVTSkgaXMgZGVmaW5lZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3NTcKKworICAgICAg ICBQTEFURk9STShDSFJPTUlVTSkgaW1wbGllcyBIQVZFX0FDQ0VTU0lCSUxJVFkKKworICAgICAg ICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDA4LTEwLTIwICBBbHAgVG9rZXIgIDxhbHBAbnVhbnRp LmNvbT4KIAogICAgICAgICBGaXggYXV0b3Rvb2xzIGRpc3QgYnVpbGQgdGFyZ2V0IGJ5IGxpc3Rp bmcgcmVjZW50bHkgYWRkZWQgaGVhZGVyCkluZGV4OiB3dGYvUGxhdGZvcm0uaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSB3dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gMzc3MzMpCisrKyB3dGYvUGxhdGZvcm0uaAko d29ya2luZyBjb3B5KQpAQCAtOTEsMTggKzkxLDE2IEBACiAjZGVmaW5lIFdURl9QTEFURk9STV9V TklYIDEKICNlbmRpZgogCi0vKiBQTEFURk9STShDSFJPTUlVTSkgKi8KLSNpZiBkZWZpbmVkKEJV SUxESU5HX0NIUk9NSVVNX18pCi0jZGVmaW5lIFdURl9QTEFURk9STV9DSFJPTUlVTSAxCi0jZW5k aWYKLQogLyogT3BlcmF0aW5nIGVudmlyb25tZW50cyAqLwogCisvKiBQTEFURk9STShDSFJPTUlV TSkgKi8KIC8qIFBMQVRGT1JNKFFUKSAqLwogLyogUExBVEZPUk0oR1RLKSAqLwogLyogUExBVEZP Uk0oTUFDKSAqLwogLyogUExBVEZPUk0oV0lOKSAqLwotI2lmIGRlZmluZWQoQlVJTERJTkdfUVRf XykKKyNpZiBkZWZpbmVkKEJVSUxESU5HX0NIUk9NSVVNX18pCisjZGVmaW5lIFdURl9QTEFURk9S TV9DSFJPTUlVTSAxCisjZWxpZiBkZWZpbmVkKEJVSUxESU5HX1FUX18pCiAjZGVmaW5lIFdURl9Q TEFURk9STV9RVCAxCiAKIC8qIFBMQVRGT1JNKEtERSkgKi8KQEAgLTI4MSw3ICsyNzksNyBAQAog I2VuZGlmCiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oV0lOKSB8fCBQ TEFURk9STShHVEspCisjaWYgUExBVEZPUk0oTUFDKSB8fCBQTEFURk9STShXSU4pIHx8IFBMQVRG T1JNKEdUSykgfHwgUExBVEZPUk0oQ0hST01JVU0pCiAjZGVmaW5lIEhBVkVfQUNDRVNTSUJJTElU WSAxCiAjZW5kaWYKIAo=