<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>217543</bug_id>
          
          <creation_ts>2020-10-09 17:16:47 -0700</creation_ts>
          <short_desc>[ macOS ] webaudio/OfflineAudioContext/onstatechange.html is a flaky failure</short_desc>
          <delta_ts>2020-11-02 13:21:50 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Audio</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Hector Lopez">hector_i_lopez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>achristensen</cc>
    
    <cc>cdumez</cc>
    
    <cc>darin</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>ggaren</cc>
    
    <cc>glenn</cc>
    
    <cc>jer.noble</cc>
    
    <cc>philipj</cc>
    
    <cc>sam</cc>
    
    <cc>sergio</cc>
    
    <cc>webkit-bot-watchers-bugzilla</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1696410</commentid>
    <comment_count>0</comment_count>
    <who name="Hector Lopez">hector_i_lopez</who>
    <bug_when>2020-10-09 17:16:47 -0700</bug_when>
    <thetext>webaudio/OfflineAudioContext/onstatechange.html


Test is a flaky failure according to history on macOS. First occurrence coincides with import at r267307

History:

https://results.webkit.org/?suite=layout-tests&amp;test=webaudio%2FOfflineAudioContext%2Fonstatechange.html&amp;platform=mac&amp;limit=50000

Diff:

--- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/webaudio/OfflineAudioContext/onstatechange-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/webaudio/OfflineAudioContext/onstatechange-actual.txt
@@ -3,11 +3,11 @@
 PASS Executing &quot;test&quot;
 PASS Audit report
 PASS &gt; [test] Signaling of statechange event
-PASS   context.state is equal to running.
+FAIL X context.state is not equal to running. Got closed. assert_true: expected true got false
+PASS   Context rendering resolved correctly.
 PASS   context.state is equal to closed.
-PASS   Context rendering resolved correctly.
 PASS   stateChangeCount is equal to 2.
 PASS   After rendering context.state is equal to closed.
-PASS &lt; [test] All assertions passed. (total 5 assertions)
-PASS # AUDIT TASK RUNNER FINISHED: 1 tasks ran successfully.
+FAIL &lt; [test] 1 out of 5 assertions were failed. assert_true: expected true got false
+FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed. assert_true: expected true got false</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1696411</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-10-09 17:17:06 -0700</bug_when>
    <thetext>&lt;rdar://problem/70160122&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1696415</commentid>
    <comment_count>2</comment_count>
    <who name="Hector Lopez">hector_i_lopez</who>
    <bug_when>2020-10-09 17:21:41 -0700</bug_when>
    <thetext>Test expectation while investigated:

https://trac.webkit.org/changeset/268303/webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1703638</commentid>
    <comment_count>3</comment_count>
      <attachid>412960</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-11-02 12:23:27 -0800</bug_when>
    <thetext>Created attachment 412960
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1703641</commentid>
    <comment_count>4</comment_count>
      <attachid>412960</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2020-11-02 12:34:05 -0800</bug_when>
    <thetext>Comment on attachment 412960
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412960&amp;action=review

&gt; Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp:105
&gt; +        callOnMainThread([this, result, currentSampleFrame = m_currentSampleFrame, protectedThis = WTFMove(protectedThis)]() mutable {
&gt; +            context().postTask([this, protectedThis = WTFMove(protectedThis), result, currentSampleFrame]() mutable {

Doesn’t seem like we need callOnMainThread if calling postTask. It already does callOnMainThread.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1703642</commentid>
    <comment_count>5</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2020-11-02 12:34:35 -0800</bug_when>
    <thetext>Oops, didn’t mean to change this to darin/review?

Don’t know why bugs.webkit.org does that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1703644</commentid>
    <comment_count>6</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-11-02 12:35:06 -0800</bug_when>
    <thetext>(In reply to Darin Adler from comment #4)
&gt; Comment on attachment 412960 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=412960&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp:105
&gt; &gt; +        callOnMainThread([this, result, currentSampleFrame = m_currentSampleFrame, protectedThis = WTFMove(protectedThis)]() mutable {
&gt; &gt; +            context().postTask([this, protectedThis = WTFMove(protectedThis), result, currentSampleFrame]() mutable {
&gt; 
&gt; Doesn’t seem like we need callOnMainThread if calling postTask. It already
&gt; does callOnMainThread.

I think you are looking at the wrong postTask?

void BaseAudioContext::postTask(WTF::Function&lt;void()&gt;&amp;&amp; task)
{
    ASSERT(isMainThread());
    if (m_isStopScheduled)
        return;

    queueTaskKeepingObjectAlive(*this, TaskSource::MediaElement, WTFMove(task));
}</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1703645</commentid>
    <comment_count>7</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2020-11-02 12:35:27 -0800</bug_when>
    <thetext>OK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1703646</commentid>
    <comment_count>8</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2020-11-02 12:35:52 -0800</bug_when>
    <thetext>Alex said review+. Alex, want to do it again so bugs.webkit.org has the record?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1703647</commentid>
    <comment_count>9</comment_count>
      <attachid>412961</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-11-02 12:37:32 -0800</bug_when>
    <thetext>Created attachment 412961
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1703669</commentid>
    <comment_count>10</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-11-02 13:21:49 -0800</bug_when>
    <thetext>Committed r269271: &lt;https://trac.webkit.org/changeset/269271&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412961.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>412960</attachid>
            <date>2020-11-02 12:23:27 -0800</date>
            <delta_ts>2020-11-02 12:37:30 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-217543-20201102122327.patch</filename>
            <type>text/plain</type>
            <size>6012</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MjUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTVhZjFmOTJlNTJlY2Vj
ZGViN2EzOTM5NGJjMzM4NzcxMDYzMzAyYi4uZWQ3MWZhOTUxZDAzNzVjZjJlMjM5YjJiZTkzNWI3
MDgzYTBiNGY0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTExLTAyICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgWyBtYWNPUyBdIHdlYmF1ZGlv
L09mZmxpbmVBdWRpb0NvbnRleHQvb25zdGF0ZWNoYW5nZS5odG1sIGlzIGEgZmxha3kgZmFpbHVy
ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3NTQz
CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MDE2MDEyMj4KKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHVuc2tpcHBlZCBleGlz
dGluZyB0ZXN0LgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9PZmZsaW5lQXVkaW9EZXN0
aW5hdGlvbk5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6T2ZmbGluZUF1ZGlvRGVzdGluYXRp
b25Ob2RlOjpzdGFydFJlbmRlcmluZyk6CisgICAgICAgIEFmdGVyIG9mZmxpbmUgcmVuZGVyaW5n
IG9uIHRoZSBhdWRpbyB0aHJlYWQgYW5kIHdlIGdvIGJhY2sgdG8gdGhlIG1haW4gdGhyZWFkLCBt
YWtlIHN1cmUgd2UgcXVldWUgYSB0YXNrIG9mIHRoZQorICAgICAgICBldmVudCBsb29wIHRvIGZp
cmUgdGhlIHN0YXRlY2hhbmdlIGFuZCBjb21wbGV0aW9uIGV2ZW50cy4gV2Ugd2VyZSBwcmV2aW91
c2x5IGZhaWxpbmcgdG8gZG8gc28gYW5kIHRoYXQgbWVhbnQKKyAgICAgICAgdGhhdCB0aGUgb3Jk
ZXJpbmcgd2l0aCBvdGhlciBtYWluIHRocmVhZCBldmVudHMgKHdoaWNoIHdlcmUgcXVldWVkIG9u
IHRoZSBldmVudCBsb29wKSB3YXMgbm90IGFsd2F5cyBjb3JyZWN0LgorCiAyMDIwLTExLTAyICBN
YXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR0xJQl0g
UkVHUkVTU0lPTihyMjY5MTQ0KSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9j
c3NvbS12aWV3L3Njcm9sbEludG9WaWV3LXNjcm9sbE1hcmdpbi5odG1sIGlzIGZhaWxpbmcKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vT2ZmbGluZUF1ZGlvRGVz
dGluYXRpb25Ob2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vT2ZmbGlu
ZUF1ZGlvRGVzdGluYXRpb25Ob2RlLmNwcAppbmRleCA0NTJlNmZiODY3YzcxNTRlZjE2YzNkZjM3
NzM3Y2M3Y2Y1NTNkYjdlLi41YjBiNjJjYWU0Y2Y1NTE2YTkyY2U3NTdiZDIyNjBhOTcwMzZmNzI2
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL09mZmxpbmVBdWRp
b0Rlc3RpbmF0aW9uTm9kZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRp
by9PZmZsaW5lQXVkaW9EZXN0aW5hdGlvbk5vZGUuY3BwCkBAIC0xMDEsMTkgKzEwMSwyMSBAQCB2
b2lkIE9mZmxpbmVBdWRpb0Rlc3RpbmF0aW9uTm9kZTo6c3RhcnRSZW5kZXJpbmcoQ29tcGxldGlv
bkhhbmRsZXI8dm9pZChPcHRpb25hbAogCiAgICAgYXV0byBvZmZUaHJlYWRSZW5kZXJpbmcgPSBb
dGhpcywgcHJvdGVjdGVkVGhpcyA9IFdURk1vdmUocHJvdGVjdGVkVGhpcyldKCkgbXV0YWJsZSB7
CiAgICAgICAgIGF1dG8gcmVzdWx0ID0gb2ZmbGluZVJlbmRlcigpOwotICAgICAgICBjYWxsT25N
YWluVGhyZWFkKFt0aGlzLCByZXN1bHQsIGN1cnJlbnRTYW1wbGVGcmFtZSA9IG1fY3VycmVudFNh
bXBsZUZyYW1lLCBwcm90ZWN0ZWRUaGlzID0gV1RGTW92ZShwcm90ZWN0ZWRUaGlzKV0gewotICAg
ICAgICAgICAgbV9zdGFydGVkUmVuZGVyaW5nID0gZmFsc2U7Ci0gICAgICAgICAgICBzd2l0Y2gg
KHJlc3VsdCkgewotICAgICAgICAgICAgY2FzZSBPZmZsaW5lUmVuZGVyUmVzdWx0OjpGYWlsdXJl
OgotICAgICAgICAgICAgICAgIGNvbnRleHQoKS5maW5pc2hlZFJlbmRlcmluZyhmYWxzZSk7Ci0g
ICAgICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgICAgICBjYXNlIE9mZmxpbmVSZW5kZXJSZXN1
bHQ6OkNvbXBsZXRlOgotICAgICAgICAgICAgICAgIGNvbnRleHQoKS5maW5pc2hlZFJlbmRlcmlu
Zyh0cnVlKTsKLSAgICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgICAgIGNhc2UgT2ZmbGlu
ZVJlbmRlclJlc3VsdDo6U3VzcGVuZGVkOgotICAgICAgICAgICAgICAgIGNvbnRleHQoKS5kaWRT
dXNwZW5kUmVuZGVyaW5nKGN1cnJlbnRTYW1wbGVGcmFtZSk7Ci0gICAgICAgICAgICAgICAgYnJl
YWs7Ci0gICAgICAgICAgICB9CisgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW3RoaXMsIHJlc3Vs
dCwgY3VycmVudFNhbXBsZUZyYW1lID0gbV9jdXJyZW50U2FtcGxlRnJhbWUsIHByb3RlY3RlZFRo
aXMgPSBXVEZNb3ZlKHByb3RlY3RlZFRoaXMpXSgpIG11dGFibGUgeworICAgICAgICAgICAgY29u
dGV4dCgpLnBvc3RUYXNrKFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gV1RGTW92ZShwcm90ZWN0ZWRU
aGlzKSwgcmVzdWx0LCBjdXJyZW50U2FtcGxlRnJhbWVdKCkgbXV0YWJsZSB7CisgICAgICAgICAg
ICAgICAgbV9zdGFydGVkUmVuZGVyaW5nID0gZmFsc2U7CisgICAgICAgICAgICAgICAgc3dpdGNo
IChyZXN1bHQpIHsKKyAgICAgICAgICAgICAgICBjYXNlIE9mZmxpbmVSZW5kZXJSZXN1bHQ6OkZh
aWx1cmU6CisgICAgICAgICAgICAgICAgICAgIGNvbnRleHQoKS5maW5pc2hlZFJlbmRlcmluZyhm
YWxzZSk7CisgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAgIGNhc2Ug
T2ZmbGluZVJlbmRlclJlc3VsdDo6Q29tcGxldGU6CisgICAgICAgICAgICAgICAgICAgIGNvbnRl
eHQoKS5maW5pc2hlZFJlbmRlcmluZyh0cnVlKTsKKyAgICAgICAgICAgICAgICAgICAgYnJlYWs7
CisgICAgICAgICAgICAgICAgY2FzZSBPZmZsaW5lUmVuZGVyUmVzdWx0OjpTdXNwZW5kZWQ6Cisg
ICAgICAgICAgICAgICAgICAgIGNvbnRleHQoKS5kaWRTdXNwZW5kUmVuZGVyaW5nKGN1cnJlbnRT
YW1wbGVGcmFtZSk7CisgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAg
IH0KKyAgICAgICAgICAgIH0pOwogICAgICAgICB9KTsKICAgICB9OwogCmRpZmYgLS1naXQgYS9M
YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDU2MjQ1
ZGM4MjE2ODA0NGU0ZTZlZjFmOTQ0OTRhMTQ0Y2Q3Yzg0My4uOWY0Y2RmZDZiMWJhNDEyMWUxNjNj
ZWJhOTVkNmE0NTM0ZjFlOTA1NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr
KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTExLTAyICBD
aHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgWyBtYWNPUyBdIHdlYmF1
ZGlvL09mZmxpbmVBdWRpb0NvbnRleHQvb25zdGF0ZWNoYW5nZS5odG1sIGlzIGEgZmxha3kgZmFp
bHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3
NTQzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MDE2MDEyMj4KKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0
YXRpb25zOgorICAgICAgICBVbnNraXAgdGVzdCB0aGF0IHNob3VsZCBubyBsb25nZXIgYmUgZmxh
a3kuCisKKyAgICAgICAgKiB3ZWJhdWRpby9PZmZsaW5lQXVkaW9Db250ZXh0L29uc3RhdGVjaGFu
Z2UtZXhwZWN0ZWQudHh0OgorICAgICAgICBSZWJhc2VsaW5lIHRlc3Qgbm93IHRoYXQgdGhlIG9y
ZGVyIG9mIHRoZSBwcm9taXNlIHJlc29sdXRpb24gYW5kIHRoZSBzdGF0ZWNoYW5nZSBldmVudCBo
YXZlIGNoYW5nZWQuCisgICAgICAgIE5vdGUgdGhhdCB0aGUgbmV3IG9yZGVyaW5nIGlzIGNvbnNp
c3RlbnQgd2l0aCBib3RoIENocm9tZSBhbmQgRmlyZWZveC4KKwogMjAyMC0xMS0wMiAgTWFydGlu
IFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dMSUJdIFJFR1JF
U1NJT04ocjI2OTE0NCkgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3Nzb20t
dmlldy9zY3JvbGxJbnRvVmlldy1zY3JvbGxNYXJnaW4uaHRtbCBpcyBmYWlsaW5nCmRpZmYgLS1n
aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRl
c3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDFmZDkzOGIxODM4NDNjN2Rj
Y2I4ZWVkYmE2NGYwNDhmMWZlYWVjNDkuLjE3NjA1OTNlNDBjOGJmMWVkOTRlZTg2YWU0N2ZmODc1
MzNlZWYwZWYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0
YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCkBA
IC0yMjM5LDggKzIyMzksNiBAQCB3ZWJraXQub3JnL2IvMjE3NDYxIFsgTW9qYXZlKyBdIGltcG9y
dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1tYXNraW5nLwogCiB3ZWJraXQub3Jn
L2IvMjE3NTQyIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVkaW8vdGhlLWF1
ZGlvLWFwaS90aGUtYXVkaW9jb250ZXh0LWludGVyZmFjZS9wcm9jZXNzaW5nLWFmdGVyLXJlc3Vt
ZS5odHRwcy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzIxNzU0MyB3ZWJh
dWRpby9PZmZsaW5lQXVkaW9Db250ZXh0L29uc3RhdGVjaGFuZ2UuaHRtbCBbIFBhc3MgRmFpbHVy
ZSBdCi0KIHdlYmtpdC5vcmcvYi8yMDkwNzMgWyBEZWJ1ZyBdIGluc3BlY3Rvci9pbmplY3RlZC1z
Y3JpcHQvYXZvaWQtZ2V0dGVyLWludm9jYXRpb24uaHRtbCBbIFBhc3MgVGltZW91dCBdCiAKIHdl
YmtpdC5vcmcvYi8yMTc2NDEgWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz
dHMveGhyL2V2ZW50LXRpbWVvdXQuYW55Lndvcmtlci5odG1sIFsgUGFzcyBGYWlsdXJlIF0KZGlm
ZiAtLWdpdCBhL0xheW91dFRlc3RzL3dlYmF1ZGlvL09mZmxpbmVBdWRpb0NvbnRleHQvb25zdGF0
ZWNoYW5nZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy93ZWJhdWRpby9PZmZsaW5lQXVkaW9D
b250ZXh0L29uc3RhdGVjaGFuZ2UtZXhwZWN0ZWQudHh0CmluZGV4IDliNWJmNzc0MjQ4ZGRjMjIz
OGFmMTVlNmNjNDNhMjA1ZDU0NmE2Y2EuLmNmMDI2ZTM2NWY3NTE2MTA5MjI4MGM0YWQ2YWJmYmU2
NGExNjUwZjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dlYmF1ZGlvL09mZmxpbmVBdWRpb0Nv
bnRleHQvb25zdGF0ZWNoYW5nZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvd2ViYXVk
aW8vT2ZmbGluZUF1ZGlvQ29udGV4dC9vbnN0YXRlY2hhbmdlLWV4cGVjdGVkLnR4dApAQCAtNCw4
ICs0LDggQEAgUEFTUyBFeGVjdXRpbmcgInRlc3QiCiBQQVNTIEF1ZGl0IHJlcG9ydAogUEFTUyA+
IFt0ZXN0XSBTaWduYWxpbmcgb2Ygc3RhdGVjaGFuZ2UgZXZlbnQKIFBBU1MgICBjb250ZXh0LnN0
YXRlIGlzIGVxdWFsIHRvIHJ1bm5pbmcuCi1QQVNTICAgY29udGV4dC5zdGF0ZSBpcyBlcXVhbCB0
byBjbG9zZWQuCiBQQVNTICAgQ29udGV4dCByZW5kZXJpbmcgcmVzb2x2ZWQgY29ycmVjdGx5Lgor
UEFTUyAgIGNvbnRleHQuc3RhdGUgaXMgZXF1YWwgdG8gY2xvc2VkLgogUEFTUyAgIHN0YXRlQ2hh
bmdlQ291bnQgaXMgZXF1YWwgdG8gMi4KIFBBU1MgICBBZnRlciByZW5kZXJpbmcgY29udGV4dC5z
dGF0ZSBpcyBlcXVhbCB0byBjbG9zZWQuCiBQQVNTIDwgW3Rlc3RdIEFsbCBhc3NlcnRpb25zIHBh
c3NlZC4gKHRvdGFsIDUgYXNzZXJ0aW9ucykK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>412961</attachid>
            <date>2020-11-02 12:37:32 -0800</date>
            <delta_ts>2020-11-02 13:21:49 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-217543-20201102123731.patch</filename>
            <type>text/plain</type>
            <size>5969</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGYzNDY4ZDI0NzFlMDU0
YmYzYjQzYWVkYjQ1N2I2YzdhYTJlMTNjOS4uMzQ1ZWNiMzAxYTEwNDViOWRmYzM0YjAwMGFiZGNl
NTlhYTliZTg5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTExLTAyICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgWyBtYWNPUyBdIHdlYmF1ZGlv
L09mZmxpbmVBdWRpb0NvbnRleHQvb25zdGF0ZWNoYW5nZS5odG1sIGlzIGEgZmxha3kgZmFpbHVy
ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3NTQz
CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MDE2MDEyMj4KKworICAgICAgICBSZXZpZXdlZCBi
eSBBbGV4IENocmlzdGVuc2VuLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdW5za2lwcGVkIGV4
aXN0aW5nIHRlc3QuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL09mZmxpbmVBdWRpb0Rl
c3RpbmF0aW9uTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpPZmZsaW5lQXVkaW9EZXN0aW5h
dGlvbk5vZGU6OnN0YXJ0UmVuZGVyaW5nKToKKyAgICAgICAgQWZ0ZXIgb2ZmbGluZSByZW5kZXJp
bmcgb24gdGhlIGF1ZGlvIHRocmVhZCBhbmQgd2UgZ28gYmFjayB0byB0aGUgbWFpbiB0aHJlYWQs
IG1ha2Ugc3VyZSB3ZSBxdWV1ZSBhIHRhc2sgb2YgdGhlCisgICAgICAgIGV2ZW50IGxvb3AgdG8g
ZmlyZSB0aGUgc3RhdGVjaGFuZ2UgYW5kIGNvbXBsZXRpb24gZXZlbnRzLiBXZSB3ZXJlIHByZXZp
b3VzbHkgZmFpbGluZyB0byBkbyBzbyBhbmQgdGhhdCBtZWFudAorICAgICAgICB0aGF0IHRoZSBv
cmRlcmluZyB3aXRoIG90aGVyIG1haW4gdGhyZWFkIGV2ZW50cyAod2hpY2ggd2VyZSBxdWV1ZWQg
b24gdGhlIGV2ZW50IGxvb3ApIHdhcyBub3QgYWx3YXlzIGNvcnJlY3QuCisKIDIwMjAtMTEtMDEg
IERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFN0YXJ0IHJlbW92aW5n
IGZ1bmN0aW9ucyB0aGF0IGltcGxpY2l0bHkgdXNlIGNvbXBvc2VkIHRyZWUKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vT2ZmbGluZUF1ZGlvRGVzdGluYXRpb25O
b2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vT2ZmbGluZUF1ZGlvRGVz
dGluYXRpb25Ob2RlLmNwcAppbmRleCA0NTJlNmZiODY3YzcxNTRlZjE2YzNkZjM3NzM3Y2M3Y2Y1
NTNkYjdlLi41YjBiNjJjYWU0Y2Y1NTE2YTkyY2U3NTdiZDIyNjBhOTcwMzZmNzI2IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL09mZmxpbmVBdWRpb0Rlc3RpbmF0
aW9uTm9kZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9PZmZsaW5l
QXVkaW9EZXN0aW5hdGlvbk5vZGUuY3BwCkBAIC0xMDEsMTkgKzEwMSwyMSBAQCB2b2lkIE9mZmxp
bmVBdWRpb0Rlc3RpbmF0aW9uTm9kZTo6c3RhcnRSZW5kZXJpbmcoQ29tcGxldGlvbkhhbmRsZXI8
dm9pZChPcHRpb25hbAogCiAgICAgYXV0byBvZmZUaHJlYWRSZW5kZXJpbmcgPSBbdGhpcywgcHJv
dGVjdGVkVGhpcyA9IFdURk1vdmUocHJvdGVjdGVkVGhpcyldKCkgbXV0YWJsZSB7CiAgICAgICAg
IGF1dG8gcmVzdWx0ID0gb2ZmbGluZVJlbmRlcigpOwotICAgICAgICBjYWxsT25NYWluVGhyZWFk
KFt0aGlzLCByZXN1bHQsIGN1cnJlbnRTYW1wbGVGcmFtZSA9IG1fY3VycmVudFNhbXBsZUZyYW1l
LCBwcm90ZWN0ZWRUaGlzID0gV1RGTW92ZShwcm90ZWN0ZWRUaGlzKV0gewotICAgICAgICAgICAg
bV9zdGFydGVkUmVuZGVyaW5nID0gZmFsc2U7Ci0gICAgICAgICAgICBzd2l0Y2ggKHJlc3VsdCkg
ewotICAgICAgICAgICAgY2FzZSBPZmZsaW5lUmVuZGVyUmVzdWx0OjpGYWlsdXJlOgotICAgICAg
ICAgICAgICAgIGNvbnRleHQoKS5maW5pc2hlZFJlbmRlcmluZyhmYWxzZSk7Ci0gICAgICAgICAg
ICAgICAgYnJlYWs7Ci0gICAgICAgICAgICBjYXNlIE9mZmxpbmVSZW5kZXJSZXN1bHQ6OkNvbXBs
ZXRlOgotICAgICAgICAgICAgICAgIGNvbnRleHQoKS5maW5pc2hlZFJlbmRlcmluZyh0cnVlKTsK
LSAgICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgICAgIGNhc2UgT2ZmbGluZVJlbmRlclJl
c3VsdDo6U3VzcGVuZGVkOgotICAgICAgICAgICAgICAgIGNvbnRleHQoKS5kaWRTdXNwZW5kUmVu
ZGVyaW5nKGN1cnJlbnRTYW1wbGVGcmFtZSk7Ci0gICAgICAgICAgICAgICAgYnJlYWs7Ci0gICAg
ICAgICAgICB9CisgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW3RoaXMsIHJlc3VsdCwgY3VycmVu
dFNhbXBsZUZyYW1lID0gbV9jdXJyZW50U2FtcGxlRnJhbWUsIHByb3RlY3RlZFRoaXMgPSBXVEZN
b3ZlKHByb3RlY3RlZFRoaXMpXSgpIG11dGFibGUgeworICAgICAgICAgICAgY29udGV4dCgpLnBv
c3RUYXNrKFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gV1RGTW92ZShwcm90ZWN0ZWRUaGlzKSwgcmVz
dWx0LCBjdXJyZW50U2FtcGxlRnJhbWVdKCkgbXV0YWJsZSB7CisgICAgICAgICAgICAgICAgbV9z
dGFydGVkUmVuZGVyaW5nID0gZmFsc2U7CisgICAgICAgICAgICAgICAgc3dpdGNoIChyZXN1bHQp
IHsKKyAgICAgICAgICAgICAgICBjYXNlIE9mZmxpbmVSZW5kZXJSZXN1bHQ6OkZhaWx1cmU6Cisg
ICAgICAgICAgICAgICAgICAgIGNvbnRleHQoKS5maW5pc2hlZFJlbmRlcmluZyhmYWxzZSk7Cisg
ICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAgIGNhc2UgT2ZmbGluZVJl
bmRlclJlc3VsdDo6Q29tcGxldGU6CisgICAgICAgICAgICAgICAgICAgIGNvbnRleHQoKS5maW5p
c2hlZFJlbmRlcmluZyh0cnVlKTsKKyAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAg
ICAgICAgICAgY2FzZSBPZmZsaW5lUmVuZGVyUmVzdWx0OjpTdXNwZW5kZWQ6CisgICAgICAgICAg
ICAgICAgICAgIGNvbnRleHQoKS5kaWRTdXNwZW5kUmVuZGVyaW5nKGN1cnJlbnRTYW1wbGVGcmFt
ZSk7CisgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAgIH0KKyAgICAg
ICAgICAgIH0pOwogICAgICAgICB9KTsKICAgICB9OwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0
cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTYwY2M3OWIwNzVhZjc2
MTYyNDBmMTU1NzU1NWQ2NDM0MGZlMDU3YS4uZTk5ZjBlZmFmNDZkYzQ1YjI3MWYyZGE3YzAzY2M4
NTQ4NDdkNjI5MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91
dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTExLTAyICBDaHJpcyBEdW1l
eiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgWyBtYWNPUyBdIHdlYmF1ZGlvL09mZmxp
bmVBdWRpb0NvbnRleHQvb25zdGF0ZWNoYW5nZS5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3NTQzCisgICAg
ICAgIDxyZGFyOi8vcHJvYmxlbS83MDE2MDEyMj4KKworICAgICAgICBSZXZpZXdlZCBieSBBbGV4
IENocmlzdGVuc2VuLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6
CisgICAgICAgIFVuc2tpcCB0ZXN0IHRoYXQgc2hvdWxkIG5vIGxvbmdlciBiZSBmbGFreS4KKwor
ICAgICAgICAqIHdlYmF1ZGlvL09mZmxpbmVBdWRpb0NvbnRleHQvb25zdGF0ZWNoYW5nZS1leHBl
Y3RlZC50eHQ6CisgICAgICAgIFJlYmFzZWxpbmUgdGVzdCBub3cgdGhhdCB0aGUgb3JkZXIgb2Yg
dGhlIHByb21pc2UgcmVzb2x1dGlvbiBhbmQgdGhlIHN0YXRlY2hhbmdlIGV2ZW50IGhhdmUgY2hh
bmdlZC4KKyAgICAgICAgTm90ZSB0aGF0IHRoZSBuZXcgb3JkZXJpbmcgaXMgY29uc2lzdGVudCB3
aXRoIGJvdGggQ2hyb21lIGFuZCBGaXJlZm94LgorCiAyMDIwLTExLTAyICBDaHJpcyBEdW1leiAg
PGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgc2tpcCBpbXBvcnRlZC93
M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dlYmF1ZGlvL3RoZS1hdWRpby1hcGkvdGhlLWF1ZGlvcGFy
YW0taW50ZXJmYWNlL2stcmF0ZS1wYW5uZXItY29ubmVjdGlvbnMuaHRtbCBvbiBtYWMtYXJtNjQg
b25seS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRp
b25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYzli
YmZmOWZlZmI1MzllZjYxYjJiM2U5MWEwM2FjNmRkNjAxYTJmMC4uNzBhMjk0ZjRkNjU4YzQ3ODc5
MTA0NzFmOWJkMDk5MzA1N2FkMTY5NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v
bWFjL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RF
eHBlY3RhdGlvbnMKQEAgLTIyNDAsOCArMjI0MCw2IEBAIHdlYmtpdC5vcmcvYi8yMTc0NjEgWyBN
b2phdmUrIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLW1hc2tpbmcv
CiAKIHdlYmtpdC5vcmcvYi8yMTc1NDIgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93
ZWJhdWRpby90aGUtYXVkaW8tYXBpL3RoZS1hdWRpb2NvbnRleHQtaW50ZXJmYWNlL3Byb2Nlc3Np
bmctYWZ0ZXItcmVzdW1lLmh0dHBzLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCi13ZWJraXQub3Jn
L2IvMjE3NTQzIHdlYmF1ZGlvL09mZmxpbmVBdWRpb0NvbnRleHQvb25zdGF0ZWNoYW5nZS5odG1s
IFsgUGFzcyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzIwOTA3MyBbIERlYnVnIF0gaW5zcGVj
dG9yL2luamVjdGVkLXNjcmlwdC9hdm9pZC1nZXR0ZXItaW52b2NhdGlvbi5odG1sIFsgUGFzcyBU
aW1lb3V0IF0KIAogd2Via2l0Lm9yZy9iLzIxNzY0MSBbIERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dl
Yi1wbGF0Zm9ybS10ZXN0cy94aHIvZXZlbnQtdGltZW91dC5hbnkud29ya2VyLmh0bWwgWyBQYXNz
IEZhaWx1cmUgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2ViYXVkaW8vT2ZmbGluZUF1ZGlv
Q29udGV4dC9vbnN0YXRlY2hhbmdlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3dlYmF1ZGlv
L09mZmxpbmVBdWRpb0NvbnRleHQvb25zdGF0ZWNoYW5nZS1leHBlY3RlZC50eHQKaW5kZXggOWI1
YmY3NzQyNDhkZGMyMjM4YWYxNWU2Y2M0M2EyMDVkNTQ2YTZjYS4uY2YwMjZlMzY1Zjc1MTYxMDky
MjgwYzRhZDZhYmZiZTY0YTE2NTBmNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvd2ViYXVkaW8v
T2ZmbGluZUF1ZGlvQ29udGV4dC9vbnN0YXRlY2hhbmdlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlv
dXRUZXN0cy93ZWJhdWRpby9PZmZsaW5lQXVkaW9Db250ZXh0L29uc3RhdGVjaGFuZ2UtZXhwZWN0
ZWQudHh0CkBAIC00LDggKzQsOCBAQCBQQVNTIEV4ZWN1dGluZyAidGVzdCIKIFBBU1MgQXVkaXQg
cmVwb3J0CiBQQVNTID4gW3Rlc3RdIFNpZ25hbGluZyBvZiBzdGF0ZWNoYW5nZSBldmVudAogUEFT
UyAgIGNvbnRleHQuc3RhdGUgaXMgZXF1YWwgdG8gcnVubmluZy4KLVBBU1MgICBjb250ZXh0LnN0
YXRlIGlzIGVxdWFsIHRvIGNsb3NlZC4KIFBBU1MgICBDb250ZXh0IHJlbmRlcmluZyByZXNvbHZl
ZCBjb3JyZWN0bHkuCitQQVNTICAgY29udGV4dC5zdGF0ZSBpcyBlcXVhbCB0byBjbG9zZWQuCiBQ
QVNTICAgc3RhdGVDaGFuZ2VDb3VudCBpcyBlcXVhbCB0byAyLgogUEFTUyAgIEFmdGVyIHJlbmRl
cmluZyBjb250ZXh0LnN0YXRlIGlzIGVxdWFsIHRvIGNsb3NlZC4KIFBBU1MgPCBbdGVzdF0gQWxs
IGFzc2VydGlvbnMgcGFzc2VkLiAodG90YWwgNSBhc3NlcnRpb25zKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>