217537 2020-10-09 15:26:39 -0700 replaceChildren() (with no arguments) silently does nothing rather than removing the children 2025-01-30 13:23:48 -0800 1 1 1 Unclassified WebKit DOM Safari Technology Preview All All RESOLVED FIXED InRadar P2 Normal --- 198578 1 ashley darin bfulgham cdumez clopez darin esprehn+autocc ews-watchlist kangil.han rniwa sam tetsuharu.ohzeki webkit-bug-importer youennf oldest_to_newest 1696379 0 ashley 2020-10-09 15:26:39 -0700 Safari TP114 appears to ship a broken implementation of elem.replaceChildren() which is enabled by default. Demo: https://downloads.scirra.com/labs/replacechildren.html Click the button. It calls replaceChildren() with empty arguments to remove the three paragraphs. It works in Chrome and Firefox and the elements disappear. In Safari it does nothing - no elements are removed. 1696443 1 ap 2020-10-09 18:18:57 -0700 Same behavior in Safari 14.0.1 beta. 1696444 2 webkit-bug-importer 2020-10-09 18:19:12 -0700 <rdar://problem/70161896> 1696486 3 tetsuharu.ohzeki 2020-10-09 21:44:45 -0700 (In reply to Alexey Proskuryakov from comment #1) > Same behavior in Safari 14.0.1 beta. I seem Safari v14 does not enable `ParentNode.replaceChildren()` in the first place. Oddly Safari TP 114 and the trunk which enables that API also does not work this. 1696496 4 darin 2020-10-10 01:34:07 -0700 This was added in r262381 and passed all the Web Platform Tests then and since. Haven’t looked at this test here yet. 1696512 5 darin 2020-10-10 11:19:28 -0700 I took a look at the DOM specification. It has an incorrect step: https://dom.spec.whatwg.org/#dom-parentnode-replacechildren Note that step 2 says "Ensure pre-insertion validity of node into this before null." But that should only be done if node is non-null. We should probably report that issue. If we took it literally then the function would need to throw a HierarchyRequestError exception, but clearly that’s needed. I took a look at the Web Platform Tests. https://github.com/web-platform-tests/wpt/blob/master/dom/nodes/ParentNode-replaceChildren.html For some reason it does not include a test case for replaceChildren without any argument, on a parent having a child. So we pass that test even though our algorithm is incorrect. Fixing the bug is really easy, and it’s also easy for me to add a test to WPT, but I don’t know how to correctly upstream a change like this. Could use some help with that. 1696513 6 darin 2020-10-10 11:31:28 -0700 (In reply to Darin Adler from comment #5) > I took a look at the DOM specification. It has an incorrect step: > > https://dom.spec.whatwg.org/#dom-parentnode-replacechildren Filed https://github.com/whatwg/dom/issues/901 1696515 7 411013 darin 2020-10-10 11:37:55 -0700 Created attachment 411013 Patch 1696516 8 ews-watchlist 2020-10-10 11:38:39 -0700 This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess 1696519 9 411015 darin 2020-10-10 12:02:15 -0700 Created attachment 411015 Patch 1696521 10 darin 2020-10-10 12:02:56 -0700 I’m going to need help with the WPT export process. I tried and couldn’t make it work. 1696530 11 darin 2020-10-10 12:28:12 -0700 https://github.com/web-platform-tests/wpt/pull/26075 1696547 12 darin 2020-10-10 13:39:30 -0700 Committed r268314: <https://trac.webkit.org/changeset/268314> 1697188 13 rniwa 2020-10-13 00:18:47 -0700 FWIW, this is definitely enabled by default on Safari 14.0.1. 1697269 14 darin 2020-10-13 09:00:25 -0700 You mean that the broken version is included in Safari 14.0.1 or that the fixed version is included in 14.0.1? 1697615 15 tetsuharu.ohzeki 2020-10-13 22:07:24 -0700 (In reply to Ryosuke Niwa from comment #13) > FWIW, this is definitely enabled by default on Safari 14.0.1. Oh, I'm sorry to add the incomplete implementation in bug 198578... 1697617 16 rniwa 2020-10-13 22:25:32 -0700 (In reply to Darin Adler from comment #14) > You mean that the broken version is included in Safari 14.0.1 or that the > fixed version is included in 14.0.1? The broken version is in Safari 14.0.1. 2090814 18 bfulgham 2025-01-30 13:23:48 -0800 The fix for this bug shipped in April, 2021: iOS 14.5 macOS 11.3 Big Sur 411013 2020-10-10 11:37:55 -0700 2020-10-10 12:04:39 -0700 Patch bug-217537-20201010113755.patch text/plain 6625 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDliNjMwMWUwODA2OGMy Y2M3OGU4ZmM3OWJiZTZhMjU4OGJiMDViMi4uNTJhMzRkNDI0Y2MyMWYzZGU0ZTA1ZGIxYjIxZWFl NGU3NmQwNzllYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTEwLTEwICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICByZXBsYWNlQ2hpbGRyZW4oKSAo d2l0aCBubyBhcmd1bWVudHMpIHNpbGVudGx5IGRvZXMgbm90aGluZyByYXRoZXIgdGhhbiByZW1v dmluZyB0aGUgY2hpbGRyZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxNzUzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogZG9tL0NvbnRhaW5lck5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29u dGFpbmVyTm9kZTo6cmVwbGFjZUNoaWxkcmVuKTogUmVtb3ZlZCBpbmNvcnJlY3QgZWFybHkgcmV0 dXJuIHdoZW4gdGhlCisgICAgICAgIG5vZGUgaXMgbnVsbCwgaW5zdGVhZCBhZGRlZCBzb21lIG51 bGwgY2hlY2tzIGFyb3VuZCB0aGUgcGFydHMgb2YgdGhlIGFsZ29yaXRobSB0aGF0CisgICAgICAg IHNob3VsZCBiZSBza2lwcGVkIGluIHRoYXQgY2FzZS4KKwogMjAyMC0xMC0xMCAgWmFsYW4gQnVq dGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0ludGVncmF0aW9uXSBUdXJu IHBhcmVudC9maXJzdCBjaGlsZCBjaGVjayBpbnRvIGVzdGFibGlzaGVzSW5saW5lRm9ybWF0dGlu Z0NvbnRleHQgaW4gY2FuVXNlRm9yTGluZUxheW91dFdpdGhSZWFzb24KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9D b250YWluZXJOb2RlLmNwcAppbmRleCBlZGQwNzY1MDAxZGJhNGFjOGIxMzQ3NjdjNTE5NDQzM2I5 NjZhMjBlLi5lZDQxZjJiNTZjZmNmNTc1YTcyNDRkMWM3ZDRiZDUzYzk1YjU1YzQzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwCkBAIC05NjEsMjQgKzk2MSwyMyBAQCBFeGNlcHRp b25Pcjx2b2lkPiBDb250YWluZXJOb2RlOjpyZXBsYWNlQ2hpbGRyZW4oVmVjdG9yPE5vZGVPclN0 cmluZz4mJiB2ZWN0b3IpCiAgICAgYXV0byByZXN1bHQgPSBjb252ZXJ0Tm9kZXNPclN0cmluZ3NJ bnRvTm9kZShXVEZNb3ZlKHZlY3RvcikpOwogICAgIGlmIChyZXN1bHQuaGFzRXhjZXB0aW9uKCkp CiAgICAgICAgIHJldHVybiByZXN1bHQucmVsZWFzZUV4Y2VwdGlvbigpOwotCi0gICAgUmVmUHRy PE5vZGU+IG5vZGUgPSByZXN1bHQucmVsZWFzZVJldHVyblZhbHVlKCk7Ci0gICAgaWYgKCFub2Rl KQotICAgICAgICByZXR1cm4geyB9OworICAgIGF1dG8gbm9kZSA9IHJlc3VsdC5yZWxlYXNlUmV0 dXJuVmFsdWUoKTsKIAogICAgIC8vIHN0ZXAgMgotICAgIGF1dG8gdmFsaWRpdHlDaGVja1Jlc3Vs dCA9IGVuc3VyZVByZUluc2VydGlvblZhbGlkaXR5KCpub2RlLCBudWxscHRyKTsKLSAgICBpZiAo dmFsaWRpdHlDaGVja1Jlc3VsdC5oYXNFeGNlcHRpb24oKSkKLSAgICAgICAgcmV0dXJuIHZhbGlk aXR5Q2hlY2tSZXN1bHQucmVsZWFzZUV4Y2VwdGlvbigpOworICAgIGlmIChub2RlKSB7CisgICAg ICAgIGlmIChhdXRvIGNoZWNrUmVzdWx0ID0gZW5zdXJlUHJlSW5zZXJ0aW9uVmFsaWRpdHkoKm5v ZGUsIG51bGxwdHIpOyBjaGVja1Jlc3VsdC5oYXNFeGNlcHRpb24oKSkKKyAgICAgICAgICAgIHJl dHVybiBjaGVja1Jlc3VsdDsKKyAgICB9CiAKICAgICAvLyBzdGVwIDMKLSAgICBSZWY8Q29udGFp bmVyTm9kZT4gcHJvdGVjdGVkVGhpcygqdGhpcyk7CisgICAgYXV0byBwcm90ZWN0ZWRUaGlzID0g bWFrZVJlZigqdGhpcyk7CiAgICAgQ2hpbGRMaXN0TXV0YXRpb25TY29wZSBtdXRhdGlvbigqdGhp cyk7CiAgICAgcmVtb3ZlQWxsQ2hpbGRyZW5XaXRoU2NyaXB0QXNzZXJ0aW9uKENoaWxkQ2hhbmdl U291cmNlOjpBUEksIERlZmVyQ2hpbGRyZW5DaGFuZ2VkOjpObyk7CiAKLSAgICBhdXRvIGluc2Vy dFJlc3VsdCA9IGFwcGVuZENoaWxkV2l0aG91dFByZUluc2VydGlvblZhbGlkaXR5Q2hlY2soKm5v ZGUpOwotICAgIGlmIChpbnNlcnRSZXN1bHQuaGFzRXhjZXB0aW9uKCkpCi0gICAgICAgIHJldHVy biBpbnNlcnRSZXN1bHQucmVsZWFzZUV4Y2VwdGlvbigpOworICAgIGlmIChub2RlKSB7CisgICAg ICAgIGlmIChhdXRvIGFwcGVuZFJlc3VsdCA9IGFwcGVuZENoaWxkV2l0aG91dFByZUluc2VydGlv blZhbGlkaXR5Q2hlY2soKm5vZGUpOyBpbnNlcnRSZXN1bHQuaGFzRXhjZXB0aW9uKCkpCisgICAg ICAgICAgICByZXR1cm4gYXBwZW5kUmVzdWx0OworICAgIH0KIAogICAgIHJlYnVpbGRTVkdFeHRl bnNpb25zRWxlbWVudHNJZk5lY2Vzc2FyeSgpOwogICAgIGRpc3BhdGNoU3VidHJlZU1vZGlmaWVk RXZlbnQoKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDZkYzk0MzlkNjZlMWNh N2Q5ODg2MmFmNzhmNzhlOTJkMDgxNDBmYzkuLmUzMDVmOTk3YmVlOTljYTAwNjFjNmI4ZGZhNzE0 MTQ3MjBjMjZkYTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIwLTEwLTEwICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAg ICByZXBsYWNlQ2hpbGRyZW4oKSAod2l0aCBubyBhcmd1bWVudHMpIHNpbGVudGx5IGRvZXMgbm90 aGluZyByYXRoZXIgdGhhbiByZW1vdmluZyB0aGUgY2hpbGRyZW4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzUzNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9u b2Rlcy9QYXJlbnROb2RlLXJlcGxhY2VDaGlsZHJlbi1leHBlY3RlZC50eHQ6CisgICAgICAgICog d2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9QYXJlbnROb2RlLXJlcGxhY2VDaGlsZHJlbi5o dG1sOgorICAgICAgICBBZGRlZCBhIHRlc3Qgb2YgcmVwbGFjZUNoaWxkcmVuIHdpdGhvdXQgYW55 IGFyZ3VtZW50LCBvbiBhIHBhcmVudCBoYXZpbmcgYSBjaGlsZC4KKwogMjAyMC0xMC0wOSAgQW50 b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KIAogICAgICAgICBDU1MgdHJhbnNmb3Jt IGNvbXB1dGVkIHN0eWxlIHNob3VsZCBub3QgcmVmbGVjdCBpbmRpdmlkdWFsIHRyYW5zZm9ybSBw cm9wZXJ0aWVzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL2RvbS9ub2Rlcy9QYXJlbnROb2RlLXJlcGxhY2VDaGlsZHJlbi1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rl cy9QYXJlbnROb2RlLXJlcGxhY2VDaGlsZHJlbi1leHBlY3RlZC50eHQKaW5kZXggMDRiZGEwYjUx NTU1MDhiYTZlODEyZDYxNzc0ZWIxMDZjYTY3MTBiMC4uNTQyYTQwNzdiMTFlYmYyNzQzNTlkMGI2 ZjYxNjA3MzUyMzEyNzZlMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9kb20vbm9kZXMvUGFyZW50Tm9kZS1yZXBsYWNlQ2hpbGRyZW4tZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvZG9tL25vZGVzL1BhcmVudE5vZGUtcmVwbGFjZUNoaWxkcmVuLWV4cGVjdGVkLnR4dApAQCAt MTMsNiArMTMsNyBAQCBQQVNTIEVsZW1lbnQucmVwbGFjZUNoaWxkcmVuKCkgd2l0aCBudWxsIGFz IGFuIGFyZ3VtZW50LCBvbiBhIHBhcmVudCBoYXZpbmcgbm8gYwogUEFTUyBFbGVtZW50LnJlcGxh Y2VDaGlsZHJlbigpIHdpdGggdW5kZWZpbmVkIGFzIGFuIGFyZ3VtZW50LCBvbiBhIHBhcmVudCBo YXZpbmcgbm8gY2hpbGQuCiBQQVNTIEVsZW1lbnQucmVwbGFjZUNoaWxkcmVuKCkgd2l0aCBvbmx5 IHRleHQgYXMgYW4gYXJndW1lbnQsIG9uIGEgcGFyZW50IGhhdmluZyBubyBjaGlsZC4KIFBBU1Mg RWxlbWVudC5yZXBsYWNlQ2hpbGRyZW4oKSB3aXRoIG9ubHkgb25lIGVsZW1lbnQgYXMgYW4gYXJn dW1lbnQsIG9uIGEgcGFyZW50IGhhdmluZyBubyBjaGlsZC4KK1BBU1MgRWxlbWVudC5yZXBsYWNl Q2hpbGRyZW4oKSB3aXRob3V0IGFueSBhcmd1bWVudCwgb24gYSBwYXJlbnQgaGF2aW5nIGEgY2hp bGQuCiBQQVNTIEVsZW1lbnQucmVwbGFjZUNoaWxkcmVuKCkgd2l0aCBudWxsIGFzIGFuIGFyZ3Vt ZW50LCBvbiBhIHBhcmVudCBoYXZpbmcgYSBjaGlsZC4KIFBBU1MgRWxlbWVudC5yZXBsYWNlQ2hp bGRyZW4oKSB3aXRoIG9uZSBlbGVtZW50IGFuZCB0ZXh0IGFzIGFyZ3VtZW50LCBvbiBhIHBhcmVu dCBoYXZpbmcgYSBjaGlsZC4KIFBBU1MgRWxlbWVudC5yZXBsYWNlQ2hpbGRyZW4oKSBzaG91bGQg bW92ZSBub2RlcyBpbiB0aGUgcmlnaHQgb3JkZXIKQEAgLTIxLDYgKzIyLDcgQEAgUEFTUyBEb2N1 bWVudEZyYWdtZW50LnJlcGxhY2VDaGlsZHJlbigpIHdpdGggbnVsbCBhcyBhbiBhcmd1bWVudCwg b24gYSBwYXJlbnQgaGEKIFBBU1MgRG9jdW1lbnRGcmFnbWVudC5yZXBsYWNlQ2hpbGRyZW4oKSB3 aXRoIHVuZGVmaW5lZCBhcyBhbiBhcmd1bWVudCwgb24gYSBwYXJlbnQgaGF2aW5nIG5vIGNoaWxk LgogUEFTUyBEb2N1bWVudEZyYWdtZW50LnJlcGxhY2VDaGlsZHJlbigpIHdpdGggb25seSB0ZXh0 IGFzIGFuIGFyZ3VtZW50LCBvbiBhIHBhcmVudCBoYXZpbmcgbm8gY2hpbGQuCiBQQVNTIERvY3Vt ZW50RnJhZ21lbnQucmVwbGFjZUNoaWxkcmVuKCkgd2l0aCBvbmx5IG9uZSBlbGVtZW50IGFzIGFu IGFyZ3VtZW50LCBvbiBhIHBhcmVudCBoYXZpbmcgbm8gY2hpbGQuCitQQVNTIERvY3VtZW50RnJh Z21lbnQucmVwbGFjZUNoaWxkcmVuKCkgd2l0aG91dCBhbnkgYXJndW1lbnQsIG9uIGEgcGFyZW50 IGhhdmluZyBhIGNoaWxkLgogUEFTUyBEb2N1bWVudEZyYWdtZW50LnJlcGxhY2VDaGlsZHJlbigp IHdpdGggbnVsbCBhcyBhbiBhcmd1bWVudCwgb24gYSBwYXJlbnQgaGF2aW5nIGEgY2hpbGQuCiBQ QVNTIERvY3VtZW50RnJhZ21lbnQucmVwbGFjZUNoaWxkcmVuKCkgd2l0aCBvbmUgZWxlbWVudCBh bmQgdGV4dCBhcyBhcmd1bWVudCwgb24gYSBwYXJlbnQgaGF2aW5nIGEgY2hpbGQuCiBQQVNTIERv Y3VtZW50RnJhZ21lbnQucmVwbGFjZUNoaWxkcmVuKCkgc2hvdWxkIG1vdmUgbm9kZXMgaW4gdGhl IHJpZ2h0IG9yZGVyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBs YXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9QYXJlbnROb2RlLXJlcGxhY2VDaGlsZHJlbi5odG1sIGIv TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vbm9kZXMvUGFy ZW50Tm9kZS1yZXBsYWNlQ2hpbGRyZW4uaHRtbAppbmRleCA2NTU3ZGI0NDEyODQ3YmU1OWY0ZWNl ZGM4OTczMWQ2ZmE4OTMxNGI5Li5jZDQ4OTdjMzc4NGZjY2RlYmIzNjU1ZGQ2OTIyMzQzN2Y2M2Qw MGQ1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2RvbS9ub2Rlcy9QYXJlbnROb2RlLXJlcGxhY2VDaGlsZHJlbi5odG1sCisrKyBiL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL25vZGVzL1BhcmVudE5v ZGUtcmVwbGFjZUNoaWxkcmVuLmh0bWwKQEAgLTQwLDYgKzQwLDE0IEBACiAgICAgICBhc3NlcnRf YXJyYXlfZXF1YWxzKHBhcmVudC5jaGlsZE5vZGVzLCBbeF0pOwogICAgIH0sIGAke25vZGVOYW1l fS5yZXBsYWNlQ2hpbGRyZW4oKSB3aXRoIG9ubHkgb25lIGVsZW1lbnQgYXMgYW4gYXJndW1lbnQs IG9uIGEgcGFyZW50IGhhdmluZyBubyBjaGlsZC5gKTsKIAorICAgIHRlc3QoKCkgPT4geworICAg ICAgY29uc3QgcGFyZW50ID0gbm9kZS5jbG9uZU5vZGUoKTsKKyAgICAgIGNvbnN0IGNoaWxkID0g ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgndGVzdCcpOworICAgICAgcGFyZW50LmFwcGVuZENoaWxk KGNoaWxkKTsKKyAgICAgIHBhcmVudC5yZXBsYWNlQ2hpbGRyZW4oKTsKKyAgICAgIGFzc2VydF9h cnJheV9lcXVhbHMocGFyZW50LmNoaWxkTm9kZXMsIFtdKTsKKyAgICB9LCBgJHtub2RlTmFtZX0u cmVwbGFjZUNoaWxkcmVuKCkgd2l0aG91dCBhbnkgYXJndW1lbnQsIG9uIGEgcGFyZW50IGhhdmlu ZyBhIGNoaWxkLmApOworCiAgICAgdGVzdCgoKSA9PiB7CiAgICAgICBjb25zdCBwYXJlbnQgPSBu b2RlLmNsb25lTm9kZSgpOwogICAgICAgY29uc3QgY2hpbGQgPSBkb2N1bWVudC5jcmVhdGVFbGVt ZW50KCd0ZXN0Jyk7Cg== 411015 2020-10-10 12:02:15 -0700 2020-10-10 13:22:13 -0700 Patch bug-217537-20201010120214.patch text/plain 6625 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDliNjMwMWUwODA2OGMy Y2M3OGU4ZmM3OWJiZTZhMjU4OGJiMDViMi4uNTJhMzRkNDI0Y2MyMWYzZGU0ZTA1ZGIxYjIxZWFl NGU3NmQwNzllYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTEwLTEwICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICByZXBsYWNlQ2hpbGRyZW4oKSAo d2l0aCBubyBhcmd1bWVudHMpIHNpbGVudGx5IGRvZXMgbm90aGluZyByYXRoZXIgdGhhbiByZW1v dmluZyB0aGUgY2hpbGRyZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxNzUzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogZG9tL0NvbnRhaW5lck5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29u dGFpbmVyTm9kZTo6cmVwbGFjZUNoaWxkcmVuKTogUmVtb3ZlZCBpbmNvcnJlY3QgZWFybHkgcmV0 dXJuIHdoZW4gdGhlCisgICAgICAgIG5vZGUgaXMgbnVsbCwgaW5zdGVhZCBhZGRlZCBzb21lIG51 bGwgY2hlY2tzIGFyb3VuZCB0aGUgcGFydHMgb2YgdGhlIGFsZ29yaXRobSB0aGF0CisgICAgICAg IHNob3VsZCBiZSBza2lwcGVkIGluIHRoYXQgY2FzZS4KKwogMjAyMC0xMC0xMCAgWmFsYW4gQnVq dGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0ludGVncmF0aW9uXSBUdXJu IHBhcmVudC9maXJzdCBjaGlsZCBjaGVjayBpbnRvIGVzdGFibGlzaGVzSW5saW5lRm9ybWF0dGlu Z0NvbnRleHQgaW4gY2FuVXNlRm9yTGluZUxheW91dFdpdGhSZWFzb24KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9D b250YWluZXJOb2RlLmNwcAppbmRleCBlZGQwNzY1MDAxZGJhNGFjOGIxMzQ3NjdjNTE5NDQzM2I5 NjZhMjBlLi5mNWQ0OGEzNWQ4MjYxYjNhZjI5ODY1YzRkYjIyYzdjNjE1NGQwMjhiIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwCkBAIC05NjEsMjQgKzk2MSwyMyBAQCBFeGNlcHRp b25Pcjx2b2lkPiBDb250YWluZXJOb2RlOjpyZXBsYWNlQ2hpbGRyZW4oVmVjdG9yPE5vZGVPclN0 cmluZz4mJiB2ZWN0b3IpCiAgICAgYXV0byByZXN1bHQgPSBjb252ZXJ0Tm9kZXNPclN0cmluZ3NJ bnRvTm9kZShXVEZNb3ZlKHZlY3RvcikpOwogICAgIGlmIChyZXN1bHQuaGFzRXhjZXB0aW9uKCkp CiAgICAgICAgIHJldHVybiByZXN1bHQucmVsZWFzZUV4Y2VwdGlvbigpOwotCi0gICAgUmVmUHRy PE5vZGU+IG5vZGUgPSByZXN1bHQucmVsZWFzZVJldHVyblZhbHVlKCk7Ci0gICAgaWYgKCFub2Rl KQotICAgICAgICByZXR1cm4geyB9OworICAgIGF1dG8gbm9kZSA9IHJlc3VsdC5yZWxlYXNlUmV0 dXJuVmFsdWUoKTsKIAogICAgIC8vIHN0ZXAgMgotICAgIGF1dG8gdmFsaWRpdHlDaGVja1Jlc3Vs dCA9IGVuc3VyZVByZUluc2VydGlvblZhbGlkaXR5KCpub2RlLCBudWxscHRyKTsKLSAgICBpZiAo dmFsaWRpdHlDaGVja1Jlc3VsdC5oYXNFeGNlcHRpb24oKSkKLSAgICAgICAgcmV0dXJuIHZhbGlk aXR5Q2hlY2tSZXN1bHQucmVsZWFzZUV4Y2VwdGlvbigpOworICAgIGlmIChub2RlKSB7CisgICAg ICAgIGlmIChhdXRvIGNoZWNrUmVzdWx0ID0gZW5zdXJlUHJlSW5zZXJ0aW9uVmFsaWRpdHkoKm5v ZGUsIG51bGxwdHIpOyBjaGVja1Jlc3VsdC5oYXNFeGNlcHRpb24oKSkKKyAgICAgICAgICAgIHJl dHVybiBjaGVja1Jlc3VsdDsKKyAgICB9CiAKICAgICAvLyBzdGVwIDMKLSAgICBSZWY8Q29udGFp bmVyTm9kZT4gcHJvdGVjdGVkVGhpcygqdGhpcyk7CisgICAgYXV0byBwcm90ZWN0ZWRUaGlzID0g bWFrZVJlZigqdGhpcyk7CiAgICAgQ2hpbGRMaXN0TXV0YXRpb25TY29wZSBtdXRhdGlvbigqdGhp cyk7CiAgICAgcmVtb3ZlQWxsQ2hpbGRyZW5XaXRoU2NyaXB0QXNzZXJ0aW9uKENoaWxkQ2hhbmdl U291cmNlOjpBUEksIERlZmVyQ2hpbGRyZW5DaGFuZ2VkOjpObyk7CiAKLSAgICBhdXRvIGluc2Vy dFJlc3VsdCA9IGFwcGVuZENoaWxkV2l0aG91dFByZUluc2VydGlvblZhbGlkaXR5Q2hlY2soKm5v ZGUpOwotICAgIGlmIChpbnNlcnRSZXN1bHQuaGFzRXhjZXB0aW9uKCkpCi0gICAgICAgIHJldHVy biBpbnNlcnRSZXN1bHQucmVsZWFzZUV4Y2VwdGlvbigpOworICAgIGlmIChub2RlKSB7CisgICAg ICAgIGlmIChhdXRvIGFwcGVuZFJlc3VsdCA9IGFwcGVuZENoaWxkV2l0aG91dFByZUluc2VydGlv blZhbGlkaXR5Q2hlY2soKm5vZGUpOyBhcHBlbmRSZXN1bHQuaGFzRXhjZXB0aW9uKCkpCisgICAg ICAgICAgICByZXR1cm4gYXBwZW5kUmVzdWx0OworICAgIH0KIAogICAgIHJlYnVpbGRTVkdFeHRl bnNpb25zRWxlbWVudHNJZk5lY2Vzc2FyeSgpOwogICAgIGRpc3BhdGNoU3VidHJlZU1vZGlmaWVk RXZlbnQoKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDZkYzk0MzlkNjZlMWNh N2Q5ODg2MmFmNzhmNzhlOTJkMDgxNDBmYzkuLmUzMDVmOTk3YmVlOTljYTAwNjFjNmI4ZGZhNzE0 MTQ3MjBjMjZkYTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIwLTEwLTEwICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAg ICByZXBsYWNlQ2hpbGRyZW4oKSAod2l0aCBubyBhcmd1bWVudHMpIHNpbGVudGx5IGRvZXMgbm90 aGluZyByYXRoZXIgdGhhbiByZW1vdmluZyB0aGUgY2hpbGRyZW4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzUzNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9u b2Rlcy9QYXJlbnROb2RlLXJlcGxhY2VDaGlsZHJlbi1leHBlY3RlZC50eHQ6CisgICAgICAgICog d2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9QYXJlbnROb2RlLXJlcGxhY2VDaGlsZHJlbi5o dG1sOgorICAgICAgICBBZGRlZCBhIHRlc3Qgb2YgcmVwbGFjZUNoaWxkcmVuIHdpdGhvdXQgYW55 IGFyZ3VtZW50LCBvbiBhIHBhcmVudCBoYXZpbmcgYSBjaGlsZC4KKwogMjAyMC0xMC0wOSAgQW50 b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KIAogICAgICAgICBDU1MgdHJhbnNmb3Jt IGNvbXB1dGVkIHN0eWxlIHNob3VsZCBub3QgcmVmbGVjdCBpbmRpdmlkdWFsIHRyYW5zZm9ybSBw cm9wZXJ0aWVzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL2RvbS9ub2Rlcy9QYXJlbnROb2RlLXJlcGxhY2VDaGlsZHJlbi1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rl cy9QYXJlbnROb2RlLXJlcGxhY2VDaGlsZHJlbi1leHBlY3RlZC50eHQKaW5kZXggMDRiZGEwYjUx NTU1MDhiYTZlODEyZDYxNzc0ZWIxMDZjYTY3MTBiMC4uNTQyYTQwNzdiMTFlYmYyNzQzNTlkMGI2 ZjYxNjA3MzUyMzEyNzZlMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9kb20vbm9kZXMvUGFyZW50Tm9kZS1yZXBsYWNlQ2hpbGRyZW4tZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvZG9tL25vZGVzL1BhcmVudE5vZGUtcmVwbGFjZUNoaWxkcmVuLWV4cGVjdGVkLnR4dApAQCAt MTMsNiArMTMsNyBAQCBQQVNTIEVsZW1lbnQucmVwbGFjZUNoaWxkcmVuKCkgd2l0aCBudWxsIGFz IGFuIGFyZ3VtZW50LCBvbiBhIHBhcmVudCBoYXZpbmcgbm8gYwogUEFTUyBFbGVtZW50LnJlcGxh Y2VDaGlsZHJlbigpIHdpdGggdW5kZWZpbmVkIGFzIGFuIGFyZ3VtZW50LCBvbiBhIHBhcmVudCBo YXZpbmcgbm8gY2hpbGQuCiBQQVNTIEVsZW1lbnQucmVwbGFjZUNoaWxkcmVuKCkgd2l0aCBvbmx5 IHRleHQgYXMgYW4gYXJndW1lbnQsIG9uIGEgcGFyZW50IGhhdmluZyBubyBjaGlsZC4KIFBBU1Mg RWxlbWVudC5yZXBsYWNlQ2hpbGRyZW4oKSB3aXRoIG9ubHkgb25lIGVsZW1lbnQgYXMgYW4gYXJn dW1lbnQsIG9uIGEgcGFyZW50IGhhdmluZyBubyBjaGlsZC4KK1BBU1MgRWxlbWVudC5yZXBsYWNl Q2hpbGRyZW4oKSB3aXRob3V0IGFueSBhcmd1bWVudCwgb24gYSBwYXJlbnQgaGF2aW5nIGEgY2hp bGQuCiBQQVNTIEVsZW1lbnQucmVwbGFjZUNoaWxkcmVuKCkgd2l0aCBudWxsIGFzIGFuIGFyZ3Vt ZW50LCBvbiBhIHBhcmVudCBoYXZpbmcgYSBjaGlsZC4KIFBBU1MgRWxlbWVudC5yZXBsYWNlQ2hp bGRyZW4oKSB3aXRoIG9uZSBlbGVtZW50IGFuZCB0ZXh0IGFzIGFyZ3VtZW50LCBvbiBhIHBhcmVu dCBoYXZpbmcgYSBjaGlsZC4KIFBBU1MgRWxlbWVudC5yZXBsYWNlQ2hpbGRyZW4oKSBzaG91bGQg bW92ZSBub2RlcyBpbiB0aGUgcmlnaHQgb3JkZXIKQEAgLTIxLDYgKzIyLDcgQEAgUEFTUyBEb2N1 bWVudEZyYWdtZW50LnJlcGxhY2VDaGlsZHJlbigpIHdpdGggbnVsbCBhcyBhbiBhcmd1bWVudCwg b24gYSBwYXJlbnQgaGEKIFBBU1MgRG9jdW1lbnRGcmFnbWVudC5yZXBsYWNlQ2hpbGRyZW4oKSB3 aXRoIHVuZGVmaW5lZCBhcyBhbiBhcmd1bWVudCwgb24gYSBwYXJlbnQgaGF2aW5nIG5vIGNoaWxk LgogUEFTUyBEb2N1bWVudEZyYWdtZW50LnJlcGxhY2VDaGlsZHJlbigpIHdpdGggb25seSB0ZXh0 IGFzIGFuIGFyZ3VtZW50LCBvbiBhIHBhcmVudCBoYXZpbmcgbm8gY2hpbGQuCiBQQVNTIERvY3Vt ZW50RnJhZ21lbnQucmVwbGFjZUNoaWxkcmVuKCkgd2l0aCBvbmx5IG9uZSBlbGVtZW50IGFzIGFu IGFyZ3VtZW50LCBvbiBhIHBhcmVudCBoYXZpbmcgbm8gY2hpbGQuCitQQVNTIERvY3VtZW50RnJh Z21lbnQucmVwbGFjZUNoaWxkcmVuKCkgd2l0aG91dCBhbnkgYXJndW1lbnQsIG9uIGEgcGFyZW50 IGhhdmluZyBhIGNoaWxkLgogUEFTUyBEb2N1bWVudEZyYWdtZW50LnJlcGxhY2VDaGlsZHJlbigp IHdpdGggbnVsbCBhcyBhbiBhcmd1bWVudCwgb24gYSBwYXJlbnQgaGF2aW5nIGEgY2hpbGQuCiBQ QVNTIERvY3VtZW50RnJhZ21lbnQucmVwbGFjZUNoaWxkcmVuKCkgd2l0aCBvbmUgZWxlbWVudCBh bmQgdGV4dCBhcyBhcmd1bWVudCwgb24gYSBwYXJlbnQgaGF2aW5nIGEgY2hpbGQuCiBQQVNTIERv Y3VtZW50RnJhZ21lbnQucmVwbGFjZUNoaWxkcmVuKCkgc2hvdWxkIG1vdmUgbm9kZXMgaW4gdGhl IHJpZ2h0IG9yZGVyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBs YXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9QYXJlbnROb2RlLXJlcGxhY2VDaGlsZHJlbi5odG1sIGIv TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vbm9kZXMvUGFy ZW50Tm9kZS1yZXBsYWNlQ2hpbGRyZW4uaHRtbAppbmRleCA2NTU3ZGI0NDEyODQ3YmU1OWY0ZWNl ZGM4OTczMWQ2ZmE4OTMxNGI5Li5jZDQ4OTdjMzc4NGZjY2RlYmIzNjU1ZGQ2OTIyMzQzN2Y2M2Qw MGQ1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2RvbS9ub2Rlcy9QYXJlbnROb2RlLXJlcGxhY2VDaGlsZHJlbi5odG1sCisrKyBiL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL25vZGVzL1BhcmVudE5v ZGUtcmVwbGFjZUNoaWxkcmVuLmh0bWwKQEAgLTQwLDYgKzQwLDE0IEBACiAgICAgICBhc3NlcnRf YXJyYXlfZXF1YWxzKHBhcmVudC5jaGlsZE5vZGVzLCBbeF0pOwogICAgIH0sIGAke25vZGVOYW1l fS5yZXBsYWNlQ2hpbGRyZW4oKSB3aXRoIG9ubHkgb25lIGVsZW1lbnQgYXMgYW4gYXJndW1lbnQs IG9uIGEgcGFyZW50IGhhdmluZyBubyBjaGlsZC5gKTsKIAorICAgIHRlc3QoKCkgPT4geworICAg ICAgY29uc3QgcGFyZW50ID0gbm9kZS5jbG9uZU5vZGUoKTsKKyAgICAgIGNvbnN0IGNoaWxkID0g ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgndGVzdCcpOworICAgICAgcGFyZW50LmFwcGVuZENoaWxk KGNoaWxkKTsKKyAgICAgIHBhcmVudC5yZXBsYWNlQ2hpbGRyZW4oKTsKKyAgICAgIGFzc2VydF9h cnJheV9lcXVhbHMocGFyZW50LmNoaWxkTm9kZXMsIFtdKTsKKyAgICB9LCBgJHtub2RlTmFtZX0u cmVwbGFjZUNoaWxkcmVuKCkgd2l0aG91dCBhbnkgYXJndW1lbnQsIG9uIGEgcGFyZW50IGhhdmlu ZyBhIGNoaWxkLmApOworCiAgICAgdGVzdCgoKSA9PiB7CiAgICAgICBjb25zdCBwYXJlbnQgPSBu b2RlLmNsb25lTm9kZSgpOwogICAgICAgY29uc3QgY2hpbGQgPSBkb2N1bWVudC5jcmVhdGVFbGVt ZW50KCd0ZXN0Jyk7Cg==