<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>217514</bug_id>
          
          <creation_ts>2020-10-09 04:35:49 -0700</creation_ts>
          <short_desc>[GLIB] Fix linking error for systems not providing &lt;sys/memfd.h&gt;</short_desc>
          <delta_ts>2020-10-14 10:45:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sergio Villar Senin">svillar</reporter>
          <assigned_to name="Sergio Villar Senin">svillar</assigned_to>
          <cc>achristensen</cc>
    
    <cc>annulen</cc>
    
    <cc>aperez</cc>
    
    <cc>cgarcia</cc>
    
    <cc>darin</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>pgriffis</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>sergio</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1696180</commentid>
    <comment_count>0</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2020-10-09 04:35:49 -0700</bug_when>
    <thetext>[GLIB] Fix linking error for systems not providing &lt;sys/memfd.h&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1696182</commentid>
    <comment_count>1</comment_count>
      <attachid>410931</attachid>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2020-10-09 04:38:40 -0700</bug_when>
    <thetext>Created attachment 410931
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1696188</commentid>
    <comment_count>2</comment_count>
      <attachid>410934</attachid>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2020-10-09 05:13:35 -0700</bug_when>
    <thetext>Created attachment 410934
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1696189</commentid>
    <comment_count>3</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2020-10-09 05:14:33 -0700</bug_when>
    <thetext>Thanks for the review Carlos!.

Adrian suggested to do a compile check, so I&apos;m attaching an alternative patch with some extra cmake changes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1696191</commentid>
    <comment_count>4</comment_count>
      <attachid>410931</attachid>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2020-10-09 05:19:38 -0700</bug_when>
    <thetext>Comment on attachment 410931
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410931&amp;action=review

I think there is a better approach, as outlined below.

&gt; Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:45
&gt;  #include &lt;sys/memfd.h&gt;

It seems that there was a mistake in the manual pages for memfd_create,
and it was never intended for it to suggest using &lt;sys/memfd.h&gt;. There is
some discussion about that here.

  https://stackoverflow.com/questions/56615488/getting-gcc-error-sys-memfd-h-no-such-file-or-directory

&gt; Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:49
&gt; +#include &lt;sys/mman.h&gt;

The &lt;sys/mman.h&gt; header always exists, we do not need to check whether it&apos;s available.
What we can do is:

  1. Always include &lt;sys/mman.h&gt;. This also works for other systems, for example
     FreeBSD also has a memfd_create() function defined in this header:
     https://github.com/freebsd/freebsd/commit/575e351fdd996f72921b87e71c2c26466e887ed2

  2. If the MFD_* macros are not defined, include &lt;linux/memfd.h&gt; and use syscall2()
     Note: Use this fall only for linux, e.g. with a __has_include(&lt;linux/memfd.h&gt;) guard.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1696192</commentid>
    <comment_count>5</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2020-10-09 05:22:05 -0700</bug_when>
    <thetext>On a second thought, I think we do not need the CMake compile check
when using the approach of always using &lt;sys/mman.h&gt; and the fallback
with &lt;linux/memfd.h&gt;+syscall2() only on Linux. That will also cover
the BSDs which implement a compatible memfd_create() function, without
adding complexity in CMake.

BTW, thanks Sergio for the patch, and sorry for the back and forth
about the CMake check O:-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1696193</commentid>
    <comment_count>6</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2020-10-09 05:28:06 -0700</bug_when>
    <thetext>Does bubblewrap work on BSD at all? BubblewrapLauncher makes unconditional use of seccomp which is Linux-only.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1696209</commentid>
    <comment_count>7</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2020-10-09 06:58:14 -0700</bug_when>
    <thetext>OTOH, we have other usage of memfd in Platform/unix/SharedMemoryUnix.cpp, where it indeed could be checked in more cross-platform way.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1696217</commentid>
    <comment_count>8</comment_count>
    <who name="Patrick Griffis">pgriffis</who>
    <bug_when>2020-10-09 08:07:50 -0700</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #6)
&gt; Does bubblewrap work on BSD at all?

No it is Linux specific.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1696588</commentid>
    <comment_count>9</comment_count>
      <attachid>410934</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2020-10-11 00:24:04 -0700</bug_when>
    <thetext>Comment on attachment 410934
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410934&amp;action=review

&gt; Source/cmake/OptionsCommon.cmake:-126
&gt; -WEBKIT_CHECK_HAVE_INCLUDE(HAVE_LINUX_MEMFD_H linux/memfd.h)

We use this in SharedMemoryUnix.cpp</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1697203</commentid>
    <comment_count>10</comment_count>
      <attachid>411203</attachid>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2020-10-13 02:10:18 -0700</bug_when>
    <thetext>Created attachment 411203
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1697206</commentid>
    <comment_count>11</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2020-10-13 02:21:29 -0700</bug_when>
    <thetext>I think it would be more correct to add compilation tests for memfd_create and use its results in all places where memfd is used</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1697775</commentid>
    <comment_count>12</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-10-14 10:44:58 -0700</bug_when>
    <thetext>Committed r268472: &lt;https://trac.webkit.org/changeset/268472&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411203.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1697776</commentid>
    <comment_count>13</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-10-14 10:45:22 -0700</bug_when>
    <thetext>&lt;rdar://problem/70299014&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>410931</attachid>
            <date>2020-10-09 04:38:40 -0700</date>
            <delta_ts>2020-10-13 02:10:01 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-217514-20201009133839.patch</filename>
            <type>text/plain</type>
            <size>1297</size>
            <attacher name="Sergio Villar Senin">svillar</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MjUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY3N2Q4YWJjMGVjMWQwNGU0
OWQxMTJhNjhjNWIzNjQyN2FmYmU2MWUuLjE5Zjg2YzE5ZjFkNGY5MmM2ZWQyMjQ1ZjJlYmYyMGZh
NjMxNTkyYTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMTAtMDkgIFNlcmdpbyBW
aWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dMSUJdIEZpeCBs
aW5raW5nIGVycm9yIGZvciBzeXN0ZW1zIG5vdCBwcm92aWRpbmcgPHN5cy9tZW1mZC5oPgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3NTE0CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv
TGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwOiBDaGVjayA8c3lzL21tYW4uaD4g
Zm9yIHBsYXRmb3JtcyBub3QgcHJvdmlkaW5nIDxzeXMvbWVtZmQuaD4uCisKIDIwMjAtMTAtMDgg
IEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViQXV0aG5d
IEltcGxlbWVudCBhIGR1bW15IFdlYkF1dGhlbnRpY2F0aW9uQWdlbnQKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExhdW5jaGVyLmNw
cCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExhdW5j
aGVyLmNwcAppbmRleCAxMjcyNTZiN2VlMzkyYzBjMjY4Yzk4MzE4ZDc5MGY3MzdiYWZhM2Y4Li5m
YjYxY2Q4MGE5NmU2NGM1NDA5OWNmYWJmMTRiNjZjMzFjODMzODhmIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1YmJsZXdyYXBMYXVuY2hlci5jcHAK
KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1
bmNoZXIuY3BwCkBAIC00NCw2ICs0NCwxMCBAQAogCiAjaW5jbHVkZSA8c3lzL21lbWZkLmg+CiAK
KyNlbGlmIF9faGFzX2luY2x1ZGUoPHN5cy9tbWFuLmg+KQorCisjaW5jbHVkZSA8c3lzL21tYW4u
aD4KKwogI2Vsc2UKIAogLy8gVGhlc2UgZGVmaW5lcyB3ZXJlIGFkZGVkIGluIGdsaWJjIDIuMjcs
IHRoZSBzYW1lIHJlbGVhc2UgdGhhdCBhZGRlZCBtZW1mZF9jcmVhdGUuCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>410934</attachid>
            <date>2020-10-09 05:13:35 -0700</date>
            <delta_ts>2020-10-13 02:10:05 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-217514-20201009141333.patch</filename>
            <type>text/plain</type>
            <size>3338</size>
            <attacher name="Sergio Villar Senin">svillar</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY3N2Q4YWJjMGVjMWQwNGU0
OWQxMTJhNjhjNWIzNjQyN2FmYmU2MWUuLjM1MWE3ZDRmN2JiZjM4NzgxOGRjMmI0ZDRkMjFlNWQ4
M2MyNjlkYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMTAtMDkgIFNlcmdpbyBW
aWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dMSUJdIEZpeCBs
aW5raW5nIGVycm9yIGZvciBzeXN0ZW1zIG5vdCBwcm92aWRpbmcgPHN5cy9tZW1mZC5oPgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3NTE0CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv
TGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwOiBDaGVjayA8c3lzL21tYW4uaD4g
b3IgZXZlbiA8bGludXgvbWVtZmQuaD4gZm9yIHBsYXRmb3JtcyBub3QgcHJvdmlkaW5nIDxzeXMv
bWVtZmQuaD4uCisKIDIwMjAtMTAtMDggIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNv
bT4KIAogICAgICAgICBbV2ViQXV0aG5dIEltcGxlbWVudCBhIGR1bW15IFdlYkF1dGhlbnRpY2F0
aW9uQWdlbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2ds
aWIvQnViYmxld3JhcExhdW5jaGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5j
aGVyL2dsaWIvQnViYmxld3JhcExhdW5jaGVyLmNwcAppbmRleCAxMjcyNTZiN2VlMzkyYzBjMjY4
Yzk4MzE4ZDc5MGY3MzdiYWZhM2Y4Li45MDM2YzZhNTQyNWMzM2EzMWNhOWEzODY4ZGEwODhkYTBi
YzQ4MTkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGli
L0J1YmJsZXdyYXBMYXVuY2hlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1
bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwCkBAIC00MCwxMiArNDAsMjQgQEAKICNk
ZWZpbmUgQkFTRV9ESVJFQ1RPUlkgIndwZSIKICNlbmRpZgogCi0jaWYgX19oYXNfaW5jbHVkZSg8
c3lzL21lbWZkLmg+KQorI2lmZGVmIEhBVkVfTUVNRkRfQ1JFQVRFCisKKyNpZiBfX2hhc19pbmNs
dWRlKDxzeXMvbW1hbi5oPikKKworI2luY2x1ZGUgPHN5cy9tbWFuLmg+CisKKyNlbGlmIF9faGFz
X2luY2x1ZGUoPHN5cy9tZW1mZC5oPikKIAogI2luY2x1ZGUgPHN5cy9tZW1mZC5oPgogCiAjZWxz
ZQogCisjaW5jbHVkZSA8bGludXgvbWVtZmQuaD4KKworI2VuZGlmCisKKyNlbHNlCisKIC8vIFRo
ZXNlIGRlZmluZXMgd2VyZSBhZGRlZCBpbiBnbGliYyAyLjI3LCB0aGUgc2FtZSByZWxlYXNlIHRo
YXQgYWRkZWQgbWVtZmRfY3JlYXRlLgogLy8gQnV0IHRoZSBrZXJuZWwgYWRkZWQgYWxsIG9mIHRo
aXMgaW4gTGludXggMy4xNy4gU28gaXQncyB0b3RhbGx5IHNhZmUgZm9yIHVzIHRvCiAvLyBkZXBl
bmQgb24sIGFzIGxvbmcgYXMgd2UgZGVmaW5lIGl0IGFsbCBvdXJzZWx2ZXMuIFJlbW92ZSB0aGlz
IG9uY2Ugd2UgZGVwZW5kIG9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1v
bi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4IDNjYzg1NjBm
ZTE0YjExZDRiNjc0M2NhOWM1OTAyM2U1ODBiYjMwYWIuLmI2NjE4ZGQ1OTFkMWM5ZThhNDBiMTAz
MzY3ZTk3ZGNhMzM0NDNkYzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9u
LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBAIC0xMjMsNyAr
MTIzLDYgQEAgV0VCS0lUX0NIRUNLX0hBVkVfSU5DTFVERShIQVZFX1BUSFJFQURfTlBfSCBwdGhy
ZWFkX25wLmgpCiBXRUJLSVRfQ0hFQ0tfSEFWRV9JTkNMVURFKEhBVkVfU1lTX1BBUkFNX0ggc3lz
L3BhcmFtLmgpCiBXRUJLSVRfQ0hFQ0tfSEFWRV9JTkNMVURFKEhBVkVfU1lTX1RJTUVfSCBzeXMv
dGltZS5oKQogV0VCS0lUX0NIRUNLX0hBVkVfSU5DTFVERShIQVZFX1NZU19USU1FQl9IIHN5cy90
aW1lYi5oKQotV0VCS0lUX0NIRUNLX0hBVkVfSU5DTFVERShIQVZFX0xJTlVYX01FTUZEX0ggbGlu
dXgvbWVtZmQuaCkKIAogIyBDaGVjayBmb3IgZnVuY3Rpb25zCiBXRUJLSVRfQ0hFQ0tfSEFWRV9G
VU5DVElPTihIQVZFX0FMSUdORURfTUFMTE9DIF9hbGlnbmVkX21hbGxvYykKQEAgLTEzMyw2ICsx
MzIsOCBAQCBXRUJLSVRfQ0hFQ0tfSEFWRV9GVU5DVElPTihIQVZFX01BTExPQ19UUklNIG1hbGxv
Y190cmltKQogV0VCS0lUX0NIRUNLX0hBVkVfRlVOQ1RJT04oSEFWRV9TVFJOU1RSIHN0cm5zdHIp
CiBXRUJLSVRfQ0hFQ0tfSEFWRV9GVU5DVElPTihIQVZFX1RJTUVHTSB0aW1lZ20pCiBXRUJLSVRf
Q0hFQ0tfSEFWRV9GVU5DVElPTihIQVZFX1ZBU1BSSU5URiB2YXNwcmludGYpCitXRUJLSVRfQ0hF
Q0tfSEFWRV9GVU5DVElPTihIQVZFX01FTUZEX0NSRUFURSBtZW1mZF9jcmVhdGUpCisKIAogIyBD
aGVjayBmb3Igc3ltYm9scwogV0VCS0lUX0NIRUNLX0hBVkVfU1lNQk9MKEhBVkVfUkVHRVhfSCBy
ZWdleGVjIHJlZ2V4LmgpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXgg
YzAzZjNkNGI1MGFmY2IyMDlmMmQ5ZDg5Njk2MjRlNThjNTBjNzI4Ni4uYmNlYjQ2YTI1YTZjMDZi
YjJkM2RmNGMwNTMxMzRmNzE4ZWEwM2I5OCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0No
YW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTEwLTA5ICBTZXJnaW8gVmlsbGFyIFNlbmlu
ICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHTElCXSBGaXggbGlua2luZyBlcnJv
ciBmb3Igc3lzdGVtcyBub3QgcHJvdmlkaW5nIDxzeXMvbWVtZmQuaD4KKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzUxNAorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnND
b21tb24uY21ha2U6IFJlcGxhY2VkIHRoZSBpbmNsdWRlIGNoZWNrIGZvciBsaW51eC9tZW1mZCBi
eSBhIGZ1bmN0aW9uIGNoZWNrIGZvciBtZW1mZF9jcmVhdGUuCisKIDIwMjAtMTAtMDggIEtlaXRo
IFJvbGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBjb3B5LXdlYmtp
dGxpYnJhcmllcy10by1wcm9kdWN0LWRpcmVjdG9yeQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>411203</attachid>
            <date>2020-10-13 02:10:18 -0700</date>
            <delta_ts>2020-10-14 10:44:59 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-217514-20201013111016.patch</filename>
            <type>text/plain</type>
            <size>1993</size>
            <attacher name="Sergio Villar Senin">svillar</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY3N2Q4YWJjMGVjMWQwNGU0
OWQxMTJhNjhjNWIzNjQyN2FmYmU2MWUuLjA1NzIwMTMyZTA4MjkyZWEzMGUyZWIzMGFmZjIwNWNh
MGE3YTUxYTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMTAtMDkgIFNlcmdpbyBW
aWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dMSUJdIEZpeCBs
aW5raW5nIGVycm9yIGZvciBzeXN0ZW1zIG5vdCBwcm92aWRpbmcgPHN5cy9tZW1mZC5oPgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3NTE0CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv
TGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwOiBVbmNvbmRpdGlvbmFsbHkgY2hl
Y2sgZm9yIDxzeXMvbW1hbi5oPiB3aGljaCBzaG91bGQgYWx3YXlzIGV4aXN0IGluc3RlYWQKKyAg
ICAgICAgb2YgPHN5cy9tZW1mZC5oPi4gQWxzbyBkZWZpbmUgdGhlIGZhbGxiYWNrIHdpdGggc3lz
Y2FsbCgpIG9ubHkgZm9yIGxpbnV4IHN5c3RlbXMgKGFzIGl0IHJlcXVpcmVzIDxsaW51eC9tZW1m
ZC5oPikuCisKIDIwMjAtMTAtMDggIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4K
IAogICAgICAgICBbV2ViQXV0aG5dIEltcGxlbWVudCBhIGR1bW15IFdlYkF1dGhlbnRpY2F0aW9u
QWdlbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIv
QnViYmxld3JhcExhdW5jaGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVy
L2dsaWIvQnViYmxld3JhcExhdW5jaGVyLmNwcAppbmRleCAxMjcyNTZiN2VlMzkyYzBjMjY4Yzk4
MzE4ZDc5MGY3MzdiYWZhM2Y4Li42OWI0ZGM2YTZhMGJjZDk0YmFmNmZhNWQzZDJiMjMxMGM0MGNi
ZGQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1
YmJsZXdyYXBMYXVuY2hlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNo
ZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwCkBAIC00MCwxMSArNDAsMTMgQEAKICNkZWZp
bmUgQkFTRV9ESVJFQ1RPUlkgIndwZSIKICNlbmRpZgogCi0jaWYgX19oYXNfaW5jbHVkZSg8c3lz
L21lbWZkLmg+KQorI2luY2x1ZGUgPHN5cy9tbWFuLmg+CiAKLSNpbmNsdWRlIDxzeXMvbWVtZmQu
aD4KKyNpZm5kZWYgTUZEX0FMTE9XX1NFQUxJTkcKIAotI2Vsc2UKKyNpZiBIQVZFKExJTlVYX01F
TUZEX0gpCisKKyNpbmNsdWRlIDxsaW51eC9tZW1mZC5oPgogCiAvLyBUaGVzZSBkZWZpbmVzIHdl
cmUgYWRkZWQgaW4gZ2xpYmMgMi4yNywgdGhlIHNhbWUgcmVsZWFzZSB0aGF0IGFkZGVkIG1lbWZk
X2NyZWF0ZS4KIC8vIEJ1dCB0aGUga2VybmVsIGFkZGVkIGFsbCBvZiB0aGlzIGluIExpbnV4IDMu
MTcuIFNvIGl0J3MgdG90YWxseSBzYWZlIGZvciB1cyB0bwpAQCAtNTksMTMgKzYxLDEzIEBACiAj
ZGVmaW5lIEZfU0VBTF9HUk9XICAgMHgwMDA0CiAjZGVmaW5lIEZfU0VBTF9XUklURSAgMHgwMDA4
CiAKLSNkZWZpbmUgTUZEX0FMTE9XX1NFQUxJTkcgMlUKLQogc3RhdGljIGludCBtZW1mZF9jcmVh
dGUoY29uc3QgY2hhciogbmFtZSwgdW5zaWduZWQgZmxhZ3MpCiB7CiAgICAgcmV0dXJuIHN5c2Nh
bGwoX19OUl9tZW1mZF9jcmVhdGUsIG5hbWUsIGZsYWdzKTsKIH0KLSNlbmRpZgorI2VuZGlmIC8v
ICNpZiBIQVZFKExJTlVYX01FTUZEX0gpCisKKyNlbmRpZiAvLyAjaWZuZGVmIE1GRF9BTExPV19T
RUFMSU5HCiAKIG5hbWVzcGFjZSBXZWJLaXQgewogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>