217507 2020-10-09 00:29:28 -0700 [WinCairo][GraphicsLayerTextureMapper] Image layers are entirely clipped since r260174 2020-10-09 12:52:18 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii cmarcelo don.olmstead ews-watchlist kondapallykalyan luiz noam ross.kirsling tomoki.imai webkit-bug-importer oldest_to_newest 1696145 0 fujii 2020-10-09 00:29:28 -0700 [WinCairo][GraphicsLayerTextureMapper] Image layers are entirely clipped since r260174 For example, compositing/images/content-image.html shows no image. Some images aren't shown in http://www.satine.org/research/webkit/snowleopard/snowstack.html 1696146 1 fujii 2020-10-09 00:30:51 -0700 since r260174 Bug 210544 – TextureMapper renders video element with "object-fit: cover" incorrectly 1696148 2 410921 fujii 2020-10-09 00:43:33 -0700 Created attachment 410921 Patch 1696161 3 tomoki.imai 2020-10-09 02:08:52 -0700 (In reply to Fujii Hironori from comment #2) > Created attachment 410921 [details] > Patch Thanks Fujii -san for the patch, and sorry for making a regression in WinCairo. The change looks good to me, but I'd like to ask Ross, Don to review and r+ in case. 1696318 4 410921 fujii 2020-10-09 12:51:25 -0700 Comment on attachment 410921 Patch Clearing flags on attachment: 410921 Committed r268280: <https://trac.webkit.org/changeset/268280> 1696319 5 fujii 2020-10-09 12:51:29 -0700 All reviewed patches have been landed. Closing bug. 1696321 6 webkit-bug-importer 2020-10-09 12:52:18 -0700 <rdar://problem/70149429> 410921 2020-10-09 00:43:33 -0700 2020-10-09 12:51:25 -0700 Patch bug-217507-20201009164331.patch text/plain 3796 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzA2MzllNTIwYzdkYmRi ZWZjZGIyZTU5ODNmMDVmY2M1NzM2NDkxNy4uOGMyYjAwY2JlMmIzN2Y5ODI1YWQ3NmVlMTE2MWJj ZjBkNDYyZjMyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTEwLTA5ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWly b11bR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXJdIEltYWdlIGxheWVycyBhcmUgZW50aXJlbHkg Y2xpcHBlZCBzaW5jZSByMjYwMTc0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTc1MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICByMjYwMTc0IGFkZGVkIGNvbnRlbnRzQ2xpcHBpbmdSZWN0IHRvIFRleHR1 cmVNYXBwZXJMYXllcjo6U3RhdGUgdG8KKyAgICAgICAgY2xpcCB0aGUgY29udGVudC4gSG93ZXZl ciwgaXQgaW1wbGVtZW50ZWQgc2V0Q29udGVudHNDbGlwcGluZ1JlY3QKKyAgICAgICAgb25seSBm b3IgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyIGJ1dCBmb3IKKyAgICAgICAgR3JhcGhpY3NMYXll clRleHR1cmVNYXBwZXIuIEJlY2F1c2UgdGhlIGluaXRpYWwgdmFsdWUgb2YKKyAgICAgICAgY29u dGVudHNDbGlwcGluZ1JlY3QgaXMgZW1wdHksIGVudGlyZSBpbWFnZSBsYXllcnMgYXJlIGNsaXBw ZWQgaW4KKyAgICAgICAgR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIuCisKKyAgICAgICAgRXhp c3RpbmcgY29tcG9zaXRpbmcvaW1hZ2VzIHRlc3RzIGNvdmVycyB0aGlzIGNoYW5nZSwgYnV0IFdp bkNhaXJvCisgICAgICAgIERSVCBhbmQgV1RSIGRvbid0IHN1cHBvcnQgcGl4ZWwgZHVtcCBpbiBB QyBtb2RlIGF0IHRoZSBtb21lbnQgKEJ1ZyAyMTUwNDEpLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyOjpzZXRDb250ZW50c0NsaXBwaW5n UmVjdCk6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllclRleHR1cmVNYXBw ZXI6OmNvbW1pdExheWVyQ2hhbmdlcyk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4 bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmg6CisKIDIwMjAtMTAtMDggIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgW1dpbkNhaXJvXSBB U1NFUlRJT04gRkFJTEVEOiBtX3JlbmRlcmluZ1VwZGF0ZVJlbWFpbmluZ1N0ZXBzLmxhc3QoKS5p c0VtcHR5KCkgaW4gV2ViQ29yZTo6UGFnZTo6ZmluYWxpemVSZW5kZXJpbmdVcGRhdGUgc2luY2Ug cjI2ODA3NQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4 bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5jcHAKaW5kZXgg YjcyNDNlOTk0YzAwNGQyMjE1ZGNiOTRjMWU0ZWViZGEwZTkyNTQwOC4uNzAxZmNiNGVlZjBhNGFl YWE0NmEwYjA2ZmYxNDY5NDBlNzJmMTc3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRl eHR1cmVNYXBwZXIuY3BwCkBAIC0yNzIsNiArMjcyLDE1IEBAIHZvaWQgR3JhcGhpY3NMYXllclRl eHR1cmVNYXBwZXI6OnNldENvbnRlbnRzUmVjdChjb25zdCBGbG9hdFJlY3QmIHZhbHVlKQogICAg IG5vdGlmeUNoYW5nZShDb250ZW50c1JlY3RDaGFuZ2UpOwogfQogCit2b2lkIEdyYXBoaWNzTGF5 ZXJUZXh0dXJlTWFwcGVyOjpzZXRDb250ZW50c0NsaXBwaW5nUmVjdChjb25zdCBGbG9hdFJvdW5k ZWRSZWN0JiByZWN0KQoreworICAgIGlmIChyZWN0ID09IG1fY29udGVudHNDbGlwcGluZ1JlY3Qp CisgICAgICAgIHJldHVybjsKKworICAgIEdyYXBoaWNzTGF5ZXI6OnNldENvbnRlbnRzQ2xpcHBp bmdSZWN0KHJlY3QpOworICAgIG5vdGlmeUNoYW5nZShDb250ZW50c1JlY3RDaGFuZ2UpOworfQor CiB2b2lkIEdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyOjpzZXRDb250ZW50c1RvU29saWRDb2xv cihjb25zdCBDb2xvciYgY29sb3IpCiB7CiAgICAgaWYgKGNvbG9yID09IG1fc29saWRDb2xvcikK QEAgLTQyNSw4ICs0MzQsMTAgQEAgdm9pZCBHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6Y29t bWl0TGF5ZXJDaGFuZ2VzKCkKICAgICBpZiAobV9jaGFuZ2VNYXNrICYgUHJlc2VydmVzM0RDaGFu Z2UpCiAgICAgICAgIG1fbGF5ZXIuc2V0UHJlc2VydmVzM0QocHJlc2VydmVzM0QoKSk7CiAKLSAg ICBpZiAobV9jaGFuZ2VNYXNrICYgQ29udGVudHNSZWN0Q2hhbmdlKQorICAgIGlmIChtX2NoYW5n ZU1hc2sgJiBDb250ZW50c1JlY3RDaGFuZ2UpIHsKICAgICAgICAgbV9sYXllci5zZXRDb250ZW50 c1JlY3QoY29udGVudHNSZWN0KCkpOworICAgICAgICBtX2xheWVyLnNldENvbnRlbnRzQ2xpcHBp bmdSZWN0KGNvbnRlbnRzQ2xpcHBpbmdSZWN0KCkpOworICAgIH0KIAogICAgIGlmIChtX2NoYW5n ZU1hc2sgJiBNYXNrc1RvQm91bmRzQ2hhbmdlKQogICAgICAgICBtX2xheWVyLnNldE1hc2tzVG9C b3VuZHMobWFza3NUb0JvdW5kcygpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5oIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFw cGVyLmgKaW5kZXggZTY2MTVlMWNkNjg2MjRhZjNlOGE5OWFjZGFkYjJlNTg4ODU0NDVkZS4uYjkz YzFkODNiZmQ0Zjg0NmM5OTQ1MGY1ODM4M2JlOWM1YjEyOGY5MSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFw cGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBo aWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmgKQEAgLTY2LDYgKzY2LDcgQEAgcHVibGljOgogICAgIHZv aWQgc2V0TmVlZHNEaXNwbGF5SW5SZWN0KGNvbnN0IEZsb2F0UmVjdCYsIFNob3VsZENsaXBUb0xh eWVyID0gQ2xpcFRvTGF5ZXIpIG92ZXJyaWRlOwogICAgIHZvaWQgc2V0Q29udGVudHNOZWVkc0Rp c3BsYXkoKSBvdmVycmlkZTsKICAgICB2b2lkIHNldENvbnRlbnRzUmVjdChjb25zdCBGbG9hdFJl Y3QmKSBvdmVycmlkZTsKKyAgICB2b2lkIHNldENvbnRlbnRzQ2xpcHBpbmdSZWN0KGNvbnN0IEZs b2F0Um91bmRlZFJlY3QmKSBvdmVycmlkZTsKIAogICAgIGJvb2wgYWRkQW5pbWF0aW9uKGNvbnN0 IEtleWZyYW1lVmFsdWVMaXN0JiwgY29uc3QgRmxvYXRTaXplJiwgY29uc3QgQW5pbWF0aW9uKiwg Y29uc3QgU3RyaW5nJiwgZG91YmxlKSBvdmVycmlkZTsKICAgICB2b2lkIHBhdXNlQW5pbWF0aW9u KGNvbnN0IFN0cmluZyYsIGRvdWJsZSkgb3ZlcnJpZGU7Cg==