217491 2020-10-08 13:28:14 -0700 [GPU Process] Use correct GPU runtime settings when creating the dynamic IOKit sandbox extensions for the WebContent process 2020-10-09 12:35:54 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan webkit-unassigned bfulgham simon.fraser webkit-bug-importer youennf oldest_to_newest 1696013 0 pvollan 2020-10-08 13:28:14 -0700 Currently, the creation of the dynamic IOKit sandbox extensions for the WebContent process is incorrectly using the same GPU runtime settings as when creating Media related dynamic mach-lookup extensions. 1696014 1 pvollan 2020-10-08 13:28:50 -0700 <rdar://problem/70066087> 1696026 2 410882 pvollan 2020-10-08 14:13:32 -0700 Created attachment 410882 Patch 1696195 3 410882 youennf 2020-10-09 05:56:29 -0700 Comment on attachment 410882 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410882&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:486 > + || !m_defaultPageGroup->preferences().captureVideoInGPUProcessEnabled() We can also capture in UIProcess, in which case we might not need the gpuIOKitExtensionHandles for capture purposes. 1696258 4 410948 pvollan 2020-10-09 10:29:06 -0700 Created attachment 410948 Patch 1696259 5 pvollan 2020-10-09 10:29:28 -0700 (In reply to youenn fablet from comment #3) > Comment on attachment 410882 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410882&action=review > > > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:486 > > + || !m_defaultPageGroup->preferences().captureVideoInGPUProcessEnabled() > > We can also capture in UIProcess, in which case we might not need the > gpuIOKitExtensionHandles for capture purposes. Thanks for reviewing! I have updated the patch. 1696315 6 ews-feeder 2020-10-09 12:35:53 -0700 Committed r268278: <https://trac.webkit.org/changeset/268278> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410948. 410882 2020-10-08 14:13:32 -0700 2020-10-09 05:56:29 -0700 Patch 217491.patch text/plain 2685 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjgyMDYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEwLTA4ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbR1BVIFByb2Nlc3NdIFVzZSBj b3JyZWN0IEdQVSBydW50aW1lIHNldHRpbmdzIHdoZW4gY3JlYXRpbmcgdGhlIGR5bmFtaWMgSU9L aXQgc2FuZGJveCBleHRlbnNpb25zIGZvciB0aGUgV2ViQ29udGVudCBwcm9jZXNzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTc0OTEKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzcwMDY2MDg3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEN1cnJlbnRseSwgdGhlIGNyZWF0aW9uIG9mIHRoZSBkeW5hbWlj IElPS2l0IHNhbmRib3ggZXh0ZW5zaW9ucyBmb3IgdGhlIFdlYkNvbnRlbnQgcHJvY2VzcyBpcyBp bmNvcnJlY3RseSB1c2luZyB0aGUgc2FtZSBHUFUKKyAgICAgICAgcnVudGltZSBzZXR0aW5ncyBh cyB3aGVuIGNyZWF0aW5nIE1lZGlhIHJlbGF0ZWQgZHluYW1pYyBtYWNoLWxvb2t1cCBleHRlbnNp b25zLiBUaGVyZSBhcmUgc2V2ZXJhbCBvdGhlciBHUFUgcnVudGltZSBmbGFncworICAgICAgICB0 aGF0IG5lZWRzIHRvIGJlIGNoZWNrZWQgYmVmb3JlIGNyZWF0aW5nIHRoZSBleHRlbnNpb25zLgor CisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQb29sQ29jb2EubW06CisgICAg ICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQb29sOjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQcm9jZXNz KToKKwogMjAyMC0xMC0wOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAg ICAgIENyYXNoIHVuZGVyIFdlYktpdDo6V2ViUHJvY2Vzc0NhY2hlOjpjbGVhcigpCkluZGV4OiBT b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNzUG9vbENvY29hLm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQb29sQ29j b2EubW0JKHJldmlzaW9uIDI2ODE1OSkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29h L1dlYlByb2Nlc3NQb29sQ29jb2EubW0JKHdvcmtpbmcgY29weSkKQEAgLTQ3OSw5ICs0NzksMTYg QEAKICAgICBpZiAobmVlZFdlYlByb2Nlc3NFeHRlbnNpb25zKSB7CiAgICAgICAgIC8vIEZJWE1F KDIwNzcxNik6IFRoZSBmb2xsb3dpbmcgc2hvdWxkIGJlIHJlbW92ZWQgd2hlbiB0aGUgR1BVIHBy b2Nlc3MgaXMgY29tcGxldGUuCiAgICAgICAgIHBhcmFtZXRlcnMubWVkaWFFeHRlbnNpb25IYW5k bGVzID0gU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlc0Zvck1hY2hMb29rdXAobWVkaWFS ZWxhdGVkTWFjaFNlcnZpY2VzKCksIFdURjo6bnVsbG9wdCk7Ci0gICAgICAgIHBhcmFtZXRlcnMu Z3B1SU9LaXRFeHRlbnNpb25IYW5kbGVzID0gU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxl c0ZvcklPS2l0Q2xhc3NFeHRlbnNpb25zKGdwdUlPS2l0Q2xhc3NlcygpLCBXVEY6Om51bGxvcHQp OwogICAgIH0KIAorICAgIGlmICghbV9kZWZhdWx0UGFnZUdyb3VwLT5wcmVmZXJlbmNlcygpLnVz ZUdQVVByb2Nlc3NGb3JNZWRpYUVuYWJsZWQoKQorICAgICAgICB8fCAhbV9kZWZhdWx0UGFnZUdy b3VwLT5wcmVmZXJlbmNlcygpLmNhcHR1cmVBdWRpb0luR1BVUHJvY2Vzc0VuYWJsZWQoKQorICAg ICAgICB8fCAhbV9kZWZhdWx0UGFnZUdyb3VwLT5wcmVmZXJlbmNlcygpLmNhcHR1cmVWaWRlb0lu R1BVUHJvY2Vzc0VuYWJsZWQoKQorICAgICAgICB8fCAhbV9kZWZhdWx0UGFnZUdyb3VwLT5wcmVm ZXJlbmNlcygpLnVzZUdQVVByb2Nlc3NGb3JDYW52YXNSZW5kZXJpbmdFbmFibGVkKCkKKyAgICAg ICAgfHwgIW1fZGVmYXVsdFBhZ2VHcm91cC0+cHJlZmVyZW5jZXMoKS51c2VHUFVQcm9jZXNzRm9y RE9NUmVuZGVyaW5nRW5hYmxlZCgpCisgICAgICAgIHx8ICFtX2RlZmF1bHRQYWdlR3JvdXAtPnBy ZWZlcmVuY2VzKCkudXNlR1BVUHJvY2Vzc0ZvcldlYkdMRW5hYmxlZCgpKQorICAgICAgICBwYXJh bWV0ZXJzLmdwdUlPS2l0RXh0ZW5zaW9uSGFuZGxlcyA9IFNhbmRib3hFeHRlbnNpb246OmNyZWF0 ZUhhbmRsZXNGb3JJT0tpdENsYXNzRXh0ZW5zaW9ucyhncHVJT0tpdENsYXNzZXMoKSwgV1RGOjpu dWxsb3B0KTsKKwogI2lmIEVOQUJMRShDRlBSRUZTX0RJUkVDVF9NT0RFKSAmJiBQTEFURk9STShJ T1NfRkFNSUxZKQogICAgIGlmIChfQVhTQXBwbGljYXRpb25BY2Nlc3NpYmlsaXR5RW5hYmxlZCgp KQogICAgICAgICBwYXJhbWV0ZXJzLnByZWZlcmVuY2VzRXh0ZW5zaW9uSGFuZGxlcyA9IFNhbmRi b3hFeHRlbnNpb246OmNyZWF0ZUhhbmRsZXNGb3JNYWNoTG9va3VwKHsgImNvbS5hcHBsZS5jZnBy ZWZzZC5hZ2VudCJfcywgImNvbS5hcHBsZS5jZnByZWZzZC5kYWVtb24iX3MgfSwgV1RGOjpudWxs b3B0KTsK 410948 2020-10-09 10:29:06 -0700 2020-10-09 12:35:54 -0700 Patch 217491.patch text/plain 2676 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjgyMDYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEwLTA4ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbR1BVIFByb2Nlc3NdIFVzZSBj b3JyZWN0IEdQVSBydW50aW1lIHNldHRpbmdzIHdoZW4gY3JlYXRpbmcgdGhlIGR5bmFtaWMgSU9L aXQgc2FuZGJveCBleHRlbnNpb25zIGZvciB0aGUgV2ViQ29udGVudCBwcm9jZXNzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTc0OTEKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzcwMDY2MDg3PgorCisgICAgICAgIFJldmlld2VkIGJ5IFlvdWVubiBG YWJsZXQuCisKKyAgICAgICAgQ3VycmVudGx5LCB0aGUgY3JlYXRpb24gb2YgdGhlIGR5bmFtaWMg SU9LaXQgc2FuZGJveCBleHRlbnNpb25zIGZvciB0aGUgV2ViQ29udGVudCBwcm9jZXNzIGlzIGlu Y29ycmVjdGx5IHVzaW5nIHRoZSBzYW1lIEdQVQorICAgICAgICBydW50aW1lIHNldHRpbmdzIGFz IHdoZW4gY3JlYXRpbmcgTWVkaWEgcmVsYXRlZCBkeW5hbWljIG1hY2gtbG9va3VwIGV4dGVuc2lv bnMuIFRoZXJlIGFyZSBzZXZlcmFsIG90aGVyIEdQVSBydW50aW1lIGZsYWdzCisgICAgICAgIHRo YXQgbmVlZHMgdG8gYmUgY2hlY2tlZCBiZWZvcmUgY3JlYXRpbmcgdGhlIGV4dGVuc2lvbnMuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Bvb2xDb2NvYS5tbToKKyAgICAg ICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3Mp OgorCiAyMDIwLTEwLTA4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg ICAgQ3Jhc2ggdW5kZXIgV2ViS2l0OjpXZWJQcm9jZXNzQ2FjaGU6OmNsZWFyKCkKSW5kZXg6IFNv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQb29sQ29jb2EubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Bvb2xDb2Nv YS5tbQkocmV2aXNpb24gMjY4MTU5KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2Ev V2ViUHJvY2Vzc1Bvb2xDb2NvYS5tbQkod29ya2luZyBjb3B5KQpAQCAtNDc5LDkgKzQ3OSwxNSBA QAogICAgIGlmIChuZWVkV2ViUHJvY2Vzc0V4dGVuc2lvbnMpIHsKICAgICAgICAgLy8gRklYTUUo MjA3NzE2KTogVGhlIGZvbGxvd2luZyBzaG91bGQgYmUgcmVtb3ZlZCB3aGVuIHRoZSBHUFUgcHJv Y2VzcyBpcyBjb21wbGV0ZS4KICAgICAgICAgcGFyYW1ldGVycy5tZWRpYUV4dGVuc2lvbkhhbmRs ZXMgPSBTYW5kYm94RXh0ZW5zaW9uOjpjcmVhdGVIYW5kbGVzRm9yTWFjaExvb2t1cChtZWRpYVJl bGF0ZWRNYWNoU2VydmljZXMoKSwgV1RGOjpudWxsb3B0KTsKLSAgICAgICAgcGFyYW1ldGVycy5n cHVJT0tpdEV4dGVuc2lvbkhhbmRsZXMgPSBTYW5kYm94RXh0ZW5zaW9uOjpjcmVhdGVIYW5kbGVz Rm9ySU9LaXRDbGFzc0V4dGVuc2lvbnMoZ3B1SU9LaXRDbGFzc2VzKCksIFdURjo6bnVsbG9wdCk7 CiAgICAgfQogCisgICAgaWYgKCFtX2RlZmF1bHRQYWdlR3JvdXAtPnByZWZlcmVuY2VzKCkudXNl R1BVUHJvY2Vzc0Zvck1lZGlhRW5hYmxlZCgpCisgICAgICAgIHx8ICghbV9kZWZhdWx0UGFnZUdy b3VwLT5wcmVmZXJlbmNlcygpLmNhcHR1cmVWaWRlb0luR1BVUHJvY2Vzc0VuYWJsZWQoKSAmJiAh bV9kZWZhdWx0UGFnZUdyb3VwLT5wcmVmZXJlbmNlcygpLmNhcHR1cmVWaWRlb0luVUlQcm9jZXNz RW5hYmxlZCgpKQorICAgICAgICB8fCAhbV9kZWZhdWx0UGFnZUdyb3VwLT5wcmVmZXJlbmNlcygp LnVzZUdQVVByb2Nlc3NGb3JDYW52YXNSZW5kZXJpbmdFbmFibGVkKCkKKyAgICAgICAgfHwgIW1f ZGVmYXVsdFBhZ2VHcm91cC0+cHJlZmVyZW5jZXMoKS51c2VHUFVQcm9jZXNzRm9yRE9NUmVuZGVy aW5nRW5hYmxlZCgpCisgICAgICAgIHx8ICFtX2RlZmF1bHRQYWdlR3JvdXAtPnByZWZlcmVuY2Vz KCkudXNlR1BVUHJvY2Vzc0ZvcldlYkdMRW5hYmxlZCgpKQorICAgICAgICBwYXJhbWV0ZXJzLmdw dUlPS2l0RXh0ZW5zaW9uSGFuZGxlcyA9IFNhbmRib3hFeHRlbnNpb246OmNyZWF0ZUhhbmRsZXNG b3JJT0tpdENsYXNzRXh0ZW5zaW9ucyhncHVJT0tpdENsYXNzZXMoKSwgV1RGOjpudWxsb3B0KTsK KwogI2lmIEVOQUJMRShDRlBSRUZTX0RJUkVDVF9NT0RFKSAmJiBQTEFURk9STShJT1NfRkFNSUxZ KQogICAgIGlmIChfQVhTQXBwbGljYXRpb25BY2Nlc3NpYmlsaXR5RW5hYmxlZCgpKQogICAgICAg ICBwYXJhbWV0ZXJzLnByZWZlcmVuY2VzRXh0ZW5zaW9uSGFuZGxlcyA9IFNhbmRib3hFeHRlbnNp b246OmNyZWF0ZUhhbmRsZXNGb3JNYWNoTG9va3VwKHsgImNvbS5hcHBsZS5jZnByZWZzZC5hZ2Vu dCJfcywgImNvbS5hcHBsZS5jZnByZWZzZC5kYWVtb24iX3MgfSwgV1RGOjpudWxsb3B0KTsK