217485 2020-10-08 11:17:17 -0700 [webkitpy] Support custom version information 2020-10-08 14:07:21 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ews-watchlist glenn webkit-bug-importer oldest_to_newest 1695967 0 jbedard 2020-10-08 11:17:17 -0700 Some configurations require more complicated version logic that sw_vers. 1695968 1 jbedard 2020-10-08 11:17:45 -0700 <rdar://problem/70069051> 1695973 2 410864 jbedard 2020-10-08 11:19:51 -0700 Created attachment 410864 Patch 1695977 3 410864 aakash_jain 2020-10-08 11:45:03 -0700 Comment on attachment 410864 Patch rs=me 1695979 4 410865 jbedard 2020-10-08 11:49:48 -0700 Created attachment 410865 Patch 1696022 5 ews-feeder 2020-10-08 14:07:21 -0700 Committed r268207: <https://trac.webkit.org/changeset/268207> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410865. 410864 2020-10-08 11:19:51 -0700 2020-10-08 11:49:46 -0700 Patch bug-217485-20201008111950.patch text/plain 2084 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2ODE5NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTEwLTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0cHldIFN1cHBvcnQgY3VzdG9tIHZlcnNpb24gaW5mb3JtYXRp b24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzQ4 NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzAwNjkwNTE+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9z eXN0ZW0vcGxhdGZvcm1pbmZvLnB5OgorICAgICAgICAoUGxhdGZvcm1JbmZvLl9faW5pdF9fKToK KwogMjAyMC0xMC0wOCAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4KIAogICAgICAg ICBBZGp1c3QgaGV1cmlzdGljIGZvciBjaGVja2luZyB3aGV0aGVyIHZpZXcgcmVhY2hlcyB2aXN1 YWxseSBub24tZW1wdHkgc3RhdGUKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9u L3N5c3RlbS9wbGF0Zm9ybWluZm8ucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3JtaW5mby5weQkocmV2aXNpb24gMjY4MTg2KQorKysg VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3JtaW5mby5weQkod29y a2luZyBjb3B5KQpAQCAtMzcsNyArMzcsOCBAQCBmcm9tIHdlYmtpdGNvcmVweSBpbXBvcnQgVmVy c2lvbgogCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5tZW1vaXplZCBpbXBvcnQgbWVtb2l6ZWQKIGZy b20gd2Via2l0cHkuY29tbW9uLnZlcnNpb25fbmFtZV9tYXAgaW1wb3J0IFBVQkxJQ19UQUJMRSwg SU5URVJOQUxfVEFCTEUsIFZlcnNpb25OYW1lTWFwCi1mcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0 ZW0uZXhlY3V0aXZlIGltcG9ydCBFeGVjdXRpdmUsIFNjcmlwdEVycm9yCitmcm9tIHdlYmtpdHB5 LmNvbW1vbi5zeXN0ZW0uZXhlY3V0aXZlIGltcG9ydCBTY3JpcHRFcnJvcgorZnJvbSB3ZWJraXRw eS5wb3J0LmNvbmZpZyBpbXBvcnQgYXBwbGVfYWRkaXRpb25zCiAKIAogX2xvZyA9IGxvZ2dpbmcu Z2V0TG9nZ2VyKF9fbmFtZV9fKQpAQCAtNjcsNyArNjgsMTEgQEAgY2xhc3MgUGxhdGZvcm1JbmZv KG9iamVjdCk6CiAgICAgICAgIHNlbGYuX2lzX2N5Z3dpbiA9IHN5c19tb2R1bGUucGxhdGZvcm0g PT0gJ2N5Z3dpbicKIAogICAgICAgICBpZiBzZWxmLm9zX25hbWUuc3RhcnRzd2l0aCgnbWFjJyk6 Ci0gICAgICAgICAgICBzZWxmLm9zX3ZlcnNpb24gPSBWZXJzaW9uLmZyb21fc3RyaW5nKHNlbGYu X2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChbJ3N3X3ZlcnMnLCAnLXByb2R1Y3RWZXJzaW9uJ10pLnJz dHJpcCgpKQorICAgICAgICAgICAgIyBXb3JrIGFyb3VuZCBmb3IgPHJkYXI6Ly9wcm9ibGVtLzcw MDY5MDUxPgorICAgICAgICAgICAgaWYgYXBwbGVfYWRkaXRpb25zKCkgYW5kIGdldGF0dHIoYXBw bGVfYWRkaXRpb25zKCksICdvc192ZXJzaW9uJywgTm9uZSk6CisgICAgICAgICAgICAgICAgc2Vs Zi5vc192ZXJzaW9uID0gYXBwbGVfYWRkaXRpb25zKCkub3NfdmVyc2lvbihzZWxmLl9leGVjdXRp dmUpCisgICAgICAgICAgICBlbHNlOgorICAgICAgICAgICAgICAgIHNlbGYub3NfdmVyc2lvbiA9 IFZlcnNpb24uZnJvbV9zdHJpbmcoc2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsnc3dfdmVy cycsICctcHJvZHVjdFZlcnNpb24nXSkucnN0cmlwKCkpCiAgICAgICAgIGVsaWYgc2VsZi5vc19u YW1lLnN0YXJ0c3dpdGgoJ3dpbicpOgogICAgICAgICAgICAgc2VsZi5vc192ZXJzaW9uID0gc2Vs Zi5fd2luX3ZlcnNpb24oKQogICAgICAgICBlbHNlOgo= 410865 2020-10-08 11:49:48 -0700 2020-10-08 14:07:21 -0700 Patch bug-217485-20201008114947.patch text/plain 2087 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2ODE5NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTEwLTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0cHldIFN1cHBvcnQgY3VzdG9tIHZlcnNpb24gaW5mb3JtYXRp b24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzQ4 NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzAwNjkwNTE+CisKKyAgICAgICAgUnViYmVyLXN0 YW1wZWQgYnkgQWFrYXNoIEphaW4uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5OgorICAgICAgICAoUGxhdGZvcm1JbmZvLl9faW5pdF9f KToKKwogMjAyMC0xMC0wOCAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4KIAogICAg ICAgICBBZGp1c3QgaGV1cmlzdGljIGZvciBjaGVja2luZyB3aGV0aGVyIHZpZXcgcmVhY2hlcyB2 aXN1YWxseSBub24tZW1wdHkgc3RhdGUKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL3N5c3RlbS9wbGF0Zm9ybWluZm8ucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3JtaW5mby5weQkocmV2aXNpb24gMjY4MTg2KQor KysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3JtaW5mby5weQko d29ya2luZyBjb3B5KQpAQCAtMzcsNyArMzcsOCBAQCBmcm9tIHdlYmtpdGNvcmVweSBpbXBvcnQg VmVyc2lvbgogCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5tZW1vaXplZCBpbXBvcnQgbWVtb2l6ZWQK IGZyb20gd2Via2l0cHkuY29tbW9uLnZlcnNpb25fbmFtZV9tYXAgaW1wb3J0IFBVQkxJQ19UQUJM RSwgSU5URVJOQUxfVEFCTEUsIFZlcnNpb25OYW1lTWFwCi1mcm9tIHdlYmtpdHB5LmNvbW1vbi5z eXN0ZW0uZXhlY3V0aXZlIGltcG9ydCBFeGVjdXRpdmUsIFNjcmlwdEVycm9yCitmcm9tIHdlYmtp dHB5LmNvbW1vbi5zeXN0ZW0uZXhlY3V0aXZlIGltcG9ydCBTY3JpcHRFcnJvcgorZnJvbSB3ZWJr aXRweS5wb3J0LmNvbmZpZyBpbXBvcnQgYXBwbGVfYWRkaXRpb25zCiAKIAogX2xvZyA9IGxvZ2dp bmcuZ2V0TG9nZ2VyKF9fbmFtZV9fKQpAQCAtNjcsNyArNjgsMTEgQEAgY2xhc3MgUGxhdGZvcm1J bmZvKG9iamVjdCk6CiAgICAgICAgIHNlbGYuX2lzX2N5Z3dpbiA9IHN5c19tb2R1bGUucGxhdGZv cm0gPT0gJ2N5Z3dpbicKIAogICAgICAgICBpZiBzZWxmLm9zX25hbWUuc3RhcnRzd2l0aCgnbWFj Jyk6Ci0gICAgICAgICAgICBzZWxmLm9zX3ZlcnNpb24gPSBWZXJzaW9uLmZyb21fc3RyaW5nKHNl bGYuX2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChbJ3N3X3ZlcnMnLCAnLXByb2R1Y3RWZXJzaW9uJ10p LnJzdHJpcCgpKQorICAgICAgICAgICAgIyBXb3JrIGFyb3VuZCBmb3IgPHJkYXI6Ly9wcm9ibGVt LzcwMDY5MDUxPgorICAgICAgICAgICAgaWYgYXBwbGVfYWRkaXRpb25zKCkgYW5kIGdldGF0dHIo YXBwbGVfYWRkaXRpb25zKCksICdvc192ZXJzaW9uJywgTm9uZSk6CisgICAgICAgICAgICAgICAg c2VsZi5vc192ZXJzaW9uID0gYXBwbGVfYWRkaXRpb25zKCkub3NfdmVyc2lvbihzZWxmLl9leGVj dXRpdmUpCisgICAgICAgICAgICBlbHNlOgorICAgICAgICAgICAgICAgIHNlbGYub3NfdmVyc2lv biA9IFZlcnNpb24uZnJvbV9zdHJpbmcoc2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsnc3df dmVycycsICctcHJvZHVjdFZlcnNpb24nXSkucnN0cmlwKCkpCiAgICAgICAgIGVsaWYgc2VsZi5v c19uYW1lLnN0YXJ0c3dpdGgoJ3dpbicpOgogICAgICAgICAgICAgc2VsZi5vc192ZXJzaW9uID0g c2VsZi5fd2luX3ZlcnNpb24oKQogICAgICAgICBlbHNlOgo=