217477 2020-10-08 08:48:35 -0700 [WPE] Include cog build artefacts in built product archive 2021-03-17 01:57:15 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221518 InRadar P2 Normal --- 1 pnormand pnormand aakash_jain aperez clopez ews-watchlist webkit-bug-importer oldest_to_newest 1695910 0 pnormand 2020-10-08 08:48:35 -0700 As Cog is a bit nicer than the current WPE MiniBrowser I wonder if we could ship it in the nightly zip archives produced by the bots. Any thoughts? 1696196 1 clopez 2020-10-09 05:56:48 -0700 A possible implementation idea is: 1. Start by having a new script (in Tools/Scripts) that allow to download and build cog [1] against the webkit built product, and also that allows to run that built cog (i guess that without installing it, just from the build directory) 2. Once we have this script, if we want to include cog in the built-product zip files (those that are downloaded via the script Tools/Scripts/webkit-flatpak-run-nightly) we can run this new script as a new step after build-webkit on the build bots (build-only bots) [1] I would even go for downloading just last cog master (instead of a specific git commit). That would even allow us to start testing that cog builds against the last wpewebkit on the build.webkit.org CI if we do 2. 1736367 2 pnormand 2021-03-05 09:03:44 -0800 Getting back to this, I recently added Cog build support, it can be enabled with this cmake option: `-DENABLE_COG=ON`. Could we enable that on the bots and pack the cog artefacts in the zip archives for the nightlies? Shouldn't have a major impact on the final zip size. 1739218 3 423122 pnormand 2021-03-14 03:25:23 -0700 Created attachment 423122 Patch 1739977 4 423122 aperez 2021-03-16 09:45:20 -0700 Comment on attachment 423122 Patch The Windows EWS failure seems unrelated, FWIW :] 1740606 5 ews-feeder 2021-03-17 01:56:52 -0700 Committed r274554: <https://commits.webkit.org/r274554> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423122. 1740607 6 webkit-bug-importer 2021-03-17 01:57:15 -0700 <rdar://problem/75517284> 423122 2021-03-14 03:25:23 -0700 2021-03-17 01:56:53 -0700 Patch bug-217477-20210314032522.patch text/plain 3657 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0Mzk3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2E0M2U3Yzg0YTViNmJjN2EwYjdlMjBlMDE5YWFjMDMz NmE2OTU4ZS4uZDg5MGY1M2Q0ZDBkYTRkMWUwMTVkMTIyZWFiYmExMzFmZmIxNjJlZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIxLTAzLTE0ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbV1BFXSBJbmNsdWRlIGNvZyBidWlsZCBhcnRlZmFjdHMgaW4gYnVpbHQgcHJv ZHVjdCBhcmNoaXZlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTc0NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJbmNsdWRlIENvZyBmaWxlcyBpbiB0aGUgemlwIGZpbGUgaWYgdGhleSdyZSBwcmVzZW50 LCBzbyB0aGUgbmlnaHRseSBydW5uZXIgd291bGQgYmUgYWJsZSB0bworICAgICAgICBzdGFydCBD b2cgaW5zdGVhZCBvZiB0aGUgV1BFIE1pbmlCcm93c2VyLgorCisgICAgICAgICogQ0lTdXBwb3J0 L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZToKKyAgICAgICAgKGNyZWF0ZVppcEZyb21MaXN0KToKKyAg ICAgICAgKGFyY2hpdmVCdWlsdFByb2R1Y3QpOgorCiAyMDIxLTAzLTEzICBTYW0gU25lZGRvbiAg PGdzbmVkZGVyc0BhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBMYXlvdXRUZXN0RmluZGVyLnNw bGl0X2ludG9fY2h1bmtzIHRvIE1hbmFnZXIuX3NwbGl0X2ludG9fY2h1bmtzCmRpZmYgLS1naXQg YS9Ub29scy9DSVN1cHBvcnQvYnVpbHQtcHJvZHVjdC1hcmNoaXZlIGIvVG9vbHMvQ0lTdXBwb3J0 L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZQppbmRleCBkZTNiY2VkMDJmZDM2MzIwOWZjNGVhOWYyMDA4 MWRjYWEwNmEwYjBmLi45MDgwNDFjYWM2MzJmZTVlMTVkNzBlZjhhZWNjYTU5ZWE3NjZlNzY4IDEw MDY0NAotLS0gYS9Ub29scy9DSVN1cHBvcnQvYnVpbHQtcHJvZHVjdC1hcmNoaXZlCisrKyBiL1Rv b2xzL0NJU3VwcG9ydC9idWlsdC1wcm9kdWN0LWFyY2hpdmUKQEAgLTExMSw3ICsxMTEsOSBAQCBk ZWYgY29weUJ1aWxkRmlsZXMoc291cmNlLCBkZXN0aW5hdGlvbiwgcGF0dGVybnMpOgogCiAKIGRl ZiBjcmVhdGVaaXBGcm9tTGlzdChsaXN0VG9aaXAsIGNvbmZpZ3VyYXRpb24sIGV4Y2x1ZGVQYXR0 ZXJuPU5vbmUpOgotICAgIGFyY2hpdmVEaXIgPSBvcy5wYXRoLmFic3BhdGgob3MucGF0aC5qb2lu KG9zLnBhdGguZGlybmFtZShfX2ZpbGVfXyksICcuLicsICcuLicsICdXZWJLaXRCdWlsZCcpKQor ICAgIGdsb2JhbCBfdG9wTGV2ZWxCdWlsZERpcmVjdG9yeQorICAgIGdsb2JhbCBfY29uZmlndXJh dGlvbkJ1aWxkRGlyZWN0b3J5CisgICAgYXJjaGl2ZURpciA9IF90b3BMZXZlbEJ1aWxkRGlyZWN0 b3J5CiAgICAgYXJjaGl2ZUZpbGUgPSBvcy5wYXRoLmpvaW4oYXJjaGl2ZURpciwgY29uZmlndXJh dGlvbiArICcuemlwJykKIAogICAgIHRyeToKQEAgLTE5NSw2ICsxOTcsNyBAQCBkZWYgbWluaWZ5 RGlyZWN0b3J5KHBsYXRmb3JtLCBkaXJlY3RvcnkpOgogCiBkZWYgYXJjaGl2ZUJ1aWx0UHJvZHVj dChjb25maWd1cmF0aW9uLCBwbGF0Zm9ybSwgZnVsbFBsYXRmb3JtLCBtaW5pZnk9RmFsc2UpOgog ICAgIGFzc2VydCBwbGF0Zm9ybSBpbiAoJ2d0aycsICdpb3MnLCAnanNjJywgJ21hYycsICd0dm9z JywgJ3dhdGNob3MnLCAnd2luJywgJ3dpbmNhaXJvJywgJ3dwZScpCisgICAgZ2xvYmFsIF9jb25m aWd1cmF0aW9uQnVpbGREaXJlY3RvcnkKIAogICAgIGlmIHBsYXRmb3JtIGluIFsnaW9zJywgJ3R2 b3MnLCAnd2F0Y2hvcyddOgogICAgICAgICBjb21iaW5lZERpcmVjdG9yeSA9IG9zLnBhdGguam9p bihfdG9wTGV2ZWxCdWlsZERpcmVjdG9yeSwgJ2NvbWJpbmVkLW1hYy1hbmQte30nLmZvcm1hdChw bGF0Zm9ybSkpCkBAIC0yMzcsMTQgKzI0MCwyNCBAQCBkZWYgYXJjaGl2ZUJ1aWx0UHJvZHVjdChj b25maWd1cmF0aW9uLCBwbGF0Zm9ybSwgZnVsbFBsYXRmb3JtLCBtaW5pZnk9RmFsc2UpOgogICAg ICAgICAjIE9uIEdUSysvV1BFL0pTQyB3ZSBkb24ndCBuZWVkIHRoZSBpbnRlcm1lZGlhdGUgc3Rl cCBvZiBjcmVhdGluZyBhIHRoaW5EaXJlY3RvcnkKICAgICAgICAgIyB0byBiZSBjb21wcmVzc2Vk IGluIGEgWklQIGZpbGUsIGJlY2F1c2Ugd2UgY2FuIGNyZWF0ZSB0aGUgWklQIGRpcmVjdGx5Lgog ICAgICAgICAjIFRoaXMgaXMgZmFzdGVyIGFuZCByZXF1aXJlcyBsZXNzIGRpc2sgcmVzb3VyY2Vz LgotICAgICAgICBuZWVkZWREaXJlY3RvcmllcyA9IFsnYmluJywgJ2xpYiddCisgICAgICAgIGNv bnRlbnRzID0gWydiaW4nLCAnbGliJ10KKworICAgICAgICAjIEZvciBXUEUgcGFjayB0aGUgQ29n IGJyb3dzZXIgYXMgd2VsbCBpZiBpdCdzIHByZXNlbnQuCisgICAgICAgIGNvZ0RpcmVjdG9yeSA9 IG9zLnBhdGguam9pbignVG9vbHMnLCAnY29nLXByZWZpeCcsICdzcmMnLCAnY29nLWJ1aWxkJykK KyAgICAgICAgYWJzb2x1dGVDb2dEaXJlY3RvcnkgPSBvcy5wYXRoLmpvaW4oX2NvbmZpZ3VyYXRp b25CdWlsZERpcmVjdG9yeSwgY29nRGlyZWN0b3J5KQorICAgICAgICBpZiBwbGF0Zm9ybSA9PSAn d3BlJyBhbmQgb3MucGF0aC5pc2RpcihhYnNvbHV0ZUNvZ0RpcmVjdG9yeSk6CisgICAgICAgICAg ICBjb250ZW50cy5leHRlbmQoW29zLnBhdGguam9pbihjb2dEaXJlY3RvcnksIGZpbGVuYW1lKSBm b3IgZmlsZW5hbWUgaW4gWydjb2cnLCAnY29nY3RsJ11dKQorICAgICAgICAgICAgZm9yIGZpbGVu YW1lIGluIG9zLmxpc3RkaXIoYWJzb2x1dGVDb2dEaXJlY3RvcnkpOgorICAgICAgICAgICAgICAg IGlmIGZpbGVuYW1lLnN0YXJ0c3dpdGgoJ2xpYmNvZ2NvcmUnKSBvciBmaWxlbmFtZS5zdGFydHN3 aXRoKCdsaWJjb2dwbGF0Zm9ybScpOgorICAgICAgICAgICAgICAgICAgICBjb250ZW50cy5hcHBl bmQob3MucGF0aC5qb2luKGNvZ0RpcmVjdG9yeSwgZmlsZW5hbWUpKQorCiAgICAgICAgICMgV2hl biBkZWJ1ZyBmaXNzaW9uIGlzIGVuYWJsZWQgdGhlIGRpcmVjdG9yaWVzIGJlbG93IGNvbnRhaW4g ZHdvIGZpbGVzCiAgICAgICAgICMgd2l0aCB0aGUgZGVidWcgaW5mb3JtYXRpb24gbmVlZGVkIHRv IGdlbmVyYXRlIGJhY2t0cmFjZXMgd2l0aCBHREIuCiAgICAgICAgIGZvciBvYmplY3REaXIgaW4g WydUb29scycsICdTb3VyY2UnXToKICAgICAgICAgICAgIGlmIGRpckNvbnRhaW5zZHdvKG9iamVj dERpcik6Ci0gICAgICAgICAgICAgICAgbmVlZGVkRGlyZWN0b3JpZXMuYXBwZW5kKG9iamVjdERp cikKKyAgICAgICAgICAgICAgICBjb250ZW50cy5hcHBlbmQob2JqZWN0RGlyKQogCi0gICAgICAg IGlmIGNyZWF0ZVppcEZyb21MaXN0KG5lZWRlZERpcmVjdG9yaWVzLCBjb25maWd1cmF0aW9uLCBl eGNsdWRlUGF0dGVybj0nKi5vJyk6CisgICAgICAgIGlmIGNyZWF0ZVppcEZyb21MaXN0KGNvbnRl bnRzLCBjb25maWd1cmF0aW9uLCBleGNsdWRlUGF0dGVybj0nKi5vJyk6CiAgICAgICAgICAgICBy ZXR1cm4gMQogCiBkZWYgdW56aXBBcmNoaXZlKGRpcmVjdG9yeVRvRXh0cmFjdFRvLCBjb25maWd1 cmF0aW9uKToK