217422 2020-10-06 20:33:02 -0700 Replace unqualified use of PlatformDisplayID in WebViewImpl 2020-10-08 00:58:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saagar webkit-unassigned darin webkit-bug-importer youennf oldest_to_newest 1695449 0 saagar 2020-10-06 20:33:02 -0700 Qualify PlatformDisplayID with WebCore:: in WebViewImpl 1695452 1 410731 saagar 2020-10-06 20:43:40 -0700 Created attachment 410731 Patch 1695460 2 410731 darin 2020-10-06 21:45:03 -0700 Comment on attachment 410731 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410731&action=review > Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:2201 > + WebCore::PlatformDisplayID displayID = WebCore::displayID(window.screen); I suggest we use auto here instead. 1695610 3 410764 saagar 2020-10-07 11:33:21 -0700 Created attachment 410764 Patch 1695818 4 ews-feeder 2020-10-08 00:57:38 -0700 Committed r268175: <https://trac.webkit.org/changeset/268175> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410764. 1695819 5 webkit-bug-importer 2020-10-08 00:58:16 -0700 <rdar://problem/70083747> 410731 2020-10-06 20:43:40 -0700 2020-10-07 11:33:19 -0700 Patch bug-217422-20201006204339.patch text/plain 2446 saagar U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVhOTA3YWQ1ZWU5ZmZjM2Yz YTM4ZmVlYzg0ODQ3OTlmMWQxYWE0MzMuLmY2N2FiNTlmMGNiNGU1ZWM3M2RhMmJkZTlhOTVhZDVm ZGQzYWZjZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMjAtMTAtMDYgIFNhYWdhciBK aGEgIDxzYWFnYXJAc2FhZ2FyamhhLmNvbT4KKworICAgICAgICBRdWFsaWZ5IFBsYXRmb3JtRGlz cGxheUlEIHdpdGggV2ViQ29yZTo6IGluIFdlYlZpZXdJbXBsCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTc0MjIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJWaWV3SW1wbCB1dGlsaXplcyB0aGluZ3Mg ZnJvbSBXZWJDb3JlIGJ1dCBkb2Vzbid0IHVzZSB0aGUgbmFtZXNwYWNlLCBpbnN0ZWFkIGNob29z aW5nIHRvCisgICAgICAgIHF1YWxpZnkgZWFjaCByZWZlcmVuY2UuIEhvd2V2ZXIsIHRoZXJlIGlz IG9uZSB1c2Ugb2YgV2ViQ29yZTo6UGxhdGZvcm1EaXNwbGF5SUQgdGhhdAorICAgICAgICBkb2Vz bid0IHVzZSB0aGUgdGhlIG5hbWVzcGFjZSBxdWFsaWZpZXIuIFVzdWFsbHkgdGhpcyAid29ya3Mi IGJlY2F1c2UgdGhlIGNvZGUgaXMgaW4gdGhlCisgICAgICAgIFdlYktpdCBuYW1lc3BhY2UsIGFu ZCBvdGhlciBmaWxlcyB0aGF0IGdldCBpbmNsdWRlZCBhYm92ZSB0aGlzIG9uZSBvZnRlbiBjb250 YWluIGNvZGUgb2YKKyAgICAgICAgdGhlIGZvcm0KKworICAgICAgICBuYW1lc3BhY2UgV2ViS2l0 IHsKKyAgICAgICAgdXNpbmcgV2ViQ29yZTsKKyAgICAgICAgLy8gY29kZQorICAgICAgICB9CisK KyAgICAgICAgd2hpY2ggaGlkZXMgdGhlIGlzc3VlIGJ5IG1ha2luZyBQbGF0Zm9ybURpc3BsYXlJ RCB2aXNpYmxlIHRvIHRoaXMgZmlsZSBhcyB3ZWxsIHdpdGhvdXQgdGhlCisgICAgICAgIHByZWZp eC4gQnkgcXVhbGlmeWluZyByZWdhcmRsZXNzIHRoZSBidWlsZCB3b3JrcyBldmVuIGlmIFdlYlZp ZXdJbXBsLm1tIGVuZHMgdXAgbmVhciB0aGUKKyAgICAgICAgdG9wIG9mIGEgdW5pZmllZCBzb3Vy Y2UgZmlsZSwgYmVmb3JlIGFub3RoZXIgZmlsZSB3aXRoIHRoYXQgc29ydCBvZiBjb25zdHJ1Y3Qg c2hvd3MgdXAuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwubW06Cisg ICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjp3aW5kb3dEaWRDaGFuZ2VTY3JlZW4pOiBBZGQg V2ViQ29yZTo6IHRvIFBsYXRmb3JtRGlzcGxheUlELgorCiAyMDIwLTEwLTA2ICBDaHJpcyBEdW1l eiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUmVsb2FkaW5nIGEgdmlldyBpbiBpdHMg cHJvY2Vzc1Rlcm1pbmF0aW9uSGFuZGxlciBkb2VzIG5vdCB3b3JrIHJlbGlhYmx5IHdoZW4gdXNp bmcgcmVsYXRlZCB2aWV3cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29j b2EvV2ViVmlld0ltcGwubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3 SW1wbC5tbQppbmRleCAxOTk0NDhlMmU1MjllNGZkNjY1OWNlMjAxZGIwNGIzMzJiZWU5YWU2Li42 YjRjZTE1MTA3MzBmY2U4YjM1YTE1ZDYyNjgxNmMzOWQ5N2ZkNzMzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQpAQCAtMjE5OCw3ICsyMTk4LDcgQEAg dm9pZCBXZWJWaWV3SW1wbDo6d2luZG93RGlkQ2hhbmdlQmFja2luZ1Byb3BlcnRpZXMoQ0dGbG9h dCBvbGRCYWNraW5nU2NhbGVGYWN0b3IKIHZvaWQgV2ViVmlld0ltcGw6OndpbmRvd0RpZENoYW5n ZVNjcmVlbigpCiB7CiAgICAgTlNXaW5kb3cgKndpbmRvdyA9IG1fdGFyZ2V0V2luZG93Rm9yTW92 ZVByZXBhcmF0aW9uID8gbV90YXJnZXRXaW5kb3dGb3JNb3ZlUHJlcGFyYXRpb24uZ2V0KCkgOiBb bV92aWV3IHdpbmRvd107Ci0gICAgUGxhdGZvcm1EaXNwbGF5SUQgZGlzcGxheUlEID0gV2ViQ29y ZTo6ZGlzcGxheUlEKHdpbmRvdy5zY3JlZW4pOworICAgIFdlYkNvcmU6OlBsYXRmb3JtRGlzcGxh eUlEIGRpc3BsYXlJRCA9IFdlYkNvcmU6OmRpc3BsYXlJRCh3aW5kb3cuc2NyZWVuKTsKICAgICBh dXRvIGZyYW1lc1BlclNlY29uZCA9IG1fcGFnZS0+cHJvY2VzcygpLnByb2Nlc3NQb29sKCkubm9t aW5hbEZyYW1lc1BlclNlY29uZEZvckRpc3BsYXkoZGlzcGxheUlEKTsKICAgICBtX3BhZ2UtPndp bmRvd1NjcmVlbkRpZENoYW5nZShkaXNwbGF5SUQsIGZyYW1lc1BlclNlY29uZCk7CiB9Cg== 410764 2020-10-07 11:33:21 -0700 2020-10-08 00:57:39 -0700 Patch bug-217422-20201007113320.patch text/plain 2411 saagar U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGEyMTUzYWY0MDhhNGRhZThi NjcxZmZmNWM3OGU5N2IxNmRmYWIyNzEuLjY3OWU0ZGI4Mzk2OWFlNWY3YzNjMzU3OWIyODMzY2I0 YTlkZTU4Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMjAtMTAtMDcgIFNhYWdhciBK aGEgIDxzYWFnYXJAc2FhZ2FyamhhLmNvbT4KKworICAgICAgICBSZXBsYWNlIHVucXVhbGlmaWVk IHVzZSBvZiBQbGF0Zm9ybURpc3BsYXlJRCBpbiBXZWJWaWV3SW1wbAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3NDIyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViVmlld0ltcGwgdXRpbGl6ZXMgdGhp bmdzIGZyb20gV2ViQ29yZSBidXQgZG9lc24ndCB1c2UgdGhlIG5hbWVzcGFjZSwgaW5zdGVhZCBj aG9vc2luZyB0bworICAgICAgICBxdWFsaWZ5IGVhY2ggcmVmZXJlbmNlLiBIb3dldmVyLCB0aGVy ZSBpcyBvbmUgdXNlIG9mIFdlYkNvcmU6OlBsYXRmb3JtRGlzcGxheUlEIHRoYXQKKyAgICAgICAg ZG9lc24ndCB1c2UgdGhlIHRoZSBuYW1lc3BhY2UgcXVhbGlmaWVyLiBVc3VhbGx5IHRoaXMgIndv cmtzIiBiZWNhdXNlIHRoZSBjb2RlIGlzIGluIHRoZQorICAgICAgICBXZWJLaXQgbmFtZXNwYWNl LCBhbmQgb3RoZXIgZmlsZXMgdGhhdCBnZXQgaW5jbHVkZWQgYWJvdmUgdGhpcyBvbmUgb2Z0ZW4g Y29udGFpbiBjb2RlIG9mCisgICAgICAgIHRoZSBmb3JtCisKKyAgICAgICAgbmFtZXNwYWNlIFdl YktpdCB7CisgICAgICAgIHVzaW5nIFdlYkNvcmU7CisgICAgICAgIC8vIGNvZGUKKyAgICAgICAg fQorCisgICAgICAgIHdoaWNoIGhpZGVzIHRoZSBpc3N1ZSBieSBtYWtpbmcgUGxhdGZvcm1EaXNw bGF5SUQgdmlzaWJsZSB0byB0aGlzIGZpbGUgYXMgd2VsbCB3aXRob3V0IHRoZQorICAgICAgICBw cmVmaXguIElmIHdlIHVzZSBhdXRvIG5vbmUgb2YgdGhpcyBtYXR0ZXJzIGJlY2F1c2UgaXQnbGwg ZGVkdWNlIHRoZSBwcmVmaXggZXZlbiBpZgorICAgICAgICBXZWJWaWV3SW1wbC5tbSBlbmRzIHVw IG5lYXIgdGhlIHRvcCBvZiBhIHVuaWZpZWQgc291cmNlIGZpbGUsIGJlZm9yZSBhbm90aGVyIGZp bGUgd2l0aCB0aGUKKyAgICAgICAgdXNpbmcgZGVjbGFyYXRpb24gc2hvd3MgdXAuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwubW06CisgICAgICAgIChXZWJLaXQ6Oldl YlZpZXdJbXBsOjp3aW5kb3dEaWRDaGFuZ2VTY3JlZW4pOiBSZXBsYWNlIFBsYXRmb3JtRGlzcGxh eUlEIHdpdGggYXV0by4KKwogMjAyMC0xMC0wNyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIE1lZGlhUmVjb3JkZXIgcGF1c2UvcmVz dW1lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1w bC5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tCmluZGV4 IDE5OTQ0OGUyZTUyOWU0ZmQ2NjU5Y2UyMDFkYjA0YjMzMmJlZTlhZTYuLjQzYWU3ZTBhMjk0NDIw MDdmMjUyYWNlYTg4YjEyNTA1YTgwOWNjMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0NvY29hL1dlYlZpZXdJbXBsLm1tCkBAIC0yMTk4LDcgKzIxOTgsNyBAQCB2b2lkIFdlYlZpZXdJ bXBsOjp3aW5kb3dEaWRDaGFuZ2VCYWNraW5nUHJvcGVydGllcyhDR0Zsb2F0IG9sZEJhY2tpbmdT Y2FsZUZhY3Rvcgogdm9pZCBXZWJWaWV3SW1wbDo6d2luZG93RGlkQ2hhbmdlU2NyZWVuKCkKIHsK ICAgICBOU1dpbmRvdyAqd2luZG93ID0gbV90YXJnZXRXaW5kb3dGb3JNb3ZlUHJlcGFyYXRpb24g PyBtX3RhcmdldFdpbmRvd0Zvck1vdmVQcmVwYXJhdGlvbi5nZXQoKSA6IFttX3ZpZXcgd2luZG93 XTsKLSAgICBQbGF0Zm9ybURpc3BsYXlJRCBkaXNwbGF5SUQgPSBXZWJDb3JlOjpkaXNwbGF5SUQo d2luZG93LnNjcmVlbik7CisgICAgYXV0byBkaXNwbGF5SUQgPSBXZWJDb3JlOjpkaXNwbGF5SUQo d2luZG93LnNjcmVlbik7CiAgICAgYXV0byBmcmFtZXNQZXJTZWNvbmQgPSBtX3BhZ2UtPnByb2Nl c3MoKS5wcm9jZXNzUG9vbCgpLm5vbWluYWxGcmFtZXNQZXJTZWNvbmRGb3JEaXNwbGF5KGRpc3Bs YXlJRCk7CiAgICAgbV9wYWdlLT53aW5kb3dTY3JlZW5EaWRDaGFuZ2UoZGlzcGxheUlELCBmcmFt ZXNQZXJTZWNvbmQpOwogfQo=