217409 2020-10-06 15:28:17 -0700 [webkitcorepy] Handle case where arguments to memoized function are lists 2020-10-09 11:01:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=216404 InRadar P2 Normal --- 1 jbedard jbedard darin dewei_zhu webkit-bug-importer oldest_to_newest 1695348 0 jbedard 2020-10-06 15:28:17 -0700 At the moment, we don't handle lists being passed to memoized functions. 1695349 1 webkit-bug-importer 2020-10-06 15:28:31 -0700 <rdar://problem/70020109> 1695391 2 410714 jbedard 2020-10-06 16:56:30 -0700 Created attachment 410714 Patch 1695608 3 jbedard 2020-10-07 11:27:12 -0700 Discussed this with Dean and Dewei, this case is a bit of a weird one because it handles what happens when someone passes a mutable argument to a memoized function. We're going to mark this as invalid and move on, the code change does what it says it does, it's just not obvious that behavior is more correct than the exception Python will raise. 410714 2020-10-06 16:56:30 -0700 2020-10-07 11:28:43 -0700 Patch bug-217409-20201006165629.patch text/plain 3846 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2ODA4NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDIwLTEwLTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0Y29yZXB5XSBIYW5kbGUgY2FzZSB3aGVyZSBhcmd1bWVudHMg dG8gbWVtb2l6ZWQgZnVuY3Rpb24gYXJlIGxpc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTc0MDkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzcw MDIwMTA5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNvcmVweS9fX2luaXRfXy5w eToKKyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5 L2RlY29yYXRvcnMucHk6CisgICAgICAgIChNZW1vaXplKToKKyAgICAgICAgKE1lbW9pemUudHVw bGVpemUpOiBSZWN1cnNpdmVseSBjb252ZXJ0IGFyZ3VtZW50IHRvIGEgdHVwbGUuCisgICAgICAg IChNZW1vaXplLl9fY2FsbF9fLmRlY29yYXRvcik6CisgICAgICAgICogU2NyaXB0cy9saWJyYXJp ZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNvcmVweS90ZXN0cy9kZWNvcmF0b3JzX3VuaXR0ZXN0LnB5 OgorICAgICAgICAoVGVzdE1lbW9pemUpOgorICAgICAgICAoVGVzdE1lbW9pemUudGVzdF90dXBs aXplKToKKwogMjAyMC0xMC0wNiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAK ICAgICAgICAgQ1NTIGhvdmVyIGFuZCAicG9pbnRlcjogZmluZSIgbWVkaWEgcXVlcmllcyBkbyBu b3QgZXZhbHVhdGUgdG8gdHJ1ZSB3aXRoIGlPUyAxMy40IG1vdXNlIHN1cHBvcnQKSW5kZXg6IFRv b2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvX19pbml0X18u cHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dl YmtpdGNvcmVweS9fX2luaXRfXy5weQkocmV2aXNpb24gMjY4MDg1KQorKysgVG9vbHMvU2NyaXB0 cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNvcmVweS9fX2luaXRfXy5weQkod29ya2lu ZyBjb3B5KQpAQCAtMzUsNyArMzUsNyBAQCBmcm9tIHdlYmtpdGNvcmVweS50aW1lb3V0IGltcG9y dCBUaW1lb3V0CiBmcm9tIHdlYmtpdGNvcmVweS5zdWJwcm9jZXNzX3V0aWxzIGltcG9ydCBUaW1l b3V0RXhwaXJlZCwgQ29tcGxldGVkUHJvY2VzcywgcnVuCiBmcm9tIHdlYmtpdGNvcmVweS5vdXRw dXRfY2FwdHVyZSBpbXBvcnQgTG9nZ2VyQ2FwdHVyZSwgT3V0cHV0Q2FwdHVyZSwgT3V0cHV0RHVw bGljYXRlCiAKLXZlcnNpb24gPSBWZXJzaW9uKDAsIDQsIDEyKQordmVyc2lvbiA9IFZlcnNpb24o MCwgNCwgMTMpCiAKIGZyb20gd2Via2l0Y29yZXB5LmF1dG9pbnN0YWxsIGltcG9ydCBQYWNrYWdl LCBBdXRvSW5zdGFsbAogaWYgc3lzLnZlcnNpb25faW5mbyA+ICgzLCAwKToKSW5kZXg6IFRvb2xz L1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvZGVjb3JhdG9ycy5w eQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Vi a2l0Y29yZXB5L2RlY29yYXRvcnMucHkJKHJldmlzaW9uIDI2ODA4NSkKKysrIFRvb2xzL1Njcmlw dHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvZGVjb3JhdG9ycy5weQkod29y a2luZyBjb3B5KQpAQCAtMzIsNiArMzIsMTQgQEAgY2xhc3MgTWVtb2l6ZShvYmplY3QpOgogICAg ICAgICBzZWxmLnRpbWVvdXQgPSB0aW1lb3V0CiAgICAgICAgIHNlbGYuY2FjaGVkID0gY2FjaGVk CiAKKyAgICBAY2xhc3NtZXRob2QKKyAgICBkZWYgdHVwbGVpemUoY2xzLCBpdGVtKToKKyAgICAg ICAgaWYgaXNpbnN0YW5jZShpdGVtLCBsaXN0KToKKyAgICAgICAgICAgIHJldHVybiB0dXBsZShp dGVtKQorICAgICAgICBpZiBpc2luc3RhbmNlKGl0ZW0sIGRpY3QpOgorICAgICAgICAgICAgcmV0 dXJuIHR1cGxlKHNvcnRlZChbKGtleSwgY2xzLnR1cGxlaXplKHZhbHVlKSkgZm9yIGtleSwgdmFs dWUgaW4gaXRlbS5pdGVtcygpXSkpCisgICAgICAgIHJldHVybiBpdGVtCisKICAgICBkZWYgX19j YWxsX18oc2VsZiwgZnVuY3Rpb24pOgogICAgICAgICBkZWYgZGVjb3JhdG9yKCphcmdzLCAqKmt3 YXJncyk6CiAgICAgICAgICAgICB0aW1lb3V0ID0gc2VsZi50aW1lb3V0CkBAIC00Miw3ICs1MCw3 IEBAIGNsYXNzIE1lbW9pemUob2JqZWN0KToKICAgICAgICAgICAgIGlmICdjYWNoZWQnIG5vdCBp biBpbnNwZWN0LmdldGFyZ3NwZWMoZnVuY3Rpb24pLmFyZ3M6CiAgICAgICAgICAgICAgICAgY2Fj aGVkID0ga3dhcmdzLnBvcCgnY2FjaGVkJywgY2FjaGVkKQogCi0gICAgICAgICAgICBrZXlhcmdz ID0gYXJncyArIHR1cGxlKHNvcnRlZChbKGtleSwgdmFsdWUpIGZvciBrZXksIHZhbHVlIGluIGt3 YXJncy5pdGVtcygpXSkpCisgICAgICAgICAgICBrZXlhcmdzID0gc2VsZi50dXBsZWl6ZShhcmdz KSArIHNlbGYudHVwbGVpemUoa3dhcmdzKQogICAgICAgICAgICAgbGFzdF9jYWxsZWQgPSBzZWxm Ll9sYXN0X2NhbGxlZFtmdW5jdGlvbl0uZ2V0KGtleWFyZ3MsIDApCiAgICAgICAgICAgICBpc19j YWNoZWQgPSBrZXlhcmdzIGluIHNlbGYuX2NhY2hlW2Z1bmN0aW9uXQogICAgICAgICAgICAgaWYg bm90IGNhY2hlZDoKSW5kZXg6IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93 ZWJraXRjb3JlcHkvdGVzdHMvZGVjb3JhdG9yc191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L3Rlc3RzL2Rl Y29yYXRvcnNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI2ODA4NSkKKysrIFRvb2xzL1NjcmlwdHMv bGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvdGVzdHMvZGVjb3JhdG9yc191bml0 dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMTA3LDMgKzEwNywxNCBAQCBjbGFzcyBUZXN0TWVt b2l6ZSh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgICAgICB0aW1lb3V0PSd0aW1lb3V0LW5l dycsCiAgICAgICAgICAgICBjYWNoZWQ9J2NhY2hlZC1uZXcnLAogICAgICAgICApLCAoJ3RpbWVv dXQtbmV3JywgJ2NhY2hlZC1uZXcnKSkKKworICAgIGRlZiB0ZXN0X3R1cGxpemUoc2VsZik6Cisg ICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoVGVzdE1lbW9pemUuaW5jcmVtZW50X3dpdGhfYXJncygK KyAgICAgICAgICAgIHRpbWVvdXQ9WzEsIDJdLAorICAgICAgICAgICAgY2FjaGVkPVsxLCAyXSwK KyAgICAgICAgKSwgKFsxLCAyXSwgWzEsIDJdKSkKKworICAgICAgICBzZWxmLmFzc2VydEVxdWFs KFRlc3RNZW1vaXplLmluY3JlbWVudF93aXRoX2FyZ3MoCisgICAgICAgICAgICB0aW1lb3V0PWRp Y3QocmVjdXJzZWQ9WzEsIDJdKSwKKyAgICAgICAgICAgIGNhY2hlZD0xLAorICAgICAgICApLCAo ZGljdChyZWN1cnNlZD1bMSwgMl0pLCAxKSkK