217398 2020-10-06 11:30:25 -0700 [LFC][Floating] Remove redundant FormattingContextRoot in FloatingContext c'tor 2020-10-06 12:09:17 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1695235 0 zalan 2020-10-06 11:30:25 -0700 now that FormattingContext has a root() getter. 1695236 1 410668 zalan 2020-10-06 11:32:09 -0700 Created attachment 410668 Patch 1695260 2 ews-feeder 2020-10-06 12:08:35 -0700 Committed r268063: <https://trac.webkit.org/changeset/268063> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410668. 1695261 3 webkit-bug-importer 2020-10-06 12:09:17 -0700 <rdar://problem/70010811> 410668 2020-10-06 11:32:09 -0700 2020-10-06 12:08:36 -0700 Patch bug-217398-20201006113208.patch text/plain 6761 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3OTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmVkNTYyNmMzOTQwNThh NTMwZGUyZGM3NzgxMGE3YjFjZGZiNTgxNS4uZGFjNjllMzU2ZjA3NTgyNGM2YjZkMDQzZmFiODQz Mzg0ZThiODE1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTEwLTA2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bRmxvYXRpbmddIFJl bW92ZSByZWR1bmRhbnQgRm9ybWF0dGluZ0NvbnRleHRSb290IGluIEZsb2F0aW5nQ29udGV4dCBj J3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3 Mzk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8g bmVlZCB0byBwYXNzIGluIHRoZSByb290IG5vdyB0aGF0IEZvcm1hdHRpbmdDb250ZXh0IGhhcyB0 aGUgcm9vdCgpIGdldHRlci4KKworICAgICAgICAqIGxheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxv Y2tGb3JtYXR0aW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJsb2Nr Rm9ybWF0dGluZ0NvbnRleHQ6OmxheW91dEluRmxvd0NvbnRlbnQpOgorICAgICAgICAqIGxheW91 dC9mbG9hdHMvRmxvYXRpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6 RmxvYXRpbmdDb250ZXh0OjpGbG9hdGluZ0NvbnRleHQpOgorICAgICAgICAqIGxheW91dC9mbG9h dHMvRmxvYXRpbmdDb250ZXh0Lmg6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkZsb2F0aW5n Q29udGV4dDo6cm9vdCBjb25zdCk6CisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcv SW5saW5lRm9ybWF0dGluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpJ bmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6bGluZUxheW91dCk6CisgICAgICAgIChXZWJDb3JlOjpM YXlvdXQ6OklubGluZUZvcm1hdHRpbmdDb250ZXh0Ojpjb21wdXRlZEludHJpbnNpY1dpZHRoRm9y Q29uc3RyYWludCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OklubGluZUZvcm1h dHRpbmdDb250ZXh0Ojpjb21wdXRlR2VvbWV0cnlGb3JMaW5lQ29udGVudCk6CisKIDIwMjAtMTAt MDUgIEpvaG4gV2lsYW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CiAKICAgICAgICAgU3RvcmFn ZSBBY2Nlc3MgQVBJOiBFbmFibGUgcGVyLXBhZ2Ugc3RvcmFnZSBhY2Nlc3Mgc2NvcGUgYW5kIGFs aWduIHRlc3QgY2FzZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zv cm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlv dXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuY3BwCmluZGV4IGI2M2Jh YWViODQwNmVhZGEyNmNmZmEwMTBmOGJhZjA5Njk2ZGJmNWMuLjUxMTE0NDYwZGM2NjJkMjMzNTk4 MWNkYTlkNTMzNjY5MWJjZGZlNzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9i bG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmNwcApA QCAtNjIsNyArNjIsNyBAQCB2b2lkIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6OmxheW91dEluRmxv d0NvbnRlbnQoSW52YWxpZGF0aW9uU3RhdGUmIGludmFsaWRhdGlvbgogICAgIExPR19XSVRIX1NU UkVBTShGb3JtYXR0aW5nQ29udGV4dExheW91dCwgc3RyZWFtIDw8ICJbU3RhcnRdIC0+IGJsb2Nr IGZvcm1hdHRpbmcgY29udGV4dCAtPiBmb3JtYXR0aW5nIHJvb3QoIiA8PCAmcm9vdCgpIDw8ICIp Iik7CiAgICAgYXV0byYgZm9ybWF0dGluZ1Jvb3QgPSByb290KCk7CiAgICAgQVNTRVJUKGZvcm1h dHRpbmdSb290Lmhhc0luRmxvd09yRmxvYXRpbmdDaGlsZCgpKTsKLSAgICBhdXRvIGZsb2F0aW5n Q29udGV4dCA9IEZsb2F0aW5nQ29udGV4dCB7IGZvcm1hdHRpbmdSb290LCAqdGhpcywgZm9ybWF0 dGluZ1N0YXRlKCkuZmxvYXRpbmdTdGF0ZSgpIH07CisgICAgYXV0byBmbG9hdGluZ0NvbnRleHQg PSBGbG9hdGluZ0NvbnRleHQgeyAqdGhpcywgZm9ybWF0dGluZ1N0YXRlKCkuZmxvYXRpbmdTdGF0 ZSgpIH07CiAKICAgICBMYXlvdXRRdWV1ZSBsYXlvdXRRdWV1ZTsKICAgICBlbnVtIGNsYXNzIExh eW91dERpcmVjdGlvbiB7IENoaWxkLCBTaWJsaW5nIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvZmxvYXRzL0Zsb2F0aW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvZmxvYXRzL0Zsb2F0aW5nQ29udGV4dC5jcHAKaW5kZXggNTViYjI3MGU2MzkwYzUzZDZi NzBjOGQ3N2I3YjhjYTEwNTE5MTE3My4uZjZkYmJiNGExNjIwMzIxODUyZGZkMWQ5M2YwZjdiYzVh MmNkOTUwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zsb2F0cy9GbG9hdGlu Z0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mbG9hdHMvRmxvYXRpbmdD b250ZXh0LmNwcApAQCAtMjEzLDkgKzIxMyw4IEBAIHN0cnVjdCBGbG9hdGluZ0NvbnRleHQ6OkFi c29sdXRlQ29vcmRpbmF0ZVZhbHVlc0ZvckZsb2F0QXZvaWRlciB7CiAgICAgSG9yaXpvbnRhbEVk Z2VzIGNvbnRhaW5pbmdCbG9ja0NvbnRlbnRCb3g7CiB9OwogCi1GbG9hdGluZ0NvbnRleHQ6OkZs b2F0aW5nQ29udGV4dChjb25zdCBDb250YWluZXJCb3gmIGZsb2F0aW5nQ29udGV4dFJvb3QsIGNv bnN0IEZvcm1hdHRpbmdDb250ZXh0JiBmb3JtYXR0aW5nQ29udGV4dCwgRmxvYXRpbmdTdGF0ZSYg ZmxvYXRpbmdTdGF0ZSkKLSAgICA6IG1fcm9vdChtYWtlV2Vha1B0cihmbG9hdGluZ0NvbnRleHRS b290KSkKLSAgICAsIG1fZm9ybWF0dGluZ0NvbnRleHQoZm9ybWF0dGluZ0NvbnRleHQpCitGbG9h dGluZ0NvbnRleHQ6OkZsb2F0aW5nQ29udGV4dChjb25zdCBGb3JtYXR0aW5nQ29udGV4dCYgZm9y bWF0dGluZ0NvbnRleHQsIEZsb2F0aW5nU3RhdGUmIGZsb2F0aW5nU3RhdGUpCisgICAgOiBtX2Zv cm1hdHRpbmdDb250ZXh0KGZvcm1hdHRpbmdDb250ZXh0KQogICAgICwgbV9mbG9hdGluZ1N0YXRl KGZsb2F0aW5nU3RhdGUpCiB7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv ZmxvYXRzL0Zsb2F0aW5nQ29udGV4dC5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zsb2F0cy9G bG9hdGluZ0NvbnRleHQuaAppbmRleCAxYWM2Njg1NDg4MzZkMGJlOWZmZjkwZGY0NGE1NTE1OTA4 NWYxYjZmLi4xNzAxZTE1MWNmN2JlYWRiYjdlNzNlN2Y3YTI0OGI0YjllNGFlNzc0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZmxvYXRzL0Zsb2F0aW5nQ29udGV4dC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2xheW91dC9mbG9hdHMvRmxvYXRpbmdDb250ZXh0LmgKQEAgLTQ0LDcg KzQ0LDcgQEAgY2xhc3MgTGF5b3V0U3RhdGU7CiBjbGFzcyBGbG9hdGluZ0NvbnRleHQgewogICAg IFdURl9NQUtFX0lTT19BTExPQ0FURUQoRmxvYXRpbmdDb250ZXh0KTsKIHB1YmxpYzoKLSAgICBG bG9hdGluZ0NvbnRleHQoY29uc3QgQ29udGFpbmVyQm94JiBmbG9hdGluZ0NvbnRleHRSb290LCBj b25zdCBGb3JtYXR0aW5nQ29udGV4dCYsIEZsb2F0aW5nU3RhdGUmKTsKKyAgICBGbG9hdGluZ0Nv bnRleHQoY29uc3QgRm9ybWF0dGluZ0NvbnRleHQmLCBGbG9hdGluZ1N0YXRlJik7CiAKICAgICBG bG9hdGluZ1N0YXRlJiBmbG9hdGluZ1N0YXRlKCkgY29uc3QgeyByZXR1cm4gbV9mbG9hdGluZ1N0 YXRlOyB9CiAKQEAgLTY5LDcgKzY5LDcgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICBMYXlvdXRT dGF0ZSYgbGF5b3V0U3RhdGUoKSBjb25zdCB7IHJldHVybiBtX2Zsb2F0aW5nU3RhdGUubGF5b3V0 U3RhdGUoKTsgfQogICAgIGNvbnN0IEZvcm1hdHRpbmdDb250ZXh0JiBmb3JtYXR0aW5nQ29udGV4 dCgpIGNvbnN0IHsgcmV0dXJuIG1fZm9ybWF0dGluZ0NvbnRleHQ7IH0KLSAgICBjb25zdCBDb250 YWluZXJCb3gmIHJvb3QoKSBjb25zdCB7IHJldHVybiAqbV9yb290OyB9CisgICAgY29uc3QgQ29u dGFpbmVyQm94JiByb290KCkgY29uc3QgeyByZXR1cm4gbV9mb3JtYXR0aW5nQ29udGV4dC5yb290 KCk7IH0KIAogICAgIHZvaWQgZmluZFBvc2l0aW9uRm9yRm9ybWF0dGluZ0NvbnRleHRSb290KEZs b2F0QXZvaWRlciYpIGNvbnN0OwogCkBAIC03OCw3ICs3OCw2IEBAIHByaXZhdGU6CiAgICAgTGF5 b3V0UG9pbnQgbWFwVG9wTGVmdFRvRmxvYXRpbmdTdGF0ZVJvb3QoY29uc3QgQm94JikgY29uc3Q7 CiAgICAgUG9pbnQgbWFwUG9pbnRGcm9tRm9ybWF0dGluZ0NvbnRleHRSb290VG9GbG9hdGluZ1N0 YXRlUm9vdChQb2ludCkgY29uc3Q7CiAKLSAgICBXZWFrUHRyPGNvbnN0IENvbnRhaW5lckJveD4g bV9yb290OwogICAgIGNvbnN0IEZvcm1hdHRpbmdDb250ZXh0JiBtX2Zvcm1hdHRpbmdDb250ZXh0 OwogICAgIEZsb2F0aW5nU3RhdGUmIG1fZmxvYXRpbmdTdGF0ZTsKIH07CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29u dGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVG b3JtYXR0aW5nQ29udGV4dC5jcHAKaW5kZXggNDcyMTg2NDljNzI5ZTQyZmU5NDI4OWJlZGFiNjM4 Yzg1MDcwMzI0Zi4uM2M2NzRlZDJlOTFmYmEzY2UzNjY0NzA0MjU5MDg1MGQ0N2RjMDRlYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9y bWF0dGluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3Jt YXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmNwcApAQCAtMTQ5LDcgKzE0OSw3IEBAIHZv aWQgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OmxpbmVMYXlvdXQoSW5saW5lSXRlbXMmIGlubGlu ZUl0ZW1zLCBMaW5lQnVpbGRlcjo6CiAgICAgICAgIHNpemVfdCBvdmVyZmxvd0NvbnRlbnRMZW5n dGggeyAwIH07CiAgICAgfTsKICAgICBPcHRpb25hbDxQcmV2aW91c0xpbmU+IHByZXZpb3VzTGlu ZTsKLSAgICBhdXRvIGZsb2F0aW5nQ29udGV4dCA9IEZsb2F0aW5nQ29udGV4dCB7IHJvb3QoKSwg KnRoaXMsIGZvcm1hdHRpbmdTdGF0ZSgpLmZsb2F0aW5nU3RhdGUoKSB9OworICAgIGF1dG8gZmxv YXRpbmdDb250ZXh0ID0gRmxvYXRpbmdDb250ZXh0IHsgKnRoaXMsIGZvcm1hdHRpbmdTdGF0ZSgp LmZsb2F0aW5nU3RhdGUoKSB9OwogICAgIGF1dG8gaXNGaXJzdExpbmUgPSBmb3JtYXR0aW5nU3Rh dGUoKS5saW5lcygpLmlzRW1wdHkoKTsKIAogICAgIGF1dG8gbGluZUJ1aWxkZXIgPSBMaW5lQnVp bGRlciB7ICp0aGlzLCBmbG9hdGluZ0NvbnRleHQsIHJvb3QoKSwgaW5saW5lSXRlbXMgfTsKQEAg LTI1OCw3ICsyNTgsNyBAQCBJbmxpbmVMYXlvdXRVbml0IElubGluZUZvcm1hdHRpbmdDb250ZXh0 Ojpjb21wdXRlZEludHJpbnNpY1dpZHRoRm9yQ29uc3RyYWludChJbgogewogICAgIGF1dG8mIGlu bGluZUl0ZW1zID0gZm9ybWF0dGluZ1N0YXRlKCkuaW5saW5lSXRlbXMoKTsKICAgICBhdXRvIG1h eGltdW1MaW5lV2lkdGggPSBJbmxpbmVMYXlvdXRVbml0IHsgfTsKLSAgICBhdXRvIGZsb2F0aW5n Q29udGV4dCA9IEZsb2F0aW5nQ29udGV4dCB7IHJvb3QoKSwgKnRoaXMsIGZvcm1hdHRpbmdTdGF0 ZSgpLmZsb2F0aW5nU3RhdGUoKSB9OworICAgIGF1dG8gZmxvYXRpbmdDb250ZXh0ID0gRmxvYXRp bmdDb250ZXh0IHsgKnRoaXMsIGZvcm1hdHRpbmdTdGF0ZSgpLmZsb2F0aW5nU3RhdGUoKSB9Owog ICAgIGF1dG8gbGluZUJ1aWxkZXIgPSBMaW5lQnVpbGRlciB7ICp0aGlzLCBmbG9hdGluZ0NvbnRl eHQsIHJvb3QoKSwgaW5saW5lSXRlbXMgfTsKICAgICBhdXRvIGxheW91dFJhbmdlID0gTGluZUJ1 aWxkZXI6OklubGluZUl0ZW1SYW5nZSB7IDAgLCBpbmxpbmVJdGVtcy5zaXplKCkgfTsKICAgICB3 aGlsZSAoIWxheW91dFJhbmdlLmlzRW1wdHkoKSkgewpAQCAtNDE0LDcgKzQxNCw3IEBAIElubGlu ZVJlY3QgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1dGVHZW9tZXRyeUZvckxpbmVDb250 ZW50KGNvbnN0IExpbmVCdWlsCiAgICAgYXV0byB1cGRhdGVGbG9hdEdlb21ldHJ5ID0gWyZdIHsK ICAgICAgICAgaWYgKGxpbmVDb250ZW50LmZsb2F0cy5pc0VtcHR5KCkpCiAgICAgICAgICAgICBy ZXR1cm47Ci0gICAgICAgIGF1dG8gZmxvYXRpbmdDb250ZXh0ID0gRmxvYXRpbmdDb250ZXh0IHsg cm9vdCgpLCAqdGhpcywgZm9ybWF0dGluZ1N0YXRlLmZsb2F0aW5nU3RhdGUoKSB9OworICAgICAg ICBhdXRvIGZsb2F0aW5nQ29udGV4dCA9IEZsb2F0aW5nQ29udGV4dCB7ICp0aGlzLCBmb3JtYXR0 aW5nU3RhdGUuZmxvYXRpbmdTdGF0ZSgpIH07CiAgICAgICAgIC8vIE1vdmUgZmxvYXRzIHRvIHRo ZWlyIGZpbmFsIHBvc2l0aW9uLgogICAgICAgICBmb3IgKGNvbnN0IGF1dG8mIGZsb2F0Q2FuZGlk YXRlIDogbGluZUNvbnRlbnQuZmxvYXRzKSB7CiAgICAgICAgICAgICBhdXRvJiBmbG9hdEJveCA9 IGZsb2F0Q2FuZGlkYXRlLml0ZW0tPmxheW91dEJveCgpOwo=