217345 2020-10-05 15:27:53 -0700 REGRESSION(r267915): Many layout tests are asserting under ~CompletionHandler() 2020-10-05 18:27:25 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 hector_i_lopez wenson_hsieh dino megan_gardner thorton webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1694895 0 hector_i_lopez 2020-10-05 15:27:53 -0700 There are about 30+ test crashing after r267915 on iOS Debug with the same ASSERTION FAILURE: WTF::CompletionHandler<void ()>::~CompletionHandler(): Completion handler should always be called !m_function iOS Debug Testers: https://build.webkit.org/builders/Apple-iOS-14-Simulator-Debug-WK2-Tests?numbuilds=50 iPad Debug Testers: https://build.webkit.org/builders/Apple-iPadOS-14-Simulator-Debug-WK2-Tests?numbuilds=50 Sample log: No crash log found for com.apple.WebKit.WebContent.Development:36682. stdout: stderr: ASSERTION FAILED: Completion handler should always be called !m_function /Volumes/Data/slave/ios-simulator-14-debug/build/WebKitBuild/Debug-iphonesimulator/usr/local/include/wtf/CompletionHandler.h(53) : WTF::CompletionHandler<void ()>::~CompletionHandler() 1 0x6376706e9 WTFCrash 2 0x63f2a7817 WTF::CompletionHandler<void ()>::~CompletionHandler() 3 0x63f2a77b5 WTF::CompletionHandler<void ()>::~CompletionHandler() 4 0x642b90a8f WebCore::DragController::finalizeDroppedImagePlaceholder(WebCore::HTMLImageElement&, WTF::CompletionHandler<void ()>&&)::$_1::~$_1() 5 0x642b731e5 WebCore::DragController::finalizeDroppedImagePlaceholder(WebCore::HTMLImageElement&, WTF::CompletionHandler<void ()>&&)::$_1::~$_1() 6 0x642ba0c35 WTF::Detail::CallableWrapper<WebCore::DragController::finalizeDroppedImagePlaceholder(WebCore::HTMLImageElement&, WTF::CompletionHandler<void ()>&&)::$_1, void>::~CallableWrapper() 7 0x642ba0b45 WTF::Detail::CallableWrapper<WebCore::DragController::finalizeDroppedImagePlaceholder(WebCore::HTMLImageElement&, WTF::CompletionHandler<void ()>&&)::$_1, void>::~CallableWrapper() 8 0x642ba0b6c WTF::Detail::CallableWrapper<WebCore::DragController::finalizeDroppedImagePlaceholder(WebCore::HTMLImageElement&, WTF::CompletionHandler<void ()>&&)::$_1, void>::~CallableWrapper() 9 0x63f23d43f std::__1::default_delete<WTF::Detail::CallableWrapperBase<void> >::operator()(WTF::Detail::CallableWrapperBase<void>*) const 10 0x63f23d3ff std::__1::unique_ptr<WTF::Detail::CallableWrapperBase<void>, std::__1::default_delete<WTF::Detail::CallableWrapperBase<void> > >::reset(WTF::Detail::CallableWrapperBase<void>*) 11 0x63f23d399 std::__1::unique_ptr<WTF::Detail::CallableWrapperBase<void>, std::__1::default_delete<WTF::Detail::CallableWrapperBase<void> > >::~unique_ptr() 12 0x63f23d375 std::__1::unique_ptr<WTF::Detail::CallableWrapperBase<void>, std::__1::default_delete<WTF::Detail::CallableWrapperBase<void> > >::~unique_ptr() 13 0x63f23d355 WTF::Function<void ()>::~Function() 14 0x63f23d335 WTF::Function<void ()>::~Function() 15 0x641da4135 WebCore::EventLoopFunctionDispatchTask::~EventLoopFunctionDispatchTask() 16 0x641da3665 WebCore::EventLoopFunctionDispatchTask::~EventLoopFunctionDispatchTask() 17 0x641da368c WebCore::EventLoopFunctionDispatchTask::~EventLoopFunctionDispatchTask() 18 0x641daf50f std::__1::default_delete<WebCore::EventLoopTask>::operator()(WebCore::EventLoopTask*) const 19 0x641daf4cf std::__1::unique_ptr<WebCore::EventLoopTask, std::__1::default_delete<WebCore::EventLoopTask> >::reset(WebCore::EventLoopTask*) 20 0x641daf469 std::__1::unique_ptr<WebCore::EventLoopTask, std::__1::default_delete<WebCore::EventLoopTask> >::~unique_ptr() 21 0x641da0495 std::__1::unique_ptr<WebCore::EventLoopTask, std::__1::default_delete<WebCore::EventLoopTask> >::~unique_ptr() 22 0x641d9fbea unsigned int WTF::Vector<std::__1::unique_ptr<WebCore::EventLoopTask, std::__1::default_delete<WebCore::EventLoopTask> >, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>::removeAllMatching<WebCore::EventLoop::stopGroup(WebCore::EventLoopTaskGroup&)::$_0>(WebCore::EventLoop::stopGroup(WebCore::EventLoopTaskGroup&)::$_0 const&, unsigned long) 23 0x641d9facb WebCore::EventLoop::stopGroup(WebCore::EventLoopTaskGroup&) 24 0x641c802a6 WebCore::EventLoopTaskGroup::stopAndDiscardAllTasks() 25 0x641c7266d WebCore::Document::stopActiveDOMObjects() 26 0x641c7243c WebCore::Document::commonTeardown() 27 0x641c7ebe3 WebCore::Document::willBeRemovedFromFrame() 28 0x642bad733 WebCore::Frame::setView(WTF::RefPtr<WebCore::FrameView, WTF::DumbPtrTraits<WebCore::FrameView>, WTF::DefaultRefDerefTraits<WebCore::FrameView> >&&) 29 0x642bb271d WebCore::Frame::createView(WebCore::IntSize const&, WTF::Optional<WebCore::Color> const&, WebCore::IntSize const&, WebCore::IntRect const&, bool, WebCore::ScrollbarMode, bool, WebCore::ScrollbarMode, bool) 30 0x110c01157 WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage() 31 0x642986a4e WebCore::FrameLoader::transitionToCommitted(WebCore::CachedPage*) LEAK: 1 WebPageProxy 1694896 1 webkit-bug-importer 2020-10-05 15:28:13 -0700 <rdar://problem/69973775> 1694921 2 wenson_hsieh 2020-10-05 16:01:43 -0700 *** Bug 217348 has been marked as a duplicate of this bug. *** 1694924 3 410578 wenson_hsieh 2020-10-05 16:07:20 -0700 Created attachment 410578 Patch 1694991 4 ews-feeder 2020-10-05 18:27:25 -0700 Committed r268025: <https://trac.webkit.org/changeset/268025> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410578. 410578 2020-10-05 16:07:20 -0700 2020-10-05 18:27:25 -0700 Patch bug-217345-20201005160719.patch text/plain 2079 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3OTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU3YmY2OWE3ZWFlMDE2M2M4 YWRjMWEwNGIyMzU2NTQ3OTNiMmQwOWIuLjJmNWQ5ZWFmMDVmYjhlNzNhOTQxOGJjNGRiZTE0MTcz ZGZiNTM1NDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMTAtMDUgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjY3 OTE1KTogTWFueSBsYXlvdXQgdGVzdHMgYXJlIGFzc2VydGluZyB1bmRlciB+Q29tcGxldGlvbkhh bmRsZXIoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjE3MzQ1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82OTk3Mzc3NT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIGRpZCAqbm90KiBpbnRlbmQgdG8g c2NoZWR1bGUgYW4gYXN5bmMgdGFzayBhZnRlciBldmVyeSBzaW5nbGUgaW1hZ2UgbG9hZCBpbiBy MjY3OTE1LiBBcGFydCBmcm9tIHRyaWdnZXJpbmcKKyAgICAgICAgYXNzZXJ0aW9ucyBvbiB2YXJp b3VzIHRlc3RzLCB0aGlzIGFsc28gY2F1c2VzIHVzIHRvIHNlbmQgZXhjZXNzaXZlIElQQyBtZXNz YWdlcyB0byB0aGUgVUkgcHJvY2VzcyB3aGVuIGxvYWRpbmcKKyAgICAgICAgaW1hZ2VzLCB3aGlj aCBjYW4ndCBiZSBnb29kIGZvciBwZXJmb3JtYW5jZS4gRml4IHRoaXMgYnkgb25seSBjYWxsaW5n IGludG8gYGNvbXB1dGVBbmRTZW5kRWRpdERyYWdTbmFwc2hvdCgpYAorICAgICAgICB3aGVuIHdl J3ZlIGZpbmlzaGVkIGxvYWRpbmcgYWxsIGRyb3BwZWQgaW1hZ2UgZWxlbWVudHMuCisKKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW06CisgICAgICAgIChXZWJL aXQ6OldlYlBhZ2U6OmRpZEZpbmlzaExvYWRpbmdJbWFnZUZvckVsZW1lbnQpOgorCiAyMDIwLTEw LTA1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtH UFUgUHJvY2Vzc10gU3VwcG9ydCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuZHJhd0ltYWdlKCkg d2l0aCBIVE1MVmlkZW9FbGVtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9X ZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCmluZGV4IDFlN2Y2NjIzNDdjZmUwZjJmZGZjZjc5Y2Vj Mzg0YWU4YWQ5NDVmOGIuLjgxMjRmZGQxMGE5NDVhYjc0NWU3ODIxNzliM2E4ZDcwZmIzZWJlM2Ug MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdl SU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdl SU9TLm1tCkBAIC0xMDE1LDcgKzEwMTUsOSBAQCB2b2lkIFdlYlBhZ2U6OmRpZENvbmNsdWRlRWRp dERyYWcoKQogCiB2b2lkIFdlYlBhZ2U6OmRpZEZpbmlzaExvYWRpbmdJbWFnZUZvckVsZW1lbnQo V2ViQ29yZTo6SFRNTEltYWdlRWxlbWVudCYgZWxlbWVudCkKIHsKLSAgICBtX3BlbmRpbmdJbWFn ZUVsZW1lbnRzRm9yRHJvcFNuYXBzaG90LnJlbW92ZSgmZWxlbWVudCk7CisgICAgaWYgKCFtX3Bl bmRpbmdJbWFnZUVsZW1lbnRzRm9yRHJvcFNuYXBzaG90LnJlbW92ZSgmZWxlbWVudCkpCisgICAg ICAgIHJldHVybjsKKwogICAgIGJvb2wgc2hvdWxkU2VuZFNuYXBzaG90ID0gbV9wZW5kaW5nSW1h Z2VFbGVtZW50c0ZvckRyb3BTbmFwc2hvdC5pc0VtcHR5KCk7CiAgICAgbV9wYWdlLT5kcmFnQ29u dHJvbGxlcigpLmZpbmFsaXplRHJvcHBlZEltYWdlUGxhY2Vob2xkZXIoZWxlbWVudCwgW3Byb3Rl Y3RlZFRoaXMgPSBtYWtlUmVmUHRyKHRoaXMpLCBzaG91bGRTZW5kU25hcHNob3RdIHsKICAgICAg ICAgaWYgKHNob3VsZFNlbmRTbmFwc2hvdCkK