217338 2020-10-05 14:36:25 -0700 ChromeClient::needsImmediateRenderingUpdate() only exists to work around a WebKit1 bug 2020-10-05 17:54:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser sabouhallawa simon.fraser webkit-bug-importer oldest_to_newest 1694867 0 simon.fraser 2020-10-05 14:36:25 -0700 ChromeClient::needsImmediateRenderingUpdate() only existing to work around a WebKit1 bug 1694868 1 410563 simon.fraser 2020-10-05 14:38:31 -0700 Created attachment 410563 Patch 1694879 2 410563 sabouhallawa 2020-10-05 14:55:34 -0700 Comment on attachment 410563 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410563&action=review > Source/WebCore/ChangeLog:9 > + because the RunLoopObserver was always invalidate at the end of the callback. invalidating? or calling invalidate()? > Source/WebKitLegacy/mac/WebView/WebViewData.h:125 > + bool m_insideCallback { false }; > + bool m_rescheduledInsideCallback { false }; I think using two booleans can be a little bit difficult to understand. Can't we use enum for the states of these two members? enum class SchedulingState { None, InsideCallback, AlreadyRescheduled } // Maybe the names need to be changed. > Source/WebKitLegacy/mac/WebView/WebViewData.mm:129 > + SetForScope<bool> insideCallbackScope(m_insideCallback, true); > + m_rescheduledInsideCallback = false; This can be changed to SetForScope<SchedulingState> change(m_schedulingState, SchedulingState::InsideCallback); 1694980 3 simon.fraser 2020-10-05 17:53:43 -0700 https://trac.webkit.org/changeset/268022/webkit 1694982 4 webkit-bug-importer 2020-10-05 17:54:17 -0700 <rdar://problem/69979228> 410563 2020-10-05 14:38:31 -0700 2020-10-05 14:55:34 -0700 Patch bug-217338-20201005143830.patch text/plain 6439 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3OTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzRjYTkxZjkyMDBiMTc3 M2I4N2QzYTcyZGRlNmYxZDAzMDU1ZGQ0ZS4uNDRmNmI0NjBjN2YxMGU3MTk5MTk2NGYyZTI2ODI1 ZTJkOWM4N2QxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTEwLTA1ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIENocm9tZUNsaWVu dDo6bmVlZHNJbW1lZGlhdGVSZW5kZXJpbmdVcGRhdGUoKSBvbmx5IGV4aXN0aW5nIHRvIHdvcmsg YXJvdW5kIGEgV2ViS2l0MSBidWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxNzMzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdlYlZpZXdMYXllckZsdXNoU2NoZWR1bGVyIGhhcyBhIGJ1ZyB3aGVyZSBz Y2hlZHVsaW5nIGluc2lkZSB0aGUgY2FsbGJhY2sgd291bGQgZmFpbAorICAgICAgICBiZWNhdXNl IHRoZSBSdW5Mb29wT2JzZXJ2ZXIgd2FzIGFsd2F5cyBpbnZhbGlkYXRlIGF0IHRoZSBlbmQgb2Yg dGhlIGNhbGxiYWNrLgorCisgICAgICAgIElmIHdlIGZpeCB0aGlzLCB3ZSBjYW4gcmVtb3ZlIENo cm9tZUNsaWVudDo6bmVlZHNJbW1lZGlhdGVSZW5kZXJpbmdVcGRhdGUoKSB3aGljaCBJIGJlbGll dmUKKyAgICAgICAgb25seSBleGlzdGVkIHRvIHdvcmsgYXJvdW5kIHRoaXMgYnVnLgorCisgICAg ICAgICogcGFnZS9DaHJvbWVDbGllbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVu dDo6c2NoZWR1bGVUaW1lZFJlbmRlcmluZ1VwZGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpDaHJv bWVDbGllbnQ6Om5lZWRzSW1tZWRpYXRlUmVuZGVyaW5nVXBkYXRlIGNvbnN0KTogRGVsZXRlZC4K KyAgICAgICAgKiBwYWdlL1JlbmRlcmluZ1VwZGF0ZVNjaGVkdWxlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJpbmdVcGRhdGVTY2hlZHVsZXI6OnNjaGVkdWxlUmVuZGVyaW5nVXBkYXRl KToKKwogMjAyMC0xMC0wNSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAg ICAgICAgW0xGQ11bSW50ZWdyYXRpb25dIEF2b2lkIGVuc3VyZUxpbmVCb3hlcyBmb3Igc29tZSBj YWxsIHNpdGVzIG9mIGlubGluZUJveEFuZE9mZnNldApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dExlZ2FjeS9tYWMvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9n CmluZGV4IGE4NDI2MGQ5OGI1MDJkNGYwM2E5M2Y2NzIxN2QxMjI3NDhhODdmOWMuLmRlZDYxYjM1 YjBkY2Y3ZGU3YzMwNjQ5N2Y2ZjM4MzNhNzMwYTgwYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXRMZWdhY3kvbWFjL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAyMC0xMC0wNSAgU2ltb24gRnJhc2VyICA8c2ltb24u ZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBDaHJvbWVDbGllbnQ6Om5lZWRzSW1tZWRpYXRl UmVuZGVyaW5nVXBkYXRlKCkgb25seSBleGlzdGluZyB0byB3b3JrIGFyb3VuZCBhIFdlYktpdDEg YnVnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTcz MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJW aWV3TGF5ZXJGbHVzaFNjaGVkdWxlciBoYXMgYSBidWcgd2hlcmUgc2NoZWR1bGluZyBpbnNpZGUg dGhlIGNhbGxiYWNrIHdvdWxkIGZhaWwKKyAgICAgICAgYmVjYXVzZSB0aGUgUnVuTG9vcE9ic2Vy dmVyIHdhcyBhbHdheXMgaW52YWxpZGF0ZSBhdCB0aGUgZW5kIG9mIHRoZSBjYWxsYmFjay4KKwor ICAgICAgICBJZiB3ZSBmaXggdGhpcywgd2UgY2FuIHJlbW92ZSBDaHJvbWVDbGllbnQ6Om5lZWRz SW1tZWRpYXRlUmVuZGVyaW5nVXBkYXRlKCkgd2hpY2ggSSBiZWxpZXZlCisgICAgICAgIG9ubHkg ZXhpc3RlZCB0byB3b3JrIGFyb3VuZCB0aGlzIGJ1Zy4KKworICAgICAgICAqIFdlYkNvcmVTdXBw b3J0L1dlYkNocm9tZUNsaWVudC5oOgorICAgICAgICAqIFdlYlZpZXcvV2ViVmlld0RhdGEuaDoK KyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXdEYXRhLm1tOgorICAgICAgICAoV2ViVmlld0xheWVy Rmx1c2hTY2hlZHVsZXI6OnNjaGVkdWxlKToKKyAgICAgICAgKFdlYlZpZXdMYXllckZsdXNoU2No ZWR1bGVyOjpsYXllckZsdXNoQ2FsbGJhY2spOgorCiAyMDIwLTEwLTAzICBZdXN1a2UgU3V6dWtp ICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gSW50cm9kdWNlIEpJVE9wZXJh dGlvbkxpc3QgdG8gdmFsaWRhdGUgSklULWNhZ2VkIHBvaW50ZXJzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0Nocm9tZUNsaWVudC5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9DaHJv bWVDbGllbnQuaAppbmRleCBmZTU5ZGI4NGFlYWNhNWY5OTEyMWI3OTBkMDA4MDkyMDYyZmY0Y2Mx Li41MTEwZDExODBhNzczZGVkNWUyM2QyZjAzYzBmN2RkMjk0ODQ3NjY2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZUNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvQ2hyb21lQ2xpZW50LmgKQEAgLTMyNyw3ICszMjcsNiBAQCBwdWJsaWM6CiAgICAgLy8gdG8g ZG8gYW4gZWFnZXIgbGF5b3V0IGJlZm9yZSB0aGUgZHJhd2luZy4KICAgICB2aXJ0dWFsIHZvaWQg c2NoZWR1bGVSZW5kZXJpbmdVcGRhdGUoKSA9IDA7CiAgICAgdmlydHVhbCBib29sIHNjaGVkdWxl VGltZWRSZW5kZXJpbmdVcGRhdGUoKSB7IHJldHVybiBmYWxzZTsgfQotICAgIHZpcnR1YWwgYm9v bCBuZWVkc0ltbWVkaWF0ZVJlbmRlcmluZ1VwZGF0ZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9 CiAgICAgLy8gUmV0dXJucyB3aGV0aGVyIG9yIG5vdCB0aGUgY2xpZW50IGNhbiByZW5kZXIgdGhl IGNvbXBvc2l0ZWQgbGF5ZXIsCiAgICAgLy8gcmVnYXJkbGVzcyBvZiB0aGUgc2V0dGluZ3MuCiAg ICAgdmlydHVhbCBib29sIGFsbG93c0FjY2VsZXJhdGVkQ29tcG9zaXRpbmcoKSBjb25zdCB7IHJl dHVybiB0cnVlOyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1JlbmRlcmluZ1Vw ZGF0ZVNjaGVkdWxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1JlbmRlcmluZ1VwZGF0ZVNj aGVkdWxlci5jcHAKaW5kZXggZmE3Y2M3NzM0NDg0ZWNjMjJhZmRiYzgxZDM5NDY3NmRkZDkwY2Fh MS4uMWFjYWUzNTJjNjMzMmI5ZWQ0MTlhZjlmMjVlOTNjNTIwOGZmOTU4YSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9SZW5kZXJpbmdVcGRhdGVTY2hlZHVsZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvUmVuZGVyaW5nVXBkYXRlU2NoZWR1bGVyLmNwcApAQCAtMTQ2LDEw ICsxNDYsNyBAQCB2b2lkIFJlbmRlcmluZ1VwZGF0ZVNjaGVkdWxlcjo6c2NoZWR1bGVJbW1lZGlh dGVSZW5kZXJpbmdVcGRhdGUoKQogCiB2b2lkIFJlbmRlcmluZ1VwZGF0ZVNjaGVkdWxlcjo6c2No ZWR1bGVSZW5kZXJpbmdVcGRhdGUoKQogewotICAgIGlmIChtX3BhZ2UuY2hyb21lKCkuY2xpZW50 KCkubmVlZHNJbW1lZGlhdGVSZW5kZXJpbmdVcGRhdGUoKSkKLSAgICAgICAgc2NoZWR1bGVJbW1l ZGlhdGVSZW5kZXJpbmdVcGRhdGUoKTsKLSAgICBlbHNlCi0gICAgICAgIHNjaGVkdWxlVGltZWRS ZW5kZXJpbmdVcGRhdGUoKTsKKyAgICBzY2hlZHVsZVRpbWVkUmVuZGVyaW5nVXBkYXRlKCk7CiB9 CiAKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYkNvcmVTdXBwb3J0 L1dlYkNocm9tZUNsaWVudC5oIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViQ29yZVN1cHBv cnQvV2ViQ2hyb21lQ2xpZW50LmgKaW5kZXggZTczYmMzMmE2MmIyOTY0ZmMyZmE4YzYxNDdjZmMw MDBhMjQzYWJhNy4uZGNkZjJjMjhkN2RlNTU3ZTVkYTI3OWE4YTlkMmQ4OGUzZDRmODk5NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21l Q2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViQ29yZVN1cHBvcnQvV2Vi Q2hyb21lQ2xpZW50LmgKQEAgLTE3NSw3ICsxNzUsNiBAQCBwcml2YXRlOgogICAgIHZvaWQgYXR0 YWNoVmlld092ZXJsYXlHcmFwaGljc0xheWVyKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIqKSBmaW5h bDsKICAgICB2b2lkIHNldE5lZWRzT25lU2hvdERyYXdpbmdTeW5jaHJvbml6YXRpb24oKSBmaW5h bDsKICAgICB2b2lkIHNjaGVkdWxlUmVuZGVyaW5nVXBkYXRlKCkgZmluYWw7Ci0gICAgYm9vbCBu ZWVkc0ltbWVkaWF0ZVJlbmRlcmluZ1VwZGF0ZSgpIGNvbnN0IGZpbmFsIHsgcmV0dXJuIHRydWU7 IH0KIAogICAgIENvbXBvc2l0aW5nVHJpZ2dlckZsYWdzIGFsbG93ZWRDb21wb3NpdGluZ1RyaWdn ZXJzKCkgY29uc3QgZmluYWwKICAgICB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5 L21hYy9XZWJWaWV3L1dlYlZpZXdEYXRhLmggYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJW aWV3L1dlYlZpZXdEYXRhLmgKaW5kZXggMWZkYTc2NzY0OWMyMjZmMjFhN2U3MmE0NjE3OWMzZjll YWViNzM1Yi4uZGZlMmMzMDBkNzY2M2JjNThmMGNmOGM2YjY3YmU4NTcwMDRjZDAyNSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJWaWV3RGF0YS5oCisrKyBi L1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmlld0RhdGEuaApAQCAtMTIxLDYg KzEyMSw4IEBAIHByaXZhdGU6CiAgICAgCiAgICAgTGF5ZXJGbHVzaENvbnRyb2xsZXIqIG1fZmx1 c2hDb250cm9sbGVyOwogICAgIHN0ZDo6dW5pcXVlX3B0cjxXZWJDb3JlOjpSdW5Mb29wT2JzZXJ2 ZXI+IG1fcnVuTG9vcE9ic2VydmVyOworICAgIGJvb2wgbV9pbnNpZGVDYWxsYmFjayB7IGZhbHNl IH07CisgICAgYm9vbCBtX3Jlc2NoZWR1bGVkSW5zaWRlQ2FsbGJhY2sgeyBmYWxzZSB9OwogfTsK IAogY2xhc3MgTGF5ZXJGbHVzaENvbnRyb2xsZXIgOiBwdWJsaWMgUmVmQ291bnRlZDxMYXllckZs dXNoQ29udHJvbGxlcj4gewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2Vi Vmlldy9XZWJWaWV3RGF0YS5tbSBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2Vi Vmlld0RhdGEubW0KaW5kZXggNGRkMzlkNjZkZTQyZTQ5ZmFkYWQ0YWVjNzg4YjE0ZDJmZGQxZTVk ZC4uODY3YmVhMzYwNjhmNTMzNjVlNzViYTY0NmE3YzM5OTg5MTcyYjFkMiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJWaWV3RGF0YS5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlZpZXdEYXRhLm1tCkBAIC00Myw2ICs0Myw3 IEBACiAjaW1wb3J0IDxXZWJDb3JlL1dlYkNvcmVKSVRPcGVyYXRpb25zLmg+CiAjaW1wb3J0IDx3 dGYvTWFpblRocmVhZC5oPgogI2ltcG9ydCA8d3RmL1J1bkxvb3AuaD4KKyNpbXBvcnQgPHd0Zi9T ZXRGb3JTY29wZS5oPgogCiAjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKICNpbXBvcnQgIldlYkdl b2xvY2F0aW9uUHJvdmlkZXJJT1MuaCIKQEAgLTEwOCw2ICsxMDksOSBAQCBXZWJWaWV3TGF5ZXJG bHVzaFNjaGVkdWxlcjo6fldlYlZpZXdMYXllckZsdXNoU2NoZWR1bGVyKCkKIAogdm9pZCBXZWJW aWV3TGF5ZXJGbHVzaFNjaGVkdWxlcjo6c2NoZWR1bGUoKQogeworICAgIGlmIChtX2luc2lkZUNh bGxiYWNrKQorICAgICAgICBtX3Jlc2NoZWR1bGVkSW5zaWRlQ2FsbGJhY2sgPSB0cnVlOworCiAg ICAgbV9ydW5Mb29wT2JzZXJ2ZXItPnNjaGVkdWxlKGN1cnJlbnRSdW5Mb29wKCkpOwogfQogCkBA IC0xMjAsNyArMTI0LDExIEBAIHZvaWQgV2ViVmlld0xheWVyRmx1c2hTY2hlZHVsZXI6OmxheWVy Rmx1c2hDYWxsYmFjaygpCiB7CiAgICAgQGF1dG9yZWxlYXNlcG9vbCB7CiAgICAgICAgIFJlZlB0 cjxMYXllckZsdXNoQ29udHJvbGxlcj4gcHJvdGVjdG9yID0gbV9mbHVzaENvbnRyb2xsZXI7Ci0g ICAgICAgIGlmIChtX2ZsdXNoQ29udHJvbGxlci0+Zmx1c2hMYXllcnMoKSkKKworICAgICAgICBT ZXRGb3JTY29wZTxib29sPiBpbnNpZGVDYWxsYmFja1Njb3BlKG1faW5zaWRlQ2FsbGJhY2ssIHRy dWUpOworICAgICAgICBtX3Jlc2NoZWR1bGVkSW5zaWRlQ2FsbGJhY2sgPSBmYWxzZTsKKworICAg ICAgICBpZiAobV9mbHVzaENvbnRyb2xsZXItPmZsdXNoTGF5ZXJzKCkgJiYgIW1fcmVzY2hlZHVs ZWRJbnNpZGVDYWxsYmFjaykKICAgICAgICAgICAgIGludmFsaWRhdGUoKTsKICAgICB9CiB9Cg==