217334 2020-10-05 13:41:25 -0700 Add JSC option to trigger a hardware breakpoint when debugger expressions are reached. 2020-10-05 14:36:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller ews-watchlist mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1694833 0 keith_miller 2020-10-05 13:41:25 -0700 Add JSC option to trigger a hardware breakpoint when debugger expressions are reached. 1694834 1 410551 keith_miller 2020-10-05 13:41:51 -0700 Created attachment 410551 Patch 1694836 2 410551 ysuzuki 2020-10-05 13:45:46 -0700 Comment on attachment 410551 Patch r=me 1694864 3 ews-feeder 2020-10-05 14:35:25 -0700 Committed r268004: <https://trac.webkit.org/changeset/268004> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410551. 1694865 4 webkit-bug-importer 2020-10-05 14:36:17 -0700 <rdar://problem/69971552> 410551 2020-10-05 13:41:51 -0700 2020-10-05 14:35:27 -0700 Patch bug-217334-20201005134150.patch text/plain 3445 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3ODg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx YmFhODFhZGE3ZGFiODkzMDA1OGE1MTdjZDk2OTAzZmVlNmU3YWMwLi5hNzg1ODU0NzkwYzUwZDli MDQyMDMxOGQwYWZjMmVhMmMyZjI2MjJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0xMC0wNSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBBZGQgSlNDIG9wdGlvbiB0byB0cmlnZ2VyIGEgaGFyZHdhcmUgYnJl YWtwb2ludCB3aGVuIGRlYnVnZ2VyIGV4cHJlc3Npb25zIGFyZSByZWFjaGVkLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3MzM0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnRlcnByZXRlci9JbnRl cnByZXRlci5jcHA6CisgICAgICAgIChKU0M6OkludGVycHJldGVyOjpkZWJ1Zyk6CisgICAgICAg ICogcnVudGltZS9KU0dsb2JhbE9iamVjdC5oOgorICAgICAgICAoSlNDOjpKU0dsb2JhbE9iamVj dDo6ZGVmYXVsdENvZGVHZW5lcmF0aW9uTW9kZSBjb25zdCk6CisgICAgICAgICogcnVudGltZS9P cHRpb25zTGlzdC5oOgorCiAyMDIwLTEwLTAyICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBl cmV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gW0dUS10gQWRkIG1pc3Npbmcg bG9jYWxlLmggaGVhZGVyIG5lZWRlZCBmb3Igc2V0bG9jYWxlKCkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCmluZGV4IDRlN2NkYzFmN2Mz Mjc1NTEwZGU0OWZlNzlhZWEwYmIzYmNkMThhN2MuLmQxNDlmNzc2MzNkZjlkY2JiZDA3NWI4MzAz M2VlMWRlZTg4YTJmNzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnBy ZXRlci9JbnRlcnByZXRlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJl dGVyL0ludGVycHJldGVyLmNwcApAQCAtMTI2NSw2ICsxMjY1LDEwIEBAIE5FVkVSX0lOTElORSB2 b2lkIEludGVycHJldGVyOjpkZWJ1ZyhDYWxsRnJhbWUqIGNhbGxGcmFtZSwgRGVidWdIb29rVHlw ZSBkZWJ1Z0hvCiB7CiAgICAgVk0mIHZtID0gY2FsbEZyYW1lLT5kZXByZWNhdGVkVk0oKTsKICAg ICBhdXRvIHNjb3BlID0gREVDTEFSRV9DQVRDSF9TQ09QRSh2bSk7CisKKyAgICBpZiAoVU5MSUtF TFkoT3B0aW9uczo6ZGVidWdnZXJUcmlnZ2Vyc0JyZWFrcG9pbnRFeGNlcHRpb24oKSkgJiYgZGVi dWdIb29rVHlwZSA9PSBEaWRSZWFjaERlYnVnZ2VyU3RhdGVtZW50KQorICAgICAgICBXVEZCcmVh a3BvaW50VHJhcCgpOworCiAgICAgRGVidWdnZXIqIGRlYnVnZ2VyID0gY2FsbEZyYW1lLT5sZXhp Y2FsR2xvYmFsT2JqZWN0KHZtKS0+ZGVidWdnZXIoKTsKICAgICBpZiAoIWRlYnVnZ2VyKQogICAg ICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U0dsb2JhbE9iamVjdC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxP YmplY3QuaAppbmRleCBhNzFkNTljYTI5NGZhZTMxMDg0ODlkYzA3NjQwZjBmOGQwMTgyNjU3Li45 NzU2NGU5YzJkZTU2YzkxZWVhZTUyZGI5NTIwNjYwYmFkNTg3Y2ZjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdC5oCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmgKQEAgLTExNjQsNyArMTE2NCw3 IEBAIGlubGluZSBKU09iamVjdCogSlNHbG9iYWxPYmplY3Q6Omdsb2JhbFRoaXMoKSBjb25zdAog aW5saW5lIE9wdGlvblNldDxDb2RlR2VuZXJhdGlvbk1vZGU+IEpTR2xvYmFsT2JqZWN0OjpkZWZh dWx0Q29kZUdlbmVyYXRpb25Nb2RlKCkgY29uc3QKIHsKICAgICBPcHRpb25TZXQ8Q29kZUdlbmVy YXRpb25Nb2RlPiBjb2RlR2VuZXJhdGlvbk1vZGU7Ci0gICAgaWYgKGhhc0ludGVyYWN0aXZlRGVi dWdnZXIoKSB8fCBPcHRpb25zOjpmb3JjZURlYnVnZ2VyQnl0ZWNvZGVHZW5lcmF0aW9uKCkpCisg ICAgaWYgKGhhc0ludGVyYWN0aXZlRGVidWdnZXIoKSB8fCBPcHRpb25zOjpmb3JjZURlYnVnZ2Vy Qnl0ZWNvZGVHZW5lcmF0aW9uKCkgfHwgT3B0aW9uczo6ZGVidWdnZXJUcmlnZ2Vyc0JyZWFrcG9p bnRFeGNlcHRpb24oKSkKICAgICAgICAgY29kZUdlbmVyYXRpb25Nb2RlLmFkZChDb2RlR2VuZXJh dGlvbk1vZGU6OkRlYnVnZ2VyKTsKICAgICBpZiAodm0oKS50eXBlUHJvZmlsZXIoKSkKICAgICAg ICAgY29kZUdlbmVyYXRpb25Nb2RlLmFkZChDb2RlR2VuZXJhdGlvbk1vZGU6OlR5cGVQcm9maWxl cik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zTGlz dC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9uc0xpc3QuaAppbmRleCBk ZGRmNGRkNjQ3MDU1ZGRhZjk5MjQ2OWU4NDU1NTQyNWQwMjFlY2MwLi44ODQzN2RhOWRlZTQwNjZm NmQ3ODU4MzkyMDViMzE3NDkyYTMxYzljIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9PcHRpb25zTGlzdC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL09wdGlvbnNMaXN0LmgKQEAgLTExMCw2ICsxMTAsNyBAQCBjb25zdGV4cHIgYm9vbCBlbmFi bGVXZWJBc3NlbWJseVN0cmVhbWluZ0FwaSA9IGZhbHNlOwogICAgIHYoQm9vbCwgZHVtcEJ5dGVj b2RlTGl2ZW5lc3NSZXN1bHRzLCBmYWxzZSwgTm9ybWFsLCBudWxscHRyKSBcCiAgICAgdihCb29s LCB2YWxpZGF0ZUJ5dGVjb2RlLCBmYWxzZSwgTm9ybWFsLCBudWxscHRyKSBcCiAgICAgdihCb29s LCBmb3JjZURlYnVnZ2VyQnl0ZWNvZGVHZW5lcmF0aW9uLCBmYWxzZSwgTm9ybWFsLCBudWxscHRy KSBcCisgICAgdihCb29sLCBkZWJ1Z2dlclRyaWdnZXJzQnJlYWtwb2ludEV4Y2VwdGlvbiwgZmFs c2UsIE5vcm1hbCwgIlVzaW5nIHRoZSBkZWJ1Z2dlciBzdGF0ZW1lbnQgd2lsbCB0cmlnZ2VyIGFu IGJyZWFrcG9pbnQgZXhjZXB0aW9uIChVc2VmdWwgd2hlbiBsbGRiaW5nKSIpIFwKICAgICB2KEJv b2wsIGR1bXBCeXRlY29kZXNCZWZvcmVHZW5lcmF0b3JpZmljYXRpb24sIGZhbHNlLCBOb3JtYWws IG51bGxwdHIpIFwKICAgICBcCiAgICAgdihCb29sLCB1c2VGdW5jdGlvbkRvdEFyZ3VtZW50cywg dHJ1ZSwgTm9ybWFsLCBudWxscHRyKSBcCg==