217328 2020-10-05 12:54:12 -0700 Use memset to zero vectors in PeriodicWave::createBandLimitedTables() 2020-10-05 14:30:28 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 212611 1 cdumez cdumez cdumez darin eric.carlson ews-watchlist ggaren glenn jer.noble philipj sam sergio webkit-bug-importer oldest_to_newest 1694799 0 cdumez 2020-10-05 12:54:12 -0700 Use memset to zero vectors in PeriodicWave::createBandLimitedTables() instead of a for loop. 1694803 1 410540 cdumez 2020-10-05 12:55:58 -0700 Created attachment 410540 Patch 1694843 2 410540 darin 2020-10-05 14:03:49 -0700 Comment on attachment 410540 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410540&action=review > Source/WebCore/ChangeLog:9 > + Use memset to zero vectors in PeriodicWave::createBandLimitedTables() instead of a for > + loop, for performance reasons. On reflection, I’m surprised this improves performance. I would expect a modern compiler to convert both into the exact same code. 1694856 3 ews-feeder 2020-10-05 14:29:50 -0700 Committed r268002: <https://trac.webkit.org/changeset/268002> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410540. 1694857 4 webkit-bug-importer 2020-10-05 14:30:28 -0700 <rdar://problem/69971290> 410540 2020-10-05 12:55:58 -0700 2020-10-05 14:29:51 -0700 Patch bug-217328-20201005125558.patch text/plain 2384 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3OTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmUzYzY1YWE2NTRiNGI5 Yjg0YjQ5ZDlhMGQwNTJjMTZhNTcxMzY0OS4uMGEzMWY0NTY4MWRlYjliYTU2ZjE4MjBmNGJkNGEx OWUyMTU5ZTU0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEwLTA1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIG1lbXNldCB0byB6ZXJv IHZlY3RvcnMgaW4gUGVyaW9kaWNXYXZlOjpjcmVhdGVCYW5kTGltaXRlZFRhYmxlcygpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTczMjgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgbWVtc2V0IHRv IHplcm8gdmVjdG9ycyBpbiBQZXJpb2RpY1dhdmU6OmNyZWF0ZUJhbmRMaW1pdGVkVGFibGVzKCkg aW5zdGVhZCBvZiBhIGZvcgorICAgICAgICBsb29wLCBmb3IgcGVyZm9ybWFuY2UgcmVhc29ucy4K KworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIFdlYi1mYWNpbmcgYmVoYXZpb3IgY2hhbmdlLgor CisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9QZXJpb2RpY1dhdmUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UGVyaW9kaWNXYXZlOjpjcmVhdGVCYW5kTGltaXRlZFRhYmxlcyk6CisKIDIwMjAt MTAtMDUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29jb2Fd IFZlY3Rvcml6ZSBsaW5lYXIgdG8gZGVjaWJlbHMgY29udmVyc2lvbiBpbiBSZWFsdGltZUFuYWx5 c2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1BlcmlvZGlj V2F2ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1BlcmlvZGljV2F2ZS5j cHAKaW5kZXggOWVkNGRlZGQ2NzMyZjhjYjkwNjVmZjc5YzZkNmU5ZTQyMzE4MGZlZC4uN2MyMWUy OWMzNTg0MjFlODU1MjFhMGQ4NmI4YjU5M2JkZmZmZTg2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy93ZWJhdWRpby9QZXJpb2RpY1dhdmUuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvd2ViYXVkaW8vUGVyaW9kaWNXYXZlLmNwcApAQCAtMTkwLDcgKzE5MCw2IEBA IHZvaWQgUGVyaW9kaWNXYXZlOjpjcmVhdGVCYW5kTGltaXRlZFRhYmxlcyhjb25zdCBmbG9hdCog cmVhbERhdGEsIGNvbnN0IGZsb2F0KiBpCiAKICAgICB1bnNpZ25lZCBmZnRTaXplID0gcGVyaW9k aWNXYXZlU2l6ZSgpOwogICAgIHVuc2lnbmVkIGhhbGZTaXplID0gZmZ0U2l6ZSAvIDI7Ci0gICAg dW5zaWduZWQgaTsKICAgICAKICAgICBudW1iZXJPZkNvbXBvbmVudHMgPSBzdGQ6Om1pbihudW1i ZXJPZkNvbXBvbmVudHMsIGhhbGZTaXplKTsKIApAQCAtMjE1LDkgKzIxNCwxMSBAQCB2b2lkIFBl cmlvZGljV2F2ZTo6Y3JlYXRlQmFuZExpbWl0ZWRUYWJsZXMoY29uc3QgZmxvYXQqIHJlYWxEYXRh LCBjb25zdCBmbG9hdCogaQogICAgICAgICAvLyBJZiBmZXdlciBjb21wb25lbnRzIHdlcmUgcHJv dmlkZWQgdGhhbiAxLzIgRkZUIHNpemUsIHRoZW4gY2xlYXIgdGhlCiAgICAgICAgIC8vIHJlbWFp bmluZyBiaW5zLiBXZSBhbHNvIG5lZWQgdG8gY3VsbCB0aGUgYWxpYXNpbmcgcGFydGlhbHMgZm9y IHRoaXMKICAgICAgICAgLy8gcGl0Y2ggcmFuZ2UuCi0gICAgICAgIGZvciAoaSA9IHN0ZDo6bWlu KG51bWJlck9mQ29tcG9uZW50cywgbnVtYmVyT2ZQYXJ0aWFscyArIDEpOyBpIDwgaGFsZlNpemU7 ICsraSkgewotICAgICAgICAgICAgcmVhbFBbaV0gPSAwOwotICAgICAgICAgICAgaW1hZ1BbaV0g PSAwOworICAgICAgICB1bnNpZ25lZCBjbGFtcGVkTnVtYmVyT2ZDb21wb25lbnRzID0gc3RkOjpt aW4obnVtYmVyT2ZDb21wb25lbnRzLCBudW1iZXJPZlBhcnRpYWxzICsgMSk7CisgICAgICAgIGlm IChjbGFtcGVkTnVtYmVyT2ZDb21wb25lbnRzIDwgaGFsZlNpemUpIHsKKyAgICAgICAgICAgIHNp emVfdCBudW1CeXRlcyA9IChoYWxmU2l6ZSAtIGNsYW1wZWROdW1iZXJPZkNvbXBvbmVudHMpICog c2l6ZW9mKGZsb2F0KTsKKyAgICAgICAgICAgIG1lbXNldCgmcmVhbFBbY2xhbXBlZE51bWJlck9m Q29tcG9uZW50c10sIDAsIG51bUJ5dGVzKTsKKyAgICAgICAgICAgIG1lbXNldCgmaW1hZ1BbY2xh bXBlZE51bWJlck9mQ29tcG9uZW50c10sIDAsIG51bUJ5dGVzKTsKICAgICAgICAgfQogCiAgICAg ICAgIC8vIENsZWFyIHBhY2tlZC1ueXF1aXN0IGFuZCBhbnkgREMtb2Zmc2V0Lgo=