217298 2020-10-04 14:31:09 -0700 [curl] WebSocket tests are failing since r267931 2020-10-04 21:20:19 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii basuke darin don.olmstead ews-watchlist galpeter ross.kirsling takashi.komori webkit-bug-importer oldest_to_newest 1694578 0 fujii 2020-10-04 14:31:09 -0700 [curl] WebSocket test are failing since r267931 https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/8810 Bug 217250 – "http:" should not be a valid URL 1694579 1 fujii 2020-10-04 14:31:59 -0700 I guess `CurlStream::CurlStream` shouldn't use `setProtocol`. > urlForConnection.setProtocol(url.protocolIs("wss") ? "https" : "http"); 1694585 2 410483 fujii 2020-10-04 14:58:44 -0700 Created attachment 410483 WIP patch 1694602 3 410491 fujii 2020-10-04 17:43:45 -0700 Created attachment 410491 Patch 1694624 4 410491 darin 2020-10-04 20:45:42 -0700 Comment on attachment 410491 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410491&action=review > Source/WebCore/platform/network/curl/CurlStream.cpp:47 > // Libcurl is not responsible for the protocol handling. It just handles connection. > // Only scheme, host and port is required. > - URL urlForConnection; > - urlForConnection.setProtocol(url.protocolIs("wss") ? "https" : "http"); > - urlForConnection.setHostAndPort(url.hostAndPort()); > - m_curlHandle->setUrl(urlForConnection); > + url.setProtocol(url.protocolIs("wss") ? "https" : "http"); > + m_curlHandle->setUrl(WTFMove(url)); The code no longer matches the comment. 1694630 5 fujii 2020-10-04 21:19:45 -0700 Committed r267954: <https://trac.webkit.org/changeset/267954> 1694631 6 webkit-bug-importer 2020-10-04 21:20:19 -0700 <rdar://problem/69940122> 410483 2020-10-04 14:58:44 -0700 2020-10-04 17:43:38 -0700 WIP patch a.diff text/plain 797 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsU3Ry ZWFtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsU3RyZWFt LmNwcAppbmRleCAyNmRjN2JlZjRiNzQuLjU4NTY2ZDkxYzMyOCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxTdHJlYW0uY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsU3RyZWFtLmNwcApAQCAtNDMsOSAr NDMsOCBAQCBDdXJsU3RyZWFtOjpDdXJsU3RyZWFtKEN1cmxTdHJlYW1TY2hlZHVsZXImIHNjaGVk dWxlciwgQ3VybFN0cmVhbUlEIHN0cmVhbUlELCBVUgogCiAgICAgLy8gTGliY3VybCBpcyBub3Qg cmVzcG9uc2libGUgZm9yIHRoZSBwcm90b2NvbCBoYW5kbGluZy4gSXQganVzdCBoYW5kbGVzIGNv bm5lY3Rpb24uCiAgICAgLy8gT25seSBzY2hlbWUsIGhvc3QgYW5kIHBvcnQgaXMgcmVxdWlyZWQu Ci0gICAgVVJMIHVybEZvckNvbm5lY3Rpb247CisgICAgVVJMIHVybEZvckNvbm5lY3Rpb24odXJs KTsKICAgICB1cmxGb3JDb25uZWN0aW9uLnNldFByb3RvY29sKHVybC5wcm90b2NvbElzKCJ3c3Mi KSA/ICJodHRwcyIgOiAiaHR0cCIpOwotICAgIHVybEZvckNvbm5lY3Rpb24uc2V0SG9zdEFuZFBv cnQodXJsLmhvc3RBbmRQb3J0KCkpOwogICAgIG1fY3VybEhhbmRsZS0+c2V0VXJsKHVybEZvckNv bm5lY3Rpb24pOwogCiAgICAgbV9jdXJsSGFuZGxlLT5lbmFibGVDb25uZWN0aW9uT25seSgpOwo= 410491 2020-10-04 17:43:45 -0700 2020-10-04 20:45:42 -0700 Patch bug-217298-20201005094344.patch text/plain 1823 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3OTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTVmNWVkNTE0YTMwMzI5 YzM5NmVlMzYyOTYwOTUxMDRkNTAwZGRlNi4uYTYyYzk3MmRiZTdkMmQyNGU2MjllOTIzYTUwMTll YmZmMjQ2ZDg5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEwLTA0ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtjdXJsXSBX ZWJTb2NrZXQgdGVzdHMgYXJlIGZhaWxpbmcgc2luY2UgcjI2NzkzMQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3Mjk4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgImh0dHA6IiBpcyBhIGludmFsaWQgVVJM IHNpbmNlIHIyNjc5MzEuIENoYW5nZSB0aGUgd2F5IGhvdyB0bworICAgICAgICBjb25zdHJ1Y3Qg YSBVUkwgZm9yIGxpYmN1cmwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3Vy bFN0cmVhbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDdXJsU3RyZWFtOjpDdXJsU3RyZWFtKTog Q29uc3RydWN0IHRoZSBVUkwganVzdCBieQorICAgICAgICByZXBsYWNpbmcgdGhlIHNjaGVtZSBw YXJ0LiBSZW1vdmVkIGEgbG9jYWwgdmFyaWFibGUKKyAgICAgICAgdXJsRm9yQ29ubmVjdGlvbi4K KwogMjAyMC0xMC0wNCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAg IFtMRkNdW0ludGVncmF0aW9uXSBFbmFibGUgc29mdCBoeXBoZW4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsU3RyZWFtLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsU3RyZWFtLmNwcAppbmRleCAyNmRjN2Jl ZjRiNzRiYzZiNGUyZTUyNmRlYzY1MjNjM2FkNmQzNjQzLi5iZDk3ZTlmZWI0NzQwNjBmMjEwNWQ3 MzQ5MmQyOWUwMmU4MDRmMGY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2N1cmwvQ3VybFN0cmVhbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jdXJsL0N1cmxTdHJlYW0uY3BwCkBAIC00MywxMCArNDMsOCBAQCBDdXJsU3RyZWFt OjpDdXJsU3RyZWFtKEN1cmxTdHJlYW1TY2hlZHVsZXImIHNjaGVkdWxlciwgQ3VybFN0cmVhbUlE IHN0cmVhbUlELCBVUgogCiAgICAgLy8gTGliY3VybCBpcyBub3QgcmVzcG9uc2libGUgZm9yIHRo ZSBwcm90b2NvbCBoYW5kbGluZy4gSXQganVzdCBoYW5kbGVzIGNvbm5lY3Rpb24uCiAgICAgLy8g T25seSBzY2hlbWUsIGhvc3QgYW5kIHBvcnQgaXMgcmVxdWlyZWQuCi0gICAgVVJMIHVybEZvckNv bm5lY3Rpb247Ci0gICAgdXJsRm9yQ29ubmVjdGlvbi5zZXRQcm90b2NvbCh1cmwucHJvdG9jb2xJ cygid3NzIikgPyAiaHR0cHMiIDogImh0dHAiKTsKLSAgICB1cmxGb3JDb25uZWN0aW9uLnNldEhv c3RBbmRQb3J0KHVybC5ob3N0QW5kUG9ydCgpKTsKLSAgICBtX2N1cmxIYW5kbGUtPnNldFVybCh1 cmxGb3JDb25uZWN0aW9uKTsKKyAgICB1cmwuc2V0UHJvdG9jb2wodXJsLnByb3RvY29sSXMoIndz cyIpID8gImh0dHBzIiA6ICJodHRwIik7CisgICAgbV9jdXJsSGFuZGxlLT5zZXRVcmwoV1RGTW92 ZSh1cmwpKTsKIAogICAgIG1fY3VybEhhbmRsZS0+ZW5hYmxlQ29ubmVjdGlvbk9ubHkoKTsKIAo=