217256 2020-10-02 15:47:01 -0700 AX: Expose lineRangeForPosition for iOS Accessibility code 2020-10-06 16:21:39 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach webkit-unassigned aboxhall apinheiro dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer zalan oldest_to_newest 1694268 0 cfleizach 2020-10-02 15:47:01 -0700 IOS needs to make use of the existing lineRangeForPosition method 1694269 1 cfleizach 2020-10-02 15:47:17 -0700 <rdar://problem/67478962> 1694270 2 410384 cfleizach 2020-10-02 15:48:22 -0700 Created attachment 410384 patch 1694915 3 410384 zalan 2020-10-05 15:50:28 -0700 Comment on attachment 410384 patch View in context: https://bugs.webkit.org/attachment.cgi?id=410384&action=review > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2689 > + auto *startMarker = [WebAccessibilityTextMarker textMarkerWithVisiblePosition:range.start cache:self.axBackingObject->axObjectCache()]; > + auto *endMarker = [WebAccessibilityTextMarker textMarkerWithVisiblePosition:range.end cache:self.axBackingObject->axObjectCache()]; auto* start/endMarker 1695240 4 410671 cfleizach 2020-10-06 11:37:13 -0700 Created attachment 410671 patch Updated 1695373 5 ews-feeder 2020-10-06 16:21:38 -0700 Committed r268084: <https://trac.webkit.org/changeset/268084> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410671. 410384 2020-10-02 15:48:22 -0700 2020-10-06 11:37:13 -0700 patch file_217256.txt text/plain 2386 cfleizach ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZw0KaW5kZXggNjVlNmFiZjY3NjJmLi44OGEwMDJkZWQxYmYgMTAwNjQ0DQotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cNCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZw0K QEAgLTEsMyArMSwxNiBAQA0KKzIwMjAtMTAtMDIgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNo QGFwcGxlLmNvbT4NCisNCisgICAgICAgIEFYOiBFeHBvc2UgbGluZVJhbmdlRm9yUG9zaXRpb24g Zm9yIGlPUyBBY2Nlc3NpYmlsaXR5IGNvZGUNCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTcyNTYNCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NzQ3 ODk2Mj4NCisNCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLg0KKw0KKyAgICAg ICAgRXhwb3NlIHRoZSBleGlzdGluZyBsaW5lUmFuZ2VGb3JQb3NpdGlvbiBtZXRob2QgZm9yIGlP UyBhY2Nlc3NpYmlsaXR5Lg0KKw0KKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2lvcy9XZWJBY2Nl c3NpYmlsaXR5T2JqZWN0V3JhcHBlcklPUy5tbToNCisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxp dHlPYmplY3RXcmFwcGVyIGxpbmVNYXJrZXJzRm9yTWFya2VyOl0pOg0KKw0KIDIwMjAtMTAtMDIg IE1lZ2FuIEdhcmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4NCiANCiAgICAgICAgIFJl bmFtZSByZXBhaW50IHRvIHJlcGFpbnRTZWxlY3Rpb24gaW4gSGlnaGxpZ2h0RGF0YSBmb3IgY2xh cml0eQ0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaW9zL1dlYkFj Y2Vzc2liaWxpdHlPYmplY3RXcmFwcGVySU9TLm1tIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9pb3MvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJJT1MubW0NCmluZGV4IDJlMmQz NmM4Y2QyYi4uNjE0NjZmNmE3MGFhIDEwMDY0NA0KLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9pb3MvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJJT1MubW0NCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaW9zL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFw cGVySU9TLm1tDQpAQCAtMjY3NSw2ICsyNjc1LDI0IEBAIHN0YXRpYyB2b2lkIEFYQXR0cmlidXRl ZFN0cmluZ0FwcGVuZFRleHQoTlNNdXRhYmxlQXR0cmlidXRlZFN0cmluZyogYXR0clN0cmluZywN CiAgICAgcmV0dXJuIFtXZWJBY2Nlc3NpYmlsaXR5VGV4dE1hcmtlciB0ZXh0TWFya2VyV2l0aFZp c2libGVQb3NpdGlvbjpsaW5lRW5kIGNhY2hlOnNlbGYuYXhCYWNraW5nT2JqZWN0LT5heE9iamVj dENhY2hlKCldOw0KIH0NCiANCisvLyBSZXR1cm5zIHN0YXJ0L2VuZCBtYXJrZXJzIGZvciB0aGUg bGluZSBiYXNlZCBvbiBwb3NpdGlvbg0KKy0gKE5TQXJyYXk8V2ViQWNjZXNzaWJpbGl0eVRleHRN YXJrZXIgKj4gKilsaW5lTWFya2Vyc0Zvck1hcmtlcjooV2ViQWNjZXNzaWJpbGl0eVRleHRNYXJr ZXIgKiltYXJrZXINCit7DQorICAgIGlmICghW3NlbGYgX3ByZXBhcmVBY2Nlc3NpYmlsaXR5Q2Fs bF0pDQorICAgICAgICByZXR1cm4gbmlsOw0KKw0KKyAgICBpZiAoIW1hcmtlcikNCisgICAgICAg IHJldHVybiBuaWw7DQorDQorICAgIGF1dG8gcmFuZ2UgPSBzZWxmLmF4QmFja2luZ09iamVjdC0+ bGluZVJhbmdlRm9yUG9zaXRpb24oW21hcmtlciB2aXNpYmxlUG9zaXRpb25dKTsNCisgICAgYXV0 byAqc3RhcnRNYXJrZXIgPSBbV2ViQWNjZXNzaWJpbGl0eVRleHRNYXJrZXIgdGV4dE1hcmtlcldp dGhWaXNpYmxlUG9zaXRpb246cmFuZ2Uuc3RhcnQgY2FjaGU6c2VsZi5heEJhY2tpbmdPYmplY3Qt PmF4T2JqZWN0Q2FjaGUoKV07DQorICAgIGF1dG8gKmVuZE1hcmtlciA9IFtXZWJBY2Nlc3NpYmls aXR5VGV4dE1hcmtlciB0ZXh0TWFya2VyV2l0aFZpc2libGVQb3NpdGlvbjpyYW5nZS5lbmQgY2Fj aGU6c2VsZi5heEJhY2tpbmdPYmplY3QtPmF4T2JqZWN0Q2FjaGUoKV07DQorICAgIGlmICghc3Rh cnRNYXJrZXIgfHwgIWVuZE1hcmtlcikNCisgICAgICAgIHJldHVybiBuaWw7DQorICAgIA0KKyAg ICByZXR1cm4gQFsgc3RhcnRNYXJrZXIsIGVuZE1hcmtlciBdOw0KK30NCisNCiAvLyBUaGlzIG1l dGhvZCBpcyBpbnRlbmRlZCB0byByZXR1cm4gdGhlIG1hcmtlciBhdCB0aGUgc3RhcnQgb2YgdGhl IGxpbmUgc3RhcnRpbmcgYXQNCiAvLyB0aGUgbWFya2VyIHRoYXQgaXMgcGFzc2VkIGludG8gdGhl IG1ldGhvZC4NCiAtIChXZWJBY2Nlc3NpYmlsaXR5VGV4dE1hcmtlciAqKWxpbmVTdGFydE1hcmtl ckZvck1hcmtlcjooV2ViQWNjZXNzaWJpbGl0eVRleHRNYXJrZXIgKiltYXJrZXINCg== 410671 2020-10-06 11:37:13 -0700 2020-10-06 16:21:38 -0700 patch file_217256.txt text/plain 2535 cfleizach aU1hYy1Qcm86L1ZvbHVtZXMvZGF0YS93ZWIvT3BlblNvdXJjZSAobWFzdGVyKSAkIGdpdCBkaWZm IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lv cy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcklPUy5tbQ0KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZw0KaW5kZXggNjVl NmFiZjY3NjJmLi43OGZiNDk4MWM0OWEgMTAwNjQ0DQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cNCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZw0KQEAgLTEsMyArMSwxNiBAQA0K KzIwMjAtMTAtMDIgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4NCisNCisg ICAgICAgIEFYOiBFeHBvc2UgbGluZVJhbmdlRm9yUG9zaXRpb24gZm9yIGlPUyBBY2Nlc3NpYmls aXR5IGNvZGUNCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTcyNTYNCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NzQ3ODk2Mj4NCisNCisgICAgICAg IFJldmlld2VkIGJ5IFphbGFuIEJ1anRhcy4NCisNCisgICAgICAgIEV4cG9zZSB0aGUgZXhpc3Rp bmcgbGluZVJhbmdlRm9yUG9zaXRpb24gbWV0aG9kIGZvciBpT1MgYWNjZXNzaWJpbGl0eS4NCisN CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9pb3MvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBw ZXJJT1MubW06DQorICAgICAgICAoLVtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciBsaW5l TWFya2Vyc0Zvck1hcmtlcjpdKToNCisNCiAyMDIwLTEwLTAyICBNZWdhbiBHYXJkbmVyICA8bWVn YW5fZ2FyZG5lckBhcHBsZS5jb20+DQogDQogICAgICAgICBSZW5hbWUgcmVwYWludCB0byByZXBh aW50U2VsZWN0aW9uIGluIEhpZ2hsaWdodERhdGEgZm9yIGNsYXJpdHkNCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lvcy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3Jh cHBlcklPUy5tbSBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaW9zL1dlYkFjY2Vzc2li aWxpdHlPYmplY3RXcmFwcGVySU9TLm1tDQppbmRleCAyZTJkMzZjOGNkMmIuLjIzZmE4YTQ1MTJi ZCAxMDA2NDQNCi0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaW9zL1dlYkFjY2Vz c2liaWxpdHlPYmplY3RXcmFwcGVySU9TLm1tDQorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L2lvcy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcklPUy5tbQ0KQEAgLTI2NzUs NiArMjY3NSwyNCBAQCBzdGF0aWMgdm9pZCBBWEF0dHJpYnV0ZWRTdHJpbmdBcHBlbmRUZXh0KE5T TXV0YWJsZUF0dHJpYnV0ZWRTdHJpbmcqIGF0dHJTdHJpbmcsDQogICAgIHJldHVybiBbV2ViQWNj ZXNzaWJpbGl0eVRleHRNYXJrZXIgdGV4dE1hcmtlcldpdGhWaXNpYmxlUG9zaXRpb246bGluZUVu ZCBjYWNoZTpzZWxmLmF4QmFja2luZ09iamVjdC0+YXhPYmplY3RDYWNoZSgpXTsNCiB9DQogDQor Ly8gUmV0dXJucyBzdGFydC9lbmQgbWFya2VycyBmb3IgdGhlIGxpbmUgYmFzZWQgb24gcG9zaXRp b24NCistIChOU0FycmF5PFdlYkFjY2Vzc2liaWxpdHlUZXh0TWFya2VyICo+ICopbGluZU1hcmtl cnNGb3JNYXJrZXI6KFdlYkFjY2Vzc2liaWxpdHlUZXh0TWFya2VyICopbWFya2VyDQorew0KKyAg ICBpZiAoIVtzZWxmIF9wcmVwYXJlQWNjZXNzaWJpbGl0eUNhbGxdKQ0KKyAgICAgICAgcmV0dXJu IG5pbDsNCisNCisgICAgaWYgKCFtYXJrZXIpDQorICAgICAgICByZXR1cm4gbmlsOw0KKw0KKyAg ICBhdXRvIHJhbmdlID0gc2VsZi5heEJhY2tpbmdPYmplY3QtPmxpbmVSYW5nZUZvclBvc2l0aW9u KFttYXJrZXIgdmlzaWJsZVBvc2l0aW9uXSk7DQorICAgIGF1dG8qIHN0YXJ0TWFya2VyID0gW1dl YkFjY2Vzc2liaWxpdHlUZXh0TWFya2VyIHRleHRNYXJrZXJXaXRoVmlzaWJsZVBvc2l0aW9uOnJh bmdlLnN0YXJ0IGNhY2hlOnNlbGYuYXhCYWNraW5nT2JqZWN0LT5heE9iamVjdENhY2hlKCldOw0K KyAgICBhdXRvKiBlbmRNYXJrZXIgPSBbV2ViQWNjZXNzaWJpbGl0eVRleHRNYXJrZXIgdGV4dE1h cmtlcldpdGhWaXNpYmxlUG9zaXRpb246cmFuZ2UuZW5kIGNhY2hlOnNlbGYuYXhCYWNraW5nT2Jq ZWN0LT5heE9iamVjdENhY2hlKCldOw0KKyAgICBpZiAoIXN0YXJ0TWFya2VyIHx8ICFlbmRNYXJr ZXIpDQorICAgICAgICByZXR1cm4gbmlsOw0KKyAgICANCisgICAgcmV0dXJuIEBbIHN0YXJ0TWFy a2VyLCBlbmRNYXJrZXIgXTsNCit9DQorDQogLy8gVGhpcyBtZXRob2QgaXMgaW50ZW5kZWQgdG8g cmV0dXJuIHRoZSBtYXJrZXIgYXQgdGhlIHN0YXJ0IG9mIHRoZSBsaW5lIHN0YXJ0aW5nIGF0DQog Ly8gdGhlIG1hcmtlciB0aGF0IGlzIHBhc3NlZCBpbnRvIHRoZSBtZXRob2QuDQogLSAoV2ViQWNj ZXNzaWJpbGl0eVRleHRNYXJrZXIgKilsaW5lU3RhcnRNYXJrZXJGb3JNYXJrZXI6KFdlYkFjY2Vz c2liaWxpdHlUZXh0TWFya2VyICopbWFya2Vy