217246 2020-10-02 13:09:00 -0700 TranslateTransformOperation shouldn't take in a FloatSize to convert z as a double 2020-10-19 23:20:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts darin ews-watchlist graouts simon.fraser webkit-bug-importer oldest_to_newest 1694199 0 graouts 2020-10-02 13:09:00 -0700 TranslateTransformOperation shouldn't take in a FloatSize to convert z as a double 1694200 1 410358 graouts 2020-10-02 13:11:23 -0700 Created attachment 410358 Patch 1694201 2 410358 darin 2020-10-02 13:17:40 -0700 Comment on attachment 410358 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410358&action=review > Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h:53 > + double xAsDouble(const FloatSize& borderBoxSize) const { return floatValueForLength(m_x, borderBoxSize.width()); } > + double yAsDouble(const FloatSize& borderBoxSize) const { return floatValueForLength(m_y, borderBoxSize.height()); } > + double zAsDouble() const { return floatValueForLength(m_z, 1); } Strange mix here. We are calling something that computes a float, then converting it to a double when returning it, then it seems 2 of the 3 call sites call narrowPrecisionToFloat on a value that was just converted *from* a float. Maybe this should return float, not double? 1696334 3 webkit-bug-importer 2020-10-09 13:09:14 -0700 <rdar://problem/70150086> 1699351 4 411771 graouts 2020-10-19 12:03:27 -0700 Created attachment 411771 Patch 1699614 5 graouts 2020-10-19 23:20:14 -0700 Committed r268714: <https://trac.webkit.org/changeset/268714> 410358 2020-10-02 13:11:23 -0700 2020-10-19 12:03:24 -0700 Patch bug-217246-20201002221122.patch text/plain 5219 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3ODg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzliNjBmZTYxMDYyMzI1 ODgzYzYwZTcyM2FiNDVkMWFmMjllOTI0MC4uNDZkZmJkN2RhNjMwODBmZmJlOTNiYzc2ZmMyMTJl NjU3MTgyYzUzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEwLTAyICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgorCisgICAgICAgIFRyYW5zbGF0ZVRyYW5z Zm9ybU9wZXJhdGlvbiBzaG91bGRuJ3QgdGFrZSBpbiBhIEZsb2F0U2l6ZSB0byBjb252ZXJ0IHog YXMgYSBkb3VibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxNzI0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSBtZXRob2QgdXNlZCB0byBnZXQgeiBhcyBhIGRvdWJsZSBkaWRuJ3QgdXNlIHRoZSBG bG9hdFNpemUgcGFyYW1ldGVyLCBzbyB3ZSByZW1vdmUgaXQuIFNpbmNlIHRoZXJlIGFscmVhZHkg aXMgYSB6KCkKKyAgICAgICAgbWV0aG9kIHdpdGhvdXQgYW4gYXJndW1lbnQgcmV0dXJuaW5nIHRo ZSB1bmRlcmx5aW5nIExlbmd0aCwgd2UgcmVuYW1lIHRoZSBtZXRob2QgcmV0dXJuaW5nIGEgZG91 YmxlIHRvIG1ha2UgaXQgY2xlYXIKKyAgICAgICAgdGhhdCBpdCdzIHJldHVybmluZyBhIGRvdWJs ZSwgYW5kIGZvbGxvdyB0aGUgc2FtZSBwYXR0ZXJuIGZvciB4IGFuZCB5LgorIAorICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpnZXRUcmFuc2Zvcm1GdW5jdGlvblZhbHVlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy90cmFuc2Zvcm1zL1RyYW5zbGF0ZVRyYW5zZm9ybU9wZXJhdGlvbi5oOgorCiAyMDIwLTA5 LTMwICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBu b24tYW5pbWF0ZWQgc3VwcG9ydCBmb3IgdGhlIENTUyB0cmFuc2xhdGUgcHJvcGVydHkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJD QS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVy Q0EuY3BwCmluZGV4IDVlOTY0N2ZmYWM4MDEzZjkyNDM3ZjVkYWViMTBhODdiNTVhZTQzNmMuLjdk MmViZTRkNzc1MWU0YTRhNDNmOTg3ZjFhNjFkMGU3YWMzMGM4NTIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcApA QCAtMTU2LDEzICsxNTYsMTMgQEAgc3RhdGljIHZvaWQgZ2V0VHJhbnNmb3JtRnVuY3Rpb25WYWx1 ZShjb25zdCBUcmFuc2Zvcm1PcGVyYXRpb24qIHRyYW5zZm9ybU9wLCBUcmEKICAgICAgICAgdmFs dWUgPSB0cmFuc2Zvcm1PcCA/IG5hcnJvd1ByZWNpc2lvblRvRmxvYXQoZG93bmNhc3Q8U2NhbGVU cmFuc2Zvcm1PcGVyYXRpb24+KCp0cmFuc2Zvcm1PcCkueigpKSA6IDE7CiAgICAgICAgIGJyZWFr OwogICAgIGNhc2UgVHJhbnNmb3JtT3BlcmF0aW9uOjpUUkFOU0xBVEVfWDoKLSAgICAgICAgdmFs dWUgPSB0cmFuc2Zvcm1PcCA/IG5hcnJvd1ByZWNpc2lvblRvRmxvYXQoZG93bmNhc3Q8VHJhbnNs YXRlVHJhbnNmb3JtT3BlcmF0aW9uPigqdHJhbnNmb3JtT3ApLngoc2l6ZSkpIDogMDsKKyAgICAg ICAgdmFsdWUgPSB0cmFuc2Zvcm1PcCA/IG5hcnJvd1ByZWNpc2lvblRvRmxvYXQoZG93bmNhc3Q8 VHJhbnNsYXRlVHJhbnNmb3JtT3BlcmF0aW9uPigqdHJhbnNmb3JtT3ApLnhBc0RvdWJsZShzaXpl KSkgOiAwOwogICAgICAgICBicmVhazsKICAgICBjYXNlIFRyYW5zZm9ybU9wZXJhdGlvbjo6VFJB TlNMQVRFX1k6Ci0gICAgICAgIHZhbHVlID0gdHJhbnNmb3JtT3AgPyBuYXJyb3dQcmVjaXNpb25U b0Zsb2F0KGRvd25jYXN0PFRyYW5zbGF0ZVRyYW5zZm9ybU9wZXJhdGlvbj4oKnRyYW5zZm9ybU9w KS55KHNpemUpKSA6IDA7CisgICAgICAgIHZhbHVlID0gdHJhbnNmb3JtT3AgPyBuYXJyb3dQcmVj aXNpb25Ub0Zsb2F0KGRvd25jYXN0PFRyYW5zbGF0ZVRyYW5zZm9ybU9wZXJhdGlvbj4oKnRyYW5z Zm9ybU9wKS55QXNEb3VibGUoc2l6ZSkpIDogMDsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBU cmFuc2Zvcm1PcGVyYXRpb246OlRSQU5TTEFURV9aOgotICAgICAgICB2YWx1ZSA9IHRyYW5zZm9y bU9wID8gbmFycm93UHJlY2lzaW9uVG9GbG9hdChkb3duY2FzdDxUcmFuc2xhdGVUcmFuc2Zvcm1P cGVyYXRpb24+KCp0cmFuc2Zvcm1PcCkueihzaXplKSkgOiAwOworICAgICAgICB2YWx1ZSA9IHRy YW5zZm9ybU9wID8gbmFycm93UHJlY2lzaW9uVG9GbG9hdChkb3duY2FzdDxUcmFuc2xhdGVUcmFu c2Zvcm1PcGVyYXRpb24+KCp0cmFuc2Zvcm1PcCkuekFzRG91YmxlKCkpIDogMDsKICAgICAgICAg YnJlYWs7CiAgICAgZGVmYXVsdDoKICAgICAgICAgYnJlYWs7CkBAIC0xODMsOSArMTgzLDkgQEAg c3RhdGljIHZvaWQgZ2V0VHJhbnNmb3JtRnVuY3Rpb25WYWx1ZShjb25zdCBUcmFuc2Zvcm1PcGVy YXRpb24qIHRyYW5zZm9ybU9wLCBUcmEKICAgICBjYXNlIFRyYW5zZm9ybU9wZXJhdGlvbjo6VFJB TlNMQVRFOgogICAgIGNhc2UgVHJhbnNmb3JtT3BlcmF0aW9uOjpUUkFOU0xBVEVfM0Q6IHsKICAg ICAgICAgY29uc3QgYXV0byogdHJhbnNsYXRlVHJhbnNmb3JtT3AgPSBkb3duY2FzdDxUcmFuc2xh dGVUcmFuc2Zvcm1PcGVyYXRpb24+KHRyYW5zZm9ybU9wKTsKLSAgICAgICAgdmFsdWUuc2V0WCh0 cmFuc2xhdGVUcmFuc2Zvcm1PcCA/IG5hcnJvd1ByZWNpc2lvblRvRmxvYXQodHJhbnNsYXRlVHJh bnNmb3JtT3AtPngoc2l6ZSkpIDogMCk7Ci0gICAgICAgIHZhbHVlLnNldFkodHJhbnNsYXRlVHJh bnNmb3JtT3AgPyBuYXJyb3dQcmVjaXNpb25Ub0Zsb2F0KHRyYW5zbGF0ZVRyYW5zZm9ybU9wLT55 KHNpemUpKSA6IDApOwotICAgICAgICB2YWx1ZS5zZXRaKHRyYW5zbGF0ZVRyYW5zZm9ybU9wID8g bmFycm93UHJlY2lzaW9uVG9GbG9hdCh0cmFuc2xhdGVUcmFuc2Zvcm1PcC0+eihzaXplKSkgOiAw KTsKKyAgICAgICAgdmFsdWUuc2V0WCh0cmFuc2xhdGVUcmFuc2Zvcm1PcCA/IG5hcnJvd1ByZWNp c2lvblRvRmxvYXQodHJhbnNsYXRlVHJhbnNmb3JtT3AtPnhBc0RvdWJsZShzaXplKSkgOiAwKTsK KyAgICAgICAgdmFsdWUuc2V0WSh0cmFuc2xhdGVUcmFuc2Zvcm1PcCA/IG5hcnJvd1ByZWNpc2lv blRvRmxvYXQodHJhbnNsYXRlVHJhbnNmb3JtT3AtPnlBc0RvdWJsZShzaXplKSkgOiAwKTsKKyAg ICAgICAgdmFsdWUuc2V0Wih0cmFuc2xhdGVUcmFuc2Zvcm1PcCA/IG5hcnJvd1ByZWNpc2lvblRv RmxvYXQodHJhbnNsYXRlVHJhbnNmb3JtT3AtPnpBc0RvdWJsZSgpKSA6IDApOwogICAgICAgICBi cmVhazsKICAgICB9CiAgICAgZGVmYXVsdDoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNsYXRlVHJhbnNmb3JtT3BlcmF0aW9uLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL1RyYW5zbGF0ZVRy YW5zZm9ybU9wZXJhdGlvbi5oCmluZGV4IDk0ODgyODY3ZDY4OTE0ZWQ4MmFlY2E0Mjk2MDA5MDdj NmVkYTUxNjIuLmZjZGI5ODk1YzE0MGI1MDM1NDNjZDU3ZjBjMjdmZGQ2YjQ1Yzc3MWEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNs YXRlVHJhbnNmb3JtT3BlcmF0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvdHJhbnNmb3Jtcy9UcmFuc2xhdGVUcmFuc2Zvcm1PcGVyYXRpb24uaApAQCAtNDgsOSAr NDgsOSBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBhZG9wdFJlZigqbmV3IFRyYW5zbGF0ZVRy YW5zZm9ybU9wZXJhdGlvbihtX3gsIG1feSwgbV96LCB0eXBlKCkpKTsKICAgICB9CiAKLSAgICBk b3VibGUgeChjb25zdCBGbG9hdFNpemUmIGJvcmRlckJveFNpemUpIGNvbnN0IHsgcmV0dXJuIGZs b2F0VmFsdWVGb3JMZW5ndGgobV94LCBib3JkZXJCb3hTaXplLndpZHRoKCkpOyB9Ci0gICAgZG91 YmxlIHkoY29uc3QgRmxvYXRTaXplJiBib3JkZXJCb3hTaXplKSBjb25zdCB7IHJldHVybiBmbG9h dFZhbHVlRm9yTGVuZ3RoKG1feSwgYm9yZGVyQm94U2l6ZS5oZWlnaHQoKSk7IH0KLSAgICBkb3Vi bGUgeihjb25zdCBGbG9hdFNpemUmKSBjb25zdCB7IHJldHVybiBmbG9hdFZhbHVlRm9yTGVuZ3Ro KG1feiwgMSk7IH0KKyAgICBkb3VibGUgeEFzRG91YmxlKGNvbnN0IEZsb2F0U2l6ZSYgYm9yZGVy Qm94U2l6ZSkgY29uc3QgeyByZXR1cm4gZmxvYXRWYWx1ZUZvckxlbmd0aChtX3gsIGJvcmRlckJv eFNpemUud2lkdGgoKSk7IH0KKyAgICBkb3VibGUgeUFzRG91YmxlKGNvbnN0IEZsb2F0U2l6ZSYg Ym9yZGVyQm94U2l6ZSkgY29uc3QgeyByZXR1cm4gZmxvYXRWYWx1ZUZvckxlbmd0aChtX3ksIGJv cmRlckJveFNpemUuaGVpZ2h0KCkpOyB9CisgICAgZG91YmxlIHpBc0RvdWJsZSgpIGNvbnN0IHsg cmV0dXJuIGZsb2F0VmFsdWVGb3JMZW5ndGgobV96LCAxKTsgfQogCiAgICAgTGVuZ3RoIHgoKSBj b25zdCB7IHJldHVybiBtX3g7IH0KICAgICBMZW5ndGggeSgpIGNvbnN0IHsgcmV0dXJuIG1feTsg fQpAQCAtNTgsNyArNTgsNyBAQCBwdWJsaWM6CiAKICAgICBib29sIGFwcGx5KFRyYW5zZm9ybWF0 aW9uTWF0cml4JiB0cmFuc2Zvcm0sIGNvbnN0IEZsb2F0U2l6ZSYgYm9yZGVyQm94U2l6ZSkgY29u c3QgZmluYWwKICAgICB7Ci0gICAgICAgIHRyYW5zZm9ybS50cmFuc2xhdGUzZCh4KGJvcmRlckJv eFNpemUpLCB5KGJvcmRlckJveFNpemUpLCB6KGJvcmRlckJveFNpemUpKTsKKyAgICAgICAgdHJh bnNmb3JtLnRyYW5zbGF0ZTNkKHhBc0RvdWJsZShib3JkZXJCb3hTaXplKSwgeUFzRG91YmxlKGJv cmRlckJveFNpemUpLCB6QXNEb3VibGUoKSk7CiAgICAgICAgIHJldHVybiBtX3guaXNQZXJjZW50 KCkgfHwgbV95LmlzUGVyY2VudCgpOwogICAgIH0KIAo= 411771 2020-10-19 12:03:27 -0700 2020-10-19 12:03:27 -0700 Patch bug-217246-20201019210326.patch text/plain 5217 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4NjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzIwOGZiOTkxMjczNmNl NTJlMjEzY2JmODkyMWY1MWQwOTNjZDFkMC4uODMzZTlhOGQxYjY1YzAzMDQyZDA4MWFmODEwYTQ0 MzU2MTcxM2FhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTEwLTAyICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgorCisgICAgICAgIFRyYW5zbGF0ZVRyYW5z Zm9ybU9wZXJhdGlvbiBzaG91bGRuJ3QgdGFrZSBpbiBhIEZsb2F0U2l6ZSB0byBjb252ZXJ0IHog YXMgYSBkb3VibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxNzI0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSBtZXRob2QgdXNlZCB0byBnZXQgeiBhcyBhIGRvdWJsZSBkaWRuJ3QgdXNlIHRoZSBG bG9hdFNpemUgcGFyYW1ldGVyLCBzbyB3ZSByZW1vdmUgaXQuIFNpbmNlIHRoZXJlIGFscmVhZHkg aXMgYSB6KCkKKyAgICAgICAgbWV0aG9kIHdpdGhvdXQgYW4gYXJndW1lbnQgcmV0dXJuaW5nIHRo ZSB1bmRlcmx5aW5nIExlbmd0aCwgd2UgcmVuYW1lIHRoZSBtZXRob2QgcmV0dXJuaW5nIGEgZG91 YmxlIHRvIG1ha2UgaXQgY2xlYXIKKyAgICAgICAgd2hhdCB0eXBlIG9mIHZhbHVlIGl0J3MgcmV0 dXJuaW5nIGEgZG91YmxlLCBhbmQgZ2l2ZW4gaG93IHRoZSBjYWxsIHNpdGVzIGNvbnZlcnRzIHRv IGEgZmxvYXQgZXZlbnR1YWxseSwgd2UgcmV0dXJuCisgICAgICAgIGEgZmxvYXQgZGlyZWN0bHku IFdlIGFsc28gZm9sbG93IHRoZSBzYW1lIHBhdHRlcm4gZm9yIHggYW5kIHkuCisgCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OmdldFRyYW5zZm9ybUZ1bmN0aW9uVmFsdWUpOgorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNsYXRlVHJhbnNmb3JtT3BlcmF0aW9uLmg6CisKIDIwMjAt MTAtMTggIEpvb25naHVuIFBhcmsgIDxqaDcxOC5wYXJrQHNhbXN1bmcuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQuIFJlbW92ZSB0aGUgZHVwbGljYXRlZCBJR05PUkVfV0FSTklOR1NfQkVHSU4o ImZyYW1lLWFkZHJlc3MiKSBjYWxscyBmcm9tIHIyNjg2NjEuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcAppbmRleCA4 ZDliNjI5MTQzYzkwYzU5M2Y1NTM4MzE1ZjM1YjU5NmE0ZTA4MGEzLi5hNGE0ZDM3MzZjYjNiMTBh ZDYwMGYzNmQ0ODVlZWM4MmMwNGJlYzgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAKQEAgLTE1NywxMyArMTU3 LDEzIEBAIHN0YXRpYyB2b2lkIGdldFRyYW5zZm9ybUZ1bmN0aW9uVmFsdWUoY29uc3QgVHJhbnNm b3JtT3BlcmF0aW9uKiB0cmFuc2Zvcm1PcCwgVHJhCiAgICAgICAgIHZhbHVlID0gdHJhbnNmb3Jt T3AgPyBuYXJyb3dQcmVjaXNpb25Ub0Zsb2F0KGRvd25jYXN0PFNjYWxlVHJhbnNmb3JtT3BlcmF0 aW9uPigqdHJhbnNmb3JtT3ApLnooKSkgOiAxOwogICAgICAgICBicmVhazsKICAgICBjYXNlIFRy YW5zZm9ybU9wZXJhdGlvbjo6VFJBTlNMQVRFX1g6Ci0gICAgICAgIHZhbHVlID0gdHJhbnNmb3Jt T3AgPyBuYXJyb3dQcmVjaXNpb25Ub0Zsb2F0KGRvd25jYXN0PFRyYW5zbGF0ZVRyYW5zZm9ybU9w ZXJhdGlvbj4oKnRyYW5zZm9ybU9wKS54KHNpemUpKSA6IDA7CisgICAgICAgIHZhbHVlID0gdHJh bnNmb3JtT3AgPyBkb3duY2FzdDxUcmFuc2xhdGVUcmFuc2Zvcm1PcGVyYXRpb24+KCp0cmFuc2Zv cm1PcCkueEFzRmxvYXQoc2l6ZSkgOiAwOwogICAgICAgICBicmVhazsKICAgICBjYXNlIFRyYW5z Zm9ybU9wZXJhdGlvbjo6VFJBTlNMQVRFX1k6Ci0gICAgICAgIHZhbHVlID0gdHJhbnNmb3JtT3Ag PyBuYXJyb3dQcmVjaXNpb25Ub0Zsb2F0KGRvd25jYXN0PFRyYW5zbGF0ZVRyYW5zZm9ybU9wZXJh dGlvbj4oKnRyYW5zZm9ybU9wKS55KHNpemUpKSA6IDA7CisgICAgICAgIHZhbHVlID0gdHJhbnNm b3JtT3AgPyBkb3duY2FzdDxUcmFuc2xhdGVUcmFuc2Zvcm1PcGVyYXRpb24+KCp0cmFuc2Zvcm1P cCkueUFzRmxvYXQoc2l6ZSkgOiAwOwogICAgICAgICBicmVhazsKICAgICBjYXNlIFRyYW5zZm9y bU9wZXJhdGlvbjo6VFJBTlNMQVRFX1o6Ci0gICAgICAgIHZhbHVlID0gdHJhbnNmb3JtT3AgPyBu YXJyb3dQcmVjaXNpb25Ub0Zsb2F0KGRvd25jYXN0PFRyYW5zbGF0ZVRyYW5zZm9ybU9wZXJhdGlv bj4oKnRyYW5zZm9ybU9wKS56KHNpemUpKSA6IDA7CisgICAgICAgIHZhbHVlID0gdHJhbnNmb3Jt T3AgPyBkb3duY2FzdDxUcmFuc2xhdGVUcmFuc2Zvcm1PcGVyYXRpb24+KCp0cmFuc2Zvcm1PcCku ekFzRmxvYXQoKSA6IDA7CiAgICAgICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAgIGJy ZWFrOwpAQCAtMTg0LDkgKzE4NCw5IEBAIHN0YXRpYyB2b2lkIGdldFRyYW5zZm9ybUZ1bmN0aW9u VmFsdWUoY29uc3QgVHJhbnNmb3JtT3BlcmF0aW9uKiB0cmFuc2Zvcm1PcCwgVHJhCiAgICAgY2Fz ZSBUcmFuc2Zvcm1PcGVyYXRpb246OlRSQU5TTEFURToKICAgICBjYXNlIFRyYW5zZm9ybU9wZXJh dGlvbjo6VFJBTlNMQVRFXzNEOiB7CiAgICAgICAgIGNvbnN0IGF1dG8qIHRyYW5zbGF0ZVRyYW5z Zm9ybU9wID0gZG93bmNhc3Q8VHJhbnNsYXRlVHJhbnNmb3JtT3BlcmF0aW9uPih0cmFuc2Zvcm1P cCk7Ci0gICAgICAgIHZhbHVlLnNldFgodHJhbnNsYXRlVHJhbnNmb3JtT3AgPyBuYXJyb3dQcmVj aXNpb25Ub0Zsb2F0KHRyYW5zbGF0ZVRyYW5zZm9ybU9wLT54KHNpemUpKSA6IDApOwotICAgICAg ICB2YWx1ZS5zZXRZKHRyYW5zbGF0ZVRyYW5zZm9ybU9wID8gbmFycm93UHJlY2lzaW9uVG9GbG9h dCh0cmFuc2xhdGVUcmFuc2Zvcm1PcC0+eShzaXplKSkgOiAwKTsKLSAgICAgICAgdmFsdWUuc2V0 Wih0cmFuc2xhdGVUcmFuc2Zvcm1PcCA/IG5hcnJvd1ByZWNpc2lvblRvRmxvYXQodHJhbnNsYXRl VHJhbnNmb3JtT3AtPnooc2l6ZSkpIDogMCk7CisgICAgICAgIHZhbHVlLnNldFgodHJhbnNsYXRl VHJhbnNmb3JtT3AgPyB0cmFuc2xhdGVUcmFuc2Zvcm1PcC0+eEFzRmxvYXQoc2l6ZSkgOiAwKTsK KyAgICAgICAgdmFsdWUuc2V0WSh0cmFuc2xhdGVUcmFuc2Zvcm1PcCA/IHRyYW5zbGF0ZVRyYW5z Zm9ybU9wLT55QXNGbG9hdChzaXplKSA6IDApOworICAgICAgICB2YWx1ZS5zZXRaKHRyYW5zbGF0 ZVRyYW5zZm9ybU9wID8gdHJhbnNsYXRlVHJhbnNmb3JtT3AtPnpBc0Zsb2F0KCkgOiAwKTsKICAg ICAgICAgYnJlYWs7CiAgICAgfQogICAgIGRlZmF1bHQ6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL1RyYW5zbGF0ZVRyYW5zZm9ybU9wZXJh dGlvbi5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9UcmFu c2xhdGVUcmFuc2Zvcm1PcGVyYXRpb24uaAppbmRleCA5MGZjYjAxODZlMmQxNDM4YWU2MmE0NTFh OWIxZjRiZWZmZmExZWMzLi4wMTFlMTAxZmI1MTkwYjJmMzVjMGJmMjYxMGQ2YzAwZjkyYmYwODBl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1z L1RyYW5zbGF0ZVRyYW5zZm9ybU9wZXJhdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNsYXRlVHJhbnNmb3JtT3BlcmF0aW9uLmgKQEAg LTQ4LDkgKzQ4LDkgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBUcmFu c2xhdGVUcmFuc2Zvcm1PcGVyYXRpb24obV94LCBtX3ksIG1feiwgdHlwZSgpKSk7CiAgICAgfQog Ci0gICAgZG91YmxlIHgoY29uc3QgRmxvYXRTaXplJiBib3JkZXJCb3hTaXplKSBjb25zdCB7IHJl dHVybiBmbG9hdFZhbHVlRm9yTGVuZ3RoKG1feCwgYm9yZGVyQm94U2l6ZS53aWR0aCgpKTsgfQot ICAgIGRvdWJsZSB5KGNvbnN0IEZsb2F0U2l6ZSYgYm9yZGVyQm94U2l6ZSkgY29uc3QgeyByZXR1 cm4gZmxvYXRWYWx1ZUZvckxlbmd0aChtX3ksIGJvcmRlckJveFNpemUuaGVpZ2h0KCkpOyB9Ci0g ICAgZG91YmxlIHooY29uc3QgRmxvYXRTaXplJikgY29uc3QgeyByZXR1cm4gZmxvYXRWYWx1ZUZv ckxlbmd0aChtX3osIDEpOyB9CisgICAgZmxvYXQgeEFzRmxvYXQoY29uc3QgRmxvYXRTaXplJiBi b3JkZXJCb3hTaXplKSBjb25zdCB7IHJldHVybiBmbG9hdFZhbHVlRm9yTGVuZ3RoKG1feCwgYm9y ZGVyQm94U2l6ZS53aWR0aCgpKTsgfQorICAgIGZsb2F0IHlBc0Zsb2F0KGNvbnN0IEZsb2F0U2l6 ZSYgYm9yZGVyQm94U2l6ZSkgY29uc3QgeyByZXR1cm4gZmxvYXRWYWx1ZUZvckxlbmd0aChtX3ks IGJvcmRlckJveFNpemUuaGVpZ2h0KCkpOyB9CisgICAgZmxvYXQgekFzRmxvYXQoKSBjb25zdCB7 IHJldHVybiBmbG9hdFZhbHVlRm9yTGVuZ3RoKG1feiwgMSk7IH0KIAogICAgIExlbmd0aCB4KCkg Y29uc3QgeyByZXR1cm4gbV94OyB9CiAgICAgTGVuZ3RoIHkoKSBjb25zdCB7IHJldHVybiBtX3k7 IH0KQEAgLTU4LDcgKzU4LDcgQEAgcHVibGljOgogCiAgICAgYm9vbCBhcHBseShUcmFuc2Zvcm1h dGlvbk1hdHJpeCYgdHJhbnNmb3JtLCBjb25zdCBGbG9hdFNpemUmIGJvcmRlckJveFNpemUpIGNv bnN0IGZpbmFsCiAgICAgewotICAgICAgICB0cmFuc2Zvcm0udHJhbnNsYXRlM2QoeChib3JkZXJC b3hTaXplKSwgeShib3JkZXJCb3hTaXplKSwgeihib3JkZXJCb3hTaXplKSk7CisgICAgICAgIHRy YW5zZm9ybS50cmFuc2xhdGUzZCh4QXNGbG9hdChib3JkZXJCb3hTaXplKSwgeUFzRmxvYXQoYm9y ZGVyQm94U2l6ZSksIHpBc0Zsb2F0KCkpOwogICAgICAgICByZXR1cm4gbV94LmlzUGVyY2VudCgp IHx8IG1feS5pc1BlcmNlbnQoKTsKICAgICB9CiAK