217244 2020-10-02 12:16:49 -0700 Web Inspector: REGRESSION(?): cannot edit Event Breakpoint 2020-10-05 10:35:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1694181 0 hi 2020-10-02 12:16:49 -0700 # STEPS TO REPRODUCE 1. inspect any page 2. add an event breakpoint (NOTE: the configuration inputs will appear here) 3. right-click the newly added event breakpoint # EXPECTED there should be an "Edit Breakpoint..." # ACTUAL there was not :( 1694184 1 410350 hi 2020-10-02 12:21:26 -0700 Created attachment 410350 Patch 1694741 2 410350 bburg 2020-10-05 10:24:43 -0700 Comment on attachment 410350 Patch r=me 1694744 3 ews-feeder 2020-10-05 10:34:33 -0700 Committed r267976: <https://trac.webkit.org/changeset/267976> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410350. 1694745 4 webkit-bug-importer 2020-10-05 10:35:16 -0700 <rdar://problem/69960462> 410350 2020-10-02 12:21:26 -0700 2020-10-05 10:34:34 -0700 Patch 217244.diff text/plain 4349 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQwYjZkYTVhZjEwOC4uYjVlNTc1MDY2MzQ0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAyMC0xMC0wMiAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog UkVHUkVTU0lPTig/KTogY2Fubm90IGVkaXQgRXZlbnQgQnJlYWtwb2ludAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3MjQ0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVs cy9FdmVudEJyZWFrcG9pbnQuanM6CisgICAgICAgIChXSS5FdmVudEJyZWFrcG9pbnQuZ2V0IHN1 cHBvcnRzRWRpdGluZyk6CisgICAgICAgIChXSS5FdmVudEJyZWFrcG9pbnQucHJvdG90eXBlLmdl dCBlZGl0YWJsZSk6CisgICAgICAgIE1vdmUgdGhlIHNwZWNpZmljIGxpc3RlbmVyIGJyZWFrcG9p bnQgbG9naWMgdG8gdGhlIGBwcm90b3R5cGVgIGZ1bmN0aW9uIGFzIGB0aGlzYCB3b24ndAorICAg ICAgICBleGlzdCBpbiB0aGUgYHN0YXRpY2AgZnVuY3Rpb24gKG5vdCB0byBtZW50aW9uIGl0J3Mg bm90IHBvc3NpYmxlIHRvIGNyZWF0ZSBhIHNwZWNpZmljCisgICAgICAgIGxpc3RlbmVyIGJyZWFr cG9pbnQgImF0IHdpbGwiIGxpa2UgaXQgaXMgZm9yIGdsb2JhbCBldmVudCBicmVha3BvaW50cyku CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9VUkxCcmVha3BvaW50LmpzOgorICAg ICAgICAoV0kuVVJMQnJlYWtwb2ludC5nZXQgc3VwcG9ydHNFZGl0aW5nKTogQWRkZWQuCisgICAg ICAgIChXSS5VUkxCcmVha3BvaW50LnByb3RvdHlwZS5nZXQgZWRpdGFibGUpOgorICAgICAgICAo V0kuVVJMQnJlYWtwb2ludC5nZXQgZWRpdGFibGUpOiBEZWxldGVkLgorICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvVmlld3MvVVJMQnJlYWtwb2ludFBvcG92ZXIuanM6CisgICAgICAgIChXSS5VUkxC cmVha3BvaW50UG9wb3Zlci5nZXQgc3VwcG9ydHNFZGl0aW5nKToKKyAgICAgICAgRHJpdmUtYnk6 IHVwZGF0ZSBuYW1pbmcgdG8gbWF0Y2ggYFdJLkV2ZW50QnJlYWtwb2ludGAuCisKIDIwMjAtMDkt MjggIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IGFkZCBjaGVja2JveCB0byBsb2NhbCBvdmVycmlkZSBwb3BvdmVyIHRvIGFsbG93IGl0 IHRvIHNraXAgdGhlIG5ldHdvcmsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL01vZGVscy9FdmVudEJyZWFrcG9pbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRXZlbnRCcmVha3BvaW50LmpzCmluZGV4IDljYjdh MGY0MjY2Ny4uMGFkODhmNGVmYjQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9Nb2RlbHMvRXZlbnRCcmVha3BvaW50LmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9FdmVudEJyZWFrcG9pbnQuanMKQEAgLTU1 LDExICs1NSw2IEBAIFdJLkV2ZW50QnJlYWtwb2ludCA9IGNsYXNzIEV2ZW50QnJlYWtwb2ludCBl eHRlbmRzIFdJLkJyZWFrcG9pbnQKIAogICAgIHN0YXRpYyBnZXQgc3VwcG9ydHNFZGl0aW5nKCkK ICAgICB7Ci0gICAgICAgIGlmICh0aGlzLl9ldmVudExpc3RlbmVyKSB7Ci0gICAgICAgICAgICAv LyBDT01QQVRJQklMSVRZIChpT1MgMTQpOiBET00uc2V0QnJlYWtwb2ludEZvckV2ZW50TGlzdGVu ZXIgZGlkIG5vdCBoYXZlIGFuICJvcHRpb25zIiBwYXJhbWV0ZXIgeWV0LgotICAgICAgICAgICAg cmV0dXJuIEluc3BlY3RvckJhY2tlbmQuaGFzQ29tbWFuZCgiRE9NLnNldEJyZWFrcG9pbnRGb3JF dmVudExpc3RlbmVyIiwgIm9wdGlvbnMiKTsKLSAgICAgICAgfQotCiAgICAgICAgIC8vIENPTVBB VElCSUxJVFkgKGlPUyAxNCk6IERPTURlYnVnZ2VyLnNldEV2ZW50QnJlYWtwb2ludCBkaWQgbm90 IGhhdmUgYW4gIm9wdGlvbnMiIHBhcmFtZXRlciB5ZXQuCiAgICAgICAgIHJldHVybiBJbnNwZWN0 b3JCYWNrZW5kLmhhc0NvbW1hbmQoIkRPTURlYnVnZ2VyLnNldEV2ZW50QnJlYWtwb2ludCIsICJv cHRpb25zIik7CiAgICAgfQpAQCAtMTE2LDcgKzExMSwxMiBAQCBXSS5FdmVudEJyZWFrcG9pbnQg PSBjbGFzcyBFdmVudEJyZWFrcG9pbnQgZXh0ZW5kcyBXSS5CcmVha3BvaW50CiAKICAgICBnZXQg ZWRpdGFibGUoKQogICAgIHsKLSAgICAgICAgcmV0dXJuIFdJLkV2ZW50QnJlYWtwb2ludC5lZGl0 YWJsZSB8fCBzdXBlci5lZGl0YWJsZTsKKyAgICAgICAgaWYgKHRoaXMuX2V2ZW50TGlzdGVuZXIp IHsKKyAgICAgICAgICAgIC8vIENPTVBBVElCSUxJVFkgKGlPUyAxNCk6IERPTS5zZXRCcmVha3Bv aW50Rm9yRXZlbnRMaXN0ZW5lciBkaWQgbm90IGhhdmUgYW4gIm9wdGlvbnMiIHBhcmFtZXRlciB5 ZXQuCisgICAgICAgICAgICByZXR1cm4gSW5zcGVjdG9yQmFja2VuZC5oYXNDb21tYW5kKCJET00u c2V0QnJlYWtwb2ludEZvckV2ZW50TGlzdGVuZXIiLCAib3B0aW9ucyIpOworICAgICAgICB9CisK KyAgICAgICAgcmV0dXJuIFdJLkV2ZW50QnJlYWtwb2ludC5zdXBwb3J0c0VkaXRpbmcgfHwgc3Vw ZXIuZWRpdGFibGU7CiAgICAgfQogCiAgICAgcmVtb3ZlKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9VUkxCcmVha3BvaW50LmpzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1VSTEJyZWFrcG9pbnQuanMK aW5kZXggOTkxODQwZjQ0NTY0Li5mNDE0OWRkMWFlOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9VUkxCcmVha3BvaW50LmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9VUkxCcmVha3BvaW50Lmpz CkBAIC0zOCw3ICszOCw3IEBAIFdJLlVSTEJyZWFrcG9pbnQgPSBjbGFzcyBVUkxCcmVha3BvaW50 IGV4dGVuZHMgV0kuQnJlYWtwb2ludAogCiAgICAgLy8gU3RhdGljCiAKLSAgICBzdGF0aWMgZ2V0 IGVkaXRhYmxlKCkKKyAgICBzdGF0aWMgZ2V0IHN1cHBvcnRzRWRpdGluZygpCiAgICAgewogICAg ICAgICAvLyBDT01QQVRJQklMSVRZIChpT1MgMTQpOiBET01EZWJ1Z2dlci5zZXRVUkxCcmVha3Bv aW50IGRpZCBub3QgaGF2ZSBhbiAib3B0aW9ucyIgcGFyYW1ldGVyIHlldC4KICAgICAgICAgcmV0 dXJuIEluc3BlY3RvckJhY2tlbmQuaGFzQ29tbWFuZCgiRE9NRGVidWdnZXIuc2V0VVJMQnJlYWtw b2ludCIsICJvcHRpb25zIik7CkBAIC04NCw3ICs4NCw3IEBAIFdJLlVSTEJyZWFrcG9pbnQgPSBj bGFzcyBVUkxCcmVha3BvaW50IGV4dGVuZHMgV0kuQnJlYWtwb2ludAogCiAgICAgZ2V0IGVkaXRh YmxlKCkKICAgICB7Ci0gICAgICAgIHJldHVybiBXSS5VUkxCcmVha3BvaW50LmVkaXRhYmxlIHx8 IHN1cGVyLmVkaXRhYmxlOworICAgICAgICByZXR1cm4gV0kuVVJMQnJlYWtwb2ludC5zdXBwb3J0 c0VkaXRpbmcgfHwgc3VwZXIuZWRpdGFibGU7CiAgICAgfQogCiAgICAgcmVtb3ZlKCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1VSTEJyZWFr cG9pbnRQb3BvdmVyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVVJMQnJlYWtwb2ludFBvcG92ZXIuanMKaW5kZXggODU1ZDA3ZjhmYWQ5Li5iZDQ2ZTIzMzFi YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1VSTEJyZWFrcG9pbnRQb3BvdmVyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1VSTEJyZWFrcG9pbnRQb3BvdmVyLmpzCkBAIC0zOCw3ICszOCw3IEBA IFdJLlVSTEJyZWFrcG9pbnRQb3BvdmVyID0gY2xhc3MgVVJMQnJlYWtwb2ludFBvcG92ZXIgZXh0 ZW5kcyBXSS5CcmVha3BvaW50UG9wb3ZlCiAKICAgICBzdGF0aWMgZ2V0IHN1cHBvcnRzRWRpdGlu ZygpCiAgICAgewotICAgICAgICByZXR1cm4gV0kuVVJMQnJlYWtwb2ludC5lZGl0YWJsZTsKKyAg ICAgICAgcmV0dXJuIFdJLlVSTEJyZWFrcG9pbnQuc3VwcG9ydHNFZGl0aW5nOwogICAgIH0KIAog ICAgIC8vIFByb3RlY3RlZAo=