217241 2020-10-02 12:03:14 -0700 Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'breakpoint.disabled = true') 2020-10-05 13:04:19 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg hi inspector-bugzilla-changes katherine_cheney webkit-bug-importer oldest_to_newest 1694177 0 hi 2020-10-02 12:03:14 -0700 # STEPS TO REPRODUCE 1. inspect any page with JS event listeners 2. uncheck the "Enabled" checkbox for any event listener on any node Uncaught Exceptions: ----------------------- - TypeError: undefined is not an object (evaluating 'breakpoint.disabled = true') (at DOMManager.js:705:19) removeBreakpointForEventListener @ DOMManager.js:705:19 hasEventListenerBreakpoint @ EventListenerSectionGroup.js:167:59 ? @ EventListenerSectionGroup.js:62:25 1694185 1 410351 hi 2020-10-02 12:21:42 -0700 Created attachment 410351 Patch 1694716 2 410351 katherine_cheney 2020-10-05 09:02:02 -0700 Comment on attachment 410351 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410351&action=review > Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js:-701 > - target.DOMAgent.removeBreakpointForEventListener(eventListener.eventListenerId); Why remove this call? 1694757 3 410351 hi 2020-10-05 10:56:46 -0700 Comment on attachment 410351 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410351&action=review >> Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js:-701 >> - target.DOMAgent.removeBreakpointForEventListener(eventListener.eventListenerId); > > Why remove this call? this is done later inside `_handleEventBreakpointDisabledStateChanged` (which is an event listener callback for `WI.Breakpoint.Event.DisabledStateDidChange`, which is dispatched by `WI.Breakpoint.prototype.set disabled`) 1694759 4 katherine_cheney 2020-10-05 11:05:17 -0700 (In reply to Devin Rousso from comment #3) > Comment on attachment 410351 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410351&action=review > > >> Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js:-701 > >> - target.DOMAgent.removeBreakpointForEventListener(eventListener.eventListenerId); > > > > Why remove this call? > > this is done later inside `_handleEventBreakpointDisabledStateChanged` > (which is an event listener callback for > `WI.Breakpoint.Event.DisabledStateDidChange`, which is dispatched by > `WI.Breakpoint.prototype.set disabled`) Nice, thanks for explaining! 1694795 5 410351 bburg 2020-10-05 12:43:52 -0700 Comment on attachment 410351 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410351&action=review r=e >>>> Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js:-701 >>>> - target.DOMAgent.removeBreakpointForEventListener(eventListener.eventListenerId); >>> >>> Why remove this call? >> >> this is done later inside `_handleEventBreakpointDisabledStateChanged` (which is an event listener callback for `WI.Breakpoint.Event.DisabledStateDidChange`, which is dispatched by `WI.Breakpoint.prototype.set disabled`) > > Nice, thanks for explaining! Would have been good to put this in the changelog :-) 1694796 6 bburg 2020-10-05 12:44:02 -0700 r=me * 1694808 7 ews-feeder 2020-10-05 13:03:10 -0700 Committed r267998: <https://trac.webkit.org/changeset/267998> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410351. 1694809 8 webkit-bug-importer 2020-10-05 13:04:19 -0700 <rdar://problem/69967550> 410351 2020-10-02 12:21:42 -0700 2020-10-05 13:03:10 -0700 Patch 217241.diff text/plain 1789 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQwYjZkYTVhZjEwOC4uMTUzNzA5YzY5NjZlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0xMC0wMiAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog VW5jYXVnaHQgRXhjZXB0aW9uOiBUeXBlRXJyb3I6IHVuZGVmaW5lZCBpcyBub3QgYW4gb2JqZWN0 IChldmFsdWF0aW5nICdicmVha3BvaW50LmRpc2FibGVkID0gdHJ1ZScpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTcyNDEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJv bGxlcnMvRE9NTWFuYWdlci5qczoKKyAgICAgICAgKFdJLkRPTU1hbmFnZXIucHJvdG90eXBlLnJl bW92ZUJyZWFrcG9pbnRGb3JFdmVudExpc3RlbmVyKToKKyAgICAgICAgSXQncyBwb3NzaWJsZSBm b3IgdGhlcmUgdG8gbm90IGJlIGEgYnJlYWtwb2ludCBmb3IgYSBnaXZlbiBldmVudCBsaXN0ZW5l ci4KKwogMjAyMC0wOS0yOCAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogYWRkIGNoZWNrYm94IHRvIGxvY2FsIG92ZXJyaWRlIHBvcG92 ZXIgdG8gYWxsb3cgaXQgdG8gc2tpcCB0aGUgbmV0d29yawpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRE9NTWFuYWdlci5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTU1hbmFnZXIu anMKaW5kZXggNDVmZGNhODc3MTI2Li40YjVkZjRhMGZhYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTU1hbmFnZXIuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRE9NTWFu YWdlci5qcwpAQCAtNjk0LDEyICs2OTQsOCBAQCBXSS5ET01NYW5hZ2VyID0gY2xhc3MgRE9NTWFu YWdlciBleHRlbmRzIFdJLk9iamVjdAogICAgIHJlbW92ZUJyZWFrcG9pbnRGb3JFdmVudExpc3Rl bmVyKGV2ZW50TGlzdGVuZXIpCiAgICAgewogICAgICAgICBsZXQgYnJlYWtwb2ludCA9IHRoaXMu X2JyZWFrcG9pbnRzRm9yRXZlbnRMaXN0ZW5lcnMudGFrZShldmVudExpc3RlbmVyLmV2ZW50TGlz dGVuZXJJZCk7Ci0gICAgICAgIGNvbnNvbGUuYXNzZXJ0KGJyZWFrcG9pbnQpOwotCi0gICAgICAg IGZvciAobGV0IHRhcmdldCBvZiBXSS50YXJnZXRzKSB7Ci0gICAgICAgICAgICBpZiAodGFyZ2V0 Lmhhc0RvbWFpbigiRE9NIikpCi0gICAgICAgICAgICAgICAgdGFyZ2V0LkRPTUFnZW50LnJlbW92 ZUJyZWFrcG9pbnRGb3JFdmVudExpc3RlbmVyKGV2ZW50TGlzdGVuZXIuZXZlbnRMaXN0ZW5lcklk KTsKLSAgICAgICAgfQorICAgICAgICBpZiAoIWJyZWFrcG9pbnQpCisgICAgICAgICAgICByZXR1 cm47CiAKICAgICAgICAgLy8gRGlzYWJsZSB0aGUgYnJlYWtwb2ludCBmaXJzdCwgc28gcmVtb3Zp bmcgYWN0aW9ucyBkb2Vzbid0IHJlLWFkZCB0aGUgYnJlYWtwb2ludC4KICAgICAgICAgYnJlYWtw b2ludC5kaXNhYmxlZCA9IHRydWU7Cg==