217235 2020-10-02 10:37:20 -0700 Web Inspector: Sources: add a + to the Local Overrides section 2020-10-05 10:38:19 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1694141 0 hi 2020-10-02 10:37:20 -0700 when manually creating local overrides it would be nice to have a button closer to the Local Overrides section (and therefore closer to the right-click "Edit Local Override..." too) 1694142 1 410336 hi 2020-10-02 10:38:12 -0700 Created attachment 410336 Patch 1694743 2 410336 bburg 2020-10-05 10:29:54 -0700 Comment on attachment 410336 Patch r=me 1694748 3 ews-feeder 2020-10-05 10:37:56 -0700 Committed r267979: <https://trac.webkit.org/changeset/267979> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410336. 1694749 4 webkit-bug-importer 2020-10-05 10:38:19 -0700 <rdar://problem/69960632> 410336 2020-10-02 10:38:12 -0700 2020-10-05 10:37:56 -0700 Patch bug-217235-20201002103812.patch text/plain 4687 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQwYjZkYTVhZjEwODgwMDU1YzYwNDRjNzQ2ZGM2 ZmRlNzZkZThlMmIuLmZjZGQ4ZGNhN2M0OGYwYzUyYWIwY2FjZjA0NTYyMjg0ODg2N2Y1NDYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTEwLTAyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBT b3VyY2VzOiBhZGQgYSArIHRvIHRoZSBMb2NhbCBPdmVycmlkZXMgc2VjdGlvbgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3MjM1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Zp ZXdzL1NvdXJjZXNOYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV0kuU291cmNl c05hdmlnYXRpb25TaWRlYmFyUGFuZWwpOgorICAgICAgICAoV0kuU291cmNlc05hdmlnYXRpb25T aWRlYmFyUGFuZWwucHJvdG90eXBlLl9wb3B1bGF0ZUNyZWF0ZUxvY2FsT3ZlcnJpZGVDb250ZXh0 TWVudSk6IEFkZGVkLgorICAgICAgICAoV0kuU291cmNlc05hdmlnYXRpb25TaWRlYmFyUGFuZWwu cHJvdG90eXBlLl9wb3B1bGF0ZUNyZWF0ZVJlc291cmNlQ29udGV4dE1lbnUpOgorCiAyMDIwLTA5 LTI4ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5z cGVjdG9yOiBhZGQgY2hlY2tib3ggdG8gbG9jYWwgb3ZlcnJpZGUgcG9wb3ZlciB0byBhbGxvdyBp dCB0byBza2lwIHRoZSBuZXR3b3JrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VzTmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZXNOYXZpZ2F0aW9u U2lkZWJhclBhbmVsLmpzCmluZGV4IDdjZGNkNDhkZmRjNWFhY2JmZmYwODJkNzVmNjljYWFkZWQ2 NmFjZjUuLmY3Y2EzYzdhY2ZmMjIyYjQ5NzE2ODk4MGRlMDBkZWEyOGEwNWFlN2UgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZXNOYXZp Z2F0aW9uU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1NvdXJjZXNOYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzCkBAIC0yMjksOCAr MjI5LDE3IEBAIFdJLlNvdXJjZXNOYXZpZ2F0aW9uU2lkZWJhclBhbmVsID0gY2xhc3MgU291cmNl c05hdmlnYXRpb25TaWRlYmFyUGFuZWwgZXh0ZW5kcyBXCiAKICAgICAgICAgdGhpcy5fbG9jYWxP dmVycmlkZXNSb3cgPSBuZXcgV0kuRGV0YWlsc1NlY3Rpb25Sb3coV0kuVUlTdHJpbmcoIk5vIE92 ZXJyaWRlcyIpKTsKIAorICAgICAgICBsZXQgbG9jYWxPdmVycmlkZU5hdmlnYXRpb25CYXJXcmFw cGVyID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CisKKyAgICAgICAgbGV0IGxvY2Fs T3ZlcnJpZGVOYXZpZ2F0aW9uQmFyID0gbmV3IFdJLk5hdmlnYXRpb25CYXI7CisgICAgICAgIGxv Y2FsT3ZlcnJpZGVOYXZpZ2F0aW9uQmFyV3JhcHBlci5hcHBlbmRDaGlsZChsb2NhbE92ZXJyaWRl TmF2aWdhdGlvbkJhci5lbGVtZW50KTsKKworICAgICAgICB0aGlzLl9jcmVhdGVMb2NhbE92ZXJy aWRlQnV0dG9uID0gbmV3IFdJLkJ1dHRvbk5hdmlnYXRpb25JdGVtKCJjcmVhdGUtbG9jYWwtb3Zl cnJpZGUiLCBXSS5VSVN0cmluZygiQ3JlYXRlIExvY2FsIE92ZXJyaWRlIiksICJJbWFnZXMvUGx1 czEzLnN2ZyIsIDEzLCAxMyk7CisgICAgICAgIFdJLmFkZE1vdXNlRG93bkNvbnRleHRNZW51SGFu ZGxlcnModGhpcy5fY3JlYXRlTG9jYWxPdmVycmlkZUJ1dHRvbi5lbGVtZW50LCB0aGlzLl9wb3B1 bGF0ZUNyZWF0ZUxvY2FsT3ZlcnJpZGVDb250ZXh0TWVudS5iaW5kKHRoaXMpKTsKKyAgICAgICAg bG9jYWxPdmVycmlkZU5hdmlnYXRpb25CYXIuYWRkTmF2aWdhdGlvbkl0ZW0odGhpcy5fY3JlYXRl TG9jYWxPdmVycmlkZUJ1dHRvbik7CisKICAgICAgICAgbGV0IGxvY2FsT3ZlcnJpZGVzR3JvdXAg PSBuZXcgV0kuRGV0YWlsc1NlY3Rpb25Hcm91cChbdGhpcy5fbG9jYWxPdmVycmlkZXNSb3ddKTsK LSAgICAgICAgdGhpcy5fbG9jYWxPdmVycmlkZXNTZWN0aW9uID0gbmV3IFdJLkRldGFpbHNTZWN0 aW9uKCJsb2NhbC1vdmVycmlkZXMiLCBXSS5VSVN0cmluZygiTG9jYWwgT3ZlcnJpZGVzIiksIFts b2NhbE92ZXJyaWRlc0dyb3VwXSk7CisgICAgICAgIHRoaXMuX2xvY2FsT3ZlcnJpZGVzU2VjdGlv biA9IG5ldyBXSS5EZXRhaWxzU2VjdGlvbigibG9jYWwtb3ZlcnJpZGVzIiwgV0kuVUlTdHJpbmco IkxvY2FsIE92ZXJyaWRlcyIpLCBbbG9jYWxPdmVycmlkZXNHcm91cF0sIGxvY2FsT3ZlcnJpZGVO YXZpZ2F0aW9uQmFyV3JhcHBlcik7CiAKICAgICAgICAgdGhpcy5fbG9jYWxPdmVycmlkZXNDb250 YWluZXIgPSB0aGlzLmNvbnRlbnRWaWV3LmVsZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgiZGl2IikpOwogICAgICAgICB0aGlzLl9sb2NhbE92ZXJyaWRlc0NvbnRhaW5l ci5jbGFzc0xpc3QuYWRkKCJsb2NhbC1vdmVycmlkZXMtY29udGFpbmVyIik7CkBAIC0yMDMxLDYg KzIwNDAsMjQgQEAgV0kuU291cmNlc05hdmlnYXRpb25TaWRlYmFyUGFuZWwgPSBjbGFzcyBTb3Vy Y2VzTmF2aWdhdGlvblNpZGViYXJQYW5lbCBleHRlbmRzIFcKICAgICAgICAgfQogICAgIH0KIAor ICAgIF9wb3B1bGF0ZUNyZWF0ZUxvY2FsT3ZlcnJpZGVDb250ZXh0TWVudShjb250ZXh0TWVudSkK KyAgICB7CisgICAgICAgIGlmIChXSS5OZXR3b3JrTWFuYWdlci5zdXBwb3J0c092ZXJyaWRpbmdS ZXNwb25zZXMoKSkgeworICAgICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXSS5VSVN0 cmluZygiTG9jYWwgT3ZlcnJpZGVcdTIwMjYiKSwgKCkgPT4geworICAgICAgICAgICAgICAgIGxl dCBwb3BvdmVyID0gbmV3IFdJLkxvY2FsUmVzb3VyY2VPdmVycmlkZVBvcG92ZXIodGhpcyk7Cisg ICAgICAgICAgICAgICAgcG9wb3Zlci5zaG93KG51bGwsIHRoaXMuX2NyZWF0ZUxvY2FsT3ZlcnJp ZGVCdXR0b24uZWxlbWVudCwgW1dJLlJlY3RFZGdlLk1BWF9ZLCBXSS5SZWN0RWRnZS5NSU5fWSwg V0kuUmVjdEVkZ2UuTUFYX1hdKTsKKyAgICAgICAgICAgIH0pOworICAgICAgICB9CisKKyAgICAg ICAgaWYgKFdJLk5ldHdvcmtNYW5hZ2VyLnN1cHBvcnRzQm9vdHN0cmFwU2NyaXB0KCkpIHsKKyAg ICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV0kuVUlTdHJpbmcoIkluc3BlY3RvciBC b290c3RyYXAgU2NyaXB0IiksIGFzeW5jICgpID0+IHsKKyAgICAgICAgICAgICAgICBhd2FpdCBX SS5uZXR3b3JrTWFuYWdlci5jcmVhdGVCb290c3RyYXBTY3JpcHQoKTsKKyAgICAgICAgICAgICAg ICBXSS5uZXR3b3JrTWFuYWdlci5ib290c3RyYXBTY3JpcHRFbmFibGVkID0gdHJ1ZTsKKyAgICAg ICAgICAgICAgICBXSS5zaG93UmVwcmVzZW50ZWRPYmplY3QoV0kubmV0d29ya01hbmFnZXIuYm9v dHN0cmFwU2NyaXB0KTsKKyAgICAgICAgICAgIH0pOworICAgICAgICB9CisgICAgfQorCiAgICAg X3BvcHVsYXRlQ3JlYXRlUmVzb3VyY2VDb250ZXh0TWVudShjb250ZXh0TWVudSkKICAgICB7CiAg ICAgICAgIGlmIChXSS5OZXR3b3JrTWFuYWdlci5zdXBwb3J0c092ZXJyaWRpbmdSZXNwb25zZXMo KSkgewpAQCAtMjA0MCwxMCArMjA2NywxMCBAQCBXSS5Tb3VyY2VzTmF2aWdhdGlvblNpZGViYXJQ YW5lbCA9IGNsYXNzIFNvdXJjZXNOYXZpZ2F0aW9uU2lkZWJhclBhbmVsIGV4dGVuZHMgVwogCiAg ICAgICAgICAgICAgICAgdGhpcy5fbG9jYWxPdmVycmlkZXNDb250YWluZXIuaGlkZGVuID0gZmFs c2U7CiAKLSAgICAgICAgICAgICAgICB0aGlzLl9sb2NhbE92ZXJyaWRlc1NlY3Rpb24udGl0bGVF bGVtZW50LnNjcm9sbEludG9WaWV3SWZOZWVkZWQoZmFsc2UpOworICAgICAgICAgICAgICAgIHRo aXMuX2NyZWF0ZUxvY2FsT3ZlcnJpZGVCdXR0b24uZWxlbWVudC5zY3JvbGxJbnRvVmlld0lmTmVl ZGVkKGZhbHNlKTsKICAgICAgICAgICAgICAgICByZXF1ZXN0QW5pbWF0aW9uRnJhbWUoKCkgPT4g ewogICAgICAgICAgICAgICAgICAgICBsZXQgcG9wb3ZlciA9IG5ldyBXSS5Mb2NhbFJlc291cmNl T3ZlcnJpZGVQb3BvdmVyKHRoaXMpOwotICAgICAgICAgICAgICAgICAgICBwb3BvdmVyLnNob3co bnVsbCwgdGhpcy5fbG9jYWxPdmVycmlkZXNTZWN0aW9uLnRpdGxlRWxlbWVudCwgW1dJLlJlY3RF ZGdlLk1BWF9ZLCBXSS5SZWN0RWRnZS5NSU5fWSwgV0kuUmVjdEVkZ2UuTUFYX1hdKTsKKyAgICAg ICAgICAgICAgICAgICAgcG9wb3Zlci5zaG93KG51bGwsIHRoaXMuX2NyZWF0ZUxvY2FsT3ZlcnJp ZGVCdXR0b24uZWxlbWVudCwgW1dJLlJlY3RFZGdlLk1BWF9ZLCBXSS5SZWN0RWRnZS5NSU5fWSwg V0kuUmVjdEVkZ2UuTUFYX1hdKTsKICAgICAgICAgICAgICAgICB9KTsKICAgICAgICAgICAgIH0p OwogICAgICAgICB9Cg==