217234 2020-10-02 10:26:42 -0700 Web Inspector: unable to create local override for resource that failed to load 2020-10-05 10:36:14 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1694135 0 hi 2020-10-02 10:26:42 -0700 # STEPS TO REPRODUCE 1. right-click "Create Local Override" for a resource that failed to load Uncaught Exceptions: ----------------------- - undefined is not an object (evaluating 'error.message') (at Resource.js:1195:26) _requestContentFailure @ Resource.js:1195:26 ? @ Resource.js:1070:71 asyncFunctionResume @ [native code] ? @ ContextMenuUtilities.js:83:87 asyncFunctionResume @ [native code] ? @ ContextMenuUtilities.js:81:93 _itemSelected @ ContextMenu.js:260:40 contextMenuItemSelected @ ContextMenu.js:184:58 contextMenuItemSelected @ InspectorFrontendAPI.js:158:47 1694155 1 webkit-bug-importer 2020-10-02 11:05:45 -0700 <rdar://problem/69888143> 1694169 2 410347 hi 2020-10-02 11:38:32 -0700 Created attachment 410347 Patch 1694742 3 410347 bburg 2020-10-05 10:26:27 -0700 Comment on attachment 410347 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410347&action=review r=me > Source/WebInspectorUI/UserInterface/Models/Resource.js:1081 > + } ?_? 1694746 4 ews-feeder 2020-10-05 10:36:13 -0700 Committed r267977: <https://trac.webkit.org/changeset/267977> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410347. 410347 2020-10-02 11:38:32 -0700 2020-10-05 10:36:14 -0700 Patch bug-217234-20201002113832.patch text/plain 6220 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQwYjZkYTVhZjEwODgwMDU1YzYwNDRjNzQ2ZGM2 ZmRlNzZkZThlMmIuLjJmOWU4MTE5MWE1NTUxNTdiYzc0OTQ1NmQxOGJkMjNhYzFjZGNjZmIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTEwLTAyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiB1 bmFibGUgdG8gY3JlYXRlIGxvY2FsIG92ZXJyaWRlIGZvciByZXNvdXJjZSB0aGF0IGZhaWxlZCB0 byBsb2FkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTcyMzQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY5ODg4MTQzPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMv UmVzb3VyY2UuanM6CisgICAgICAgIChXSS5SZXNvdXJjZS5wcm90b3R5cGUuYXN5bmMgY3JlYXRl TG9jYWxSZXNvdXJjZU92ZXJyaWRlKToKKyAgICAgICAgV3JhcCB0aGUgYFdJLlNvdXJjZUNvZGUu cHJvdG90eXBlLnJlcXVlc3RDb250ZW50YCBjYWxsIGluIGEgYHRyeWAgaW4gY2FzZSB0aGUgY29u dGVudCBpcyBub3QKKyAgICAgICAgYWJsZSB0byBiZSBmZXRjaGVkLiBJZiBzbywgZGV0ZXJtaW5l IHRoZSBNSU1FIGZyb20gdGhlIFVSTCBhbmQgZmFsbCBiYWNrIHRvIGAiImAuCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlQ29udGVudFZpZXcuanM6CisgICAgICAgIChX SS5SZXNvdXJjZUNvbnRlbnRWaWV3LnByb3RvdHlwZS5yZXF1ZXN0TG9jYWxSZXNvdXJjZU92ZXJy aWRlSW5pdGlhbENvbnRlbnQpOgorICAgICAgICAoV0kuUmVzb3VyY2VDb250ZW50Vmlldy5wcm90 b3R5cGUuYXN5bmMgX2dldENvbnRlbnRGb3JMb2NhbFJlc291cmNlT3ZlcnJpZGVGcm9tRmlsZSk6 CisgICAgICAgIERyaXZlLWJ5OiBkcm9wIGBpbml0aWFsYCBmcm9tIHRoZSBwYXJhbWV0ZXIgbmFt ZSBhcyBpdCdzIG5vdCByZWFsbHkgbmVjZXNzYXJ5LgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9WaWV3cy9UZXh0UmVzb3VyY2VDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLlRleHRSZXNv dXJjZUNvbnRlbnRWaWV3LnByb3RvdHlwZS5yZXF1ZXN0TG9jYWxSZXNvdXJjZU92ZXJyaWRlSW5p dGlhbENvbnRlbnQpOgorICAgICAgICBEcml2ZS1ieTogaW5jbHVkZSB0aGUgYG1pbWVUeXBlYCBh bmQgYGJhc2U2NEVuY29kZWRgIG9mIHRoZSByZWxhdGVkIGBXSS5SZXNvdXJjZWAuCisKIDIwMjAt MDktMjggIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IGFkZCBjaGVja2JveCB0byBsb2NhbCBvdmVycmlkZSBwb3BvdmVyIHRvIGFsbG93 IGl0IHRvIHNraXAgdGhlIG5ldHdvcmsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL01vZGVscy9SZXNvdXJjZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL01vZGVscy9SZXNvdXJjZS5qcwppbmRleCA4MWU0ODhjNzQ3NTdhNDVi OGZiZWMzZWJjMmM0MDBjMzQxNjJmMWY2Li4xMTBjNTNjZGIyZmI2Y2ZiNzJkNWJlMWJhNWQ2NjBj YjdhNWRkMmQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Nb2RlbHMvUmVzb3VyY2UuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvTW9kZWxzL1Jlc291cmNlLmpzCkBAIC0xMDYyLDE4ICsxMDYyLDI5IEBAIFdJLlJlc291 cmNlID0gY2xhc3MgUmVzb3VyY2UgZXh0ZW5kcyBXSS5Tb3VyY2VDb2RlCiAgICAgICAgIGNvb2tp ZVtXSS5SZXNvdXJjZS5NYWluUmVzb3VyY2VDb29raWVLZXldID0gdGhpcy5pc01haW5SZXNvdXJj ZSgpOwogICAgIH0KIAotICAgIGFzeW5jIGNyZWF0ZUxvY2FsUmVzb3VyY2VPdmVycmlkZSh7aW5p dGlhbE1JTUVUeXBlLCBpbml0aWFsQmFzZTY0RW5jb2RlZCwgaW5pdGlhbENvbnRlbnR9ID0ge30p CisgICAgYXN5bmMgY3JlYXRlTG9jYWxSZXNvdXJjZU92ZXJyaWRlKHttaW1lVHlwZSwgYmFzZTY0 RW5jb2RlZCwgY29udGVudH0gPSB7fSkKICAgICB7CiAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KCF0 aGlzLmlzTG9jYWxSZXNvdXJjZU92ZXJyaWRlKTsKICAgICAgICAgY29uc29sZS5hc3NlcnQoV0ku TmV0d29ya01hbmFnZXIuc3VwcG9ydHNPdmVycmlkaW5nUmVzcG9uc2VzKCkpOwogCi0gICAgICAg IGxldCB7cmF3Q29udGVudCwgcmF3QmFzZTY0RW5jb2RlZH0gPSBhd2FpdCB0aGlzLnJlcXVlc3RD b250ZW50KCk7CisgICAgICAgIG1pbWVUeXBlID8/PSB0aGlzLm1pbWVUeXBlID8/IFdJLm1pbWVU eXBlRm9yRmlsZUV4dGVuc2lvbihXSS5maWxlRXh0ZW5zaW9uRm9yRmlsZW5hbWUodGhpcy51cmxD b21wb25lbnRzLmxhc3RQYXRoQ29tcG9uZW50KSk7CisKKyAgICAgICAgaWYgKGJhc2U2NEVuY29k ZWQgPT09IHVuZGVmaW5lZCB8fCBjb250ZW50ID09PSB1bmRlZmluZWQpIHsKKyAgICAgICAgICAg IHRyeSB7CisgICAgICAgICAgICAgICAgbGV0IHtyYXdDb250ZW50LCByYXdCYXNlNjRFbmNvZGVk fSA9IGF3YWl0IHRoaXMucmVxdWVzdENvbnRlbnQoKTsKKyAgICAgICAgICAgICAgICBjb250ZW50 ID8/PSByYXdDb250ZW50OworICAgICAgICAgICAgICAgIGJhc2U2NEVuY29kZWQgPz89IHJhd0Jh c2U2NEVuY29kZWQ7CisgICAgICAgICAgICB9IGNhdGNoIHsKKyAgICAgICAgICAgICAgICBjb250 ZW50ID8/PSAiIjsKKyAgICAgICAgICAgICAgICBiYXNlNjRFbmNvZGVkID8/PSAhV0kuc2hvdWxk VHJlYXRNSU1FVHlwZUFzVGV4dChtaW1lVHlwZSk7CisgICAgICAgICAgICB9CisgICAgICAgIH0K IAogICAgICAgICByZXR1cm4gV0kuTG9jYWxSZXNvdXJjZU92ZXJyaWRlLmNyZWF0ZShXSS5Mb2Nh bFJlc291cmNlT3ZlcnJpZGUuSW50ZXJjZXB0VHlwZS5SZXNwb25zZSwgewogICAgICAgICAgICAg dXJsOiB0aGlzLnVybCwKLSAgICAgICAgICAgIG1pbWVUeXBlOiBpbml0aWFsTUlNRVR5cGUgIT09 IHVuZGVmaW5lZCA/IGluaXRpYWxNSU1FVHlwZSA6IHRoaXMubWltZVR5cGUsCi0gICAgICAgICAg ICBjb250ZW50OiBpbml0aWFsQ29udGVudCAhPT0gdW5kZWZpbmVkID8gaW5pdGlhbENvbnRlbnQg OiByYXdDb250ZW50LAotICAgICAgICAgICAgYmFzZTY0RW5jb2RlZDogaW5pdGlhbEJhc2U2NEVu Y29kZWQgIT09IHVuZGVmaW5lZCA/IGluaXRpYWxCYXNlNjRFbmNvZGVkIDogcmF3QmFzZTY0RW5j b2RlZCwKKyAgICAgICAgICAgIG1pbWVUeXBlLAorICAgICAgICAgICAgY29udGVudCwKKyAgICAg ICAgICAgIGJhc2U2NEVuY29kZWQsCiAgICAgICAgICAgICBzdGF0dXNDb2RlOiB0aGlzLnN0YXR1 c0NvZGUsCiAgICAgICAgICAgICBzdGF0dXNUZXh0OiB0aGlzLnN0YXR1c1RleHQsCiAgICAgICAg ICAgICBoZWFkZXJzOiB0aGlzLnJlc3BvbnNlSGVhZGVycywKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlQ29udGVudFZpZXcuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZUNvbnRl bnRWaWV3LmpzCmluZGV4IDQ1NjU0OWE2YTJhNWU2Zjc4M2ViZTg1MWU1ZGMwMGI4NjQ4NDZmN2Uu LjRhZDI1YjFhYTk2MmMzMmYyZjJkYTk2ZDFmNTc0YzJkYzFlNGJhMDEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlQ29udGVudFZp ZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVz b3VyY2VDb250ZW50Vmlldy5qcwpAQCAtMTQ2LDExICsxNDYsNyBAQCBXSS5SZXNvdXJjZUNvbnRl bnRWaWV3ID0gY2xhc3MgUmVzb3VyY2VDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRWaWV3 CiAgICAgICAgICAgICBjb25zb2xlLmFzc2VydChmaWxlTGlzdC5sZW5ndGggPT09IDEpOwogCiAg ICAgICAgICAgICB0aGlzLl9nZXRDb250ZW50Rm9yTG9jYWxSZXNvdXJjZU92ZXJyaWRlRnJvbUZp bGUoZmlsZUxpc3RbMF0sICh7bWltZVR5cGUsIGJhc2U2NEVuY29kZWQsIGNvbnRlbnR9KSA9PiB7 Ci0gICAgICAgICAgICAgICAgY2FsbGJhY2soewotICAgICAgICAgICAgICAgICAgICBpbml0aWFs TUlNRVR5cGU6IG1pbWVUeXBlLAotICAgICAgICAgICAgICAgICAgICBpbml0aWFsQmFzZTY0RW5j b2RlZDogYmFzZTY0RW5jb2RlZCwKLSAgICAgICAgICAgICAgICAgICAgaW5pdGlhbENvbnRlbnQ6 IGNvbnRlbnQsCi0gICAgICAgICAgICAgICAgfSk7CisgICAgICAgICAgICAgICAgY2FsbGJhY2so e21pbWVUeXBlLCBiYXNlNjRFbmNvZGVkLCBjb250ZW50fSk7CiAgICAgICAgICAgICB9KTsKICAg ICAgICAgfSk7CiAgICAgfQpAQCAtMjgxLDExICsyNzcsMTEgQEAgV0kuUmVzb3VyY2VDb250ZW50 VmlldyA9IGNsYXNzIFJlc291cmNlQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50Vmlldwog CiAgICAgYXN5bmMgX2dldENvbnRlbnRGb3JMb2NhbFJlc291cmNlT3ZlcnJpZGVGcm9tRmlsZShm aWxlLCBjYWxsYmFjaykKICAgICB7Ci0gICAgICAgIGxldCBpbml0aWFsTUlNRVR5cGUgPSBmaWxl LnR5cGUgfHwgV0kubWltZVR5cGVGb3JGaWxlRXh0ZW5zaW9uKFdJLmZpbGVFeHRlbnNpb25Gb3JG aWxlbmFtZShmaWxlLm5hbWUpKTsKLSAgICAgICAgaWYgKFdJLnNob3VsZFRyZWF0TUlNRVR5cGVB c1RleHQoaW5pdGlhbE1JTUVUeXBlKSkgeworICAgICAgICBsZXQgbWltZVR5cGUgPSBmaWxlLnR5 cGUgfHwgV0kubWltZVR5cGVGb3JGaWxlRXh0ZW5zaW9uKFdJLmZpbGVFeHRlbnNpb25Gb3JGaWxl bmFtZShmaWxlLm5hbWUpKTsKKyAgICAgICAgaWYgKFdJLnNob3VsZFRyZWF0TUlNRVR5cGVBc1Rl eHQobWltZVR5cGUpKSB7CiAgICAgICAgICAgICBhd2FpdCBXSS5GaWxlVXRpbGl0aWVzLnJlYWRU ZXh0KGZpbGUsIGFzeW5jICh7dGV4dH0pID0+IHsKICAgICAgICAgICAgICAgICBhd2FpdCBjYWxs YmFjayh7Ci0gICAgICAgICAgICAgICAgICAgIG1pbWVUeXBlOiBpbml0aWFsTUlNRVR5cGUsCisg ICAgICAgICAgICAgICAgICAgIG1pbWVUeXBlLAogICAgICAgICAgICAgICAgICAgICBiYXNlNjRF bmNvZGVkOiBmYWxzZSwKICAgICAgICAgICAgICAgICAgICAgY29udGVudDogdGV4dCwKICAgICAg ICAgICAgICAgICB9KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1RleHRSZXNvdXJjZUNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dFJlc291cmNlQ29udGVudFZpZXcuanMKaW5k ZXggZjdkMmRlZmY0MTRmODlmMTAzMTgxMWY0OGFlZTU1MTkzMGNiYzI3Mi4uYjY2ODIwNzlmNDNl YWZlYTUzMzJhYjhjMzViZDNkN2IzMTk3YWYxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dFJlc291cmNlQ29udGVudFZpZXcuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dFJlc291cmNl Q29udGVudFZpZXcuanMKQEAgLTE1MSw3ICsxNTEsMTEgQEAgV0kuVGV4dFJlc291cmNlQ29udGVu dFZpZXcgPSBjbGFzcyBUZXh0UmVzb3VyY2VDb250ZW50VmlldyBleHRlbmRzIFdJLlJlc291cmNl Q28KIAogICAgIHJlcXVlc3RMb2NhbFJlc291cmNlT3ZlcnJpZGVJbml0aWFsQ29udGVudChjYWxs YmFjaykKICAgICB7Ci0gICAgICAgIGNhbGxiYWNrKHtpbml0aWFsQ29udGVudDogdGhpcy5fdGV4 dEVkaXRvci5zdHJpbmd9KTsKKyAgICAgICAgY2FsbGJhY2soeworICAgICAgICAgICAgbWltZVR5 cGU6IHRoaXMucmVzb3VyY2UubWltZVR5cGUsCisgICAgICAgICAgICBiYXNlNjRFbmNvZGVkOiB0 aGlzLnJlc291cmNlLmJhc2U2NEVuY29kZWQsCisgICAgICAgICAgICBjb250ZW50OiB0aGlzLl90 ZXh0RWRpdG9yLnN0cmluZywKKyAgICAgICAgfSk7CiAgICAgfQogCiAgICAgZ2V0IHN1cHBvcnRz U2F2ZSgpCg==