217188 2020-10-01 13:32:03 -0700 [PlayStation] Fix build break after r267753 2020-10-10 13:20:19 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead alecflett beidson darin ews-watchlist fujii jsbell webkit-bug-importer oldest_to_newest 1693855 0 don.olmstead 2020-10-01 13:32:03 -0700 Looks like an issue with structured binding like https://bugs.webkit.org/show_bug.cgi?id=201489 1693857 1 410263 don.olmstead 2020-10-01 13:42:04 -0700 Created attachment 410263 Patch 1693911 2 ews-feeder 2020-10-01 16:10:52 -0700 Committed r267857: <https://trac.webkit.org/changeset/267857> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410263. 1693912 3 webkit-bug-importer 2020-10-01 16:12:34 -0700 <rdar://problem/69860615> 1696544 4 410263 darin 2020-10-10 13:20:19 -0700 Comment on attachment 410263 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410263&action=review > Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:957 > + for (auto& iter : indexInfoMap) { Just noticed this. There are a few things wrong with this: 1) On the WebKit project we prefer words over abbreviations. "iter" is not a word. 2) The identifier "iter" sounds like short for "iterator" but the iterators are automatically handled by a range-based for loop and so this is not an iterator. In contexts like this typically call this "key/value pair" or "pair", even though it’s not a std::pair. 410263 2020-10-01 13:42:04 -0700 2020-10-01 16:10:52 -0700 Patch bug-217188.diff text/plain 2117 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiMGQ4MGY3YTA2Y2QuLjVjNDUzOGRlMjE4MiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE4IEBACisyMDIwLTEwLTAxICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29u eS5jb20+CisKKyAgICAgICAgW1BsYXlTdGF0aW9uXSBGaXggYnVpbGQgYnJlYWsgYWZ0ZXIgcjI2 Nzc1MworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3 MTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWZ0 ZXIgcjI2Nzc1MyB0aGUgUGxheVN0YXRpb24gYnVpbGRzIHN0YXJ0ZWQgZmFpbGluZyB3aXRoIGFu IGVycm9yIGFyb3VuZCBhIHN0cnVjdHVyZWQKKyAgICAgICAgYmluZGluZyBkZWNsYXJhdGlvbiBv ZiBhIHR1cGxlIHR5cGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVo YXZpb3IuCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvU1FMaXRlSURCQmFj a2luZ1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQlNlcnZlcjo6U1FMaXRlSURCQmFj a2luZ1N0b3JlOjpoYW5kbGVEdXBsaWNhdGVJbmRleElEcyk6CisKIDIwMjAtMTAtMDEgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihy MjY3NzgxKTogQVNTRVJUSU9OIEZBSUxFRDogT3B0aW9uYWwuaCg1MjUpIDogVCAqV1RGOjpPcHRp b25hbDxXZWJDb3JlOjpMYXlvdXQ6OkxpbmVSdW46OlRleHQ+OjpvcGVyYXRvci0+KCkgb24gMTYg ZmFzdC9sYXlvdXRmb3JtYXR0aW5nY29udGV4dC8qIHRlc3RzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvU1FMaXRlSURCQmFja2luZ1N0b3JlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9TUUxpdGVJREJCYWNr aW5nU3RvcmUuY3BwCmluZGV4IDEzM2JjMGNlNzI0Yi4uMzk5NjgyNWY1ZjVmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvU1FMaXRlSURCQmFja2lu Z1N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIv U1FMaXRlSURCQmFja2luZ1N0b3JlLmNwcApAQCAtOTU0LDE0ICs5NTQsMTQgQEAgYm9vbCBTUUxp dGVJREJCYWNraW5nU3RvcmU6OmFkZEV4aXN0aW5nSW5kZXgoSURCT2JqZWN0U3RvcmVJbmZvJiBv YmplY3RTdG9yZUluZm8KIAogYm9vbCBTUUxpdGVJREJCYWNraW5nU3RvcmU6OmhhbmRsZUR1cGxp Y2F0ZUluZGV4SURzKGNvbnN0IEhhc2hNYXA8dWludDY0X3QsIFZlY3RvcjxJREJJbmRleEluZm8+ PiYgaW5kZXhJbmZvTWFwLCBJREJEYXRhYmFzZUluZm8mIGRhdGFiYXNlSW5mbykKIHsKLSAgICBm b3IgKGF1dG8mIFtpbmRleElELCBpbmZvc10gOiBpbmRleEluZm9NYXApIHsKLSAgICAgICAgaWYg KGluZm9zLnNpemUoKSA9PSAxKQorICAgIGZvciAoYXV0byYgaXRlciA6IGluZGV4SW5mb01hcCkg eworICAgICAgICBpZiAoaXRlci52YWx1ZS5zaXplKCkgPT0gMSkKICAgICAgICAgICAgIGNvbnRp bnVlOwogCi0gICAgICAgIGlmICghcmVtb3ZlRXhpc3RpbmdJbmRleChpbmRleElEKSkKKyAgICAg ICAgaWYgKCFyZW1vdmVFeGlzdGluZ0luZGV4KGl0ZXIua2V5KSkKICAgICAgICAgICAgIHJldHVy biBmYWxzZTsKIAotICAgICAgICBmb3IgKGF1dG8gaW5mbyA6IGluZm9zKSB7CisgICAgICAgIGZv ciAoYXV0byBpbmZvIDogaXRlci52YWx1ZSkgewogICAgICAgICAgICAgYXV0byBvYmplY3RTdG9y ZUluZm8gPSBkYXRhYmFzZUluZm8uaW5mb0ZvckV4aXN0aW5nT2JqZWN0U3RvcmUoaW5mby5vYmpl Y3RTdG9yZUlkZW50aWZpZXIoKSk7CiAgICAgICAgICAgICBBU1NFUlQob2JqZWN0U3RvcmVJbmZv KTsKICAgICAgICAgICAgIG9iamVjdFN0b3JlSW5mby0+ZGVsZXRlSW5kZXgoaW5mby5pZGVudGlm aWVyKCkpOwo=