217179 2020-10-01 06:21:12 -0700 MIME type parser should skip trailing HTTP whitespace 2020-10-05 01:14:17 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rbuis rbuis achristensen darin webkit-bug-importer oldest_to_newest 1693734 0 rbuis 2020-10-01 06:21:12 -0700 MIME type parser should skip trailing HTTP whitespace in Mimesniff mode [1]. [1] https://mimesniff.spec.whatwg.org/#parse-a-mime-type (Steps 8 and 11.9.2) 1693738 1 410228 rbuis 2020-10-01 06:40:38 -0700 Created attachment 410228 Patch 1694492 2 410228 achristensen 2020-10-03 20:26:43 -0700 Comment on attachment 410228 Patch This may be a baby step in the right direction, but the web platform test indicates this may very well cause a regression. Could we expand on this patch until it says PASS? 1694573 3 rbuis 2020-10-04 14:15:45 -0700 (In reply to Alex Christensen from comment #2) > Comment on attachment 410228 [details] > Patch > > This may be a baby step in the right direction, but the web platform test > indicates this may very well cause a regression. Could we expand on this > patch until it says PASS? It needs to be combined with https://bugs.webkit.org/show_bug.cgi?id=217296 to convert it into a PASS. While I can't explain the changed result (only had time to look into it briefly), I am not sure if trading one FAIL for another is so bad here. 1694648 4 ews-feeder 2020-10-05 01:13:54 -0700 Committed r267957: <https://trac.webkit.org/changeset/267957> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410228. 1694649 5 webkit-bug-importer 2020-10-05 01:14:17 -0700 <rdar://problem/69944827> 410228 2020-10-01 06:40:38 -0700 2020-10-05 01:13:54 -0700 Patch bug-217179-20201001144037.patch text/plain 6238 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3Nzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTNkNGM1YTljMTdlNWI1 YjhmNzc0MzlmMzkzNzBjMTQzN2Q3NzM3Ny4uYjlmZGY4NTRkNzllYjJiNjIyYzM1YmE5NzUxYWMw MmY2NTZkNzY2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTEwLTAxICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTUlNRSB0eXBlIHBhcnNlciBzaG91 bGQgc2tpcCB0cmFpbGluZyBIVFRQIHdoaXRlc3BhY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzE3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE1JTUUgdHlwZSBwYXJzZXIgc2hvdWxkIHNraXAgdHJh aWxpbmcgSFRUUCB3aGl0ZXNwYWNlIGluIE1pbWVzbmlmZiBtb2RlIFsxXS4KKworICAgICAgICBb MV0gaHR0cHM6Ly9taW1lc25pZmYuc3BlYy53aGF0d2cub3JnLyNwYXJzZS1hLW1pbWUtdHlwZSAo U3RlcHMgOCBhbmQgMTEuOS4yKQorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9QYXJzZWRD b250ZW50VHlwZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpwYXJzZVRva2VuKToKKwogMjAyMC0w OS0zMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgTWVkaWFS ZWNvcmRlciBzaG91bGQgc3VwcG9ydCBpc1R5cGVTdXBwb3J0ZWQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUGFyc2VkQ29udGVudFR5cGUuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9QYXJzZWRDb250ZW50VHlwZS5jcHAKaW5kZXggYzIz YWJkODg1Y2MyNzE0ODUxMGFiMzc2OTUwOTNmNTBkZmFlN2U4ZC4uOTc1ZGQzZTJlZTViY2M2ZDNk NDFkMDA1YTAwZTRhNTQ3ZDBkOGQwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9QYXJzZWRDb250ZW50VHlwZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9QYXJzZWRDb250ZW50VHlwZS5jcHAKQEAgLTc0LDggKzc0LDEzIEBAIHN0 YXRpYyBTdHJpbmdWaWV3IHBhcnNlVG9rZW4oU3RyaW5nVmlldyBpbnB1dCwgdW5zaWduZWQmIHN0 YXJ0SW5kZXgsIENoYXJhY3Rlck1lCiAgICAgaWYgKHRva2VuRW5kID09IHRva2VuU3RhcnQpCiAg ICAgICAgIHJldHVybiBTdHJpbmdWaWV3KCk7CiAgICAgaWYgKHNraXBUcmFpbGluZ1doaXRlc3Bh Y2UpIHsKLSAgICAgICAgd2hpbGUgKGlucHV0W3Rva2VuRW5kIC0gMV0gPT0gJyAnKQotICAgICAg ICAgICAgLS10b2tlbkVuZDsKKyAgICAgICAgaWYgKG1vZGUgPT0gTW9kZTo6UmZjMjA0NSkgewor ICAgICAgICAgICAgd2hpbGUgKGlucHV0W3Rva2VuRW5kIC0gMV0gPT0gJyAnKQorICAgICAgICAg ICAgICAgIC0tdG9rZW5FbmQ7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICB3aGlsZSAo aXNIVFRQU3BhY2UoaW5wdXRbdG9rZW5FbmQgLSAxXSkpCisgICAgICAgICAgICAgICAgLS10b2tl bkVuZDsKKyAgICAgICAgfQogICAgIH0KICAgICByZXR1cm4gaW5wdXQuc3Vic3RyaW5nKHRva2Vu U3RhcnQsIHRva2VuRW5kIC0gdG9rZW5TdGFydCk7CiB9CmRpZmYgLS1naXQgYS9Ub29scy9DaGFu Z2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzU2ODM1ZTMwNTI4ZWVlNzU4OTBmODZlMjBi N2ZlY2VkMDQxOWE3NS4uMjE4YjYyMDlmZjNlYTlkNzViZWVhZmI2YTg5YzcxNzYzNWVkZThlMiAx MDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDIwLTEwLTAxICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAg ICAgICAgTUlNRSB0eXBlIHBhcnNlciBzaG91bGQgc2tpcCB0cmFpbGluZyBIVFRQIHdoaXRlc3Bh Y2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzE3 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB1 bml0IHRlc3RzIGZvciB0cmFpbGluZyBIVFRQIHdoaXRlc3BhY2UuCisKKyAgICAgICAgKiBUZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvUGFyc2VkQ29udGVudFR5cGUuY3BwOgorICAgICAgICAo VGVzdFdlYktpdEFQSTo6VEVTVCk6CisKIDIwMjAtMDktMzAgIFBoaWxpcHBlIE5vcm1hbmQgIDxw bm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIEludGVybmFsIGF1ZGlv IHJlbmRlcmluZyBzdXBwb3J0CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYkNvcmUvUGFyc2VkQ29udGVudFR5cGUuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJDb3JlL1BhcnNlZENvbnRlbnRUeXBlLmNwcAppbmRleCA5YjU1MzEyNDIwMGMzMTQ2NzVm OTBjYmYyMzRmNDE2YzA1NWIyMGRiLi4zYzMxYTNhODAyZjMzZjMyMjAzZTQ1ZWY5Y2E4ZTRmMGYx NmViZGVkIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvUGFy c2VkQ29udGVudFR5cGUuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29y ZS9QYXJzZWRDb250ZW50VHlwZS5jcHAKQEAgLTcxLDYgKzcxLDE0IEBAIFRFU1QoUGFyc2VkQ29u dGVudFR5cGUsIE1pbWVTbmlmZikKICAgICBFWFBFQ1RfVFJVRShpc1ZhbGlkQ29udGVudFR5cGUo InRleHQvcGxhaW47PXdyb25nO3Rlc3Q9dmFsdWUiLCBNb2RlOjpNaW1lU25pZmYpKTsKICAgICBF WFBFQ1RfVFJVRShpc1ZhbGlkQ29udGVudFR5cGUoInRleHQvcGxhaW47dGVzdD12YWx1ZTt3cm9u Zz0iLCBNb2RlOjpNaW1lU25pZmYpKTsKICAgICBFWFBFQ1RfVFJVRShpc1ZhbGlkQ29udGVudFR5 cGUoInRleHQvcGxhaW47dGVzdD12YWx1ZTs9d3JvbmciLCBNb2RlOjpNaW1lU25pZmYpKTsKKyAg ICBFWFBFQ1RfVFJVRShpc1ZhbGlkQ29udGVudFR5cGUoInRleHQvcGxhaW4gO3Rlc3Q9dmFsdWUi LCBNb2RlOjpNaW1lU25pZmYpKTsKKyAgICBFWFBFQ1RfVFJVRShpc1ZhbGlkQ29udGVudFR5cGUo InRleHQvcGxhaW5cbjt0ZXN0PXZhbHVlIiwgTW9kZTo6TWltZVNuaWZmKSk7CisgICAgRVhQRUNU X1RSVUUoaXNWYWxpZENvbnRlbnRUeXBlKCJ0ZXh0L3BsYWluXHI7dGVzdD12YWx1ZSIsIE1vZGU6 Ok1pbWVTbmlmZikpOworICAgIEVYUEVDVF9UUlVFKGlzVmFsaWRDb250ZW50VHlwZSgidGV4dC9w bGFpblx0O3Rlc3Q9dmFsdWUiLCBNb2RlOjpNaW1lU25pZmYpKTsKKyAgICBFWFBFQ1RfVFJVRShp c1ZhbGlkQ29udGVudFR5cGUoInRleHQvcGxhaW47dGVzdD12YWx1ZSA7dGVzdD12YWx1ZSIsIE1v ZGU6Ok1pbWVTbmlmZikpOworICAgIEVYUEVDVF9UUlVFKGlzVmFsaWRDb250ZW50VHlwZSgidGV4 dC9wbGFpbjt0ZXN0PXZhbHVlXG47dGVzdD12YWx1ZSIsIE1vZGU6Ok1pbWVTbmlmZikpOworICAg IEVYUEVDVF9UUlVFKGlzVmFsaWRDb250ZW50VHlwZSgidGV4dC9wbGFpbjt0ZXN0PXZhbHVlXHI7 dGVzdD12YWx1ZSIsIE1vZGU6Ok1pbWVTbmlmZikpOworICAgIEVYUEVDVF9UUlVFKGlzVmFsaWRD b250ZW50VHlwZSgidGV4dC9wbGFpbjt0ZXN0PXZhbHVlXHQ7dGVzdD12YWx1ZSIsIE1vZGU6Ok1p bWVTbmlmZikpOwogCiAgICAgRVhQRUNUX1RSVUUoaXNWYWxpZENvbnRlbnRUeXBlKCJ0ZXh0L3Bs YWluO3Rlc3Q9XCJ2YWx1ZVwiIiwgTW9kZTo6TWltZVNuaWZmKSk7CiAgICAgRVhQRUNUX1RSVUUo aXNWYWxpZENvbnRlbnRUeXBlKCJ0ZXh0L3BsYWluO3Rlc3Q9XCJ2YWx1ZSIsIE1vZGU6Ok1pbWVT bmlmZikpOwpAQCAtMTgxLDYgKzE4OSw5IEBAIFRFU1QoUGFyc2VkQ29udGVudFR5cGUsIFNlcmlh bGl6ZSkKICAgICBFWFBFQ1RfU1RSRVEoc2VyaWFsaXplSWZWYWxpZCgidGV4dC8gIiksICJOT1RW QUxJRCIpOwogICAgIEVYUEVDVF9TVFJFUShzZXJpYWxpemVJZlZhbGlkKCJ7L30iKSwgIk5PVFZB TElEIik7CiAgICAgRVhQRUNUX1NUUkVRKHNlcmlhbGl6ZUlmVmFsaWQoIngveCA7eD14IiksICJ4 L3g7eD14Iik7CisgICAgRVhQRUNUX1NUUkVRKHNlcmlhbGl6ZUlmVmFsaWQoIngveFxuO3g9eCIp LCAieC94O3g9eCIpOworICAgIEVYUEVDVF9TVFJFUShzZXJpYWxpemVJZlZhbGlkKCJ4L3hccjt4 PXgiKSwgIngveDt4PXgiKTsKKyAgICBFWFBFQ1RfU1RSRVEoc2VyaWFsaXplSWZWYWxpZCgieC94 XHQ7eD14IiksICJ4L3g7eD14Iik7CiAgICAgRVhQRUNUX1NUUkVRKHNlcmlhbGl6ZUlmVmFsaWQo InRleHQvcGxhaW4iKSwgInRleHQvcGxhaW4iKTsKICAgICBFWFBFQ1RfU1RSRVEoc2VyaWFsaXpl SWZWYWxpZCgidGV4dC9wbGFpblwwIiksICJ0ZXh0L3BsYWluIik7CiAgICAgRVhQRUNUX1NUUkVR KHNlcmlhbGl6ZUlmVmFsaWQoIiB0ZXh0L3BsYWluIiksICJ0ZXh0L3BsYWluIik7CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1w b3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCBlYTU1MDBmMDllMWFkOTk1YTI0MjU5Nzk4NWEzNzQw ZTg4M2M4NmVhLi45MmNiMDM1MThhMjM0N2JkZDY3ODBlZmZmZWVlYWM1NTI1ZmU1YjM5IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0xMC0wMSAg Um9iIEJ1aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgorCisgICAgICAgIE1JTUUgdHlwZSBwYXJzZXIg c2hvdWxkIHNraXAgdHJhaWxpbmcgSFRUUCB3aGl0ZXNwYWNlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTcxNzkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGVzdCBleHBlY3RhdGlvbi4KKwor ICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy94aHIvb3ZlcnJpZGVtaW1ldHlwZS1ibG9iLWV4 cGVjdGVkLnR4dDoKKwogMjAyMC0wOS0zMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5j b20+CiAKICAgICAgICAgTWVkaWFSZWNvcmRlciBzaG91bGQgc3VwcG9ydCBpc1R5cGVTdXBwb3J0 ZWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMveGhyL292ZXJyaWRlbWltZXR5cGUtYmxvYi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3hoci9vdmVycmlkZW1pbWV0eXBlLWJsb2It ZXhwZWN0ZWQudHh0CmluZGV4IDM0ZWZlNGRkMzczMTI3Zjg5MzdhY2FjOTZhOWM3ZmYwMmQ5YzAz NTMuLjljZjMzM2U5YzJkNGRjYjliZTkyNDc2N2EyZWJjMDEyNDA2NzdkOWUgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMveGhyL292ZXJyaWRl bWltZXR5cGUtYmxvYi1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy94aHIvb3ZlcnJpZGVtaW1ldHlwZS1ibG9iLWV4cGVjdGVkLnR4 dApAQCAtNDksNyArNDksNyBAQCBGQUlMIDQ0KSBNSU1FIHR5cGVzIG5lZWQgdG8gYmUgcGFyc2Vk IGFuZCBzZXJpYWxpemVkOiB4L3g7dGVzdD0iXCBhc3NlcnRfZXF1YWxzOgogUEFTUyA0NSkgTUlN RSB0eXBlcyBuZWVkIHRvIGJlIHBhcnNlZCBhbmQgc2VyaWFsaXplZDogeC94O3g9CiBQQVNTIDQ2 KSBNSU1FIHR5cGVzIG5lZWQgdG8gYmUgcGFyc2VkIGFuZCBzZXJpYWxpemVkOiB4L3g7eD0JCiBG QUlMIDQ3KSBNSU1FIHR5cGVzIG5lZWQgdG8gYmUgcGFyc2VkIGFuZCBzZXJpYWxpemVkOiB4L3gK LVxyCSA7eD14IGFzc2VydF9lcXVhbHM6IGV4cGVjdGVkICJ4L3g7eD14IiBidXQgZ290ICJhcHBs aWNhdGlvbi9vY3RldC1zdHJlYW0iCitccgkgO3g9eCBhc3NlcnRfZXF1YWxzOiBleHBlY3RlZCAi eC94O3g9eCIgYnV0IGdvdCAiIgogRkFJTCA0OCkgTUlNRSB0eXBlcyBuZWVkIHRvIGJlIHBhcnNl ZCBhbmQgc2VyaWFsaXplZDoKIFxyCSB4L3g7eD14CiBccgkgIGFzc2VydF9lcXVhbHM6IGV4cGVj dGVkICJ4L3g7eD14IiBidXQgZ290ICIiCg==