217167 2020-10-01 00:53:27 -0700 [JSC] Do not use std::function in setPrivateField and definePrivateField 2020-10-01 04:33:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer oldest_to_newest 1693667 0 ysuzuki 2020-10-01 00:53:27 -0700 [JSC] Do not use std::function in setPrivateField and definePrivateField 1693669 1 410202 ysuzuki 2020-10-01 00:54:28 -0700 Created attachment 410202 Patch 1693670 2 410202 ross.kirsling 2020-10-01 00:58:51 -0700 Comment on attachment 410202 Patch Seems fine to me. 1693700 3 ews-feeder 2020-10-01 03:51:34 -0700 Committed r267826: <https://trac.webkit.org/changeset/267826> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410202. 1693701 4 webkit-bug-importer 2020-10-01 03:52:19 -0700 <rdar://problem/69830770> 410202 2020-10-01 00:54:28 -0700 2020-10-01 04:33:21 -0700 Patch bug-217167-20201001005427.patch text/plain 4625 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3ODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh OWQ3M2RlNmNiZjZhZDJlNzRjNjI3YThlY2U4OWUwODFlMTY4MTk4Li5hMjVjMmUyNTUwOWMwZTMw NmZlYmJhM2VjODcxMTg0MDAzYWM4MWZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0xMC0wMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIERvIG5vdCB1c2Ugc3RkOjpmdW5jdGlvbiBpbiBzZXRQcml2YXRl RmllbGQgYW5kIGRlZmluZVByaXZhdGVGaWVsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3MTY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgc3RkOjpmdW5jdGlvbiBjYW4gcG90ZW50aWFsbHkgYWxsb2Nh dGUgYW4gb2JqZWN0IGluIGhlYXAuIFdlIHNob3VsZCBzaG91bGQganVzdCBwYXNzIGxhbWJkYSB3 aXRoIGEgdGVtcGxhdGl6ZWQgcGFyYW1ldGVyIGluc3RlYWQuCisKKyAgICAgICAgKiBqaXQvSklU T3BlcmF0aW9ucy5jcHA6CisgICAgICAgIChKU0M6OnNldFByaXZhdGVGaWVsZCk6CisgICAgICAg IChKU0M6OmRlZmluZVByaXZhdGVGaWVsZCk6CisKIDIwMjAtMDktMzAgIFl1c3VrZSBTdXp1a2kg IDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBXZSBzaG91bGQgbm90IHRhZyBD IGZ1bmN0aW9uIHdpdGggSklUIGNvZGUgcmVsYXRlZCBwdHIgdGFnCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcAppbmRleCAzM2FjZjgzNjlhNmNhNDJjZDNkODg2 YWNlMGMzOTk3MzE2NjVjZjg5Li4zOTMxMjQxMjk4YjVjNDFkMTdjNGE0YjIwNWU1NGYxZmE3ZmRm MDdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAKQEAg LTY3Myw4ICs2NzMsOCBAQCBKU0NfREVGSU5FX0pJVF9PUEVSQVRJT04ob3BlcmF0aW9uUHV0QnlJ ZERpcmVjdE5vblN0cmljdE9wdGltaXplLCB2b2lkLCAoSlNHbG9iYQogCiB9IC8vIGV4dGVybiAi QyIKIAotdXNpbmcgUHV0UHJpdmF0ZUZpZWxkQ2FsbGJhY2sgPSBzdGQ6OmZ1bmN0aW9uPHZvaWQo Vk0mLCBDb2RlQmxvY2sqLCBTdHJ1Y3R1cmUqLCBQdXRQcm9wZXJ0eVNsb3QmLCBjb25zdCBJZGVu dGlmaWVyJik+OwotQUxXQVlTX0lOTElORSBzdGF0aWMgdm9pZCBzZXRQcml2YXRlRmllbGQoVk0m IHZtLCBKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBDYWxsRnJhbWUqIGNhbGxGcmFtZSwg SlNWYWx1ZSBiYXNlVmFsdWUsIENhY2hlYWJsZUlkZW50aWZpZXIgaWRlbnRpZmllciwgSlNWYWx1 ZSB2YWx1ZSwgY29uc3QgUHV0UHJpdmF0ZUZpZWxkQ2FsbGJhY2smIGNhbGxiYWNrID0gUHV0UHJp dmF0ZUZpZWxkQ2FsbGJhY2soKSkKK3RlbXBsYXRlPHR5cGVuYW1lIFB1dFByaXZhdGVGaWVsZENh bGxiYWNrPgorQUxXQVlTX0lOTElORSBzdGF0aWMgdm9pZCBzZXRQcml2YXRlRmllbGQoVk0mIHZt LCBKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBDYWxsRnJhbWUqIGNhbGxGcmFtZSwgSlNW YWx1ZSBiYXNlVmFsdWUsIENhY2hlYWJsZUlkZW50aWZpZXIgaWRlbnRpZmllciwgSlNWYWx1ZSB2 YWx1ZSwgUHV0UHJpdmF0ZUZpZWxkQ2FsbGJhY2sgY2FsbGJhY2spCiB7CiAgICAgYXV0byBzY29w ZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOwogCkBAIC02ODksMTEgKzY4OSwxMSBAQCBBTFdB WVNfSU5MSU5FIHN0YXRpYyB2b2lkIHNldFByaXZhdGVGaWVsZChWTSYgdm0sIEpTR2xvYmFsT2Jq ZWN0KiBnbG9iYWxPYmplY3QsCiAgICAgYmFzZU9iamVjdC0+c2V0UHJpdmF0ZUZpZWxkKGdsb2Jh bE9iamVjdCwgaWRlbnQsIHZhbHVlLCBwdXRTbG90KTsKICAgICBSRVRVUk5fSUZfRVhDRVBUSU9O KHNjb3BlLCB2b2lkKCkpOwogCi0gICAgaWYgKGNhbGxiYWNrKQotICAgICAgICBjYWxsYmFjayh2 bSwgY29kZUJsb2NrLCBvbGRTdHJ1Y3R1cmUsIHB1dFNsb3QsIGlkZW50KTsKKyAgICBjYWxsYmFj ayh2bSwgY29kZUJsb2NrLCBvbGRTdHJ1Y3R1cmUsIHB1dFNsb3QsIGlkZW50KTsKIH0KIAotQUxX QVlTX0lOTElORSBzdGF0aWMgdm9pZCBkZWZpbmVQcml2YXRlRmllbGQoVk0mIHZtLCBKU0dsb2Jh bE9iamVjdCogZ2xvYmFsT2JqZWN0LCBDYWxsRnJhbWUqIGNhbGxGcmFtZSwgSlNWYWx1ZSBiYXNl VmFsdWUsIENhY2hlYWJsZUlkZW50aWZpZXIgaWRlbnRpZmllciwgSlNWYWx1ZSB2YWx1ZSwgY29u c3QgUHV0UHJpdmF0ZUZpZWxkQ2FsbGJhY2smIGNhbGxiYWNrID0gUHV0UHJpdmF0ZUZpZWxkQ2Fs bGJhY2soKSkKK3RlbXBsYXRlPHR5cGVuYW1lIFB1dFByaXZhdGVGaWVsZENhbGxiYWNrPgorQUxX QVlTX0lOTElORSBzdGF0aWMgdm9pZCBkZWZpbmVQcml2YXRlRmllbGQoVk0mIHZtLCBKU0dsb2Jh bE9iamVjdCogZ2xvYmFsT2JqZWN0LCBDYWxsRnJhbWUqIGNhbGxGcmFtZSwgSlNWYWx1ZSBiYXNl VmFsdWUsIENhY2hlYWJsZUlkZW50aWZpZXIgaWRlbnRpZmllciwgSlNWYWx1ZSB2YWx1ZSwgUHV0 UHJpdmF0ZUZpZWxkQ2FsbGJhY2sgY2FsbGJhY2spCiB7CiAgICAgYXV0byBzY29wZSA9IERFQ0xB UkVfVEhST1dfU0NPUEUodm0pOwogCkBAIC03MDgsOCArNzA4LDcgQEAgQUxXQVlTX0lOTElORSBz dGF0aWMgdm9pZCBkZWZpbmVQcml2YXRlRmllbGQoVk0mIHZtLCBKU0dsb2JhbE9iamVjdCogZ2xv YmFsT2JqZWMKICAgICBiYXNlT2JqZWN0LT5kZWZpbmVQcml2YXRlRmllbGQoZ2xvYmFsT2JqZWN0 LCBpZGVudCwgdmFsdWUsIHB1dFNsb3QpOwogICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUs IHZvaWQoKSk7CiAKLSAgICBpZiAoY2FsbGJhY2spCi0gICAgICAgIGNhbGxiYWNrKHZtLCBjb2Rl QmxvY2ssIG9sZFN0cnVjdHVyZSwgcHV0U2xvdCwgaWRlbnQpOworICAgIGNhbGxiYWNrKHZtLCBj b2RlQmxvY2ssIG9sZFN0cnVjdHVyZSwgcHV0U2xvdCwgaWRlbnQpOwogfQogCiBleHRlcm4gIkMi IHsKQEAgLTcyMyw3ICs3MjIsNyBAQCBKU0NfREVGSU5FX0pJVF9PUEVSQVRJT04ob3BlcmF0aW9u UHV0QnlJZERlZmluZVByaXZhdGVGaWVsZFN0cmljdCwgdm9pZCwgKEpTR2xvYgogICAgIEpTVmFs dWUgdmFsdWUgPSBKU1ZhbHVlOjpkZWNvZGUoZW5jb2RlZFZhbHVlKTsKICAgICBKU1ZhbHVlIGJh c2VWYWx1ZSA9IEpTVmFsdWU6OmRlY29kZShlbmNvZGVkQmFzZSk7CiAKLSAgICBkZWZpbmVQcml2 YXRlRmllbGQodm0sIGdsb2JhbE9iamVjdCwgY2FsbEZyYW1lLCBiYXNlVmFsdWUsIGlkZW50aWZp ZXIsIHZhbHVlKTsKKyAgICBkZWZpbmVQcml2YXRlRmllbGQodm0sIGdsb2JhbE9iamVjdCwgY2Fs bEZyYW1lLCBiYXNlVmFsdWUsIGlkZW50aWZpZXIsIHZhbHVlLCBbXShWTSYsIENvZGVCbG9jayos IFN0cnVjdHVyZSosIFB1dFByb3BlcnR5U2xvdCYsIGNvbnN0IElkZW50aWZpZXImKSB7IH0pOwog fQogCiBKU0NfREVGSU5FX0pJVF9PUEVSQVRJT04ob3BlcmF0aW9uUHV0QnlJZERlZmluZVByaXZh dGVGaWVsZFN0cmljdE9wdGltaXplLCB2b2lkLCAoSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVj dCwgU3RydWN0dXJlU3R1YkluZm8qIHN0dWJJbmZvLCBFbmNvZGVkSlNWYWx1ZSBlbmNvZGVkVmFs dWUsIEVuY29kZWRKU1ZhbHVlIGVuY29kZWRCYXNlLCB1aW50cHRyX3QgcmF3Q2FjaGVhYmxlSWRl bnRpZmllcikpCkBAIC03NTcsNyArNzU2LDcgQEAgSlNDX0RFRklORV9KSVRfT1BFUkFUSU9OKG9w ZXJhdGlvblB1dEJ5SWRTZXRQcml2YXRlRmllbGRTdHJpY3QsIHZvaWQsIChKU0dsb2JhbE8KICAg ICBKU1ZhbHVlIHZhbHVlID0gSlNWYWx1ZTo6ZGVjb2RlKGVuY29kZWRWYWx1ZSk7CiAgICAgSlNW YWx1ZSBiYXNlVmFsdWUgPSBKU1ZhbHVlOjpkZWNvZGUoZW5jb2RlZEJhc2UpOwogCi0gICAgc2V0 UHJpdmF0ZUZpZWxkKHZtLCBnbG9iYWxPYmplY3QsIGNhbGxGcmFtZSwgYmFzZVZhbHVlLCBpZGVu dGlmaWVyLCB2YWx1ZSk7CisgICAgc2V0UHJpdmF0ZUZpZWxkKHZtLCBnbG9iYWxPYmplY3QsIGNh bGxGcmFtZSwgYmFzZVZhbHVlLCBpZGVudGlmaWVyLCB2YWx1ZSwgW10oVk0mLCBDb2RlQmxvY2sq LCBTdHJ1Y3R1cmUqLCBQdXRQcm9wZXJ0eVNsb3QmLCBjb25zdCBJZGVudGlmaWVyJikgeyB9KTsK IH0KIAogSlNDX0RFRklORV9KSVRfT1BFUkFUSU9OKG9wZXJhdGlvblB1dEJ5SWRTZXRQcml2YXRl RmllbGRTdHJpY3RPcHRpbWl6ZSwgdm9pZCwgKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3Qs IFN0cnVjdHVyZVN0dWJJbmZvKiBzdHViSW5mbywgRW5jb2RlZEpTVmFsdWUgZW5jb2RlZFZhbHVl LCBFbmNvZGVkSlNWYWx1ZSBlbmNvZGVkQmFzZSwgdWludHB0cl90IHJhd0NhY2hlYWJsZUlkZW50 aWZpZXIpKQo=