21715 2008-10-17 13:39:24 -0700 JavaScriptDebugServer::didRemoveListener should recompile all JS functions 2008-10-17 14:05:09 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ggaren timothy kmccullough timothy oldest_to_newest 95767 0 ggaren 2008-10-17 13:39:24 -0700 Currently, we only recompile when removing the last listener. We should instead recompile when removing any listener. This would match the behavior of didAddListener, and ensure that, when multiple debuggers are running, closing one returns its page to normal, fast-running mode. 95770 1 24461 timothy 2008-10-17 14:03:07 -0700 Created attachment 24461 Proposed patch 95771 2 24461 ggaren 2008-10-17 14:03:56 -0700 Comment on attachment 24461 Proposed patch r=me 95772 3 24461 timothy 2008-10-17 14:05:02 -0700 Comment on attachment 24461 Proposed patch Landed in r37659. 24461 2008-10-17 14:03:07 -0700 2008-10-17 14:03:56 -0700 Proposed patch 0001--Recompile-the-JavaScript-functions-when-remo.patch text/plain 3682 timothy RnJvbSAzNzEyODIyZDIxMzc2MjAzNThiOGU1YTBhYzMyNjRiYTlhMmIwODM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBGcmksIDE3IE9jdCAyMDA4IDE0OjAyOjI1IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gICAg ICAgICBSZWNvbXBpbGUgdGhlIEphdmFTY3JpcHQgZnVuY3Rpb25zIHdoZW4gcmVtb3ZpbmcgYW55 IGxpc3RlbmVyLCBzbyBmdW5jdGlvbnMgdGhhdCBhcmUKICAgICAgICAgbm90IGJlaW5nIGRlYnVn Z2VkIGNhbiByZXN1bWUgbm9ybWFsIHNwZWVkIGFnYWluLgoKICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3MTUKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgogICAgICAgICogYmluZGluZ3MvanMvSlNET01XaW5kb3dCYXNlLmNwcDoK ICAgICAgICAoV2ViQ29yZTo6SlNET01XaW5kb3dCYXNlOjpnbG9iYWxFeGVjKTogQ2hhbmdlZCBh biBhc3NlcnQgaW50byBhbiBpZiBjaGVjay4gVGhpcyBhc3NlcnQKICAgICAgICB3YXMgZmlyaW5n IHdoZW4gY2xvc2luZyB0aGUgd2luZG93IGFuZCBoYXZpbmcgdGhlIHJlY29tcGlsZSBmaXJlIGFm dGVyLiBUaGlzIHdhcyBhbgogICAgICAgIG92ZXJ6ZWxpb3VzIGFzc2VydCBub3cuCiAgICAgICAg KiBpbnNwZWN0b3IvSmF2YVNjcmlwdERlYnVnU2VydmVyLmNwcDoKICAgICAgICAoV2ViQ29yZTo6 SmF2YVNjcmlwdERlYnVnU2VydmVyOjpkaWRSZW1vdmVMaXN0ZW5lcik6IFN0YXJ0IHRoZSByZWNv bXBpbGUgdGltZXIuCiAgICAgICAgKFdlYkNvcmU6OkphdmFTY3JpcHREZWJ1Z1NlcnZlcjo6ZGlk UmVtb3ZlTGFzdExpc3RlbmVyKTogUmVtb3ZlZCB0aGUgcmVjb21waWxlIHRpbWVyIHN0YXJ0Lgot LS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE3ICsr KysrKysrKysrKysrKysrCiBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93QmFzZS5jcHAg ICAgIHwgICAgNCArKy0tCiBXZWJDb3JlL2luc3BlY3Rvci9KYXZhU2NyaXB0RGVidWdTZXJ2ZXIu Y3BwIHwgICAgMyArKy0KIDMgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMyBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IGZlNDk1N2MuLmI1MjQzZTkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMDgtMTAtMTcgIFRp bW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCisgICAgICAgIFJlY29tcGlsZSB0 aGUgSmF2YVNjcmlwdCBmdW5jdGlvbnMgd2hlbiByZW1vdmluZyBhbnkgbGlzdGVuZXIsIHNvIGZ1 bmN0aW9ucyB0aGF0IGFyZQorICAgICAgICBub3QgYmVpbmcgZGVidWdnZWQgY2FuIHJlc3VtZSBu b3JtYWwgc3BlZWQgYWdhaW4uCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxNzE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0Jhc2UuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SlNET01XaW5kb3dCYXNlOjpnbG9iYWxFeGVjKTogQ2hhbmdlZCBhbiBhc3NlcnQg aW50byBhbiBpZiBjaGVjay4gVGhpcyBhc3NlcnQKKyAgICAgICAgd2FzIGZpcmluZyB3aGVuIGNs b3NpbmcgdGhlIHdpbmRvdyBhbmQgaGF2aW5nIHRoZSByZWNvbXBpbGUgZmlyZSBhZnRlci4gVGhp cyB3YXMgYW4KKyAgICAgICAgb3ZlcnplbGlvdXMgYXNzZXJ0IG5vdy4KKyAgICAgICAgKiBpbnNw ZWN0b3IvSmF2YVNjcmlwdERlYnVnU2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkphdmFT Y3JpcHREZWJ1Z1NlcnZlcjo6ZGlkUmVtb3ZlTGlzdGVuZXIpOiBTdGFydCB0aGUgcmVjb21waWxl IHRpbWVyLgorICAgICAgICAoV2ViQ29yZTo6SmF2YVNjcmlwdERlYnVnU2VydmVyOjpkaWRSZW1v dmVMYXN0TGlzdGVuZXIpOiBSZW1vdmVkIHRoZSByZWNvbXBpbGUgdGltZXIgc3RhcnQuCisKKzIw MDgtMTAtMTcgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCiAgICAgICAg IEZpeGVzIGEgcmVncmVzc2lvbiB3aGVyZSBzdGFydGluZyBhIGRlYnVnZ2luZyBzZXNzaW9uIGlu CiAgICAgICAgIGFub3RoZXIgV2ViIEluc3BlY3RvciB3aW5kb3cgd291bGQgbm90IHNob3cgYW55 IHNjcmlwdHMuCiAgICAgICAgIEFsc28gb25seSBhdHRhY2ggdGhlIGRlYnVnZ2VyIHRvIG9ubHkg dGhlIHJlcXVpcmVkIFBhZ2VzLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RP TVdpbmRvd0Jhc2UuY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0Jhc2UuY3Bw CmluZGV4IGJjZjIyZGYuLjZmZDE4OWIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvanMv SlNET01XaW5kb3dCYXNlLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93 QmFzZS5jcHAKQEAgLTY4Nyw4ICs2ODcsOCBAQCBFeGVjU3RhdGUqIEpTRE9NV2luZG93QmFzZTo6 Z2xvYmFsRXhlYygpCiB7CiAgICAgLy8gV2UgbmVlZCB0byBtYWtlIHN1cmUgdGhhdCBhbnkgc2Ny aXB0IGV4ZWN1dGlvbiBoYXBwZW5pbmcgaW4gdGhpcwogICAgIC8vIGZyYW1lIGRvZXMgbm90IGRl c3Ryb3kgaXQKLSAgICBBU1NFUlQoaW1wbCgpLT5mcmFtZSgpKTsKLSAgICBpbXBsKCktPmZyYW1l KCktPmtlZXBBbGl2ZSgpOworICAgIGlmIChGcmFtZSAqZnJhbWUgPSBpbXBsKCktPmZyYW1lKCkp CisgICAgICAgIGZyYW1lLT5rZWVwQWxpdmUoKTsKICAgICByZXR1cm4gQmFzZTo6Z2xvYmFsRXhl YygpOwogfQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9KYXZhU2NyaXB0RGVidWdT ZXJ2ZXIuY3BwIGIvV2ViQ29yZS9pbnNwZWN0b3IvSmF2YVNjcmlwdERlYnVnU2VydmVyLmNwcApp bmRleCA3YjQyYWM2Li4zZDM0MzExIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9KYXZh U2NyaXB0RGVidWdTZXJ2ZXIuY3BwCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL0phdmFTY3JpcHRE ZWJ1Z1NlcnZlci5jcHAKQEAgLTU5Niw2ICs1OTYsOCBAQCB2b2lkIEphdmFTY3JpcHREZWJ1Z1Nl cnZlcjo6ZGlkUmVtb3ZlTGlzdGVuZXIoUGFnZSogcGFnZSkKICAgICBpZiAoaGFzR2xvYmFsTGlz dGVuZXJzKCkgfHwgKHBhZ2UgJiYgaGFzTGlzdGVuZXJzSW50ZXJlc3RlZEluUGFnZShwYWdlKSkp CiAgICAgICAgIHJldHVybjsKIAorICAgIG1fcmVjb21waWxlVGltZXIuc3RhcnRPbmVTaG90KDAp OworCiAgICAgaWYgKHBhZ2UpCiAgICAgICAgIHBhZ2UtPnNldERlYnVnZ2VyKDApOwogICAgIGVs c2UKQEAgLTYwNSw3ICs2MDcsNiBAQCB2b2lkIEphdmFTY3JpcHREZWJ1Z1NlcnZlcjo6ZGlkUmVt b3ZlTGlzdGVuZXIoUGFnZSogcGFnZSkKIHZvaWQgSmF2YVNjcmlwdERlYnVnU2VydmVyOjpkaWRS ZW1vdmVMYXN0TGlzdGVuZXIoKQogewogICAgIG1fZG9uZVByb2Nlc3NpbmdEZWJ1Z2dlckV2ZW50 cyA9IHRydWU7Ci0gICAgbV9yZWNvbXBpbGVUaW1lci5zdGFydE9uZVNob3QoMCk7CiB9CiAKIH0g Ly8gbmFtZXNwYWNlIFdlYkNvcmUKLS0gCjEuNi4wLjIKCg==