217142 2020-09-30 12:42:24 -0700 REGRESSION[267763] RELEASE_ASSERT in allNetworkProcesses hit when registering legacy protocol handlers before instantiating any WebKit objects 2020-10-01 09:47:31 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=216041 InRadar P2 Normal --- 1 achristensen achristensen beidson cdumez ggaren thorton webkit-bug-importer oldest_to_newest 1693493 0 achristensen 2020-09-30 12:42:24 -0700 REGRESSION[267763] RELEASE_ASSERT in allNetworkProcesses hit when registering legacy protocol handlers before instantiating any WebKit objects 1693494 1 410147 achristensen 2020-09-30 12:46:18 -0700 Created attachment 410147 Patch 1693496 2 410147 achristensen 2020-09-30 12:59:53 -0700 Comment on attachment 410147 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410147&action=review > Source/WebKit/ChangeLog:12 > + This unfortunately can't be tested with our current infrastructure because TestsController's constructor calls initializeMainThread. I verified that removing the initializeMainThread call from TestsController::TestsController causes me to hit the issue in the radar and this fixes it. 1693504 3 achristensen 2020-09-30 13:27:56 -0700 http://trac.webkit.org/r267802 1693505 4 webkit-bug-importer 2020-09-30 13:28:36 -0700 <rdar://problem/69805862> 1693763 5 410147 ggaren 2020-10-01 09:11:02 -0700 Comment on attachment 410147 Patch Shouldn't we have initialized WebKit2 when we created the WebProcessPool? If not, what about all the other functions here, like registerURLSchemeAsCORSEnabled? 1693771 6 achristensen 2020-10-01 09:47:31 -0700 WebKit2 is initialized when making a WebProcessPool. The problem here is registerGlobalURLSchemeAsHavingCustomProtocolHandlers is static, so no WebProcessPool is instantiated. 410147 2020-09-30 12:46:18 -0700 2020-09-30 13:19:29 -0700 Patch bug-217142-20200930124617.patch text/plain 2478 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3Nzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEzMmU1Y2NjMDE5ZDAwNTkx NmMxYTg5ZDE4MzVhMmJhZGQwNDU5NDIuLjc1MWI4MzMyZDA2ODk5ZDZkOGExMTU3OWU5Yzk5ZjVl NDRiNWRlZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDktMzAgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9O WzI2Nzc2M10gUkVMRUFTRV9BU1NFUlQgaW4gYWxsTmV0d29ya1Byb2Nlc3NlcyBoaXQgd2hlbiBy ZWdpc3RlcmluZyBsZWdhY3kgcHJvdG9jb2wgaGFuZGxlcnMgYmVmb3JlIGluc3RhbnRpYXRpbmcg YW55IFdlYktpdCBvYmplY3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTcxNDIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY5Nzc4ODc5PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFTEVBU0VfQVNT RVJUKFJ1bkxvb3A6OmlzTWFpbigpKSB3YXMgY3Jhc2hpbmcgYmVjYXVzZSBXVEY6OmluaXRpYWxp emVNYWluVGhyZWFkIGhhZG4ndCBiZWVuIGNhbGxlZC4KKyAgICAgICAgVGhpcyB3YXNuJ3QgYSBw cm9ibGVtIGJlZm9yZSByMjY3NzYzIGJlY2F1c2UgdGhlIGFzc2VydGlvbiBkaWQgbm90IGV4aXN0 LiAgUmF0aGVyIHRoYW4gcmVtb3ZlIHRoZSBhc3NlcnRpb24gKHdoaWNoIEkgdGhpbmsgaXMgaW1w b3J0YW50IHRvIGhhdmUpCisgICAgICAgIGxldCdzIGp1c3QgaW5pdGlhbGl6ZSBXZWJLaXQgdGhy ZWFkaW5nIGF0IHRoZXNlIFNQSSBlbnRyeSBwb2ludHMuCisgICAgICAgIFRoaXMgdW5mb3J0dW5h dGVseSBjYW4ndCBiZSB0ZXN0ZWQgd2l0aCBvdXIgY3VycmVudCBpbmZyYXN0cnVjdHVyZSBiZWNh dXNlIFRlc3RzQ29udHJvbGxlcidzIGNvbnN0cnVjdG9yIGNhbGxzIGluaXRpYWxpemVNYWluVGhy ZWFkLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OnJlZ2lzdGVyR2xvYmFsVVJMU2NoZW1lQXNIYXZpbmdD dXN0b21Qcm90b2NvbEhhbmRsZXJzKToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6 OnVucmVnaXN0ZXJHbG9iYWxVUkxTY2hlbWVBc0hhdmluZ0N1c3RvbVByb3RvY29sSGFuZGxlcnMp OgorCiAyMDIwLTA5LTMwICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjY3Nzg4LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCmluZGV4IGJjYzhkMGI4NzNhMmNlZDczMWRkOTYyMmEy NmI5NDQ5MmVhMzNkNzAuLjE3NzhlMjMyYjZlZTkxYTk2YTczYzM0MWY1ZTdjZDE2ZDIzZGEzNmUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKQEAgLTEyODEs NiArMTI4MSw3IEBAIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OnJlZ2lzdGVyR2xvYmFsVVJMU2NoZW1l QXNIYXZpbmdDdXN0b21Qcm90b2NvbEhhbmRsZXJzKGNvbnN0CiAgICAgaWYgKCF1cmxTY2hlbWUp CiAgICAgICAgIHJldHVybjsKIAorICAgIEluaXRpYWxpemVXZWJLaXQyKCk7CiAgICAgZ2xvYmFs VVJMU2NoZW1lc1dpdGhDdXN0b21Qcm90b2NvbEhhbmRsZXJzKCkuYWRkKHVybFNjaGVtZSk7CiAg ICAgZm9yIChhdXRvIG5ldHdvcmtQcm9jZXNzIDogTmV0d29ya1Byb2Nlc3NQcm94eTo6YWxsTmV0 d29ya1Byb2Nlc3NlcygpKQogICAgICAgICBuZXR3b3JrUHJvY2Vzcy0+cmVnaXN0ZXJTY2hlbWVG b3JMZWdhY3lDdXN0b21Qcm90b2NvbCh1cmxTY2hlbWUpOwpAQCAtMTI5MSw2ICsxMjkyLDcgQEAg dm9pZCBXZWJQcm9jZXNzUG9vbDo6dW5yZWdpc3Rlckdsb2JhbFVSTFNjaGVtZUFzSGF2aW5nQ3Vz dG9tUHJvdG9jb2xIYW5kbGVycyhjb24KICAgICBpZiAoIXVybFNjaGVtZSkKICAgICAgICAgcmV0 dXJuOwogCisgICAgSW5pdGlhbGl6ZVdlYktpdDIoKTsKICAgICBnbG9iYWxVUkxTY2hlbWVzV2l0 aEN1c3RvbVByb3RvY29sSGFuZGxlcnMoKS5yZW1vdmUodXJsU2NoZW1lKTsKICAgICBmb3IgKGF1 dG8gbmV0d29ya1Byb2Nlc3MgOiBOZXR3b3JrUHJvY2Vzc1Byb3h5OjphbGxOZXR3b3JrUHJvY2Vz c2VzKCkpCiAgICAgICAgIG5ldHdvcmtQcm9jZXNzLT51bnJlZ2lzdGVyU2NoZW1lRm9yTGVnYWN5 Q3VzdG9tUHJvdG9jb2wodXJsU2NoZW1lKTsK