217133 2020-09-30 11:02:44 -0700 Remove responseIsXML 2020-09-30 23:49:21 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rbuis rbuis darin webkit-bug-importer oldest_to_newest 1693450 0 rbuis 2020-09-30 11:02:44 -0700 Remove responseIsXML method, it can be inlined and is still readable, also it in one case this avoids calling the non trivial responseMIMEType. 1693451 1 410139 rbuis 2020-09-30 11:04:00 -0700 Created attachment 410139 Patch 1693656 2 ews-feeder 2020-09-30 23:48:33 -0700 Committed r267821: <https://trac.webkit.org/changeset/267821> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410139. 1693657 3 webkit-bug-importer 2020-09-30 23:49:21 -0700 <rdar://problem/69824720> 410139 2020-09-30 11:04:00 -0700 2020-09-30 23:48:33 -0700 Patch bug-217133-20200930190359.patch text/plain 3393 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3Nzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTNkNGM1YTljMTdlNWI1 YjhmNzc0MzlmMzkzNzBjMTQzN2Q3NzM3Ny4uYzBkNzE3NGFkYWJkOWNjYTgxZGI0ZTVlOWFjMTVi OTBjNTM2ZDgyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA5LTMwICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHJlc3BvbnNlSXNYTUwK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzEzMwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBy ZXNwb25zZUlzWE1MIG1ldGhvZCwgaXQgY2FuIGJlIGlubGluZWQgYW5kIGlzIHN0aWxsIHJlYWRh YmxlLCBhbHNvCisgICAgICAgIGl0IGluIG9uZSBjYXNlIHRoaXMgYXZvaWRzIGNhbGxpbmcgdGhl IG5vbiB0cml2aWFsIHJlc3BvbnNlTUlNRVR5cGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBO byBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiB4bWwvWE1MSHR0cFJlcXVlc3QuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Q6OmNyZWF0ZURlY29kZXIgY29uc3Qp OgorICAgICAgICAoV2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Q6OnJlc3BvbnNlSXNYTUwgY29uc3Qp OiBEZWxldGVkLgorICAgICAgICAqIHhtbC9YTUxIdHRwUmVxdWVzdC5oOgorCiAyMDIwLTA5LTMw ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBNZWRpYVJlY29y ZGVyIHNob3VsZCBzdXBwb3J0IGlzVHlwZVN1cHBvcnRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRw UmVxdWVzdC5jcHAKaW5kZXggMDY4NjZkY2MxYzNhYTJiZTg5NzQzNjY1ZTRmMTBmY2Q3MTNlZmEw YS4uNmZmZWNjNGNlZThlNjgwNWU2Njk1Zjg5NGUzY2VjYWQwNDhkNjU3OCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwCkBAIC0xNzIsMTAgKzE3MiwxMSBAQCBFeGNlcHRpb25P cjxEb2N1bWVudCo+IFhNTEh0dHBSZXF1ZXN0OjpyZXNwb25zZVhNTCgpCiAKICAgICAgICAgU3Ry aW5nIG1pbWVUeXBlID0gcmVzcG9uc2VNSU1FVHlwZSgpOwogICAgICAgICBib29sIGlzSFRNTCA9 IGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKG1pbWVUeXBlLCAidGV4dC9odG1sIik7Cisg ICAgICAgIGJvb2wgaXNYTUwgPSBNSU1FVHlwZVJlZ2lzdHJ5Ojppc1hNTE1JTUVUeXBlKG1pbWVU eXBlKTsKIAogICAgICAgICAvLyBUaGUgVzNDIHNwZWMgcmVxdWlyZXMgdGhlIGZpbmFsIE1JTUUg dHlwZSB0byBiZSBzb21lIHZhbGlkIFhNTCB0eXBlLCBvciB0ZXh0L2h0bWwuCiAgICAgICAgIC8v IElmIGl0IGlzIHRleHQvaHRtbCwgdGhlbiB0aGUgcmVzcG9uc2VUeXBlIG9mICJkb2N1bWVudCIg bXVzdCBoYXZlIGJlZW4gc3VwcGxpZWQgZXhwbGljaXRseS4KLSAgICAgICAgaWYgKChtX3Jlc3Bv bnNlLmlzSW5IVFRQRmFtaWx5KCkgJiYgIXJlc3BvbnNlSXNYTUwoKSAmJiAhaXNIVE1MKQorICAg ICAgICBpZiAoKG1fcmVzcG9uc2UuaXNJbkhUVFBGYW1pbHkoKSAmJiAhaXNYTUwgJiYgIWlzSFRN TCkKICAgICAgICAgICAgIHx8IChpc0hUTUwgJiYgcmVzcG9uc2VUeXBlKCkgPT0gUmVzcG9uc2VU eXBlOjpFbXB0eVN0cmluZykpIHsKICAgICAgICAgICAgIG1fcmVzcG9uc2VEb2N1bWVudCA9IG51 bGxwdHI7CiAgICAgICAgIH0gZWxzZSB7CkBAIC04NTgsMTEgKzg1OSw2IEBAIFN0cmluZyBYTUxI dHRwUmVxdWVzdDo6cmVzcG9uc2VNSU1FVHlwZSgpIGNvbnN0CiAgICAgcmV0dXJuIG1pbWVUeXBl OwogfQogCi1ib29sIFhNTEh0dHBSZXF1ZXN0OjpyZXNwb25zZUlzWE1MKCkgY29uc3QKLXsKLSAg ICByZXR1cm4gTUlNRVR5cGVSZWdpc3RyeTo6aXNYTUxNSU1FVHlwZShyZXNwb25zZU1JTUVUeXBl KCkpOwotfQotCiBpbnQgWE1MSHR0cFJlcXVlc3Q6OnN0YXR1cygpIGNvbnN0CiB7CiAgICAgaWYg KHJlYWR5U3RhdGUoKSA9PSBVTlNFTlQgfHwgcmVhZHlTdGF0ZSgpID09IE9QRU5FRCB8fCBtX2Vy cm9yKQpAQCAtOTk2LDcgKzk5Miw3IEBAIFJlZjxUZXh0UmVzb3VyY2VEZWNvZGVyPiBYTUxIdHRw UmVxdWVzdDo6Y3JlYXRlRGVjb2RlcigpIGNvbnN0CiAKICAgICBzd2l0Y2ggKHJlc3BvbnNlVHlw ZSgpKSB7CiAgICAgY2FzZSBSZXNwb25zZVR5cGU6OkVtcHR5U3RyaW5nOgotICAgICAgICBpZiAo cmVzcG9uc2VJc1hNTCgpKSB7CisgICAgICAgIGlmIChNSU1FVHlwZVJlZ2lzdHJ5Ojppc1hNTE1J TUVUeXBlKHJlc3BvbnNlTUlNRVR5cGUoKSkpIHsKICAgICAgICAgICAgIGF1dG8gZGVjb2RlciA9 IFRleHRSZXNvdXJjZURlY29kZXI6OmNyZWF0ZSgiYXBwbGljYXRpb24veG1sIik7CiAgICAgICAg ICAgICAvLyBEb24ndCBzdG9wIG9uIGVuY29kaW5nIGVycm9ycywgdW5saWtlIGl0IGlzIGRvbmUg Zm9yIG90aGVyIGtpbmRzIG9mIFhNTCByZXNvdXJjZXMuIFRoaXMgbWF0Y2hlcyB0aGUgYmVoYXZp b3Igb2YgcHJldmlvdXMgV2ViS2l0IHZlcnNpb25zLCBGaXJlZm94IGFuZCBPcGVyYS4KICAgICAg ICAgICAgIGRlY29kZXItPnVzZUxlbmllbnRYTUxEZWNvZGluZygpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmggYi9Tb3VyY2UvV2ViQ29yZS94bWwvWE1M SHR0cFJlcXVlc3QuaAppbmRleCA3ZjUxNjVkNTc5MDYzYWRhZWE2ZjVmNzY1ZmIyMjVmYzc1MzU5 Mzc4Li4wYjFlZDI5M2RiMjE0ZjNmNmU5MTBlZDM5NGJmOGRlNmY3YzI2NzE3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS94bWwvWE1MSHR0cFJlcXVlc3QuaApAQCAtMTYxLDggKzE2MSw2IEBAIHByaXZhdGU6CiAgICAg dm9pZCBkaWRGYWlsKGNvbnN0IFJlc291cmNlRXJyb3ImKSBvdmVycmlkZTsKICAgICB2b2lkIG5v dGlmeUlzRG9uZShib29sKSBmaW5hbDsKIAotICAgIGJvb2wgcmVzcG9uc2VJc1hNTCgpIGNvbnN0 OwotCiAgICAgT3B0aW9uYWw8RXhjZXB0aW9uT3I8dm9pZD4+IHByZXBhcmVUb1NlbmQoKTsKICAg ICBFeGNlcHRpb25Pcjx2b2lkPiBzZW5kKERvY3VtZW50Jik7CiAgICAgRXhjZXB0aW9uT3I8dm9p ZD4gc2VuZChjb25zdCBTdHJpbmcmID0geyB9KTsK