217123 2020-09-30 02:13:32 -0700 [GTK] Chassis type check fails if the value is quoted 2020-09-30 07:18:17 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alicem webkit-unassigned benjamin bugs-noreply cdumez cgarcia cmarcelo ews-watchlist oldest_to_newest 1693330 0 alicem 2020-09-30 02:13:32 -0700 The values in /etc/machine-info can be quoteed like `CHASSIS="handset"`. In this case the check will fail because `"handset"` isn't same as `handset`. We should unquote it. 1693346 1 410108 alicem 2020-09-30 05:20:52 -0700 Created attachment 410108 Patch 1693351 2 410108 cgarcia 2020-09-30 06:07:15 -0700 Comment on attachment 410108 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410108&action=review > Source/WTF/wtf/glib/ChassisType.cpp:51 > + if (error.get() != nullptr) Do not compare to nullptr, and you don't need the .get() either: if (error) g_warning(); 1693354 3 410111 alicem 2020-09-30 06:24:51 -0700 Created attachment 410111 Patch 1693355 4 alicem 2020-09-30 06:25:03 -0700 Sure. 1693373 5 ews-feeder 2020-09-30 07:18:16 -0700 Committed r267789: <https://trac.webkit.org/changeset/267789> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410111. 410108 2020-09-30 05:20:52 -0700 2020-09-30 06:24:44 -0700 Patch bug-217123-20200930172051.patch text/plain 1843 alicem U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQxOTdjNjY1OWYxNDc3YTY1NDNlOTky OWQ1MzY1OTkzOTkzNDFmMzQuLmQzYzBlOGZmZWVjZTFlYjQwN2MzZTBlMWZmZTY0OTQ2OTU4N2Fl MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDktMzAgIEFsZXhhbmRlciBNaWtoYXlsZW5r byAgPGFsZXhtQGdub21lLm9yZz4KKworICAgICAgICBbR1RLXSBDaGFzc2lzIHR5cGUgY2hlY2sg ZmFpbHMgaWYgdGhlIHZhbHVlIGlzIHF1b3RlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3MTIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU29tZXRpbWVzIHRoZSBjaGFzc2lzIHR5cGUgY2FuIGJlIHF1 b3RlZCwgaW4gdGhpcyBjYXNlIHdlJ2xsIGZhaWwgdG8KKyAgICAgICAgcGFyc2UgaXQgYW5kIGZh bGwgYmFjayB0byBkZXNrdG9wIHR5cGUuIFVucXVvdGUgdGhlIHN0cmluZyBiZWZvcmUKKyAgICAg ICAgYXR0ZW1wdGluZyB0byBwYXJzZSBpdC4KKworICAgICAgICAqIHd0Zi9nbGliL0NoYXNzaXNU eXBlLmNwcDoKKyAgICAgICAgKFdURjo6cmVhZE1hY2hpbmVJbmZvQ2hhc3Npc1R5cGUpOgorCiAy MDIwLTA5LTI5ICBTYW0gV2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBbUHJl ZmVyZW5jZXNdIEFkb3B0IHNoYXJlZCBwcmVmZXJlbmNlcyBjb25maWd1cmF0aW9uIGFuZCBzY3Jp cHQgaW4gV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9nbGliL0NoYXNzaXNUeXBl LmNwcCBiL1NvdXJjZS9XVEYvd3RmL2dsaWIvQ2hhc3Npc1R5cGUuY3BwCmluZGV4IDNmYzMyNmUz YmFjMzE3NTg1Y2IxNzEyZTgxYTM3MDc1M2I0ZDBmMzcuLmI4MjY5ZGUzYjdmMzE5MzJjZjhhMmM3 ZGYwYjc3NjJkMTMxYTg5ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL2dsaWIvQ2hhc3Np c1R5cGUuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL2dsaWIvQ2hhc3Npc1R5cGUuY3BwCkBAIC00 Niw3ICs0NiwxMiBAQCBzdGF0aWMgT3B0aW9uYWw8Q2hhc3Npc1R5cGU+IHJlYWRNYWNoaW5lSW5m b0NoYXNzaXNUeXBlKCkKICAgICBmb3IgKGludCBpID0gMDsgc3BsaXQuZ2V0KClbaV07ICsraSkg ewogICAgICAgICBpZiAoZ19zdHJfaGFzX3ByZWZpeChzcGxpdC5nZXQoKVtpXSwgIkNIQVNTSVM9 IikpIHsKICAgICAgICAgICAgIGNoYXIqIGNoYXNzaXMgPSBzcGxpdC5nZXQoKVtpXSArIDg7Ci0g ICAgICAgICAgICBpZiAoIXN0cmNtcChjaGFzc2lzLCAidGFibGV0IikgfHwgIXN0cmNtcChjaGFz c2lzLCAiaGFuZHNldCIpKQorCisgICAgICAgICAgICBHVW5pcXVlUHRyPGNoYXI+IHVucXVvdGVk KGdfc2hlbGxfdW5xdW90ZShjaGFzc2lzLCAmZXJyb3Iub3V0UHRyKCkpKTsKKyAgICAgICAgICAg IGlmIChlcnJvci5nZXQoKSAhPSBudWxscHRyKQorICAgICAgICAgICAgICAgIGdfd2FybmluZygi Q291bGQgbm90IHVucXVvdGUgY2hhc3NpcyB0eXBlICVzOiAlcyIsIGNoYXNzaXMsIGVycm9yLT5t ZXNzYWdlKTsKKworICAgICAgICAgICAgaWYgKCFzdHJjbXAodW5xdW90ZWQuZ2V0KCksICJ0YWJs ZXQiKSB8fCAhc3RyY21wKHVucXVvdGVkLmdldCgpLCAiaGFuZHNldCIpKQogICAgICAgICAgICAg ICAgIHJldHVybiBDaGFzc2lzVHlwZTo6TW9iaWxlOwogCiAgICAgICAgICAgICByZXR1cm4gQ2hh c3Npc1R5cGU6OkRlc2t0b3A7Cg== 410111 2020-09-30 06:24:51 -0700 2020-09-30 07:18:16 -0700 Patch bug-217123-20200930182450.patch text/plain 1826 alicem U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQxOTdjNjY1OWYxNDc3YTY1NDNlOTky OWQ1MzY1OTkzOTkzNDFmMzQuLmQzYzBlOGZmZWVjZTFlYjQwN2MzZTBlMWZmZTY0OTQ2OTU4N2Fl MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDktMzAgIEFsZXhhbmRlciBNaWtoYXlsZW5r byAgPGFsZXhtQGdub21lLm9yZz4KKworICAgICAgICBbR1RLXSBDaGFzc2lzIHR5cGUgY2hlY2sg ZmFpbHMgaWYgdGhlIHZhbHVlIGlzIHF1b3RlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3MTIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU29tZXRpbWVzIHRoZSBjaGFzc2lzIHR5cGUgY2FuIGJlIHF1 b3RlZCwgaW4gdGhpcyBjYXNlIHdlJ2xsIGZhaWwgdG8KKyAgICAgICAgcGFyc2UgaXQgYW5kIGZh bGwgYmFjayB0byBkZXNrdG9wIHR5cGUuIFVucXVvdGUgdGhlIHN0cmluZyBiZWZvcmUKKyAgICAg ICAgYXR0ZW1wdGluZyB0byBwYXJzZSBpdC4KKworICAgICAgICAqIHd0Zi9nbGliL0NoYXNzaXNU eXBlLmNwcDoKKyAgICAgICAgKFdURjo6cmVhZE1hY2hpbmVJbmZvQ2hhc3Npc1R5cGUpOgorCiAy MDIwLTA5LTI5ICBTYW0gV2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBbUHJl ZmVyZW5jZXNdIEFkb3B0IHNoYXJlZCBwcmVmZXJlbmNlcyBjb25maWd1cmF0aW9uIGFuZCBzY3Jp cHQgaW4gV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9nbGliL0NoYXNzaXNUeXBl LmNwcCBiL1NvdXJjZS9XVEYvd3RmL2dsaWIvQ2hhc3Npc1R5cGUuY3BwCmluZGV4IDNmYzMyNmUz YmFjMzE3NTg1Y2IxNzEyZTgxYTM3MDc1M2I0ZDBmMzcuLjE4YmVmNzdkNGVmNmI0NzA3YzEzOGM5 ZjRiNmYzYWFjNTEyYjZlMTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL2dsaWIvQ2hhc3Np c1R5cGUuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL2dsaWIvQ2hhc3Npc1R5cGUuY3BwCkBAIC00 Niw3ICs0NiwxMiBAQCBzdGF0aWMgT3B0aW9uYWw8Q2hhc3Npc1R5cGU+IHJlYWRNYWNoaW5lSW5m b0NoYXNzaXNUeXBlKCkKICAgICBmb3IgKGludCBpID0gMDsgc3BsaXQuZ2V0KClbaV07ICsraSkg ewogICAgICAgICBpZiAoZ19zdHJfaGFzX3ByZWZpeChzcGxpdC5nZXQoKVtpXSwgIkNIQVNTSVM9 IikpIHsKICAgICAgICAgICAgIGNoYXIqIGNoYXNzaXMgPSBzcGxpdC5nZXQoKVtpXSArIDg7Ci0g ICAgICAgICAgICBpZiAoIXN0cmNtcChjaGFzc2lzLCAidGFibGV0IikgfHwgIXN0cmNtcChjaGFz c2lzLCAiaGFuZHNldCIpKQorCisgICAgICAgICAgICBHVW5pcXVlUHRyPGNoYXI+IHVucXVvdGVk KGdfc2hlbGxfdW5xdW90ZShjaGFzc2lzLCAmZXJyb3Iub3V0UHRyKCkpKTsKKyAgICAgICAgICAg IGlmIChlcnJvcikKKyAgICAgICAgICAgICAgICBnX3dhcm5pbmcoIkNvdWxkIG5vdCB1bnF1b3Rl IGNoYXNzaXMgdHlwZSAlczogJXMiLCBjaGFzc2lzLCBlcnJvci0+bWVzc2FnZSk7CisKKyAgICAg ICAgICAgIGlmICghc3RyY21wKHVucXVvdGVkLmdldCgpLCAidGFibGV0IikgfHwgIXN0cmNtcCh1 bnF1b3RlZC5nZXQoKSwgImhhbmRzZXQiKSkKICAgICAgICAgICAgICAgICByZXR1cm4gQ2hhc3Np c1R5cGU6Ok1vYmlsZTsKIAogICAgICAgICAgICAgcmV0dXJuIENoYXNzaXNUeXBlOjpEZXNrdG9w Owo=