217118 2020-09-29 19:40:02 -0700 REGRESSION(r267402): [ macOS iOS Release ] imported/w3c/web-platform-tests/user-timing/measure-l3.any.worker.html is a flaky failure 2021-01-08 13:50:03 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 hector_i_lopez achristensen achristensen clopez ews-watchlist sam thorton webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1693286 0 hector_i_lopez 2020-09-29 19:40:02 -0700 imported/w3c/web-platform-tests/user-timing/measure-l3.any.worker.html Test is a flaky failure according to history on macOS Release and iOS Release. First occurrence of failure at https://trac.webkit.org/changeset/267402/webkit History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fuser-timing%2Fmeasure-l3.any.worker.html&platform=ios&platform=mac&limit=50000 Diff: --- /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/user-timing/measure-l3.any.worker-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/user-timing/measure-l3.any.worker-actual.txt @@ -1,5 +1,5 @@ PASS When the end mark is given and the start is unprovided, the end time of the measure entry should be the end mark's time, the start time should be 0. -PASS When the start mark is given and the end is unprovided, the start time of the measure entry should be the start mark's time, the end should be now. +FAIL When the start mark is given and the end is unprovided, the start time of the measure entry should be the start mark's time, the end should be now. assert_greater_than_equal: expected a number greater than or equal to 13.000000000000002 but got 13 PASS When start and end mark are both given, the start time and end time of the measure entry should be the the marks' time, repectively Was able to reproduce this with r267769: run-webkit-tests imported/w3c/web-platform-tests/user-timing/measure-l3.any.worker.html --iterations 1000 --exit-after-n-failures 3 -1 -f running 1 test Running 6 DumpRenderTrees in parallel. [35/1000] imported/w3c/web-platform-tests/user-timing/measure-l3.any.worker.html failed unexpectedly (text diff) [46/1000] imported/w3c/web-platform-tests/user-timing/measure-l3.any.worker.html failed unexpectedly (text diff) [47/1000] imported/w3c/web-platform-tests/user-timing/measure-l3.any.worker.html failed unexpectedly (text diff) Exiting early after 3 failures. 42 tests run. 39 tests ran as expected, 3 didn't (958 didn't run): Regressions: Unexpected text-only failures (1) imported/w3c/web-platform-tests/user-timing/measure-l3.any.worker.html [ Failure ] Diff: --- /Volumes/Data/Builds/build-267769/layout-test-results/imported/w3c/web-platform-tests/user-timing/measure-l3.any.worker-expected.txt +++ /Volumes/Data/Builds/build-267769/layout-test-results/imported/w3c/web-platform-tests/user-timing/measure-l3.any.worker-actual.txt @@ -1,5 +1,5 @@ PASS When the end mark is given and the start is unprovided, the end time of the measure entry should be the end mark's time, the start time should be 0. -PASS When the start mark is given and the end is unprovided, the start time of the measure entry should be the start mark's time, the end should be now. +FAIL When the start mark is given and the end is unprovided, the start time of the measure entry should be the start mark's time, the end should be now. assert_greater_than_equal: expected a number greater than or equal to 26.000000000000004 but got 26 PASS When start and end mark are both given, the start time and end time of the measure entry should be the the marks' time, repectively 1693287 1 webkit-bug-importer 2020-09-29 19:40:23 -0700 <rdar://problem/69774340> 1693289 2 hector_i_lopez 2020-09-29 19:45:59 -0700 Test expectation while investigated: https://trac.webkit.org/changeset/267778/webkit 1718348 3 417279 achristensen 2021-01-08 11:00:40 -0800 Created attachment 417279 Patch 1718349 4 ews-watchlist 2021-01-08 11:01:40 -0800 This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess 1718373 5 417279 thorton 2021-01-08 11:56:35 -0800 Comment on attachment 417279 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417279&action=review > LayoutTests/imported/w3c/web-platform-tests/user-timing/measure-l3.any.js:25 > + assert_greater_than_equal(Number(endTime(measureEntry).toFixed(2)), endMin); > + assert_greater_than_equal(endMax, Number(endTime(measureEntry).toFixed(2))); Would it be better to do this by subtraction and picking a maximum delta instead? 1718375 6 417279 achristensen 2021-01-08 11:57:52 -0800 Comment on attachment 417279 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417279&action=review >> LayoutTests/imported/w3c/web-platform-tests/user-timing/measure-l3.any.js:25 >> + assert_greater_than_equal(endMax, Number(endTime(measureEntry).toFixed(2))); > > Would it be better to do this by subtraction and picking a maximum delta instead? Probably, but this is consistent with what is already done elsewhere in this test. 1718428 7 ews-feeder 2021-01-08 13:50:00 -0800 Committed r271320: <https://trac.webkit.org/changeset/271320> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417279. 417279 2021-01-08 11:00:40 -0800 2021-01-08 13:50:01 -0800 Patch bug-217118-20210108110039.patch text/plain 5065 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMzAxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWFkMGYyYjE4NjYxNGVkYThhOGE1 MzFhZjAzMmE2NDBhODNlNzc0Ni4uZWEzZmI2NDY0OTExOTlkNDQ4YTU4MDJlYmQxMTRmMGJlZjIw NzBiMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAxLTA4ICBBbGV4IENocmlzdGVuc2Vu ICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjY3NDAy KTogWyBtYWNPUyBpT1MgUmVsZWFzZSBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMv dXNlci10aW1pbmcvbWVhc3VyZS1sMy5hbnkud29ya2VyLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTcxMTgK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY5Nzc0MzQwPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHIyNjg5Mjggd2Fzbid0IHN1ZmZpY2llbnQuICBU aGlzIHRlc3Qgc3RpbGwgZmFpbGVkIGFib3V0IDEvNTAwIHJ1bnMgZm9yIG1lLCBidXQgYWZ0ZXIg ZnVydGhlciB0cnVuY2F0aW9uIG9mIGxlc3Mgc2lnbmlmaWNhbnQgYml0cworICAgICAgICBpdCBz dWNjZXNzZnVsbHkgcmFuIDEwMDAwIHRpbWVzIHdpdGggbm8gZmFpbHVyZXMuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisgICAgICAgICogcGxhdGZvcm0v bWFjL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMjEtMDEtMDggIFlvdWVubiBGYWJsZXQgIDx5b3Vl bm5AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBjb3VudCBmYWlsdXJlIGNoZWNrIGluIExheW91 dFRlc3RzL3dlYnJ0Yy9oMjY0LWhpZ2guaHRtbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1w b3J0ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cK aW5kZXggYzZiMjMxOGFmNGUzNmIzM2RhOTc5NmE0YjY2MjJiNjY5YTVmZWRmMC4uOGYzMDQyOGQ3 M2FhNGVhZWU5YTM1MzA2YWZjMjA3NTY5NjM0ZmJiNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDEtMDggIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNjc0MDIpOiBb IG1hY09TIGlPUyBSZWxlYXNlIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy91c2Vy LXRpbWluZy9tZWFzdXJlLWwzLmFueS53b3JrZXIuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzExOAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2ViLXBsYXRm b3JtLXRlc3RzL3VzZXItdGltaW5nL21lYXN1cmUtbDMuYW55LmpzOgorICAgICAgICAodGVzdCk6 CisKIDIwMjEtMDEtMDcgIENhdGhpZSBDaGVuICA8Y2F0aGllY2hlbkBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFVwZGF0ZSBXUFQgdGVzdCBzdWl0ZSBmb3IgaW50ZXJzZWN0aW9uLW9ic2VydmVyCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3Vz ZXItdGltaW5nL21lYXN1cmUtbDMuYW55LmpzIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy91c2VyLXRpbWluZy9tZWFzdXJlLWwzLmFueS5qcwppbmRleCBiNGQ0 YzY1MDUzMzM5ZjJlZTIyZDU5YTgwMTExNTQ4YTAzMzBjZGQyLi42NDJiNTVhYjYzNWUyYzAyMWQ5 OWMxYWFmM2U5MjRjYTJjNWMwYzI5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3VzZXItdGltaW5nL21lYXN1cmUtbDMuYW55LmpzCisrKyBi L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvdXNlci10aW1pbmcv bWVhc3VyZS1sMy5hbnkuanMKQEAgLTIxLDggKzIxLDggQEAgdGVzdChmdW5jdGlvbigpIHsKICAg Y29uc3QgbWVhc3VyZUVudHJ5ID0gcGVyZm9ybWFuY2UubWVhc3VyZSgiQSIsICJtYXJrIiwgdW5k ZWZpbmVkKTsKICAgY29uc3QgZW5kTWF4ID0gTnVtYmVyKHBlcmZvcm1hbmNlLm5vdygpLnRvRml4 ZWQoMikpOwogICBhc3NlcnRfZXF1YWxzKG1lYXN1cmVFbnRyeS5zdGFydFRpbWUsIG1hcmtFbnRy eS5zdGFydFRpbWUpOwotICBhc3NlcnRfZ3JlYXRlcl90aGFuX2VxdWFsKGVuZFRpbWUobWVhc3Vy ZUVudHJ5KSwgZW5kTWluKTsKLSAgYXNzZXJ0X2dyZWF0ZXJfdGhhbl9lcXVhbChlbmRNYXgsIGVu ZFRpbWUobWVhc3VyZUVudHJ5KSk7CisgIGFzc2VydF9ncmVhdGVyX3RoYW5fZXF1YWwoTnVtYmVy KGVuZFRpbWUobWVhc3VyZUVudHJ5KS50b0ZpeGVkKDIpKSwgZW5kTWluKTsKKyAgYXNzZXJ0X2dy ZWF0ZXJfdGhhbl9lcXVhbChlbmRNYXgsIE51bWJlcihlbmRUaW1lKG1lYXN1cmVFbnRyeSkudG9G aXhlZCgyKSkpOwogfSwgIldoZW4gdGhlIHN0YXJ0IG1hcmsgaXMgZ2l2ZW4gYW5kIHRoZSBlbmQg aXMgdW5wcm92aWRlZCwgdGhlIHN0YXJ0IHRpbWUgb2YgdGhlIG1lYXN1cmUgZW50cnkgc2hvdWxk IGJlIHRoZSBzdGFydCBtYXJrJ3MgdGltZSwgdGhlIGVuZCBzaG91bGQgYmUgbm93LiIpOwogCiB0 ZXN0KGZ1bmN0aW9uKCkgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdr Mi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhw ZWN0YXRpb25zCmluZGV4IGUwMDM3NjE4Y2M0ZTQyY2NmZTc4NDUxMjhhZGMzYWFiOTNjMWZiMTMu LjBlMDJkMjFjNjY1OTU3NTEyZDgyYzY1ZDM0YTdlMjE1OTk3OWVjYmEgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL2lvcy13azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTE4NjcsOCArMTg2Nyw2 IEBAIHdlYmtpdC5vcmcvYi8yMTYyOTIgWyBSZWxlYXNlIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy9jc3MvY3NzLWZsZXhib3gvCiB3ZWJraXQub3JnL2IvMTg2MDQ1IGltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy11aS90ZXh0LW92ZXJmbG93LTAxNy5odG1s IFsgU2tpcCBdCiB3ZWJraXQub3JnL2IvMTg2MDQ1IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvY3NzL2Nzcy12YWx1ZXMvdmhfbm90X3JlZnJlc2hpbmdfb25fY2hyb21lLmh0bWwgWyBT a2lwIF0KIAotd2Via2l0Lm9yZy9iLzIxNzExOCBbIFJlbGVhc2UgXSBpbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL3VzZXItdGltaW5nL21lYXN1cmUtbDMuYW55Lndvcmtlci5odG1sIFsg UGFzcyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzIxNzI1NyB3ZWJnbC8xLjAuMy9jb25mb3Jt YW5jZS90ZXh0dXJlcy90ZXgtaW1hZ2UtYW5kLXN1Yi1pbWFnZS0yZC13aXRoLXZpZGVvLmh0bWwg WyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzIxNzI1OCBzdmcvVzNDLUkxOE4vdHNwYW4tZGly ZWN0aW9uLXJ0bC5zdmcgWyBGYWlsdXJlIF0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RF eHBlY3RhdGlvbnMKaW5kZXggNWUzMjk2OTk2NGQyZDU3OWQzYWI0YThmOWM1OWU1OWI4MmVmMWI1 NC4uYzllMWFkZmMzMmQ1OWY4MTFlODMwM2Y4Njg4ODZhZjA3NTUxN2NlMiAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTIyMDYsMTQgKzIyMDYsMTAgQEAg d2Via2l0Lm9yZy9iLzIxNjQ5MiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3NlbGVj dGlvbi9leHRlbmQtMDAuaHRtbCBbIFMKIFsgYXJtNjQgXSB3ZWJhdWRpby9BbmFseXNlci9yZWFs dGltZWFuYWx5c2VyLWZyZXEtZGF0YS5odG1sIFsgRmFpbHVyZSBdCiBbIGFybTY0IF0gd2ViYXVk aW8vT3NjaWxsYXRvci9uby1kZXppcHBlcmluZy5odG1sIFsgRmFpbHVyZSBdCiAKLXdlYmtpdC5v cmcvYi8yMTcxMTggWyBSZWxlYXNlIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy91 c2VyLXRpbWluZy9tZWFzdXJlLWwzLmFueS53b3JrZXIuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCi0K ICMgVGhlc2UgdGVzdHMgZmFpbCBpbiBNYWMgZHVlIHRvIHN1YnBpeGVsIGRpZmZlcmVuY2VzIGZv ciB0aGUgbWFya2VyIHBvc2l0aW9uCiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nz cy9jc3MtbGlzdHMvbGlzdC1zdHlsZS10eXBlLXN0cmluZy0wMDIuaHRtbCBbIEltYWdlT25seUZh aWx1cmUgXQogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWxpc3RzL2xp c3Qtc3R5bGUtdHlwZS1zdHJpbmctMDA0Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIAotd2Vi a2l0Lm9yZy9iLzIxNzQxNCBbIFJlbGVhc2UgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL3VzZXItdGltaW5nL21lYXN1cmUtbDMuYW55Lmh0bWwgWyBQYXNzIEZhaWx1cmUgXQotCiB3 ZWJraXQub3JnL2IvMjE3NDYxIFsgTW9qYXZlKyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvY3NzL2Nzcy1tYXNraW5nL2NsaXAtcGF0aC9zdmctY2xpcFBhdGguc3ZnIFsgU2tpcCBd CiAKIHdlYmtpdC5vcmcvYi8yMDkwNzMgWyBEZWJ1ZyBdIGluc3BlY3Rvci9pbmplY3RlZC1zY3Jp cHQvYXZvaWQtZ2V0dGVyLWludm9jYXRpb24uaHRtbCBbIFBhc3MgVGltZW91dCBdCg==