217112 2020-09-29 17:49:39 -0700 We should avoid making connections to the GPU Process during garbage collection 2020-09-29 20:28:16 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh dino sabouhallawa thorton webkit-bug-importer oldest_to_newest 1693247 0 wenson_hsieh 2020-09-29 17:49:39 -0700 1 0x15e1a1779 WTFCrash 2 0x10f41d7cb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x11093ae59 WTF::WeakPtr<WebKit::RemoteRenderingBackend, WTF::EmptyCounter>::operator->() const 4 0x11093b44a WebKit::RemoteImageBufferMessageHandler::waitForCreateImageBufferBackend() 5 0x110964340 WebKit::RemoteImageBuffer<WebKit::ImageBufferShareableIOSurfaceBackend>::ensureBackendCreated() const 6 0x10fa3493c WebCore::ConcreteImageBuffer<WebKit::ImageBufferShareableIOSurfaceBackend>::memoryCost() const 7 0x1430ace73 WebCore::CanvasBase::memoryCost() const 8 0x140b9cc5c WebCore::JSHTMLCanvasElement::visitChildren(JSC::JSCell*, JSC::SlotVisitor&) 9 0x15f3d4d64 JSC::SlotVisitor::visitChildren(JSC::JSCell const*) 10 0x15f3dc6ef JSC::SlotVisitor::drain(WTF::MonotonicTime)::$_3::operator()(JSC::MarkStackArray&) const 11 0x15f3d5294 JSC::IterationStatus JSC::SlotVisitor::forEachMarkStack<JSC::SlotVisitor::drain(WTF::MonotonicTime)::$_3>(JSC::SlotVisitor::drain(WTF::MonotonicTime)::$_3 const&) 12 0x15f3d521a JSC::SlotVisitor::drain(WTF::MonotonicTime) 13 0x15f3d5f77 JSC::SlotVisitor::drainFromShared(JSC::SlotVisitor::SharedDrainMode, WTF::MonotonicTime) 14 0x15f36d24b JSC::Heap::runBeginPhase(JSC::GCConductor)::$_19::operator()() const 15 0x15f36d0ae WTF::SharedTaskFunctor<void (), JSC::Heap::runBeginPhase(JSC::GCConductor)::$_19>::run() 16 0x15e227129 WTF::ParallelHelperClient::runTask(WTF::RefPtr<WTF::SharedTask<void ()>, WTF::DumbPtrTraits<WTF::SharedTask<void ()> >, WTF::DefaultRefDerefTraits<WTF::SharedTask<void ()> > > const&) 17 0x15e22825a WTF::ParallelHelperPool::Thread::work() 18 0x15e1b7913 WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0::operator()() const 19 0x15e1b74fe WTF::Detail::CallableWrapper<WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0, void>::call() 20 0x15e1c9a22 WTF::Function<void ()>::operator()() const 21 0x15e279998 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) 22 0x15e285a68 WTF::wtfThreadEntryPoint(void*) 23 0x7fff2030f9b4 _pthread_start 24 0x7fff2030b4d7 thread_start 1693284 1 410086 wenson_hsieh 2020-09-29 19:10:26 -0700 Created attachment 410086 Patch 1693288 2 410086 thorton 2020-09-29 19:45:42 -0700 Comment on attachment 410086 Patch memoryCost() and externalMemoryCost() don't do IPC? also, do we EVER need to make the backing store to answer this question? I'd expect us to know the size up front... I guess it's about IOSurface size rounding or complicated layouts? 1693290 3 wenson_hsieh 2020-09-29 19:57:05 -0700 Thanks for the review! (In reply to Tim Horton from comment #2) > Comment on attachment 410086 [details] > Patch > > memoryCost() and externalMemoryCost() don't do IPC? Yeah — from what I could gather, memoryCost() and externalMemoryCost() just ask the image buffer backend; however, in the process of creating the backend when using GPUP, we end up also establishing a connection to the GPUP 😬 > > also, do we EVER need to make the backing store to answer this question? I'd > expect us to know the size up front... I guess it's about IOSurface size > rounding or complicated layouts? I think in theory, we shouldn’t; however, the ImageBufferBackend is the thing responsible for keeping track of sizes (and the thing that knows how to estimate memory cost). 1693297 4 ews-feeder 2020-09-29 20:27:30 -0700 Committed r267780: <https://trac.webkit.org/changeset/267780> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410086. 1693298 5 webkit-bug-importer 2020-09-29 20:28:16 -0700 <rdar://problem/69775393> 410086 2020-09-29 19:10:26 -0700 2020-09-29 20:27:30 -0700 Patch bug-217112-20200929191025.patch text/plain 2884 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGEwMzg4NWJmYTI0ODUw OGU3YzlhOTg3M2NlY2M2MjhmM2JlMjIxMy4uOTg5MGY0ZjRhMmFjODNhYWE1ZDJlZDdlZDY1ZjE5 NTU1NWM4NGQ0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDIwLTA5LTI5ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFdlIHNob3VsZCBh dm9pZCBtYWtpbmcgY29ubmVjdGlvbnMgdG8gdGhlIEdQVSBQcm9jZXNzIGR1cmluZyBnYXJiYWdl IGNvbGxlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxNzExMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEN1cnJlbnRseSwgaXQncyBwb3NzaWJsZSB0byBlc3RhYmxpc2ggYSBjb25uZWN0aW9uIHRv IHRoZSBHUFUgcHJvY2VzcyBmcm9tIHRoZSB3ZWIgY29udGVudCBwcm9jZXNzIGluIHRoZSBtaWRk bGUKKyAgICAgICAgb2YgZ2FyYmFnZSBjb2xsZWN0aW9uLiBUaGlzIG1heSBvY2N1ciBpZiBHQyBv Y2N1cnMgYWZ0ZXIgYSBjYW52YXMgZWxlbWVudCBhbmQgaXRzIGltYWdlIGJ1ZmZlciBoYXMgYmVl biBjcmVhdGVkLAorICAgICAgICBidXQgYmVmb3JlIHRoZSBpbWFnZSBidWZmZXIgaGFzIGluaXRp YWxpemVkIGl0cyBiYWNrZW5kICh3aGljaCwgaW4gdGhlIGNhc2Ugb2YgdXNpbmcgdGhlIEdQVSBw cm9jZXNzIGZvcgorICAgICAgICByZW5kZXJpbmcsIGlzIGEgUmVtb3RlUmVuZGVyaW5nQmFja2Vu ZCkuIFdoaWxlIGVzdGltYXRpbmcgbWVtb3J5IGNvc3QgZm9yIHRoZSBjYW52YXMgZWxlbWVudCwg aWYgYSByZW1vdGUKKyAgICAgICAgcmVuZGVyaW5nIGJhY2tlbmQgaGFzIG5vdCBiZWVuIGNyZWF0 ZWQgeWV0LCB3ZSBlbmQgdXAgY3JlYXRpbmcgaXQgdW5kZXJuZWF0aCBgZW5zdXJlQmFja2VuZENy ZWF0ZWQoKWAsIGFuZAorICAgICAgICBzdWJzZXF1ZW50bHkgYmxvY2sgdGhlIHdlYiBwcm9jZXNz IHVudGlsIHRoZSBHUFUgcHJvY2VzcyBpcyBmaW5pc2hlZCBjcmVhdGluZyB0aGUgcHJveHkgcmVu ZGVyaW5nIGJhY2tlbmQuCisKKyAgICAgICAgV2hlbiBydW5uaW5nIGxheW91dCB0ZXN0cyBpbiBg ZmFzdC9jYW52YXNgLCB0aGlzIGNhdXNlcyBzb21lIGxheW91dCB0ZXN0cyB0byBvY2Nhc2lvbmFs bHkgaGl0IGFzc2VydGlvbnMgdW5kZXIKKyAgICAgICAgYFJlbW90ZUltYWdlQnVmZmVyTWVzc2Fn ZUhhbmRsZXI6OndhaXRGb3JDcmVhdGVJbWFnZUJ1ZmZlckJhY2tlbmRgLCBkdWUgdG8gYWNjZXNz aW5nIGBtX3JlbW90ZVJlbmRlcmluZ0JhY2tlbmRgCisgICAgICAgIChhIHdlYWsgcG9pbnRlciku CisKKyAgICAgICAgVG8gZml4IHRoaXMsIGluIHRoZSBjYXNlIHdoZXJlIHRoZSBpbWFnZSBidWZm ZXIgZG9lcyBub3QgeWV0IGhhdmUgYSByZW5kZXJpbmcgYmFja2VuZCwgd2Ugc2hvdWxkIHNpbXBs eSByZXR1cm4gMAorICAgICAgICBpbnN0ZWFkIG9mIHRlbGxpbmcgdGhlIEdQVSBwcm9jZXNzIHRv IGFsbG9jYXRlIHRoZSBhY3R1YWwgaW1hZ2UgYnVmZmVyIGFuZCB0aGVuIHJldHVybmluZyBhIG5v bi16ZXJvIGNvc3QuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Db25jcmV0ZUltYWdl QnVmZmVyLmg6CisKIDIwMjAtMDktMjkgIFBlbmcgTGl1ICA8cGVuZy5saXU2QGFwcGxlLmNvbT4K IAogICAgICAgICBbTWVkaWEgaW4gR1BVIFByb2Nlc3NdIFVzZSBWaWRlb0xheWVyTWFuYWdlciB0 byBtYW5hZ2UgbGF5ZXJzIG9mIE1lZGlhUGxheWVyUHJpdmF0ZVJlbW90ZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29uY3JldGVJbWFnZUJ1ZmZlci5oIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29uY3JldGVJbWFnZUJ1ZmZlci5oCmlu ZGV4IDNiYThjMTJiZWMwMGY0N2Q1MzM2MjhkZDA1YThkMGYyMzQ0YTU5MDkuLmM2YzE5ZTEyODlm NDhiMDIwZWE3OGJjZTM5ZDEwNmMzZGI5M2IwN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0NvbmNyZXRlSW1hZ2VCdWZmZXIuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db25jcmV0ZUltYWdlQnVmZmVyLmgKQEAgLTExMiwxNiAr MTEyLDEyIEBAIHByb3RlY3RlZDoKIAogICAgIHNpemVfdCBtZW1vcnlDb3N0KCkgY29uc3Qgb3Zl cnJpZGUKICAgICB7Ci0gICAgICAgIGlmIChhdXRvKiBiYWNrZW5kID0gZW5zdXJlQmFja2VuZENy ZWF0ZWQoKSkKLSAgICAgICAgICAgIHJldHVybiBiYWNrZW5kLT5tZW1vcnlDb3N0KCk7Ci0gICAg ICAgIHJldHVybiAwOworICAgICAgICByZXR1cm4gbV9iYWNrZW5kID8gbV9iYWNrZW5kLT5tZW1v cnlDb3N0KCkgOiAwOwogICAgIH0KIAogICAgIHNpemVfdCBleHRlcm5hbE1lbW9yeUNvc3QoKSBj b25zdCBvdmVycmlkZQogICAgIHsKLSAgICAgICAgaWYgKGF1dG8qIGJhY2tlbmQgPSBlbnN1cmVC YWNrZW5kQ3JlYXRlZCgpKQotICAgICAgICAgICAgcmV0dXJuIGJhY2tlbmQtPmV4dGVybmFsTWVt b3J5Q29zdCgpOwotICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0dXJuIG1fYmFja2VuZCA/ IG1fYmFja2VuZC0+ZXh0ZXJuYWxNZW1vcnlDb3N0KCkgOiAwOwogICAgIH0KIAogICAgIE5hdGl2 ZUltYWdlUHRyIGNvcHlOYXRpdmVJbWFnZShCYWNraW5nU3RvcmVDb3B5IGNvcHlCZWhhdmlvciA9 IENvcHlCYWNraW5nU3RvcmUpIGNvbnN0IG92ZXJyaWRlCg==