217109 2020-09-29 16:29:32 -0700 Web Inspector: exempt API::SharedJSContext from remote inspection and automatic inspection 2020-09-30 09:48:50 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg inspector-bugzilla-changes mark.lam webkit-bug-importer oldest_to_newest 1693214 0 bburg 2020-09-29 16:29:32 -0700 This is only used to deserialize objects, there is no point to allowing inspection. 1693215 1 bburg 2020-09-29 16:29:47 -0700 <rdar://problem/69386559> 1693220 2 410066 bburg 2020-09-29 16:33:41 -0700 Created attachment 410066 Proposed Fix 1693222 3 410066 mark.lam 2020-09-29 16:38:16 -0700 Comment on attachment 410066 Proposed Fix r=me 1693236 4 bburg 2020-09-29 17:11:40 -0700 There is some concern that setting the property will happen too late and this will already be paused underneath -[JSContext initWithVirtualMachine:]. Alternate ideas: - temporarily disable automatic inspection when initializing that JSContext. - add SPI to JSContext to specifically disable automatic inspection. - in the pauseWaitingForAutomaticInspection wait loop, check if remote inspection has been disabled and bail if so. - make webinspectord detect when an automatic inspection candidate has disabled remote inspection and delete any associated automatic inspection sessions. 1693403 5 410066 bburg 2020-09-30 09:17:31 -0700 Comment on attachment 410066 Proposed Fix Let's proceed, if this is not enough we'll find out soon. 1693407 6 ews-feeder 2020-09-30 09:35:05 -0700 Committed r267793: <https://trac.webkit.org/changeset/267793> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410066. 1693412 7 bburg 2020-09-30 09:48:50 -0700 Oof, looks like we should be doing this instead: previous = JSRemoteInspectorGetInspectionEnabledByDefault() JSRemoteInspectorSetInspectionEnabledByDefault(false) // initialize the JSContext, disable remote inspection explicitly. JSRemoteInspectorSetInspectionEnabledByDefault(previous) 410066 2020-09-29 16:33:41 -0700 2020-09-30 09:35:05 -0700 Proposed Fix bug-217109-20200929163341.patch text/plain 2003 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NzY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMwZGE0MzVmOTcxZjA2ZWJl YTI4YWIzM2JlYTgzYTUzYTcxNmZiNDguLmEzY2Y4YTY5ZWRmYzAzOWUyOTlhYTc2NjRkZjA2YmNi NzM4YTBiZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDktMjkgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogZXhlbXB0IEFQ STo6U2hhcmVkSlNDb250ZXh0IGZyb20gcmVtb3RlIGluc3BlY3Rpb24gYW5kIGF1dG9tYXRpYyBp bnNwZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTcxMDkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY5Mzg2NTU5PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGhhdmUgc2VlbiBvY2Nhc2lv bmFsIHVuZXhwZWN0ZWQgc3BpbnMgdW5kZXJuZWF0aCBwYXVzZVdhaXRpbmdGb3JSZW1vdGVJbnNw ZWN0aW9uKCkgd2FpdGluZworICAgICAgICBmb3IgdGhpcyBKU0NvbnRleHQuIFNpbmNlIGl0IGRv ZXMgbm90IGV2YWx1YXRlIEphdmFTY3JpcHQgYW5kIGlzIFdlYktpdC1pbnRlcm5hbCwgc2ltcGx5 IGRpc2FibGUKKyAgICAgICAgcmVtb3RlIGluc3BlY3Rpb24gZm9yIHRoZSBKU0NvbnRleHQuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL0FQSVNlcmlhbGl6ZWRTY3JpcHRWYWx1ZUNv Y29hLm1tOgorICAgICAgICAoQVBJOjpTaGFyZWRKU0NvbnRleHQ6OmVuc3VyZUNvbnRleHQpOgor CiAyMDIwLTA5LTI5ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgTW92ZSBOZXR3b3JrUHJvY2Vzc1Byb3h5IG93bmVyc2hpcCBmcm9tIFdlYlBy b2Nlc3NQb29sIHRvIFdlYnNpdGVEYXRhU3RvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9Db2NvYS9BUElTZXJpYWxpemVkU2NyaXB0VmFsdWVDb2NvYS5tbSBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9BUElTZXJpYWxpemVkU2NyaXB0VmFsdWVD b2NvYS5tbQppbmRleCAxZTYzMzg0NzE5MTJjYzMzYTg4YjY4MzRlOGZiOTY5OTk1YWJlNzM2Li4y ZWI3NWNlOTFmNWJkM2IzMTk5NDk1MzEzNTJmZDliYzJlMTA5YTdhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvQVBJU2VyaWFsaXplZFNjcmlwdFZhbHVlQ29j b2EubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL0FQSVNlcmlhbGl6 ZWRTY3JpcHRWYWx1ZUNvY29hLm1tCkBAIC0yNyw3ICsyNyw3IEBACiAjaW1wb3J0ICJBUElTZXJp YWxpemVkU2NyaXB0VmFsdWUuaCIKIAogI2ltcG9ydCA8SmF2YVNjcmlwdENvcmUvQVBJQ2FzdC5o PgotI2ltcG9ydCA8SmF2YVNjcmlwdENvcmUvSlNDb250ZXh0Lmg+CisjaW1wb3J0IDxKYXZhU2Ny aXB0Q29yZS9KU0NvbnRleHRQcml2YXRlLmg+CiAjaW1wb3J0IDxKYXZhU2NyaXB0Q29yZS9KU0ds b2JhbE9iamVjdElubGluZXMuaD4KICNpbXBvcnQgPEphdmFTY3JpcHRDb3JlL0pTVmFsdWUuaD4K ICNpbXBvcnQgPHd0Zi9OZXZlckRlc3Ryb3llZC5oPgpAQCAtNDYsNiArNDYsNyBAQCBwdWJsaWM6 CiAgICAgewogICAgICAgICBpZiAoIW1fY29udGV4dCkgewogICAgICAgICAgICAgbV9jb250ZXh0 ID0gYWRvcHROUyhbW0pTQ29udGV4dCBhbGxvY10gaW5pdF0pOworICAgICAgICAgICAgW21fY29u dGV4dCBfc2V0UmVtb3RlSW5zcGVjdGlvbkVuYWJsZWQ6Tk9dOwogICAgICAgICAgICAgbV90aW1l ci5zdGFydE9uZVNob3QoMV9zKTsKICAgICAgICAgfQogICAgICAgICByZXR1cm4gbV9jb250ZXh0 LmdldCgpOwo=