217107 2020-09-29 15:24:41 -0700 Fix EXT_color_buffer_half_float on iOS 2021-02-05 16:10:37 -0800 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 216010 126404 1 jdarpinian jdarpinian dino ews-watchlist graouts kbr kondapallykalyan thomas.kranz webkit-bug-importer oldest_to_newest 1693182 0 jdarpinian 2020-09-29 15:24:41 -0700 Fix EXT_color_buffer_half_float on iOS 1693183 1 410058 jdarpinian 2020-09-29 15:25:14 -0700 Created attachment 410058 Patch 1693184 2 ews-watchlist 2020-09-29 15:26:10 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1693186 3 jdarpinian 2020-09-29 15:26:58 -0700 *** Bug 216998 has been marked as a duplicate of this bug. *** 1693191 4 410058 kbr 2020-09-29 15:48:20 -0700 Comment on attachment 410058 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410058&action=review Looks good; one small question. r+ > Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp:296 > + functions->hasExtension("GL_EXT_color_buffer_half_float")) Should this be "hasGLESExtension" (here and upstream)? 1693193 5 410061 jdarpinian 2020-09-29 15:52:16 -0700 Created attachment 410061 Patch 1693194 6 410058 jdarpinian 2020-09-29 15:53:25 -0700 Comment on attachment 410058 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410058&action=review >> Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp:296 >> + functions->hasExtension("GL_EXT_color_buffer_half_float")) > > Should this be "hasGLESExtension" (here and upstream)? Sure, it doesn't make a difference here because the GLES check is redundant to the one in isAtLeastGLES, but it makes sense to be consistent. 1693217 7 ews-feeder 2020-09-29 16:32:02 -0700 Committed r267770: <https://trac.webkit.org/changeset/267770> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410061. 1693218 8 webkit-bug-importer 2020-09-29 16:33:15 -0700 <rdar://problem/69768975> 1724180 9 thomas.kranz 2021-02-01 03:19:21 -0800 As of iOS/iPadOS 14.4, this does not seem to be fixed for WebGL2 contexts. It DOES work with Safari on macOS. The extension is reported for WebGL on both platforms. 1725482 10 kbr 2021-02-03 21:23:51 -0800 The ANGLE backend for WebGL 2.0 hasn't shipped in Safari on iOS yet, I'm afraid. As soon as WebGL 2.0 is enabled by default on iOS - no longer experimentally - this will work. 1725970 11 thomas.kranz 2021-02-05 01:15:33 -0800 Oops, please forgive my unattentive reading of the ticket. :( I suppose we don't have a timeframe for the switch on iOS, do we? 1726317 12 kbr 2021-02-05 16:10:37 -0800 I'm afraid we don't. 410058 2020-09-29 15:25:14 -0700 2020-09-29 15:52:15 -0700 Patch bug-217107-20200929152513.patch text/plain 3091 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggOTFjYTUyYWIwMGE2ZWE5ZTZhNGU1ZDIwM2JmYjE3YWZmY2ZlZDNiZi4uODY0ZGEwZWIyMTYx YTAxMDYyMzhmZjNiNjRjNzFhNDg1ZTc4NzYyNCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA5LTI5ICBKYW1lcyBEYXJwaW5pYW4gIDxqZGFycGlu aWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggRVhUX2NvbG9yX2J1ZmZlcl9oYWxmX2Zs b2F0IG9uIGlPUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjE3MTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBzcmMvbGliQU5HTEUvQ29udGV4dC5jcHA6CisgICAgICAgIChnbDo6Q29udGV4dDo6Z2Vu ZXJhdGVTdXBwb3J0ZWRFeHRlbnNpb25zIGNvbnN0KToKKyAgICAgICAgKiBzcmMvbGliQU5HTEUv cmVuZGVyZXIvZ2wvcmVuZGVyZXJnbF91dGlscy5jcHA6CisgICAgICAgIChyeDo6bmF0aXZlZ2xf Z2w6OkdlbmVyYXRlVGV4dHVyZUZvcm1hdENhcHMpOgorCiAyMDIwLTA5LTI0ICBEZWFuIEphY2tz b24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJHTCBzaG91bGQgdXNlIEdMRVMgaW4g aU9TIGFwcHMgcnVubmluZyBvbiBBcHBsZSBTaWxpY29uCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhp cmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvQ29udGV4dC5jcHAgYi9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9zcmMvbGliQU5HTEUvQ29udGV4dC5jcHAKaW5kZXggZGNjYzhhNzg4NDFiMjU4MmMx YTg5Y2JjZTM5Yjk0NTgyZTM4N2JmNS4uMWZlZTc1MGVjNmJkMTlhNmU3MjAxOTE0YTZmM2Y4MGQ5 YmEwMDQ1YiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xF L0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9D b250ZXh0LmNwcApAQCAtMzE5Miw3ICszMTkyLDcgQEAgRXh0ZW5zaW9ucyBDb250ZXh0OjpnZW5l cmF0ZVN1cHBvcnRlZEV4dGVuc2lvbnMoKSBjb25zdAogICAgICAgICAvLyBXZSByZXF1aXJlIGNv bG9yQnVmZmVyRmxvYXQgdG8gYmUgcHJlc2VudCBpbiBvcmRlciB0byBlbmFibGUgY29sb3JCdWZm ZXJIYWxmRmxvYXQsIHNvCiAgICAgICAgIC8vIHRoYXQgYmxpdHRpbmcgaXMgYWx3YXlzIGFsbG93 ZWQgaWYgdGhlIHJlcXVlc3RlZCBmb3JtYXRzIGFyZSBleHBvc2VkIGFuZCBoYXZlIHRoZSBjb3Jy ZWN0CiAgICAgICAgIC8vIGZlYXR1cmUgY2FwYWJpbGl0aWVzCi0gICAgICAgIGlmICghc3VwcG9y dGVkRXh0ZW5zaW9ucy5jb2xvckJ1ZmZlckZsb2F0KQorICAgICAgICBpZiAoIXN1cHBvcnRlZEV4 dGVuc2lvbnMuY29sb3JCdWZmZXJGbG9hdCAmJiAhbVdlYkdMQ29udGV4dCkKICAgICAgICAgewog ICAgICAgICAgICAgc3VwcG9ydGVkRXh0ZW5zaW9ucy5jb2xvckJ1ZmZlckhhbGZGbG9hdCA9IGZh bHNlOwogICAgICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMv bGliQU5HTEUvcmVuZGVyZXIvZ2wvcmVuZGVyZXJnbF91dGlscy5jcHAgYi9Tb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvcmVuZGVyZXJnbF91dGlscy5jcHAK aW5kZXggNDcyZTM0MDY5ZjU4MTk4ZTMyNmJhOTUzMjllYjRhM2JmYmVjMmQyOC4uMmY2YTZiNmE2 ZTExNDg3NGU5NDU0YmY4ODI2NWEyYmI1Y2E4ODE2YiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL2dsL3JlbmRlcmVyZ2xfdXRpbHMuY3Bw CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9nbC9y ZW5kZXJlcmdsX3V0aWxzLmNwcApAQCAtMjg4LDYgKzI4OCwxOCBAQCBzdGF0aWMgZ2w6OlRleHR1 cmVDYXBzIEdlbmVyYXRlVGV4dHVyZUZvcm1hdENhcHMoY29uc3QgRnVuY3Rpb25zR0wgKmZ1bmN0 aW9ucywKICAgICB0ZXh0dXJlQ2Fwcy5ibGVuZGFibGUgICAgICAgICA9IHRleHR1cmVDYXBzLnJl bmRlcmJ1ZmZlciB8fCB0ZXh0dXJlQ2Fwcy50ZXh0dXJlQXR0YWNobWVudDsKIAogICAgIC8vIERv IGV4dHJhIHJlbmRlcmFiaWxpdHkgdmFsaWRhdGlvbiBmb3Igc29tZSBmb3JtYXRzLgorICAgIGlm IChpbnRlcm5hbEZvcm1hdCA9PSBHTF9SMTZGIHx8IGludGVybmFsRm9ybWF0ID09IEdMX1JHMTZG IHx8IGludGVybmFsRm9ybWF0ID09IEdMX1JHQjE2RikKKyAgICB7CisgICAgICAgIC8vIFN1cHBv cnRSZXF1aXJlbWVudCBjYW4ndCBjdXJyZW50bHkgZXhwcmVzcyBhIGNvbmRpdGlvbiBvZiB0aGUg Zm9ybSAodmVyc2lvbiAmJiBleHRlbnNpb24pCisgICAgICAgIC8vIHx8IG90aGVyIGV4dGVuc2lv bnMsIHNvIGRvIHRoZSAodmVyc2lvbiAmJiBleHRlbnNpb24pIHBhcnQgaGVyZS4KKyAgICAgICAg aWYgKGZ1bmN0aW9ucy0+aXNBdExlYXN0R0xFUyhnbDo6VmVyc2lvbigzLCAwKSkgJiYKKyAgICAg ICAgICAgIGZ1bmN0aW9ucy0+aGFzRXh0ZW5zaW9uKCJHTF9FWFRfY29sb3JfYnVmZmVyX2hhbGZf ZmxvYXQiKSkKKyAgICAgICAgeworICAgICAgICAgICAgdGV4dHVyZUNhcHMudGV4dHVyZUF0dGFj aG1lbnQgPSB0cnVlOworICAgICAgICAgICAgdGV4dHVyZUNhcHMucmVuZGVyYnVmZmVyICAgICAg PSB0cnVlOworICAgICAgICB9CisgICAgfQorCiAgICAgLy8gV2UgcmVxdWlyZSBHTF9SR0JBMTZG IGlzIHJlbmRlcmFibGUgdG8gZXhwb3NlIEVYVF9jb2xvcl9idWZmZXJfaGFsZl9mbG9hdCBidXQg d2UgY2FuJ3Qga25vdwogICAgIC8vIGlmIHRoZSBmb3JtYXQgaXMgc3VwcG9ydGVkIHVubGVzcyB3 ZSB0cnkgdG8gY3JlYXRlIGEgZnJhbWVidWZmZXIuCiAgICAgaWYgKGludGVybmFsRm9ybWF0ID09 IEdMX1JHQkExNkYpCg== 410061 2020-09-29 15:52:16 -0700 2020-09-29 16:32:03 -0700 Patch bug-217107-20200929155216.patch text/plain 3096 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggOTFjYTUyYWIwMGE2ZWE5ZTZhNGU1ZDIwM2JmYjE3YWZmY2ZlZDNiZi4uYjE3OWJjZmNkNmQ5 MGVmOGFjNjYxMGI2ZDhiMTdkNmQ0MjAzNjFiYyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA5LTI5ICBKYW1lcyBEYXJwaW5pYW4gIDxqZGFycGlu aWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggRVhUX2NvbG9yX2J1ZmZlcl9oYWxmX2Zs b2F0IG9uIGlPUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjE3MTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSdXNzZWxsLgorCisgICAg ICAgICogc3JjL2xpYkFOR0xFL0NvbnRleHQuY3BwOgorICAgICAgICAoZ2w6OkNvbnRleHQ6Omdl bmVyYXRlU3VwcG9ydGVkRXh0ZW5zaW9ucyBjb25zdCk6CisgICAgICAgICogc3JjL2xpYkFOR0xF L3JlbmRlcmVyL2dsL3JlbmRlcmVyZ2xfdXRpbHMuY3BwOgorICAgICAgICAocng6Om5hdGl2ZWds X2dsOjpHZW5lcmF0ZVRleHR1cmVGb3JtYXRDYXBzKToKKwogMjAyMC0wOS0yNCAgRGVhbiBKYWNr c29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViR0wgc2hvdWxkIHVzZSBHTEVTIGlu IGlPUyBhcHBzIHJ1bm5pbmcgb24gQXBwbGUgU2lsaWNvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1Ro aXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL0NvbnRleHQuY3BwIGIvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvc3JjL2xpYkFOR0xFL0NvbnRleHQuY3BwCmluZGV4IGRjY2M4YTc4ODQxYjI1ODJj MWE4OWNiY2UzOWI5NDU4MmUzODdiZjUuLjFmZWU3NTBlYzZiZDE5YTZlNzIwMTkxNGE2ZjNmODBk OWJhMDA0NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdM RS9Db250ZXh0LmNwcAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUv Q29udGV4dC5jcHAKQEAgLTMxOTIsNyArMzE5Miw3IEBAIEV4dGVuc2lvbnMgQ29udGV4dDo6Z2Vu ZXJhdGVTdXBwb3J0ZWRFeHRlbnNpb25zKCkgY29uc3QKICAgICAgICAgLy8gV2UgcmVxdWlyZSBj b2xvckJ1ZmZlckZsb2F0IHRvIGJlIHByZXNlbnQgaW4gb3JkZXIgdG8gZW5hYmxlIGNvbG9yQnVm ZmVySGFsZkZsb2F0LCBzbwogICAgICAgICAvLyB0aGF0IGJsaXR0aW5nIGlzIGFsd2F5cyBhbGxv d2VkIGlmIHRoZSByZXF1ZXN0ZWQgZm9ybWF0cyBhcmUgZXhwb3NlZCBhbmQgaGF2ZSB0aGUgY29y cmVjdAogICAgICAgICAvLyBmZWF0dXJlIGNhcGFiaWxpdGllcwotICAgICAgICBpZiAoIXN1cHBv cnRlZEV4dGVuc2lvbnMuY29sb3JCdWZmZXJGbG9hdCkKKyAgICAgICAgaWYgKCFzdXBwb3J0ZWRF eHRlbnNpb25zLmNvbG9yQnVmZmVyRmxvYXQgJiYgIW1XZWJHTENvbnRleHQpCiAgICAgICAgIHsK ICAgICAgICAgICAgIHN1cHBvcnRlZEV4dGVuc2lvbnMuY29sb3JCdWZmZXJIYWxmRmxvYXQgPSBm YWxzZTsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3Jj L2xpYkFOR0xFL3JlbmRlcmVyL2dsL3JlbmRlcmVyZ2xfdXRpbHMuY3BwIGIvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL2dsL3JlbmRlcmVyZ2xfdXRpbHMuY3Bw CmluZGV4IDQ3MmUzNDA2OWY1ODE5OGUzMjZiYTk1MzI5ZWI0YTNiZmJlYzJkMjguLjI1MGZjMTdh ZTdiNDczNTY3MGY0OThlZjZiY2U3M2Y1N2E2OWU4MWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGly ZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9nbC9yZW5kZXJlcmdsX3V0aWxzLmNw cAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wv cmVuZGVyZXJnbF91dGlscy5jcHAKQEAgLTI4OCw2ICsyODgsMTggQEAgc3RhdGljIGdsOjpUZXh0 dXJlQ2FwcyBHZW5lcmF0ZVRleHR1cmVGb3JtYXRDYXBzKGNvbnN0IEZ1bmN0aW9uc0dMICpmdW5j dGlvbnMsCiAgICAgdGV4dHVyZUNhcHMuYmxlbmRhYmxlICAgICAgICAgPSB0ZXh0dXJlQ2Fwcy5y ZW5kZXJidWZmZXIgfHwgdGV4dHVyZUNhcHMudGV4dHVyZUF0dGFjaG1lbnQ7CiAKICAgICAvLyBE byBleHRyYSByZW5kZXJhYmlsaXR5IHZhbGlkYXRpb24gZm9yIHNvbWUgZm9ybWF0cy4KKyAgICBp ZiAoaW50ZXJuYWxGb3JtYXQgPT0gR0xfUjE2RiB8fCBpbnRlcm5hbEZvcm1hdCA9PSBHTF9SRzE2 RiB8fCBpbnRlcm5hbEZvcm1hdCA9PSBHTF9SR0IxNkYpCisgICAgeworICAgICAgICAvLyBTdXBw b3J0UmVxdWlyZW1lbnQgY2FuJ3QgY3VycmVudGx5IGV4cHJlc3MgYSBjb25kaXRpb24gb2YgdGhl IGZvcm0gKHZlcnNpb24gJiYgZXh0ZW5zaW9uKQorICAgICAgICAvLyB8fCBvdGhlciBleHRlbnNp b25zLCBzbyBkbyB0aGUgKHZlcnNpb24gJiYgZXh0ZW5zaW9uKSBwYXJ0IGhlcmUuCisgICAgICAg IGlmIChmdW5jdGlvbnMtPmlzQXRMZWFzdEdMRVMoZ2w6OlZlcnNpb24oMywgMCkpICYmCisgICAg ICAgICAgICBmdW5jdGlvbnMtPmhhc0dMRVNFeHRlbnNpb24oIkdMX0VYVF9jb2xvcl9idWZmZXJf aGFsZl9mbG9hdCIpKQorICAgICAgICB7CisgICAgICAgICAgICB0ZXh0dXJlQ2Fwcy50ZXh0dXJl QXR0YWNobWVudCA9IHRydWU7CisgICAgICAgICAgICB0ZXh0dXJlQ2Fwcy5yZW5kZXJidWZmZXIg ICAgICA9IHRydWU7CisgICAgICAgIH0KKyAgICB9CisKICAgICAvLyBXZSByZXF1aXJlIEdMX1JH QkExNkYgaXMgcmVuZGVyYWJsZSB0byBleHBvc2UgRVhUX2NvbG9yX2J1ZmZlcl9oYWxmX2Zsb2F0 IGJ1dCB3ZSBjYW4ndCBrbm93CiAgICAgLy8gaWYgdGhlIGZvcm1hdCBpcyBzdXBwb3J0ZWQgdW5s ZXNzIHdlIHRyeSB0byBjcmVhdGUgYSBmcmFtZWJ1ZmZlci4KICAgICBpZiAoaW50ZXJuYWxGb3Jt YXQgPT0gR0xfUkdCQTE2RikK