217096 2020-09-29 11:12:51 -0700 Modify END_AX_OBJC_EXCEPTIONS macro to assert to aid debugging of layout tests. 2020-09-29 18:06:24 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 cfleizach webkit-bug-importer oldest_to_newest 1693026 0 andresg_22 2020-09-29 11:12:51 -0700 Modify END_AX_OBJC_EXCEPTIONS macro to assert to aid debugging of layout tests. 1693032 1 410024 andresg_22 2020-09-29 11:19:21 -0700 Created attachment 410024 Patch 1693033 2 410024 cfleizach 2020-09-29 11:21:48 -0700 Comment on attachment 410024 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410024&action=review > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:38 > + ASSERT_NOT_REACHED(); \ if we're going to assert here, do we even need to do anything else? 1693043 3 andresg_22 2020-09-29 11:34:54 -0700 (In reply to chris fleizach from comment #2) > Comment on attachment 410024 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410024&action=review > > > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:38 > > + ASSERT_NOT_REACHED(); \ > > if we're going to assert here, do we even need to do anything else? The original intention is to re-throw the exceptions that are not NSAccessibilityExceptions. So I wouldn't want to change that behavior in release builds in case someone/something depends on it. 1693256 4 ews-feeder 2020-09-29 18:05:38 -0700 Committed r267774: <https://trac.webkit.org/changeset/267774> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410024. 1693257 5 webkit-bug-importer 2020-09-29 18:06:24 -0700 <rdar://problem/69772194> 410024 2020-09-29 11:19:21 -0700 2020-09-29 18:05:38 -0700 Patch bug-217096-20200929141920.patch text/plain 2019 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NTc5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzk0ZjJmYzQwODFmMTc0MDBiMzk1NjlkZDg1MzQwZmI3 MTQxMWI0YS4uOWQ3N2ExZWFmOWI3NmIxYjg2OWZlMDlhNDViZTlmNTc3NTdmOWMyOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIwLTA5LTI5ICBBbmRyZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4K KworICAgICAgICBNb2RpZnkgRU5EX0FYX09CSkNfRVhDRVBUSU9OUyBtYWNybyB0byBhc3NlcnQg dG8gYWlkIGRlYnVnZ2luZyBvZiBsYXlvdXQgdGVzdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTcwOTYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQgb24gdGhyb3duIGV4 Y2VwdGlvbnMuIFRoaXMgd2lsbCB0ZWxsIHVzIGltbWVkaWF0ZWx5CisgICAgICAgIHRoZSBsb2Nh dGlvbiBvZiBhIGZhaWx1cmUgaW5zdGVhZCBvZiBzaWxlbnRseSBzd2FsbG93aW5nIHRoZSBleGNl cHRpb24KKyAgICAgICAgYW5kIHBvc2libHkgY2F1c2luZyBhIGhhbmcvdGltZW91dCBtdWNoIGhh cmRlciB0byBmaW5kIGFmdGVyIHRoZSBmYWN0LgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5l ci9JbmplY3RlZEJ1bmRsZS9tYWMvQWNjZXNzaWJpbGl0eUNvbW1vbk1hYy5oOgorCiAyMDIwLTA5 LTI1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICByZXN1 bHRzLndlYmtpdC5vcmc6IFVzZSBzMyBmb3IgY29sZCBzdG9yYWdlCmRpZmYgLS1naXQgYS9Ub29s cy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL21hYy9BY2Nlc3NpYmlsaXR5Q29tbW9u TWFjLmggYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL21hYy9BY2Nlc3Np YmlsaXR5Q29tbW9uTWFjLmgKaW5kZXggMTE3NDgxYjhkYjU2ZDE5NmU0YmRkZjZmZThkYjllYzJj YWYwMjc4NS4uZTdhMjBiNzVjNGNjOWE2YzZjOTc0ODczZDdmZGZiNzRjZWQwMDJiNCAxMDA2NDQK LS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9tYWMvQWNjZXNzaWJp bGl0eUNvbW1vbk1hYy5oCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5k bGUvbWFjL0FjY2Vzc2liaWxpdHlDb21tb25NYWMuaApAQCAtMzQsNyArMzQsMTEgQEAKIC8vIElm IGFuIHVuc3VwcG9ydGVkIGF0dHJpYnV0ZSBpcyBwYXNzZWQgaW4sIGl0IHdpbGwgcmFpc2UgYW4g YWNjZXNzaWJpbGl0eSBleGNlcHRpb24uIFRoZXNlIGFyZSB1c3VhbGx5IGNhdWdodCBieSB0aGUg QWNjZXNzaWJpbGl0eSBSdW50aW1lIHRvIGluZm9ybQogLy8gdGhlIEFYIGNsaWVudCBhcHAgb2Yg dGhlIGVycm9yLiBIb3dldmVyLCBEUlQgaXMgdGhlIEFYIGNsaWVudCBhcHAsIHNvIGl0IG11c3Qg Y2F0Y2ggdGhlc2UgZXhjZXB0aW9ucy4KICNkZWZpbmUgQkVHSU5fQVhfT0JKQ19FWENFUFRJT05T IEB0cnkgewotI2RlZmluZSBFTkRfQVhfT0JKQ19FWENFUFRJT05TIH0gQGNhdGNoKE5TRXhjZXB0 aW9uICplKSB7IGlmICghW1tlIG5hbWVdIGlzRXF1YWxUb1N0cmluZzpOU0FjY2Vzc2liaWxpdHlF eGNlcHRpb25dKSBAdGhyb3c7IH0KKyNkZWZpbmUgRU5EX0FYX09CSkNfRVhDRVBUSU9OUyB9IEBj YXRjaChOU0V4Y2VwdGlvbiAqZSkgeyBcCisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7IFwKKyAg ICBpZiAoIVtlLm5hbWUgaXNFcXVhbFRvU3RyaW5nOk5TQWNjZXNzaWJpbGl0eUV4Y2VwdGlvbl0p IFwKKyAgICAgICAgQHRocm93OyBcCisgICAgfQogCiBAaW50ZXJmYWNlIE5TU3RyaW5nIChKU1N0 cmluZ1JlZkFkZGl0aW9ucykKICsgKE5TU3RyaW5nICopc3RyaW5nV2l0aEpTU3RyaW5nUmVmOihK U1N0cmluZ1JlZilqc1N0cmluZ1JlZjsK