217079 2020-09-28 23:36:40 -0700 REGRESSION(r259582): Build fails on aarch64 Linux with WebKit 2.30.1 on LLIntOffsetsExtractor.cpp.o 2020-09-30 17:01:46 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Other Linux REOPENED InRadar P2 Normal --- 217135 1 guillaume.gardet webkit-unassigned benjamin cdumez cmarcelo commit-queue ews-watchlist keith_miller mark.lam mcatanzaro mgorse msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1692841 0 guillaume.gardet 2020-09-28 23:36:40 -0700 Build failed on aarch64 Linux with WebKit 2.30.1 with GCC 10.2. [ 214s] FAILED: Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o [ 214s] /usr/bin/ccache /var/lib/build/ccache/bin/c++ -DBUILDING_GTK__=1 -DBUILDING_WITH_CMAKE=1 -DBWRAP_EXECUTABLE=\"/usr/bin/bwrap\" -DDBUS_PROXY_EXECUTABLE=\"/usr/bin/xdg-dbus-proxy\" -DGETTEXT_PACKAGE=\"WebKit2GTK-4.0\" -DHAVE_CONFIG_H=1 -DJSC_COMPILATION -DJSC_GLIB_API_ENABLED -DSTATICALLY_LINKED_WITH_WTF -DSVN_REVISION=\"tarball\" -DWEBKITGTK_API_VERSION_STRING=\"4.0\" -IDerivedSources/ForwardingHeaders -I. -I../Source/JavaScriptCore -I../Source/JavaScriptCore/API -I../Source/JavaScriptCore/assembler -I../Source/JavaScriptCore/b3 -I../Source/JavaScriptCore/b3/air -I../Source/JavaScriptCore/bindings -I../Source/JavaScriptCore/builtins -I../Source/JavaScriptCore/bytecode -I../Source/JavaScriptCore/bytecompiler -I../Source/JavaScriptCore/dfg -I../Source/JavaScriptCore/disassembler -I../Source/JavaScriptCore/disassembler/ARM64 -I../Source/JavaScriptCore/disassembler/udis86 -I../Source/JavaScriptCore/domjit -I../Source/JavaScriptCore/ftl -I../Source/JavaScriptCore/heap -I../Source/JavaScriptCore/debugger -I../Source/JavaScriptCore/inspector -I../Source/JavaScriptCore/inspector/agents -I../Source/JavaScriptCore/inspector/augmentable -I../Source/JavaScriptCore/inspector/remote -I../Source/JavaScriptCore/interpreter -I../Source/JavaScriptCore/jit -I../Source/JavaScriptCore/llint -I../Source/JavaScriptCore/parser -I../Source/JavaScriptCore/profiler -I../Source/JavaScriptCore/runtime -I../Source/JavaScriptCore/tools -I../Source/JavaScriptCore/wasm -I../Source/JavaScriptCore/wasm/js -I../Source/JavaScriptCore/yarr -IDerivedSources/JavaScriptCore -IDerivedSources/JavaScriptCore/inspector -IDerivedSources/JavaScriptCore/runtime -IDerivedSources/JavaScriptCore/yarr -IDerivedSources/ForwardingHeaders/JavaScriptCore/glib -IDerivedSources/JavaScriptCore/javascriptcoregtk/jsc -I../Source/JavaScriptCore/API/glib -IDerivedSources/JavaScriptCore/javascriptcoregtk -I../Source/JavaScriptCore/inspector/remote/glib -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include -fdiagnostics-color=always -Wextra -Wall -Wno-expansion-to-defined -Wno-noexcept-type -Wno-psabi -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -g1 -Wl,--no-keep-memory -DNDEBUG -fno-strict-aliasing -fno-exceptions -fno-rtti -O3 -DNDEBUG -fPIE -std=c++17 -MD -MT Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o -MF Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o.d -o Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o -c ../Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp [ 214s] In file included from ../Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:30, [ 214s] from ../Source/JavaScriptCore/assembler/MacroAssembler.h:46, [ 214s] from ../Source/JavaScriptCore/jit/GPRInfo.h:28, [ 214s] from ../Source/JavaScriptCore/bytecode/ArithProfile.h:28, [ 214s] from ../Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:28: [ 214s] ../Source/JavaScriptCore/assembler/ARM64Assembler.h: In static member function 'static void JSC::ARM64Assembler::replaceWithJump(void*, void*)': [ 214s] ../Source/JavaScriptCore/assembler/ARM64Assembler.h:2576:51: error: 'class JSC::ExecutableAllocator' has no member named 'getJumpIslandTo' [ 214s] 2576 | to = ExecutableAllocator::singleton().getJumpIslandTo(where, to); [ 214s] | ^~~~~~~~~~~~~~~ [ 214s] ../Source/JavaScriptCore/assembler/ARM64Assembler.h: In static member function 'static void* JSC::ARM64Assembler::prepareForAtomicRelinkJumpConcurrently(void*, void*)': [ 214s] ../Source/JavaScriptCore/assembler/ARM64Assembler.h:2781:49: error: 'class JSC::ExecutableAllocator' has no member named 'getJumpIslandToConcurrently' [ 214s] 2781 | return ExecutableAllocator::singleton().getJumpIslandToConcurrently(from, to); [ 214s] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ [ 214s] ../Source/JavaScriptCore/assembler/ARM64Assembler.h: In static member function 'static void JSC::ARM64Assembler::linkJumpOrCall(int*, const int*, void*)': [ 214s] ../Source/JavaScriptCore/assembler/ARM64Assembler.h:3024:51: error: 'class JSC::ExecutableAllocator' has no member named 'getJumpIslandTo' [ 214s] 3024 | to = ExecutableAllocator::singleton().getJumpIslandTo(bitwise_cast<void*>(fromInstruction), to); [ 214s] | ^~~~~~~~~~~~~~~ 1692877 1 guillaume.gardet 2020-09-29 04:18:53 -0700 It was also failing with 2.30.0. 1692917 2 mgorse 2020-09-29 08:31:36 -0700 We are currently passing -DENABLE_JIT=OFF on aarch64. 1693015 3 mcatanzaro 2020-09-29 11:00:12 -0700 Looks like this broke in r259582 "Implement 1GB of executable memory on arm64" 1693160 4 mgorse 2020-09-29 14:39:22 -0700 I tried patching wtf/Platform.h to only define USE_JUMP_ISLANDS if JIT is enabled, but now I get this failure, related to R262670 I think: ../Source/JavaScriptCore/assembler/LinkBuffer.cpp: In member function 'void JSC::LinkBuffer::copyCompactAndLinkCode(JSC::MacroAssembler&, JSC::JITCompilationEffort)': ../Source/JavaScriptCore/assembler/LinkBuffer.cpp:380:13: error: there are no arguments to 'dumpJITMemory' that depend on a template parameter, so a declaration of 'dumpJITMemory' must be available [-fpermissive] 1693242 5 410073 mgorse 2020-09-29 17:33:52 -0700 Created attachment 410073 Patch. 1693384 6 410073 mcatanzaro 2020-09-30 08:06:02 -0700 Comment on attachment 410073 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=410073&action=review > Source/JavaScriptCore/assembler/LinkBuffer.cpp:377 > + ASSERT(codeOutData == outData); Careful, the assert is different in the two codepaths! 1693396 7 410127 mgorse 2020-09-30 08:55:06 -0700 Created attachment 410127 Patch. Good catch. Fixed the asserts. 1693402 8 410127 mcatanzaro 2020-09-30 09:17:11 -0700 Comment on attachment 410127 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=410127&action=review > Source/JavaScriptCore/assembler/LinkBuffer.cpp:389 > + performJITMemcpy(codeOutData, outData, m_size); > +#endif // ENABLE_JIT I had to investigate why it's OK to call performJITMemcpy when JIT is disabled. Turns out it just does a memcpy. OK. 1693422 9 ews-feeder 2020-09-30 10:07:18 -0700 Committed r267795: <https://trac.webkit.org/changeset/267795> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410127. 1693424 10 webkit-bug-importer 2020-09-30 10:08:20 -0700 <rdar://problem/69796640> 1693433 11 410127 mark.lam 2020-09-30 10:35:45 -0700 Comment on attachment 410127 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=410127&action=review Please roll out this patch and fix the issues below. > Source/JavaScriptCore/assembler/LinkBuffer.cpp:377 > +#if ENABLE(JIT) This change doesn't make sense. LinkBuffer::copyCompactAndLinkCode() should only be built in if the assembler is enabled. Not only that, this change is actually wrong. If useFastJITPermissions() is true, we should not be doing the performJITMemcpy() here at all. You've actually introduced a bug. Fortunately, this bug will not manifest if ENABLE(JIT) is true. It still makes the code lie about what is correct and expected. I think the real fix for this should be to ensure that all the support for the ASSEMBLER is not built in if none of the JITs are enabled. For now, can you roll out this patch and move this ENABLE(JIT) this to just around the if statement for the dumpJITMemory? Also add a FIXME comment here that this is a temporary build fix until we can figure out why all this JIT and ASSEMBLER infrastructure is built in on Linux when JIT is disabled. You should also check why ENABLE(ASSEMBLER) is enabled for you. For example, do you have ENABLE(YARR_JIT) set to true, or do you have ENABLE(C_LOOP) set to false for your configuration? Maybe there's no bug there, but you should make sure. > Source/WTF/wtf/PlatformEnable.h:888 > +#if CPU(ARM64) && CPU(ADDRESS64) && ENABLE(JIT) This change also doesn't make sense. USE(JUMP_ISLANDS) should at most be dependent on ENABLE(ASSEMBLER), but it is only ever used in assembler code. Hence, this change should not be necessary at all. 1693436 12 410127 mark.lam 2020-09-30 10:37:50 -0700 Comment on attachment 410127 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=410127&action=review >> Source/WTF/wtf/PlatformEnable.h:888 >> +#if CPU(ARM64) && CPU(ADDRESS64) && ENABLE(JIT) > > This change also doesn't make sense. USE(JUMP_ISLANDS) should at most be dependent on ENABLE(ASSEMBLER), but it is only ever used in assembler code. Hence, this change should not be necessary at all. If there's no configuration issue on your part, adding this ENABLE(JIT) as a workaround is executable for now. Please add a FIXME to say that this is a temporary workaround (just like in my previous comment). 1693455 13 commit-queue 2020-09-30 11:19:09 -0700 Re-opened since this is blocked by bug 217135 1693460 14 mcatanzaro 2020-09-30 11:34:26 -0700 Mike, I've been talking with Mark about this. This build failure only occurs when cloop and JIT are both enabled. This is not a configuration that we *intentionally* use on Linux (although Apple uses it). Problem is I changed WebKitFeatures.cmake a while back to do the right thing on all architectures, so we no longer have to pass -DENABLE_JIT=OFF -DUSE_SYSTEM_MALLOC=ON. Except it really only does the right thing on all architectures *except* aarch64, where it's impossible to make the right choice without knowing system page size (which could be different on the builder than on the target system). So enterprise distros that support 64k pages still need to set these flags manually, but only for aarch64. Now here is my mistake: I used to have WebKitFeatures.cmake set up such that -DENABLE_JIT=OFF would set -DENABLE_C_LOOP=ON. And I assumed that was still the case, but it no longer is, because that code was no longer needed anymore now that it does the right thing for "all" architectures (oops). So you're ending up with cloop disabled by mistake, and that is why LinkBuffer.cpp is being compiled. I have the identical mistake in RHEL's build system too. So there are two problems: (a) you should build with -DENABLE_C_LOOP=ON. (b) this bug really should be fixed as Mark suggests, but it should only affect Apple ports because only Apple ports should be building this file with JIT disabled. P.S. There is no amazing reason to always enable cloop when JIT is disabled. Upstream WebKit has three options: cloop, asm llint, and JIT. We just simplify it down to two for Linux so there is one fewer case to think about. Hence, it's not wrong or horrible to ship with both cloop and JIT disabled, just not what I had intended. 1693461 15 mcatanzaro 2020-09-30 11:35:20 -0700 (In reply to Michael Catanzaro from comment #14) > Mike, I've been talking with Mark about this. This build failure only occurs > when cloop and JIT are both enabled. I meant: both disabled 1693466 16 mcatanzaro 2020-09-30 11:50:09 -0700 (In reply to Mark Lam from comment #11) > I think the real fix for this should be to ensure that all the support for > the ASSEMBLER is not built in if none of the JITs are enabled. I notice there are only a few ENABLE(JIT) guards under Source/JavaScriptCore/assembler: $ git grep 'ENABLE(JIT)' MacroAssemblerCodeRef.h:#if CPU(ARM_THUMB2) && ENABLE(JIT) testmasm.cpp:#if ENABLE(JIT) testmasm.cpp:#else // not ENABLE(JIT) testmasm.cpp:#endif // ENABLE(JIT) I also notice we have, in PlatformEnable.h: /* If either the JIT or the RegExp JIT is enabled, then the Assembler must be enabled as well: */ #if ENABLE(JIT) || ENABLE(YARR_JIT) || !ENABLE(C_LOOP) #if defined(ENABLE_ASSEMBLER) && !ENABLE_ASSEMBLER #error "Cannot enable the JIT or RegExp JIT without enabling the Assembler" #else #undef ENABLE_ASSEMBLER #define ENABLE_ASSEMBLER 1 #endif #endif So we could just remove || !ENABLE(C_LOOP) from the first line, and remove the test from MacroAssemblerCodeRef.h. (testmasm.cpp is built regardless of whether JIT is enabled.) 1693471 17 mark.lam 2020-09-30 11:54:03 -0700 (In reply to Michael Catanzaro from comment #16) > (In reply to Mark Lam from comment #11) > > I think the real fix for this should be to ensure that all the support for > > the ASSEMBLER is not built in if none of the JITs are enabled. > > I notice there are only a few ENABLE(JIT) guards under > Source/JavaScriptCore/assembler: > > $ git grep 'ENABLE(JIT)' > MacroAssemblerCodeRef.h:#if CPU(ARM_THUMB2) && ENABLE(JIT) > testmasm.cpp:#if ENABLE(JIT) > testmasm.cpp:#else // not ENABLE(JIT) > testmasm.cpp:#endif // ENABLE(JIT) > > I also notice we have, in PlatformEnable.h: > > /* If either the JIT or the RegExp JIT is enabled, then the Assembler must be > enabled as well: */ > #if ENABLE(JIT) || ENABLE(YARR_JIT) || !ENABLE(C_LOOP) > #if defined(ENABLE_ASSEMBLER) && !ENABLE_ASSEMBLER > #error "Cannot enable the JIT or RegExp JIT without enabling the Assembler" > #else > #undef ENABLE_ASSEMBLER > #define ENABLE_ASSEMBLER 1 > #endif > #endif > > So we could just remove || !ENABLE(C_LOOP) from the first line, and remove > the test from MacroAssemblerCodeRef.h. (testmasm.cpp is built regardless of > whether JIT is enabled.) Yes, the assembler should not need to be on if we don't enable any JITs. I think this is an existing bug when building for the asm llint. It's something I'll look into eventually, but I don't think we should need to fix that right now to resolve this bug's build failure. But if you would like to try to fix it, that's fine too. 1693475 18 mcatanzaro 2020-09-30 12:00:57 -0700 Ah, actually there is a flaw in my plan. If we have ENABLE_JIT=ON but ENABLE_YARR_JIT=OFF, then we need ENABLE_ASSEMBLER=ON. I don't know why that should be supported -- it smells like too many build configurations -- but it does mean that ENABLE_ASSEMBLER=ON cannot currently assume ENABLE_JIT=ON (unless we change that). 1693476 19 mcatanzaro 2020-09-30 12:01:38 -0700 (In reply to Michael Catanzaro from comment #18) > If we have ENABLE_JIT=ON but > ENABLE_YARR_JIT=OFF, then we need ENABLE_ASSEMBLER=ON. I guess I'm really backwards today. I meant: "if we have ENABLE_JIT=OFF but ENABLE_YARR_JIT=ON, then we need ENABLE_ASSEMBLER=ON" 1693570 20 mgorse 2020-09-30 16:18:27 -0700 Thanks. If I pass -DENABLE_C_LOOP=ON to cmake, then I get a successful build (I also needed to pass -DENABLE_SAMPLING_PROFILER=OFF). I'll make that change to openSUSE / SLE. 1693583 21 mcatanzaro 2020-09-30 17:01:46 -0700 (In reply to Mike Gorse from comment #20) > Thanks. If I pass -DENABLE_C_LOOP=ON to cmake, then I get a successful build > (I also needed to pass -DENABLE_SAMPLING_PROFILER=OFF). > I'll make that change to openSUSE / SLE. And I'll make that change in RHEL. We really need to come up with something better for aarch64. :/ 410073 2020-09-29 17:33:52 -0700 2020-09-30 08:55:06 -0700 Patch. build.patch text/plain 2749 mgorse ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDk2ZTVlYTI3YzhiYS4uNWE1ZDM2ZjI0YmY1IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wOS0yOSAgTWlr ZSBHb3JzZSAgPG1nb3JzZUBzdXNlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNTk1ODIp OiBCdWlsZCBmYWlscyBvbiBhYXJjaDY0IExpbnV4IHdpdGggV2ViS2l0IDIuMzAuMSBvbiBMTElu dE9mZnNldHNFeHRyYWN0b3IuY3BwLm8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxNzA3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL0xpbmtCdWZmZXIuY3BwOgorICAgICAgICAoSlND OjpMaW5rQnVmZmVyOjpjb3B5Q29tcGFjdEFuZExpbmtDb2RlKTogRE9uJ3QgY29tcGlsZSBpbiBh IGNhbGwgdG8KKyAgICAgICAgZHVtcEpJVE1lbW9yeSBpZiBKSVQgaXMgZGlzYWJsZWQ7IGxlYWRz IHRvIGEgYnVpbGQgZmFpbHVyZS4KKwogMjAyMC0wOS0yNiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBh cHBsZS5jb20+CiAKICAgICAgICAgUmVmYWN0b3IgdGVzdCBydW5uZXIgY29kZSB0byBjdXQgZG93 biBvbiBjb3B5L3Bhc3RlIGNvZGUgYW5kIGxvbmctd2luZGVkIHJlcGV0aXRpdmUgaWRpb21zCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0xpbmtCdWZmZXIuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9MaW5rQnVmZmVyLmNwcAppbmRleCBi NjU3N2E5ZThjNGUuLmMwYzM3MDJhNGQzMSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9MaW5rQnVmZmVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL0xpbmtCdWZmZXIuY3BwCkBAIC0zNzQsMTQgKzM3NCwxNyBAQCB2b2lkIExpbmtC dWZmZXI6OmNvcHlDb21wYWN0QW5kTGlua0NvZGUoTWFjcm9Bc3NlbWJsZXImIG1hY3JvQXNzZW1i bGVyLCBKSVRDb21waQogICAgICAgICBtX2V4ZWN1dGFibGVNZW1vcnktPnNocmluayhtX3NpemUp OwogICAgIH0KIAorICAgIEFTU0VSVChjb2RlT3V0RGF0YSA9PSBvdXREYXRhKTsKKyNpZiBFTkFC TEUoSklUKQogICAgIGlmICh1c2VGYXN0SklUUGVybWlzc2lvbnMoKSkgewotICAgICAgICBBU1NF UlQoY29kZU91dERhdGEgPT0gb3V0RGF0YSk7CiAgICAgICAgIGlmIChVTkxJS0VMWShPcHRpb25z OjpkdW1wSklUTWVtb3J5UGF0aCgpKSkKICAgICAgICAgICAgIGR1bXBKSVRNZW1vcnkob3V0RGF0 YSwgb3V0RGF0YSwgbV9zaXplKTsKICAgICB9IGVsc2UgewotICAgICAgICBBU1NFUlQoY29kZU91 dERhdGEgIT0gb3V0RGF0YSk7CiAgICAgICAgIHBlcmZvcm1KSVRNZW1jcHkoY29kZU91dERhdGEs IG91dERhdGEsIG1fc2l6ZSk7CiAgICAgfQorI2Vsc2UKKyAgICBwZXJmb3JtSklUTWVtY3B5KGNv ZGVPdXREYXRhLCBvdXREYXRhLCBtX3NpemUpOworI2VuZGlmIC8vIEVOQUJMRV9KSVQKIAogICAg IGp1bXBzVG9MaW5rLmNsZWFyKCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9n IGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXggZDk1YTZkMTg1MDVjLi5mOWFjODBhNzdmOTUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDktMjkgIE1pa2UgR29yc2UgIDxtZ29yc2VAc3Vz ZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjU5NTgyKTogQnVpbGQgZmFpbHMgb24gYWFy Y2g2NCBMaW51eCB3aXRoIFdlYktpdCAyLjMwLjEgb24gTExJbnRPZmZzZXRzRXh0cmFjdG9yLmNw cC5vCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTcw NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0 Zi9QbGF0Zm9ybUVuYWJsZS5oOiBPbmx5IGRlZmluZSBVU0VfSlVNUF9JU0xBTkRTIGlmIEpJVCBp cyBlbmFibGVkLgorCiAyMDIwLTA5LTI5ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2Vu QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHBsaXN0LWJhc2VkIFJlc291cmNlTG9hZFN0 YXRpc3RpY3Mgc3RvcmFnZSwgd2hpY2ggaGFzIGJlZW4gcmVwbGFjZWQgYnkgZGF0YWJhc2UtYmFz ZWQgc3RvcmFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1FbmFibGUuaCBi L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtRW5hYmxlLmgKaW5kZXggOTE2NmNmZGQ5NTU0Li4zNjEx N2Q4ODIwODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtRW5hYmxlLmgKKysr IGIvU291cmNlL1dURi93dGYvUGxhdGZvcm1FbmFibGUuaApAQCAtODg1LDYgKzg4NSw2IEBACiAj ZXJyb3IgIkVOQUJMRShXSExTTF9DT01QSUxFUikgcmVxdWlyZXMgRU5BQkxFKFdFQkdQVSkiCiAj ZW5kaWYKIAotI2lmIENQVShBUk02NCkgJiYgQ1BVKEFERFJFU1M2NCkKKyNpZiBDUFUoQVJNNjQp ICYmIENQVShBRERSRVNTNjQpICYmIEVOQUJMRShKSVQpCiAjZGVmaW5lIFVTRV9KVU1QX0lTTEFO RFMgMQogI2VuZGlmCg== 410127 2020-09-30 08:55:06 -0700 2020-09-30 10:35:45 -0700 Patch. build.patch text/plain 2781 mgorse ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDk2ZTVlYTI3YzhiYS4uNWE1ZDM2ZjI0YmY1IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wOS0zMCAgTWlr ZSBHb3JzZSAgPG1nb3JzZUBzdXNlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNTk1ODIp OiBCdWlsZCBmYWlscyBvbiBhYXJjaDY0IExpbnV4IHdpdGggV2ViS2l0IDIuMzAuMSBvbiBMTElu dE9mZnNldHNFeHRyYWN0b3IuY3BwLm8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxNzA3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL0xpbmtCdWZmZXIuY3BwOgorICAgICAgICAoSlND OjpMaW5rQnVmZmVyOjpjb3B5Q29tcGFjdEFuZExpbmtDb2RlKTogRE9uJ3QgY29tcGlsZSBpbiBh IGNhbGwgdG8KKyAgICAgICAgZHVtcEpJVE1lbW9yeSBpZiBKSVQgaXMgZGlzYWJsZWQ7IGxlYWRz IHRvIGEgYnVpbGQgZmFpbHVyZS4KKwogMjAyMC0wOS0yNiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBh cHBsZS5jb20+CiAKICAgICAgICAgUmVmYWN0b3IgdGVzdCBydW5uZXIgY29kZSB0byBjdXQgZG93 biBvbiBjb3B5L3Bhc3RlIGNvZGUgYW5kIGxvbmctd2luZGVkIHJlcGV0aXRpdmUgaWRpb21zCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0xpbmtCdWZmZXIuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9MaW5rQnVmZmVyLmNwcAppbmRleCBi NjU3N2E5ZThjNGUuLmI3OTc0MGZjM2UyMyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9MaW5rQnVmZmVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL0xpbmtCdWZmZXIuY3BwCkBAIC0zNzQsNiArMzc0LDcgQEAgdm9pZCBMaW5rQnVm ZmVyOjpjb3B5Q29tcGFjdEFuZExpbmtDb2RlKE1hY3JvQXNzZW1ibGVyJiBtYWNyb0Fzc2VtYmxl ciwgSklUQ29tcGkKICAgICAgICAgbV9leGVjdXRhYmxlTWVtb3J5LT5zaHJpbmsobV9zaXplKTsK ICAgICB9CiAKKyNpZiBFTkFCTEUoSklUKQogICAgIGlmICh1c2VGYXN0SklUUGVybWlzc2lvbnMo KSkgewogICAgICAgICBBU1NFUlQoY29kZU91dERhdGEgPT0gb3V0RGF0YSk7CiAgICAgICAgIGlm IChVTkxJS0VMWShPcHRpb25zOjpkdW1wSklUTWVtb3J5UGF0aCgpKSkKQEAgLTM4Miw2ICszODMs MTAgQEAgdm9pZCBMaW5rQnVmZmVyOjpjb3B5Q29tcGFjdEFuZExpbmtDb2RlKE1hY3JvQXNzZW1i bGVyJiBtYWNyb0Fzc2VtYmxlciwgSklUQ29tcGkKICAgICAgICAgQVNTRVJUKGNvZGVPdXREYXRh ICE9IG91dERhdGEpOwogICAgICAgICBwZXJmb3JtSklUTWVtY3B5KGNvZGVPdXREYXRhLCBvdXRE YXRhLCBtX3NpemUpOwogICAgIH0KKyNlbHNlCisgICAgQVNTRVJUKGNvZGVPdXREYXRhICE9IG91 dERhdGEpOworICAgIHBlcmZvcm1KSVRNZW1jcHkoY29kZU91dERhdGEsIG91dERhdGEsIG1fc2l6 ZSk7CisjZW5kaWYgLy8gRU5BQkxFX0pJVAogCiAgICAganVtcHNUb0xpbmsuY2xlYXIoKTsKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpp bmRleCBkOTVhNmQxODUwNWMuLmY5YWM4MGE3N2Y5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAy MC0wOS0zMCAgTWlrZSBHb3JzZSAgPG1nb3JzZUBzdXNlLmNvbT4KKworICAgICAgICBSRUdSRVNT SU9OKHIyNTk1ODIpOiBCdWlsZCBmYWlscyBvbiBhYXJjaDY0IExpbnV4IHdpdGggV2ViS2l0IDIu MzAuMSBvbiBMTEludE9mZnNldHNFeHRyYWN0b3IuY3BwLm8KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzA3OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtRW5hYmxlLmg6IE9ubHkg ZGVmaW5lIFVTRV9KVU1QX0lTTEFORFMgaWYgSklUIGlzIGVuYWJsZWQuCisKIDIwMjAtMDktMjkg IEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBS ZW1vdmUgcGxpc3QtYmFzZWQgUmVzb3VyY2VMb2FkU3RhdGlzdGljcyBzdG9yYWdlLCB3aGljaCBo YXMgYmVlbiByZXBsYWNlZCBieSBkYXRhYmFzZS1iYXNlZCBzdG9yYWdlCmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUVuYWJsZS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm1F bmFibGUuaAppbmRleCA5MTY2Y2ZkZDk1NTQuLjM2MTE3ZDg4MjA4NSAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvUGxhdGZvcm1FbmFibGUuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9y bUVuYWJsZS5oCkBAIC04ODUsNiArODg1LDYgQEAKICNlcnJvciAiRU5BQkxFKFdITFNMX0NPTVBJ TEVSKSByZXF1aXJlcyBFTkFCTEUoV0VCR1BVKSIKICNlbmRpZgogCi0jaWYgQ1BVKEFSTTY0KSAm JiBDUFUoQUREUkVTUzY0KQorI2lmIENQVShBUk02NCkgJiYgQ1BVKEFERFJFU1M2NCkgJiYgRU5B QkxFKEpJVCkKICNkZWZpbmUgVVNFX0pVTVBfSVNMQU5EUyAxCiAjZW5kaWYK