217068 2020-09-28 17:15:02 -0700 [tvOS] [watchOS] Add support in libTestWTFAlwaysMissing-iOS-v2.tbd 2020-09-29 13:13:33 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad jbedard aakash_jain jbedard jlewis3 thorton webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1692719 0 ryanhaddad 2020-09-28 17:15:02 -0700 Since the tvOS simulator bot was updated to the tvOS 14 SDK, the build has been failing with the following: ld: warning: directory not found for option '-F/Applications/Xcode.app/Contents/Developer/Platforms/AppleTVSimulator.platform/Developer/SDKs/AppleTVSimulator14.0.sdk/System/Library/Frameworks/Quartz.framework/Frameworks' ld: warning: building for tvOS Simulator, but linking in .tbd built for iOS Simulator, 'TestWTFAlwaysMissing-iOS-v2' ld: warning: Could not find or use auto-linked library 'TestWTFAlwaysMissing-iOS-v2' Undefined symbols for architecture x86_64: "_TestWTFAlwaysMissing", referenced from: TestWebKitAPI::WeakLinking_WeakImport_Test::TestBody() in libTestWTF.a(WeakLinking.o) "_TestWTFAlwaysMissingWithoutAttributeWeakImport", referenced from: TestWebKitAPI::WeakLinking_WeakImport_Test::TestBody() in libTestWTF.a(WeakLinking.o) ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) https://build.webkit.org/builders/Apple-tvOS-Simulator-14-Release-Build/builds/1/steps/compile-webkit/logs/stdio The tvOS device build seems OK. 1692720 1 webkit-bug-importer 2020-09-28 17:15:43 -0700 <rdar://problem/69724742> 1692725 2 jbedard 2020-09-28 17:21:05 -0700 My bet is that we're somehow missing Tools/TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd in the tvOS Simulator build. 1692960 3 410011 jbedard 2020-09-29 09:42:45 -0700 Created attachment 410011 Patch 1692963 4 jbedard 2020-09-29 09:45:16 -0700 Looks like the rules for platform specifiers in tbd has gotten a bit more strict, I was able to reproduce this locally and this change fixes the problem. I'm pretty much certain that watchOS needs it as well. 1692967 5 aakash_jain 2020-09-29 09:49:13 -0700 rs=me if EWS passes. 1693084 6 410031 jbedard 2020-09-29 12:31:00 -0700 Created attachment 410031 Patch 1693102 7 ews-feeder 2020-09-29 13:13:32 -0700 Committed r267757: <https://trac.webkit.org/changeset/267757> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410031. 410011 2020-09-29 09:42:45 -0700 2020-09-29 12:30:59 -0700 Patch bug-217068-20200929094244.patch text/plain 1544 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2Nzc0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTA5LTI5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbdHZPU10gW3dhdGNoT1NdIEFkZCBzdXBwb3J0IGluIGxpYlRlc3RXVEZB bHdheXNNaXNzaW5nLWlPUy12Mi50YmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxNzA2OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjk3MjQ3NDI+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0 V2ViS2l0QVBJL1Rlc3RzL1dURi9kYXJ3aW4vbGliVGVzdFdURkFsd2F5c01pc3NpbmctaU9TLXYy LnRiZDogQWRkIHdhdGNoT1MgYW5kIHR2T1MuCisKIDIwMjAtMDktMjkgIEFha2FzaCBKYWluICA8 YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIExpbWl0IG51bWJlciBvZiB0ZXN0cyB0 byBsb2cgaW4gY2FzZSBvZiBsYXJnZSBudW1iZXIgb2YgSlNDIHRlc3QgZmFpbHVyZXMKSW5kZXg6 IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL2Rhcndpbi9saWJUZXN0V1RGQWx3YXlzTWlz c2luZy1pT1MtdjIudGJkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V1RGL2Rhcndpbi9saWJUZXN0V1RGQWx3YXlzTWlzc2luZy1pT1MtdjIudGJkCShyZXZpc2lvbiAy Njc3MzQpCisrKyBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9kYXJ3aW4vbGliVGVzdFdU RkFsd2F5c01pc3NpbmctaU9TLXYyLnRiZAkod29ya2luZyBjb3B5KQpAQCAtMSw3ICsxLDcgQEAK IC0tLSAhdGFwaS10YmQtdjIKIGFyY2hzOiBbIGkzODYsIHg4Nl82NCwgYXJtdjcsIGFybXY3cywg YXJtNjQsIGFybTY0XzMyLCBhcm02NGUgXQogdXVpZHM6IFsgJ2kzODY6IDZFQTgxQTBBLUQ4M0Yt NDA4MS1CM0VBLTkwNDE5QzE1NzNCQTg3JywgJ3g4Nl82NDogMjhFODFFMTEtMjc5NC00MTkyLUE0 NkEtMDZDNzNDOUJBRkI5JywgJ2FybXY3OiAwMEM2NzM5Ny1GN0EyLTQzMUEtOUYyNy1ENEY2MTEw NkZDMUYnLCAnYXJtdjdzOiBGOUMxNzJGQy1BMTEyLTQ4OEMtODg5Qi1CNzBGQTIwQUU4MjcnLCAn YXJtNjQ6IDNGREIxMkZCLTBCRjItNDA1Qy1CMjFBLTJEM0QyRDE4RUI1RicsICdhcm02NF8zMjog N0FBQ0Y5MkYtQTExQy00MDE1LTk0MzQtMzY1Q0UzREM1RjlFJyBdCi1wbGF0Zm9ybTogaW9zCitw bGF0Zm9ybTogaW9zIHR2b3Mgd2F0Y2hvcwogaW5zdGFsbC1uYW1lOiAvdXNyL2xvY2FsL2xpYi9s aWJUZXN0V1RGQWx3YXlzTWlzc2luZy5keWxpYgogb2JqYy1jb25zdHJhaW50OiBub25lCiBleHBv cnRzOgo= 410031 2020-09-29 12:31:00 -0700 2020-09-29 13:13:33 -0700 Patch bug-217068-20200929123059.patch text/plain 1546 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2Nzc1NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTA5LTI5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbdHZPU10gW3dhdGNoT1NdIEFkZCBzdXBwb3J0IGluIGxpYlRlc3RXVEZB bHdheXNNaXNzaW5nLWlPUy12Mi50YmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxNzA2OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjk3MjQ3NDI+ CisKKyAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgQWFrYXNoIEphaW4uCisKKyAgICAgICAgKiBU ZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9kYXJ3aW4vbGliVGVzdFdURkFsd2F5c01pc3NpbmctaU9T LXYyLnRiZDogQWRkIHdhdGNoT1MgYW5kIHR2T1MuCisKIDIwMjAtMDktMjkgIFJ5YW4gSGFkZGFk ICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAgVVJMIGZvciBBcHBsZS1pT1MtMTQt U2ltdWxhdG9yLURlYnVnLVdLMi1UZXN0cyBpcyBicm9rZW4gb24gdGhlIGRhc2hib2FyZApJbmRl eDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvZGFyd2luL2xpYlRlc3RXVEZBbHdheXNN aXNzaW5nLWlPUy12Mi50YmQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XVEYvZGFyd2luL2xpYlRlc3RXVEZBbHdheXNNaXNzaW5nLWlPUy12Mi50YmQJKHJldmlzaW9u IDI2Nzc1NSkKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL2Rhcndpbi9saWJUZXN0 V1RGQWx3YXlzTWlzc2luZy1pT1MtdjIudGJkCSh3b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEsNyBA QAogLS0tICF0YXBpLXRiZC12MgogYXJjaHM6IFsgaTM4NiwgeDg2XzY0LCBhcm12NywgYXJtdjdz LCBhcm02NCwgYXJtNjRfMzIsIGFybTY0ZSBdCiB1dWlkczogWyAnaTM4NjogNkVBODFBMEEtRDgz Ri00MDgxLUIzRUEtOTA0MTlDMTU3M0JBODcnLCAneDg2XzY0OiAyOEU4MUUxMS0yNzk0LTQxOTIt QTQ2QS0wNkM3M0M5QkFGQjknLCAnYXJtdjc6IDAwQzY3Mzk3LUY3QTItNDMxQS05RjI3LUQ0RjYx MTA2RkMxRicsICdhcm12N3M6IEY5QzE3MkZDLUExMTItNDg4Qy04ODlCLUI3MEZBMjBBRTgyNycs ICdhcm02NDogM0ZEQjEyRkItMEJGMi00MDVDLUIyMUEtMkQzRDJEMThFQjVGJywgJ2FybTY0XzMy OiA3QUFDRjkyRi1BMTFDLTQwMTUtOTQzNC0zNjVDRTNEQzVGOUUnIF0KLXBsYXRmb3JtOiBpb3MK K3BsYXRmb3JtOiBpb3MgdHZvcyB3YXRjaG9zCiBpbnN0YWxsLW5hbWU6IC91c3IvbG9jYWwvbGli L2xpYlRlc3RXVEZBbHdheXNNaXNzaW5nLmR5bGliCiBvYmpjLWNvbnN0cmFpbnQ6IG5vbmUKIGV4 cG9ydHM6Cg==