21702 2008-10-16 22:57:03 -0700 Special op_create_activation for the case where there are no named parameters 2008-10-18 02:46:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 20813 1 zwarich zwarich oldest_to_newest 95704 0 zwarich 2008-10-16 22:57:03 -0700 Considering that the Raytrace V8 benchmark is a microbenchmark for the creation of the 'arguments' object, it might be a good idea to move some of the compilation into an extra parameter (or parameters) to the opcode. 95860 1 24487 zwarich 2008-10-18 02:06:03 -0700 Created attachment 24487 Proposed patch 95861 2 24487 oliver 2008-10-18 02:11:15 -0700 Comment on attachment 24487 Proposed patch r=me 95865 3 zwarich 2008-10-18 02:46:50 -0700 Landed in r37678. 24487 2008-10-18 02:06:03 -0700 2008-10-18 02:11:15 -0700 Proposed patch arguments.diff text/plain 4421 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3Njc3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMDgtMTAt MTggIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMTcwMjogU3BlY2lhbCBvcF9j cmVhdGVfYWN0aXZhdGlvbiBmb3IgdGhlIGNhc2Ugd2hlcmUgdGhlcmUgYXJlIG5vIG5hbWVkIHBh cmFtZXRlcnMKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTcwMj4KKworICAgICAgICBUaGlzIGlzIGEgMi41JSBzcGVlZHVwIG9uIHRoZSBWOCBSYXl0 cmFjZSBiZW5jaG1hcmsgYW5kIGEgMS4xJSBzcGVlZHVwCisgICAgICAgIG9uIHRoZSBWOCBFYXJs ZXktQm95ZXIgYmVuY2htYXJrLgorCisgICAgICAgICogVk0vQ1RJLmNwcDoKKyAgICAgICAgKEpT Qzo6Q1RJOjpwcml2YXRlQ29tcGlsZU1haW5QYXNzKToKKyAgICAgICAgKiBWTS9NYWNoaW5lLmNw cDoKKyAgICAgICAgKEpTQzo6TWFjaGluZTo6Y3RpX29wX2NyZWF0ZV9hcmd1bWVudHNfbm9fcGFy YW1zKToKKyAgICAgICAgKiBWTS9NYWNoaW5lLmg6CisgICAgICAgICoga2pzL0FyZ3VtZW50cy5o OgorICAgICAgICAoSlNDOjpBcmd1bWVudHM6Oik6CisgICAgICAgIChKU0M6OkFyZ3VtZW50czo6 QXJndW1lbnRzKToKKwogMjAwOC0xMC0xNyAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENhbWVyb24gWndhcmljaC4KSW5kZXg6IFZNL0NU SS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVk0vQ1RJLmNwcAkocmV2aXNpb24gMzc2NzYpCisrKyBWTS9D VEkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDg0LDcgKzIwODQsNyBAQCB2b2lkIENUSTo6cHJp dmF0ZUNvbXBpbGVNYWluUGFzcygpCiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAg ICAgICBjYXNlIG9wX2NyZWF0ZV9hcmd1bWVudHM6IHsKLSAgICAgICAgICAgIGVtaXRDVElDYWxs KGksIE1hY2hpbmU6OmN0aV9vcF9jcmVhdGVfYXJndW1lbnRzKTsKKyAgICAgICAgICAgIGVtaXRD VElDYWxsKGksIChtX2NvZGVCbG9jay0+bnVtUGFyYW1ldGVycyA9PSAxKSA/IE1hY2hpbmU6OmN0 aV9vcF9jcmVhdGVfYXJndW1lbnRzX25vX3BhcmFtcyA6IE1hY2hpbmU6OmN0aV9vcF9jcmVhdGVf YXJndW1lbnRzKTsKICAgICAgICAgICAgIGkgKz0gMTsKICAgICAgICAgICAgIGJyZWFrOwogICAg ICAgICB9CkluZGV4OiBWTS9NYWNoaW5lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBWTS9NYWNoaW5lLmNw cAkocmV2aXNpb24gMzc2NzYpCisrKyBWTS9NYWNoaW5lLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NDc3NSw2ICs0Nzc1LDEzIEBAIHZvaWQgTWFjaGluZTo6Y3RpX29wX2NyZWF0ZV9hcmd1bWVudHMo Q1QKICAgICBBUkdfY2FsbEZyYW1lW1JlZ2lzdGVyRmlsZTo6QXJndW1lbnRzUmVnaXN0ZXJdID0g YXJndW1lbnRzOwogfQogCit2b2lkIE1hY2hpbmU6OmN0aV9vcF9jcmVhdGVfYXJndW1lbnRzX25v X3BhcmFtcyhDVElfQVJHUykKK3sKKyAgICBBcmd1bWVudHMqIGFyZ3VtZW50cyA9IG5ldyAoQVJH X2dsb2JhbERhdGEpIEFyZ3VtZW50cyhBUkdfY2FsbEZyYW1lLCBBcmd1bWVudHM6OkFyZ3VtZW50 c05vUGFyYW1ldGVycyk7CisgICAgQVJHX2NhbGxGcmFtZS0+c2V0Q2FsbGVlQXJndW1lbnRzKGFy Z3VtZW50cyk7CisgICAgQVJHX2NhbGxGcmFtZVtSZWdpc3RlckZpbGU6OkFyZ3VtZW50c1JlZ2lz dGVyXSA9IGFyZ3VtZW50czsKK30KKwogdm9pZCBNYWNoaW5lOjpjdGlfb3BfdGVhcl9vZmZfYWN0 aXZhdGlvbihDVElfQVJHUykKIHsKICAgICBDVElfU1RBQ0tfSEFDSygpOwpJbmRleDogVk0vTWFj aGluZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFZNL01hY2hpbmUuaAkocmV2aXNpb24gMzc2NzYpCisrKyBW TS9NYWNoaW5lLmgJKHdvcmtpbmcgY29weSkKQEAgLTE4Niw2ICsxODYsNyBAQCBuYW1lc3BhY2Ug SlNDIHsKICAgICAgICAgc3RhdGljIFZvaWRQdHJQYWlyIFNGWF9DQUxMIGN0aV9vcF9jYWxsX0pT RnVuY3Rpb24oQ1RJX0FSR1MpOwogICAgICAgICBzdGF0aWMgSlNWYWx1ZSogU0ZYX0NBTEwgY3Rp X29wX2NhbGxfTm90SlNGdW5jdGlvbihDVElfQVJHUyk7CiAgICAgICAgIHN0YXRpYyB2b2lkIFNG WF9DQUxMIGN0aV9vcF9jcmVhdGVfYXJndW1lbnRzKENUSV9BUkdTKTsKKyAgICAgICAgc3RhdGlj IHZvaWQgU0ZYX0NBTEwgY3RpX29wX2NyZWF0ZV9hcmd1bWVudHNfbm9fcGFyYW1zKENUSV9BUkdT KTsKICAgICAgICAgc3RhdGljIHZvaWQgU0ZYX0NBTEwgY3RpX29wX3RlYXJfb2ZmX2FjdGl2YXRp b24oQ1RJX0FSR1MpOwogICAgICAgICBzdGF0aWMgdm9pZCBTRlhfQ0FMTCBjdGlfb3BfdGVhcl9v ZmZfYXJndW1lbnRzKENUSV9BUkdTKTsKICAgICAgICAgc3RhdGljIHZvaWQgU0ZYX0NBTEwgY3Rp X29wX3JldF9zY29wZUNoYWluKENUSV9BUkdTKTsKSW5kZXg6IGtqcy9Bcmd1bWVudHMuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBranMvQXJndW1lbnRzLmgJKHJldmlzaW9uIDM3Njc2KQorKysga2pzL0FyZ3Vt ZW50cy5oCSh3b3JraW5nIGNvcHkpCkBAIC01Myw3ICs1MywxMiBAQCBuYW1lc3BhY2UgSlNDIHsK IAogICAgIGNsYXNzIEFyZ3VtZW50cyA6IHB1YmxpYyBKU09iamVjdCB7CiAgICAgcHVibGljOgor ICAgICAgICBlbnVtIEFyZ3VtZW50c1BhcmFtZXRlcnMgeworICAgICAgICAgICAgQXJndW1lbnRz Tm9QYXJhbWV0ZXJzCisgICAgICAgIH07CisKICAgICAgICAgQXJndW1lbnRzKENhbGxGcmFtZSop OworICAgICAgICBBcmd1bWVudHMoQ2FsbEZyYW1lKiwgZW51bSBBcmd1bWVudHNQYXJhbWV0ZXJz KTsKICAgICAgICAgdmlydHVhbCB+QXJndW1lbnRzKCk7CiAKICAgICAgICAgc3RhdGljIGNvbnN0 IENsYXNzSW5mbyBpbmZvOwpAQCAtMTQwLDYgKzE0NSwzMyBAQCBuYW1lc3BhY2UgSlNDIHsKICAg ICAgICAgZC0+b3ZlcnJvZGVDYWxsZWUgPSBmYWxzZTsKICAgICB9CiAKKyAgICBpbmxpbmUgQXJn dW1lbnRzOjpBcmd1bWVudHMoQ2FsbEZyYW1lKiBjYWxsRnJhbWUsIGVudW0gQXJndW1lbnRzUGFy YW1ldGVycykKKyAgICAgICAgOiBKU09iamVjdChjYWxsRnJhbWUtPmxleGljYWxHbG9iYWxPYmpl Y3QoKS0+YXJndW1lbnRzU3RydWN0dXJlKCkpCisgICAgICAgICwgZChuZXcgQXJndW1lbnRzRGF0 YSkKKyAgICB7CisgICAgICAgIHVuc2lnbmVkIG51bUFyZ3VtZW50cyA9IGNhbGxGcmFtZS0+YXJn dW1lbnRDb3VudCgpIC0gMTsKKworICAgICAgICBkLT5udW1QYXJhbWV0ZXJzID0gMDsKKyAgICAg ICAgZC0+bnVtQXJndW1lbnRzID0gbnVtQXJndW1lbnRzOworICAgICAgICBkLT5hY3RpdmF0aW9u ID0gMDsKKworICAgICAgICBSZWdpc3RlciogZXh0cmFBcmd1bWVudHM7CisgICAgICAgIGlmIChu dW1Bcmd1bWVudHMgPiBzaXplb2YoZC0+ZXh0cmFBcmd1bWVudHNGaXhlZEJ1ZmZlcikgLyBzaXpl b2YoUmVnaXN0ZXIpKQorICAgICAgICAgICAgZXh0cmFBcmd1bWVudHMgPSBuZXcgUmVnaXN0ZXJb bnVtQXJndW1lbnRzXTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgZXh0cmFBcmd1bWVudHMg PSBkLT5leHRyYUFyZ3VtZW50c0ZpeGVkQnVmZmVyOworCisgICAgICAgIFJlZ2lzdGVyKiBhcmd2 ID0gY2FsbEZyYW1lLT5yZWdpc3RlcnMoKSAtIFJlZ2lzdGVyRmlsZTo6Q2FsbEZyYW1lSGVhZGVy U2l6ZSAtIG51bUFyZ3VtZW50cyAtIDE7CisgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkg PCBudW1Bcmd1bWVudHM7ICsraSkKKyAgICAgICAgICAgIGV4dHJhQXJndW1lbnRzW2ldID0gYXJn dltpXTsKKworICAgICAgICBkLT5leHRyYUFyZ3VtZW50cyA9IGV4dHJhQXJndW1lbnRzOworCisg ICAgICAgIGQtPmNhbGxlZSA9IGNhbGxGcmFtZS0+Y2FsbGVlKCk7CisgICAgICAgIGQtPm92ZXJy b2RlTGVuZ3RoID0gZmFsc2U7CisgICAgICAgIGQtPm92ZXJyb2RlQ2FsbGVlID0gZmFsc2U7Cisg ICAgfQorCiAgICAgaW5saW5lIHZvaWQgQXJndW1lbnRzOjpjb3B5UmVnaXN0ZXJzKCkKICAgICB7 CiAgICAgICAgIEFTU0VSVCghaXNUb3JuT2ZmKCkpOwo=