217012 2020-09-26 07:32:44 -0700 [SOUP] WebSocket: cookies set in request don't appear in the inspector 2020-09-27 05:46:06 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply mcatanzaro oldest_to_newest 1692185 0 cgarcia 2020-09-26 07:32:44 -0700 Cookies are set by libsoup and we are notifying about the handshake being sent before the cookie header is added to the request. 1692186 1 409776 cgarcia 2020-09-26 07:35:20 -0700 Created attachment 409776 Patch 1692193 2 409776 mcatanzaro 2020-09-26 08:58:20 -0700 Comment on attachment 409776 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409776&action=review > Source/WebKit/NetworkProcess/soup/WebSocketTaskSoup.cpp:83 > + g_signal_connect(msg, "starting", G_CALLBACK(+[](SoupMessage* msg, WebSocketTask* task) { +[] to convert to vanilla function pointer so we can use it in a signal callback is amazing... I didn't know this was possible! 1692339 3 cgarcia 2020-09-27 05:46:06 -0700 Committed r267655: <https://trac.webkit.org/changeset/267655> 409776 2020-09-26 07:35:20 -0700 2020-09-26 08:58:20 -0700 Patch soup-socket-cookies-inspector.diff text/plain 1826 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggODdkODk3OTk1OTI3Li4zMGU4NmE3Mjc2YmYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTcgQEAKKzIwMjAtMDktMjYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtTT1VQXSBXZWJTb2NrZXQ6IGNvb2tpZXMgc2V0IGluIHJlcXVl c3QgZG9uJ3QgYXBwZWFyIGluIHRoZSBpbnNwZWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzAxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIENvb2tpZXMgYXJlIHNldCBieSBsaWJzb3VwIGFuZCB3 ZSBhcmUgbm90aWZ5aW5nIGFib3V0IHRoZSBoYW5kc2hha2UgYmVpbmcgc2VudCBiZWZvcmUgdGhl IGNvb2tpZSBoZWFkZXIgaXMgYWRkZWQKKyAgICAgICAgdG8gdGhlIHJlcXVlc3QuCisKKyAgICAg ICAgKiBOZXR3b3JrUHJvY2Vzcy9zb3VwL1dlYlNvY2tldFRhc2tTb3VwLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViU29ja2V0VGFzazo6V2ViU29ja2V0VGFzayk6IENvbm5lY3QgdG8gU291cE1l c3NhZ2U6OnN0YXJ0aW5nIHRvIG5vdGlmeSB0aGUgd2ViIHByb2Nlc3MgdGhlIGhhbmRzaGFrZQor ICAgICAgICByZXF1ZXN0IGhhcyBiZWVuIHNlbnQuCisKIDIwMjAtMDktMjYgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtTT1VQXSBEbyBub3Qg c2V0IHNpdGUgZm9yIGNvb2tpZXMgdHdpY2UgaW4gY2FzZSBvZiByZWRpcmVjdGlvbgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9zb3VwL1dlYlNvY2tldFRhc2tTb3Vw LmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvc291cC9XZWJTb2NrZXRUYXNrU291 cC5jcHAKaW5kZXggM2YxNzUwNjdkZWY4Li4xZWEwMTAxZThhYWEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvc291cC9XZWJTb2NrZXRUYXNrU291cC5jcHAKKysrIGIv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9zb3VwL1dlYlNvY2tldFRhc2tTb3VwLmNwcApA QCAtODAsOSArODAsMTEgQEAgV2ViU29ja2V0VGFzazo6V2ViU29ja2V0VGFzayhOZXR3b3JrU29j a2V0Q2hhbm5lbCYgY2hhbm5lbCwgU291cFNlc3Npb24qIHNlc3Npb24KICAgICAgICAgICAgICAg ICB0YXNrLT5kaWRGYWlsKFN0cmluZzo6ZnJvbVVURjgoZXJyb3ItPm1lc3NhZ2UpKTsKICAgICAg ICAgfSwgdGhpcyk7CiAKLSAgICBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QgcmVxdWVzdDsKLSAg ICByZXF1ZXN0LnVwZGF0ZUZyb21Tb3VwTWVzc2FnZShtc2cpOwotICAgIG1fY2hhbm5lbC5kaWRT ZW5kSGFuZHNoYWtlUmVxdWVzdChXVEZNb3ZlKHJlcXVlc3QpKTsKKyAgICBnX3NpZ25hbF9jb25u ZWN0KG1zZywgInN0YXJ0aW5nIiwgR19DQUxMQkFDSygrW10oU291cE1lc3NhZ2UqIG1zZywgV2Vi U29ja2V0VGFzayogdGFzaykgeworICAgICAgICBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QgcmVx dWVzdDsKKyAgICAgICAgcmVxdWVzdC51cGRhdGVGcm9tU291cE1lc3NhZ2UobXNnKTsKKyAgICAg ICAgdGFzay0+bV9jaGFubmVsLmRpZFNlbmRIYW5kc2hha2VSZXF1ZXN0KFdURk1vdmUocmVxdWVz dCkpOworICAgIH0pLCB0aGlzKTsKIH0KIAogV2ViU29ja2V0VGFzazo6fldlYlNvY2tldFRhc2so KQo=