217010 2020-09-26 00:59:58 -0700 [SOUP] Do not set site for cookies twice in case of redirection 2020-09-26 09:00:00 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto bugs-noreply ews-watchlist gustavo mcatanzaro pgriffis oldest_to_newest 1692166 0 cgarcia 2020-09-26 00:59:58 -0700 ResourceRequest::updateSoupMessage() already fills the same site information, but we are duplicating the code in NetworkDataTaskSoup::continueHTTPRedirection() 1692167 1 409771 cgarcia 2020-09-26 01:03:02 -0700 Created attachment 409771 Patch 1692174 2 409771 mcatanzaro 2020-09-26 04:47:18 -0700 Comment on attachment 409771 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409771&action=review > Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:115 > + if (!isSameSiteUnspecified()) { Is it OK for SameSite to ever be unspecified when we send a message? Maybe we should have an assert to ensure that doesn't happen? 1692179 3 cgarcia 2020-09-26 06:49:53 -0700 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 409771 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409771&action=review > > > Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:115 > > + if (!isSameSiteUnspecified()) { > > Is it OK for SameSite to ever be unspecified when we send a message? Maybe > we should have an assert to ensure that doesn't happen? I don't know. 1692182 4 cgarcia 2020-09-26 06:52:42 -0700 Committed r267621: <https://trac.webkit.org/changeset/267621> 1692194 5 mcatanzaro 2020-09-26 09:00:00 -0700 (In reply to Michael Catanzaro from comment #2) > Is it OK for SameSite to ever be unspecified when we send a message? Maybe > we should have an assert to ensure that doesn't happen? Hm, I was thinking: "can we assert that same site data has been provided when needed?" But I think this actually is just used to indicate SameSite is not specified, rather than being set with SameSite=Lax, SameSite=Strict, or SameSite=None. 409771 2020-09-26 01:03:02 -0700 2020-09-26 04:47:18 -0700 Patch wk2-soup-same-site.diff text/plain 4058 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2NWYxNGRmOThmMDkuLjYxNWMyOGI2MzE2MyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDIwLTA5LTI2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBbU09VUF0gRG8gbm90IHNldCBzaXRlIGZvciBjb29raWVz IHR3aWNlIGluIGNhc2Ugb2YgcmVkaXJlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzAxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE9ubHkgc2V0IGlzLXRvcGxldmVsLW5hdmlnYXRpb24gb24g U291cE1lc3NhZ2Ugd2hlbiBzYW1lIHNpdGUgaW5mbyBpcyBwcmVzZW50LgorCisgICAgICAgICog cGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVxdWVzdFNvdXAuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0Ojp1cGRhdGVTb3VwTWVzc2FnZU1lbWJlcnMgY29uc3Qp OgorCiAyMDIwLTA5LTI1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KIAogICAgICAgICBbU09VUF0gU2xhY2suY29tIGlzIG5vdCB3b3JraW5nLCBuZXcgbWVzc2Fn ZXMgZG8gbm90IGxvYWQgZHVlIHRvIFdlYlNvY2tldCBhdXRoZW50aWNhdGlvbiBmYWlsdXJlIGlz c3VlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVz b3VyY2VSZXF1ZXN0U291cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvUmVzb3VyY2VSZXF1ZXN0U291cC5jcHAKaW5kZXggZDhjZjFkM2M3MGFmLi5lMTY3ODAxNDc4 YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNv dXJjZVJlcXVlc3RTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3NvdXAvUmVzb3VyY2VSZXF1ZXN0U291cC5jcHAKQEAgLTExMiwxMiArMTEyLDEzIEBAIHZvaWQg UmVzb3VyY2VSZXF1ZXN0Ojp1cGRhdGVTb3VwTWVzc2FnZU1lbWJlcnMoU291cE1lc3NhZ2UqIHNv dXBNZXNzYWdlKSBjb25zdAogICAgICAgICBzb3VwX21lc3NhZ2Vfc2V0X2ZpcnN0X3BhcnR5KHNv dXBNZXNzYWdlLCBmaXJzdFBhcnR5LmdldCgpKTsKIAogI2lmIFNPVVBfQ0hFQ0tfVkVSU0lPTigy LCA2OSwgOTApCi0gICAgaWYgKG1fc2FtZVNpdGVEaXNwb3NpdGlvbiA9PSBSZXNvdXJjZVJlcXVl c3Q6OlNhbWVTaXRlRGlzcG9zaXRpb246OlNhbWVTaXRlKSB7Ci0gICAgICAgIEdVbmlxdWVQdHI8 U291cFVSST4gc2l0ZUZvckNvb2tpZXMgPSB1cmxUb1NvdXBVUkkobV91cmwpOwotICAgICAgICBz b3VwX21lc3NhZ2Vfc2V0X3NpdGVfZm9yX2Nvb2tpZXMoc291cE1lc3NhZ2UsIHNpdGVGb3JDb29r aWVzLmdldCgpKTsKKyAgICBpZiAoIWlzU2FtZVNpdGVVbnNwZWNpZmllZCgpKSB7CisgICAgICAg IGlmIChpc1NhbWVTaXRlKCkpIHsKKyAgICAgICAgICAgIEdVbmlxdWVQdHI8U291cFVSST4gc2l0 ZUZvckNvb2tpZXMgPSB1cmxUb1NvdXBVUkkobV91cmwpOworICAgICAgICAgICAgc291cF9tZXNz YWdlX3NldF9zaXRlX2Zvcl9jb29raWVzKHNvdXBNZXNzYWdlLCBzaXRlRm9yQ29va2llcy5nZXQo KSk7CisgICAgICAgIH0KKyAgICAgICAgc291cF9tZXNzYWdlX3NldF9pc190b3BfbGV2ZWxfbmF2 aWdhdGlvbihzb3VwTWVzc2FnZSwgaXNUb3BTaXRlKCkpOwogICAgIH0KLQotICAgIHNvdXBfbWVz c2FnZV9zZXRfaXNfdG9wX2xldmVsX25hdmlnYXRpb24oc291cE1lc3NhZ2UsIGlzVG9wU2l0ZSgp KTsKICNlbmRpZgogCiAgICAgc291cF9tZXNzYWdlX3NldF9mbGFncyhzb3VwTWVzc2FnZSwgbV9z b3VwRmxhZ3MpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZwppbmRleCAzZGI3NTY4MmNhMTYuLmZlYTViNDE1MTljMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNyBAQAorMjAyMC0wOS0yNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1NPVVBdIERvIG5vdCBzZXQgc2l0ZSBmb3Ig Y29va2llcyB0d2ljZSBpbiBjYXNlIG9mIHJlZGlyZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTcwMTAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXNvdXJjZVJlcXVlc3Q6OnVwZGF0ZVNvdXBN ZXNzYWdlKCkgYWxyZWFkeSBmaWxscyB0aGUgc2FtZSBzaXRlIGluZm9ybWF0aW9uLCBidXQgd2Ug YXJlIGR1cGxpY2F0aW5nIHRoZSBjb2RlIGluCisgICAgICAgIE5ldHdvcmtEYXRhVGFza1NvdXA6 OmNvbnRpbnVlSFRUUFJlZGlyZWN0aW9uKCkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9z b3VwL05ldHdvcmtEYXRhVGFza1NvdXAuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrRGF0 YVRhc2tTb3VwOjpjb250aW51ZUhUVFBSZWRpcmVjdGlvbik6IERvIG5vdCBzZXQgc2FtZSBzaXRl IGluZm9ybWF0aW9uIGhlcmUsIGl0IHdpbGwgYmUgZG9uZQorICAgICAgICBhZ2FpbiBpbiBOZXR3 b3JrRGF0YVRhc2tTb3VwOjpjcmVhdGVSZXF1ZXN0KCkuCisKIDIwMjAtMDktMjQgIENhcmxvcyBH YXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04o cjI2NzUwMik6IFtHVEtdW1dQRV0gZXBoZW1lcmFsIFdlYktpdFdlYnNpdGVEYXRhTWFuYWdlciBp Z25vcmVzIFRMUyBlcnJvcnMgYnkgZGVmYXVsdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtEYXRhVGFza1NvdXAuY3BwIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtEYXRhVGFza1NvdXAuY3BwCmluZGV4IDU0NTYy NmNhZDViNi4uYzk5YmNiMDczNjZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQ cm9jZXNzL3NvdXAvTmV0d29ya0RhdGFUYXNrU291cC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtEYXRhVGFza1NvdXAuY3BwCkBAIC02OTUsMTkgKzY5 NSw4IEBAIHZvaWQgTmV0d29ya0RhdGFUYXNrU291cDo6Y29udGludWVIVFRQUmVkaXJlY3Rpb24o KQogICAgIG1fbGFzdEhUVFBNZXRob2QgPSByZXF1ZXN0Lmh0dHBNZXRob2QoKTsKICAgICByZXF1 ZXN0LnJlbW92ZUNyZWRlbnRpYWxzKCk7CiAKLSAgICBpZiAoaXNUb3BMZXZlbE5hdmlnYXRpb24o KSkgeworICAgIGlmIChpc1RvcExldmVsTmF2aWdhdGlvbigpKQogICAgICAgICByZXF1ZXN0LnNl dEZpcnN0UGFydHlGb3JDb29raWVzKHJlcXVlc3QudXJsKCkpOwotI2lmIFNPVVBfQ0hFQ0tfVkVS U0lPTigyLCA2OSwgOTApCi0gICAgICAgIHNvdXBfbWVzc2FnZV9zZXRfaXNfdG9wX2xldmVsX25h dmlnYXRpb24obV9zb3VwTWVzc2FnZS5nZXQoKSwgdHJ1ZSk7Ci0jZW5kaWYKLSAgICB9Ci0KLSNp ZiBTT1VQX0NIRUNLX1ZFUlNJT04oMiwgNjksIDkwKQotICAgIGlmIChyZXF1ZXN0LmlzU2FtZVNp dGUoKSkgewotICAgICAgICBHVW5pcXVlUHRyPFNvdXBVUkk+IHJlcXVlc3RVUkkgPSB1cmxUb1Nv dXBVUkkocmVxdWVzdC51cmwoKSk7Ci0gICAgICAgIHNvdXBfbWVzc2FnZV9zZXRfc2l0ZV9mb3Jf Y29va2llcyhtX3NvdXBNZXNzYWdlLmdldCgpLCByZXF1ZXN0VVJJLmdldCgpKTsKLSAgICB9Ci0j ZW5kaWYKIAogICAgIGlmIChpc0Nyb3NzT3JpZ2luKSB7CiAgICAgICAgIC8vIFRoZSBuZXR3b3Jr IGxheWVyIG1pZ2h0IGNhcnJ5IG92ZXIgc29tZSBoZWFkZXJzIGZyb20gdGhlIG9yaWdpbmFsIHJl cXVlc3QgdGhhdAo=