216984 2020-09-25 12:13:01 -0700 Simplify SVGTests.hasExtension idl 2020-09-25 14:07:18 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198652 https://bugs.webkit.org/show_bug.cgi?id=204125 InRadar P2 Normal --- 1 rbuis rbuis cdumez dino esprehn+autocc ews-watchlist fmalita gyuyoung.kim kondapallykalyan pdr sabouhallawa sam schenney sergio webkit-bug-importer zimmermann oldest_to_newest 1691975 0 rbuis 2020-09-25 12:13:01 -0700 Simplify SVGTests.hasExtension idl by removing optional and default parameter. Skipping the parameter will now result in the parameter being a null string, which gives the same behaviour as before as the method just checks against non null namespaces. [1] https://www.w3.org/TR/SVG11/types.html#__svg__SVGTests__hasExtension 1691986 1 409720 rbuis 2020-09-25 12:26:53 -0700 Created attachment 409720 Patch 1692005 2 ews-feeder 2020-09-25 13:19:43 -0700 Committed r267590: <https://trac.webkit.org/changeset/267590> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409720. 1692006 3 webkit-bug-importer 2020-09-25 13:20:17 -0700 <rdar://problem/69590625> 1692016 4 sabouhallawa 2020-09-25 13:47:30 -0700 SVGTests.hasExtension and SVGTests.requiredFeatures were removed in SVG2. Specs link: https://www.w3.org/TR/SVG2/types.html#InterfaceSVGTests WebKit bugs to remove hasExtension and requiredFeatures: https://bugs.webkit.org/show_bug.cgi?id=198652 https://bugs.webkit.org/show_bug.cgi?id=204125 Chrome bug to remove requiredFeatures: https://bugzilla.mozilla.org/show_bug.cgi?id=1295404 Chrome bug to remove hasExtension: https://bugs.chromium.org/p/chromium/issues/detail?id=532405 1692019 5 rbuis 2020-09-25 14:07:18 -0700 (In reply to Said Abou-Hallawa from comment #4) > SVGTests.hasExtension and SVGTests.requiredFeatures were removed in SVG2. > > Specs link: > https://www.w3.org/TR/SVG2/types.html#InterfaceSVGTests > > WebKit bugs to remove hasExtension and requiredFeatures: > https://bugs.webkit.org/show_bug.cgi?id=198652 > https://bugs.webkit.org/show_bug.cgi?id=204125 > > Chrome bug to remove requiredFeatures: > https://bugzilla.mozilla.org/show_bug.cgi?id=1295404 > > Chrome bug to remove hasExtension: > https://bugs.chromium.org/p/chromium/issues/detail?id=532405 My main motivation is to remove the "Using "undefined" as default parameter value is wrong" FIXMEs, I'll continue to work on that. Is there anything left before removing these two methods? If not, I could work on that or review your patches. 409720 2020-09-25 12:26:53 -0700 2020-09-25 13:19:44 -0700 Patch bug-216984-20200925202648.patch text/plain 2944 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTYyZDJhYmEwNDBmMDAx M2Q3ZTZjOGFiNmY3MzNiNWI5MDQ2YWZjMi4uZmM4ZTYzNjg3NDNjNjVjYzA1ZWE1MmJmNDcyOTBm ODkyMTE2M2I5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA5LTI1ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgU2ltcGxpZnkgU1ZHVGVzdHMuaGFz RXh0ZW5zaW9uIGlkbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjE2OTg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgU2ltcGxpZnkgU1ZHVGVzdHMuaGFzRXh0ZW5zaW9uIGlkbCBieSByZW1vdmluZyBvcHRp b25hbCBhbmQgZGVmYXVsdCBwYXJhbWV0ZXIuCisgICAgICAgIFNraXBwaW5nIHRoZSBwYXJhbWV0 ZXIgd2lsbCBub3cgcmVzdWx0IGluIHRoZSBwYXJhbWV0ZXIgYmVpbmcgYSBudWxsIHN0cmluZywK KyAgICAgICAgd2hpY2ggZ2l2ZXMgdGhlIHNhbWUgYmVoYXZpb3VyIGFzIGJlZm9yZSBhcyB0aGUg bWV0aG9kIGp1c3QgY2hlY2tzCisgICAgICAgIGFnYWluc3Qgbm9uIG51bGwgbmFtZXNwYWNlcy4K KworICAgICAgICBbMV0gaHR0cHM6Ly93d3cudzMub3JnL1RSL1NWRzExL3R5cGVzLmh0bWwjX19z dmdfX1NWR1Rlc3RzX19oYXNFeHRlbnNpb24KKworICAgICAgICAqIHBhZ2UvRE9NV2luZG93Lmlk bDoKKyAgICAgICAgKiBzdmcvU1ZHVGVzdHMuaWRsOgorCiAyMDIwLTA5LTI1ICBBZHJpYW4gUGVy ZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgTm9uLXVuaWZpZWQg YnVpbGQgZml4ZXMsIGxhdGUgU2VwdGVtYmVyIDIwMjAgZWRpdGlvbgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01X aW5kb3cuaWRsCmluZGV4IDYwZWM5YmY5MWY4MDI0ZjAxZjIzMTQyNzQ2Y2ZjYzU1NWEyNDA5NDcu LmNkMmExZTU2NjVkYTIzOTFhNzhiMTNhMmJkYTUxOTZlNDJjYmQwYmUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L0RPTVdpbmRvdy5pZGwKQEAgLTE1Niw3ICsxNTYsNyBAQCB0eXBlZGVmIFVTVlN0cmluZyBDU1NP TVN0cmluZzsKICAgICBbUmVwbGFjZWFibGUsIEN1c3RvbUdldHRlcl0gcmVhZG9ubHkgYXR0cmli dXRlIEV2ZW50IGV2ZW50OwogICAgIGF0dHJpYnV0ZSBET01TdHJpbmcgZGVmYXVsdFN0YXR1czsK ICAgICBbSW1wbGVtZW50ZWRBcz1kZWZhdWx0U3RhdHVzXSBhdHRyaWJ1dGUgRE9NU3RyaW5nIGRl ZmF1bHRzdGF0dXM7IC8vIEZvciBjb21wYXRpYmlsaXR5IHdpdGggbGVnYWN5IGNvbnRlbnQuCi0g ICAgYm9vbGVhbiBmaW5kKG9wdGlvbmFsIERPTVN0cmluZyBzdHJpbmcsIG9wdGlvbmFsIGJvb2xl YW4gY2FzZVNlbnNpdGl2ZSA9IGZhbHNlLCBvcHRpb25hbCBib29sZWFuIGJhY2t3YXJkcyA9IGZh bHNlLCBvcHRpb25hbCBib29sZWFuIHdyYXAgPSBmYWxzZSwgb3B0aW9uYWwgYm9vbGVhbiB3aG9s ZVdvcmQgPSBmYWxzZSwgb3B0aW9uYWwgYm9vbGVhbiBzZWFyY2hJbkZyYW1lcyA9IGZhbHNlLCBv cHRpb25hbCBib29sZWFuIHNob3dEaWFsb2cgPSBmYWxzZSk7IC8vIEZJWE1FOiBVc2luZyAidW5k ZWZpbmVkIiBhcyBkZWZhdWx0IHBhcmFtZXRlciB2YWx1ZSBpcyB3cm9uZy4KKyAgICBib29sZWFu IGZpbmQob3B0aW9uYWwgRE9NU3RyaW5nIHN0cmluZywgb3B0aW9uYWwgYm9vbGVhbiBjYXNlU2Vu c2l0aXZlID0gZmFsc2UsIG9wdGlvbmFsIGJvb2xlYW4gYmFja3dhcmRzID0gZmFsc2UsIG9wdGlv bmFsIGJvb2xlYW4gd3JhcCA9IGZhbHNlLCBvcHRpb25hbCBib29sZWFuIHdob2xlV29yZCA9IGZh bHNlLCBvcHRpb25hbCBib29sZWFuIHNlYXJjaEluRnJhbWVzID0gZmFsc2UsIG9wdGlvbmFsIGJv b2xlYW4gc2hvd0RpYWxvZyA9IGZhbHNlKTsKICAgICBbUmVwbGFjZWFibGVdIHJlYWRvbmx5IGF0 dHJpYnV0ZSAgYm9vbGVhbiBvZmZzY3JlZW5CdWZmZXJpbmc7CiAgICAgW1JlcGxhY2VhYmxlXSBy ZWFkb25seSBhdHRyaWJ1dGUgbG9uZyBzY3JlZW5MZWZ0OwogICAgIFtSZXBsYWNlYWJsZV0gcmVh ZG9ubHkgYXR0cmlidXRlIGxvbmcgc2NyZWVuVG9wOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvc3ZnL1NWR1Rlc3RzLmlkbCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdUZXN0cy5pZGwKaW5k ZXggZDgxZGI3YmNiOTMxNjMxYTgwNDM0ZDA3NWY3MTUwZmY3NjBkMjZmMS4uODY1Y2MzOTJjOWEx YWQ5NDg4MTNkZGIwODA1MTAyMDliMzdmYjBkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv c3ZnL1NWR1Rlc3RzLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVGVzdHMuaWRsCkBA IC0zMyw2ICszMyw1IEBAIGludGVyZmFjZSBtaXhpbiBTVkdUZXN0cyB7CiAgICAgLy8gQXMgb2Yg U1ZHMiwgdGhlIGZvbGxvd2luZyBhcmUgbm8gbG9uZ2VyIHBhcnQgb2YgdGhpcyBpbnRlcmZhY2Uu CiAKICAgICBbU2FtZU9iamVjdF0gcmVhZG9ubHkgYXR0cmlidXRlIFNWR1N0cmluZ0xpc3QgcmVx dWlyZWRGZWF0dXJlczsKLSAgICAvLyBGSVhNRTogVXNpbmcgInVuZGVmaW5lZCIgYXMgZGVmYXVs dCBwYXJhbWV0ZXIgdmFsdWUgaXMgd3JvbmcuCi0gICAgYm9vbGVhbiBoYXNFeHRlbnNpb24ob3B0 aW9uYWwgRE9NU3RyaW5nIGV4dGVuc2lvbiA9ICJ1bmRlZmluZWQiKTsKKyAgICBib29sZWFuIGhh c0V4dGVuc2lvbihET01TdHJpbmcgZXh0ZW5zaW9uKTsKIH07Cg==