216980 2020-09-25 10:31:00 -0700 REGRESSION (r267516): `--use-gpu-process` no longer enables GPU process when running layout tests 2020-09-25 12:04:37 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh eric.carlson ews-watchlist glenn jbedard jer.noble peng.liu6 thorton webkit-bug-importer oldest_to_newest 1691935 0 wenson_hsieh 2020-09-25 10:31:00 -0700 SSIA 1691936 1 409706 wenson_hsieh 2020-09-25 10:37:58 -0700 Created attachment 409706 Patch 1691939 2 thorton 2020-09-25 10:43:25 -0700 So glad these are strings 1691940 3 thorton 2020-09-25 10:43:48 -0700 Maybe we should assert (just for the purposes of testrunner; we don't want to do something more drastic in production) that features exist when turning them on? 1691943 4 wenson_hsieh 2020-09-25 10:49:48 -0700 (In reply to Tim Horton from comment #3) > Maybe we should assert (just for the purposes of testrunner; we don't want > to do something more drastic in production) that features exist when turning > them on? Sounds good — I’ll do this in a followup. 1691966 5 ews-feeder 2020-09-25 12:03:30 -0700 Committed r267586: <https://trac.webkit.org/changeset/267586> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409706. 1691969 6 webkit-bug-importer 2020-09-25 12:04:37 -0700 <rdar://problem/69585877> 409706 2020-09-25 10:37:58 -0700 2020-09-25 12:03:30 -0700 Patch bug-216980-20200925103757.patch text/plain 2424 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NTc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzg2ZTEzOTQwMjUyNGRmOTUzY2M4M2ExZDIzOTE1MjA4 MGZiYjk1ZS4uN2MzNzY2OGM3YzFhZjE0YWYzNDg0ZWI1ZmYxOTk5ZjE2YTFkOWZjYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIwLTA5LTI1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIFJFR1JFU1NJT04gKHIyNjc1MTYpOiBgLS11c2UtZ3B1LXByb2Nlc3NgIG5vIGxv bmdlciBlbmFibGVzIEdQVSBwcm9jZXNzIHdoZW4gcnVubmluZyBsYXlvdXQgdGVzdHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjk4MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmFtZSBgVXNlR1BV UHJvY2Vzc0Zvck1lZGlhYCBhbmQgYFJlbmRlckNhbnZhc0luR1BVUHJvY2Vzc0VuYWJsZWRgLCBh bmQgYWRkaXRpb25hbGx5IGVuYWJsZSBhIGZldyBpbnRlcm5hbAorICAgICAgICBmZWF0dXJlIGZs YWdzOiBgVXNlR1BVUHJvY2Vzc0ZvcldlYkdMRW5hYmxlZGAsIGBVc2VHUFVQcm9jZXNzRm9yRE9N UmVuZGVyaW5nRW5hYmxlZGAsIGFuZAorICAgICAgICBgQ2FwdHVyZVZpZGVvSW5HUFVQcm9jZXNz RW5hYmxlZGAuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5f d2Via2l0X3Rlc3RzLnB5OgorICAgICAgICAocGFyc2VfYXJncyk6CisKIDIwMjAtMDktMjUgIFlv dWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBkZWZh dWx0IGJlaGF2aW9yIGZvciBnZXRVc2VyTWVkaWEgcmVxdWVzdHMgaW4gY2FzZSB3aGVyZSB0aGVy ZSBpcyBubyBkZWxlZ2F0ZSBzZXQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CmluZGV4IDZjZmFhZjY2MGE1NGEzNTA2 ZDc1OGU3NTExNjUzNjk3ZGYwNWYzYTYuLjBkM2UzY2JkNjhkZWE5NTVhYWUwMmUzMjNkOTlkMDVm MDc2MzY0NGQgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3J1bl93ZWJraXRfdGVzdHMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQpAQCAtMzg0LDkgKzM4NCwxMiBAQCBkZWYgcGFyc2Vf YXJncyhhcmdzKToKICAgICAgICAgb3B0aW9ucy5hZGRpdGlvbmFsX2V4cGVjdGF0aW9ucy5pbnNl cnQoMCwgaG9zdC5maWxlc3lzdGVtLmpvaW4oaG9zdC5zY20oKS5jaGVja291dF9yb290LCAnTGF5 b3V0VGVzdHMvZ3B1LXByb2Nlc3MvVGVzdEV4cGVjdGF0aW9ucycpKQogICAgICAgICBpZiBub3Qg b3B0aW9ucy5pbnRlcm5hbF9mZWF0dXJlOgogICAgICAgICAgICAgb3B0aW9ucy5pbnRlcm5hbF9m ZWF0dXJlID0gW10KLSAgICAgICAgb3B0aW9ucy5pbnRlcm5hbF9mZWF0dXJlLmFwcGVuZCgnVXNl R1BVUHJvY2Vzc0Zvck1lZGlhJykKKyAgICAgICAgb3B0aW9ucy5pbnRlcm5hbF9mZWF0dXJlLmFw cGVuZCgnVXNlR1BVUHJvY2Vzc0Zvck1lZGlhRW5hYmxlZCcpCiAgICAgICAgIG9wdGlvbnMuaW50 ZXJuYWxfZmVhdHVyZS5hcHBlbmQoJ0NhcHR1cmVBdWRpb0luR1BVUHJvY2Vzc0VuYWJsZWQnKQot ICAgICAgICBvcHRpb25zLmludGVybmFsX2ZlYXR1cmUuYXBwZW5kKCdSZW5kZXJDYW52YXNJbkdQ VVByb2Nlc3NFbmFibGVkJykKKyAgICAgICAgb3B0aW9ucy5pbnRlcm5hbF9mZWF0dXJlLmFwcGVu ZCgnQ2FwdHVyZVZpZGVvSW5HUFVQcm9jZXNzRW5hYmxlZCcpCisgICAgICAgIG9wdGlvbnMuaW50 ZXJuYWxfZmVhdHVyZS5hcHBlbmQoJ1VzZUdQVVByb2Nlc3NGb3JDYW52YXNSZW5kZXJpbmdFbmFi bGVkJykKKyAgICAgICAgb3B0aW9ucy5pbnRlcm5hbF9mZWF0dXJlLmFwcGVuZCgnVXNlR1BVUHJv Y2Vzc0ZvckRPTVJlbmRlcmluZ0VuYWJsZWQnKQorICAgICAgICBvcHRpb25zLmludGVybmFsX2Zl YXR1cmUuYXBwZW5kKCdVc2VHUFVQcm9jZXNzRm9yV2ViR0xFbmFibGVkJykKICAgICAgICAgaWYg b3B0aW9ucy5yZXN1bHRfcmVwb3J0X2ZsYXZvcjoKICAgICAgICAgICAgIHJhaXNlIFJ1bnRpbWVF cnJvcignLS11c2UtZ3B1LXByb2Nlc3MgaW1wbGljaXRseSBzZXRzIHRoZSByZXN1bHQgZmxhdm9y LCB0aGlzIHNob3VsZCBub3QgYmUgb3ZlcnJpZGRlbicpCiAgICAgICAgIG9wdGlvbnMucmVzdWx0 X3JlcG9ydF9mbGF2b3IgPSAnZ3B1cHJvY2VzcycK