216976 2020-09-25 08:25:59 -0700 [LFC][Out-of-flow] ASSERTION FAILED: !layoutBox.isOutOfFlowPositioned() in WebCore::Layout::FormattingContext::Geometry::computedHeightValue 2020-09-25 09:06:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1691892 0 zalan 2020-09-25 08:25:59 -0700 ssia 1691894 1 409697 zalan 2020-09-25 08:31:31 -0700 Created attachment 409697 Patch 1691895 2 409697 koivisto 2020-09-25 08:33:05 -0700 Comment on attachment 409697 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409697&action=review > Source/WebCore/layout/FormattingContextGeometry.cpp:-1177 > - // FIXME: Find out if min/max-height properties should also be taken into account here. I guess we found out! 1691897 3 zalan 2020-09-25 08:39:51 -0700 (In reply to Antti Koivisto from comment #2) > Comment on attachment 409697 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409697&action=review > > > Source/WebCore/layout/FormattingContextGeometry.cpp:-1177 > > - // FIXME: Find out if min/max-height properties should also be taken into account here. > > I guess we found out! Most certainly we did! 1691903 4 ews-feeder 2020-09-25 09:05:48 -0700 Committed r267572: <https://trac.webkit.org/changeset/267572> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409697. 1691904 5 webkit-bug-importer 2020-09-25 09:06:18 -0700 <rdar://problem/69574883> 409697 2020-09-25 08:31:31 -0700 2020-09-25 09:05:49 -0700 Patch bug-216976-20200925083130.patch text/plain 6917 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTU5Y2NhNDg4YWIyY2M2 YTllZDkxYmI3ZWRlOGEyNjRmOTQxODI4Yy4uY2ZiMmQ2NTUwNjEwY2QxMGM5YzM0MTc2OTcwMjZm ZDBhNDViMGJkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTA5LTI1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bT3V0LW9mLWZsb3dd IEFTU0VSVElPTiBGQUlMRUQ6ICFsYXlvdXRCb3guaXNPdXRPZkZsb3dQb3NpdGlvbmVkKCkgaW4g V2ViQ29yZTo6TGF5b3V0OjpGb3JtYXR0aW5nQ29udGV4dDo6R2VvbWV0cnk6OmNvbXB1dGVkSGVp Z2h0VmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxNjk3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEdlb21ldHJ5Ojpjb21wdXRlZEhlaWdodFZhbHVlIGlzIGEgc2ltcGxlIHJlc29sdmVyIGZ1bmN0 aW9uLiBJdCBzaG91bGQgbm90IHJlYWxseSBjYXJlIGFib3V0CisgICAgICAgIHdoZXRoZXIgdGhl IGJveCdzIGNvbnRhaW5pbmcgYmxvY2sgaGFzIHZhbGlkIHZlcnRpY2FsIGdlb21ldHJ5LiBUaGUg Y2FsbHNpdGUgKHdoZXJlIHRoaXMgYXNzZXJ0IGlzIGltcG9ydGFudCkgaXMgYWxyZWFkeSB0ZXN0 aW5nIHRoaXMgY29uZGl0aW9uLgorCisgICAgICAgIFRlc3Q6IGZhc3QvbGF5b3V0Zm9ybWF0dGlu Z2NvbnRleHQvb3V0LW9mLWZsb3ctd2l0aC1ub24tZml4ZWQtaGVpZ2h0LXNpbXBsZS5odG1sCisK KyAgICAgICAgKiBsYXlvdXQvRm9ybWF0dGluZ0NvbnRleHQuaDoKKyAgICAgICAgKiBsYXlvdXQv Rm9ybWF0dGluZ0NvbnRleHRHZW9tZXRyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6 OkZvcm1hdHRpbmdDb250ZXh0OjpHZW9tZXRyeTo6Y29tcHV0ZWRIZWlnaHRWYWx1ZSBjb25zdCk6 CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkZvcm1hdHRpbmdDb250ZXh0OjpHZW9tZXRyeTo6 Y29uc3RyYWludHNGb3JJbkZsb3dDb250ZW50KToKKyAgICAgICAgKiBsYXlvdXQvYmxvY2tmb3Jt YXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5 b3V0OjpCbG9ja0Zvcm1hdHRpbmdDb250ZXh0OjpsYXlvdXRJbkZsb3dDb250ZW50KToKKwogMjAy MC0wOS0yMyAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNvbT4KIAogICAgICAgICBN aXNzaW5nIHNjb3BlIHJlbGVhc2UgaW4gSlNET01CdWlsdGluQ29uc3RydWN0b3JCYXNlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvRm9ybWF0dGluZ0NvbnRleHQuaCBiL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9Gb3JtYXR0aW5nQ29udGV4dC5oCmluZGV4IDJhMjEyZGZiYTc1OTNl YWEyMjdkYjk2MTZjNjc2MDBhMWNjY2JhNTMuLjQxY2JmZTZiMGYyOGRlNmQ3YjgyZDZjOTc5YTUy NDFmMGNhZTg5MTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9Gb3JtYXR0aW5n Q29udGV4dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9Gb3JtYXR0aW5nQ29udGV4dC5o CkBAIC00MCw3ICs0MCw2IEBAIHN0cnVjdCBMZW5ndGg7CiAKIG5hbWVzcGFjZSBMYXlvdXQgewog Ci1jbGFzcyBCb3g7CiBjbGFzcyBCb3hHZW9tZXRyeTsKIGNsYXNzIFJlcGxhY2VkQm94Owogc3Ry dWN0IENvbXB1dGVkSG9yaXpvbnRhbE1hcmdpbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9Gb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9Gb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcAppbmRleCA1MzcwNTk3NjU5ZWQ1YmE2 NTA1ZGI5ODVhMWQwODUzMDk5NThhZDFlLi5jZmY2MzM0NGNlOTM2M2QwOTk5ZGJlNmM1ZjhhMTMy Y2JjOTAyYzFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvRm9ybWF0dGluZ0Nv bnRleHRHZW9tZXRyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L0Zvcm1hdHRpbmdD b250ZXh0R2VvbWV0cnkuY3BwCkBAIC03NCw4ICs3NCw2IEBAIE9wdGlvbmFsPExheW91dFVuaXQ+ IEZvcm1hdHRpbmdDb250ZXh0OjpHZW9tZXRyeTo6Y29tcHV0ZWRIZWlnaHRWYWx1ZShjb25zdCBC b3gmCiAgICAgICAgIHJldHVybiBMYXlvdXRVbml0IHsgaGVpZ2h0LnZhbHVlKCkgfTsKIAogICAg IGlmICghY29udGFpbmluZ0Jsb2NrSGVpZ2h0KSB7Ci0gICAgICAgIC8vIENvbnRhaW5pbmcgYmxv Y2sncyBoZWlnaHQgaXMgYWxyZWFkeSBjb21wdXRlZCBzaW5jZSB3ZSBsYXlvdXQgdGhlIG91dC1v Zi1mbG93IGJveGVzIGFzIHRoZSBsYXN0IHN0ZXAuCi0gICAgICAgIEFTU0VSVCghbGF5b3V0Qm94 LmlzT3V0T2ZGbG93UG9zaXRpb25lZCgpKTsKICAgICAgICAgaWYgKGxheW91dFN0YXRlKCkuaW5R dWlya3NNb2RlKCkpCiAgICAgICAgICAgICBjb250YWluaW5nQmxvY2tIZWlnaHQgPSBmb3JtYXR0 aW5nQ29udGV4dCgpLnF1aXJrcygpLmhlaWdodFZhbHVlT2ZOZWFyZXN0Q29udGFpbmluZ0Jsb2Nr V2l0aEZpeGVkSGVpZ2h0KGxheW91dEJveCk7CiAgICAgICAgIGVsc2UgewpAQCAtMTE3NCw3ICsx MTcyLDYgQEAgRm9ybWF0dGluZ0NvbnRleHQ6OkNvbnN0cmFpbnRzRm9yT3V0T2ZGbG93Q29udGVu dCBGb3JtYXR0aW5nQ29udGV4dDo6R2VvbWV0cnk6OmMKIEZvcm1hdHRpbmdDb250ZXh0OjpDb25z dHJhaW50c0ZvckluRmxvd0NvbnRlbnQgRm9ybWF0dGluZ0NvbnRleHQ6Okdlb21ldHJ5Ojpjb25z dHJhaW50c0ZvckluRmxvd0NvbnRlbnQoY29uc3QgQ29udGFpbmVyQm94JiBjb250YWluZXJCb3gs IE9wdGlvbmFsPEVzY2FwZVJlYXNvbj4gZXNjYXBlUmVhc29uKQogewogICAgIGF1dG8mIGJveEdl b21ldHJ5ID0gZm9ybWF0dGluZ0NvbnRleHQoKS5nZW9tZXRyeUZvckJveChjb250YWluZXJCb3gs IGVzY2FwZVJlYXNvbik7Ci0gICAgLy8gRklYTUU6IEZpbmQgb3V0IGlmIG1pbi9tYXgtaGVpZ2h0 IHByb3BlcnRpZXMgc2hvdWxkIGFsc28gYmUgdGFrZW4gaW50byBhY2NvdW50IGhlcmUuCiAgICAg cmV0dXJuIHsgeyBib3hHZW9tZXRyeS5jb250ZW50Qm94TGVmdCgpLCBib3hHZW9tZXRyeS5jb250 ZW50Qm94V2lkdGgoKSB9LCB7IGJveEdlb21ldHJ5LmNvbnRlbnRCb3hUb3AoKSwgY29tcHV0ZWRI ZWlnaHQoY29udGFpbmVyQm94KSB9IH07CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQu Y3BwCmluZGV4IGFiMzE1ZjE1ZjBlMDI0MWJlZjdmZTMzOGY1ZWVjOWQyODFiYzI5OTguLmI2M2Jh YWViODQwNmVhZGEyNmNmZmEwMTBmOGJhZjA5Njk2ZGJmNWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRp bmdDb250ZXh0LmNwcApAQCAtMTQ3LDcgKzE0Nyw3IEBAIHZvaWQgQmxvY2tGb3JtYXR0aW5nQ29u dGV4dDo6bGF5b3V0SW5GbG93Q29udGVudChJbnZhbGlkYXRpb25TdGF0ZSYgaW52YWxpZGF0aW9u CiAKICAgICAgICAgICAgIGF1dG8gZXN0YWJsaXNoZXNGb3JtYXR0aW5nQ29udGV4dCA9IGxheW91 dEJveC5lc3RhYmxpc2hlc0Zvcm1hdHRpbmdDb250ZXh0KCk7IAogICAgICAgICAgICAgaWYgKGVz dGFibGlzaGVzRm9ybWF0dGluZ0NvbnRleHQpIHsKLSAgICAgICAgICAgICAgICAvLyBOb3cgdGhh dCB3ZSBjb21wdXRlZCB0aGUgcm9vdCdzIGhlaWdodCwgd2UgY2FuIGxheW91dCB0aGUgb3V0LW9m LWZsb3cgZGVzY2VuZGFudHMuCisgICAgICAgICAgICAgICAgLy8gTm93IHRoYXQgd2UgY29tcHV0 ZWQgdGhlIGJveCdzIGhlaWdodCwgd2UgY2FuIGxheW91dCB0aGUgb3V0LW9mLWZsb3cgZGVzY2Vu ZGFudHMuCiAgICAgICAgICAgICAgICAgaWYgKGlzPENvbnRhaW5lckJveD4obGF5b3V0Qm94KSAm JiBkb3duY2FzdDxDb250YWluZXJCb3g+KGxheW91dEJveCkuaGFzQ2hpbGQoKSkgewogICAgICAg ICAgICAgICAgICAgICBhdXRvJiBjb250YWluZXJCb3ggPSBkb3duY2FzdDxDb250YWluZXJCb3g+ KGxheW91dEJveCk7CiAgICAgICAgICAgICAgICAgICAgIExheW91dENvbnRleHQ6OmNyZWF0ZUZv cm1hdHRpbmdDb250ZXh0KGNvbnRhaW5lckJveCwgbGF5b3V0U3RhdGUoKSktPmxheW91dE91dE9m Rmxvd0NvbnRlbnQoaW52YWxpZGF0aW9uU3RhdGUsIGdlb21ldHJ5KCkuY29uc3RyYWludHNGb3JP dXRPZkZsb3dDb250ZW50KGNvbnRhaW5lckJveCkpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDgxM2MyNDY0YzYwMmUxNWI5 MWZkODRjODFhOWQwOWU5MzQ3YWY2ZmYuLjJhZDk5OGEzOWE4YTNmMTAwZDVlYjI0NGIzMTlmMTQ2 MjhjMzJhZWYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wOS0yNSAgWmFsYW4gQnVqdGFz ICA8emFsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFtMRkNdW091dC1vZi1mbG93XSBBU1NFUlRJ T04gRkFJTEVEOiAhbGF5b3V0Qm94LmlzT3V0T2ZGbG93UG9zaXRpb25lZCgpIGluIFdlYkNvcmU6 OkxheW91dDo6Rm9ybWF0dGluZ0NvbnRleHQ6Okdlb21ldHJ5Ojpjb21wdXRlZEhlaWdodFZhbHVl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY5NzYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3Qv bGF5b3V0Zm9ybWF0dGluZ2NvbnRleHQvb3V0LW9mLWZsb3ctd2l0aC1ub24tZml4ZWQtaGVpZ2h0 LXNpbXBsZS1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2xheW91dGZvcm1h dHRpbmdjb250ZXh0L291dC1vZi1mbG93LXdpdGgtbm9uLWZpeGVkLWhlaWdodC1zaW1wbGUuaHRt bDogQWRkZWQuCisKIDIwMjAtMDktMjMgIFRhZGV1IFphZ2FsbG8gIDx0emFnYWxsb0BhcHBsZS5j b20+CiAKICAgICAgICAgTWlzc2luZyBzY29wZSByZWxlYXNlIGluIEpTRE9NQnVpbHRpbkNvbnN0 cnVjdG9yQmFzZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9sYXlvdXRmb3JtYXR0aW5n Y29udGV4dC9vdXQtb2YtZmxvdy13aXRoLW5vbi1maXhlZC1oZWlnaHQtc2ltcGxlLWV4cGVjdGVk Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L291dC1vZi1m bG93LXdpdGgtbm9uLWZpeGVkLWhlaWdodC1zaW1wbGUtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li42ZDZjMzExOGUyZWJlZjRjY2Y0MWU1YTEzZTRkNWM3MjgwOGMyZjJjCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9sYXlvdXRmb3JtYXR0aW5nY29udGV4dC9vdXQtb2YtZmxv dy13aXRoLW5vbi1maXhlZC1oZWlnaHQtc2ltcGxlLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSw5 IEBACis8IURPQ1RZUEUgaHRtbD4gPCEtLSB3ZWJraXQtdGVzdC1ydW5uZXIgWyBpbnRlcm5hbDpM YXlvdXRGb3JtYXR0aW5nQ29udGV4dEVuYWJsZWQ9dHJ1ZSBpbnRlcm5hbDpMYXlvdXRGb3JtYXR0 aW5nQ29udGV4dEludGVncmF0aW9uRW5hYmxlZD1mYWxzZSBdIC0tPgorPHN0eWxlPgorZGl2IHsK KyAgd2lkdGg6IDEwMHB4OyAKKyAgaGVpZ2h0OiAxMDBweDsKKyAgYmFja2dyb3VuZC1jb2xvcjog Z3JlZW47Cit9Cis8L3N0eWxlPgorPGRpdj48L2Rpdj4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvbGF5b3V0Zm9ybWF0dGluZ2NvbnRleHQvb3V0LW9mLWZsb3ctd2l0aC1ub24tZml4ZWQt aGVpZ2h0LXNpbXBsZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9sYXlvdXRmb3JtYXR0aW5nY29u dGV4dC9vdXQtb2YtZmxvdy13aXRoLW5vbi1maXhlZC1oZWlnaHQtc2ltcGxlLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uODY4MzZmOWNlNzIyMGQ5MzBmOTcyZDZkMTU3MGZiMDU5ZDg3ZjdlZgotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvbGF5b3V0Zm9ybWF0dGluZ2NvbnRleHQvb3V0LW9m LWZsb3ctd2l0aC1ub24tZml4ZWQtaGVpZ2h0LXNpbXBsZS5odG1sCkBAIC0wLDAgKzEsMTcgQEAK KzwhRE9DVFlQRSBodG1sPiA8IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIGludGVybmFsOkxheW91 dEZvcm1hdHRpbmdDb250ZXh0RW5hYmxlZD10cnVlIGludGVybmFsOkxheW91dEZvcm1hdHRpbmdD b250ZXh0SW50ZWdyYXRpb25FbmFibGVkPWZhbHNlIF0gLS0+Cis8c3R5bGU+CisuY29udGFpbmVy IHsKKyAgcG9zaXRpb246IHJlbGF0aXZlOworICBoZWlnaHQ6IDIwMHB4OworfQorCisuY2hpbGQg eworICB3aWR0aDogMTAwcHg7IAorICBoZWlnaHQ6IDUwJTsKKyAgcG9zaXRpb246IGFic29sdXRl OyAKKyAgdG9wOiAwcHg7CisgIGxlZnQ6IDBweDsKKyAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47 Cit9Cis8L3N0eWxlPgorPGRpdiBjbGFzcz1jb250YWluZXI+PGRpdiBjbGFzcz1jaGlsZD48ZGl2 PjwvZGl2PjwvZGl2PjwvZGl2Pgo=