216946 2020-09-24 15:47:42 -0700 Clean up VideoLayerManagerObjC 2020-09-25 09:25:16 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 peng.liu6 peng.liu6 eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1691695 0 peng.liu6 2020-09-24 15:47:42 -0700 Clean up VideoLayerManagerObjC 1691698 1 409629 peng.liu6 2020-09-24 15:52:46 -0700 Created attachment 409629 Patch 1691909 2 ews-feeder 2020-09-25 09:24:38 -0700 Committed r267573: <https://trac.webkit.org/changeset/267573> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409629. 1691910 3 webkit-bug-importer 2020-09-25 09:25:16 -0700 <rdar://problem/69575850> 409629 2020-09-24 15:52:46 -0700 2020-09-25 09:24:38 -0700 Patch bug-216946-20200924155246.patch text/plain 5864 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjg1NWY3YjgyZTIyZWYw NjA5ODBmZmVkYzRjZGFkZTRhYzBkODQ5MS4uZTJiNmQ2NGVmNTBkMzI3ZTNlMDA4NmE1ZTg3MDJj ODUwNGM5MjljMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTA5LTI0ICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgQ2xlYW4gdXAgVmlkZW9MYXll ck1hbmFnZXJPYmpDCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTY5NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBSZW1vdmUgbV92aWRlb0lubGluZUZyYW1lLiBBbHNvLCBjaGFuZ2UgdGhlIG9yZGVyIG9m IHNvbWUgdmFyaWFibGVzCisgICAgICAgIGFuZCBmdW5jdGlvbnMgdG8gcHV0IHJlbGF0ZWQgdGhp bmdzIHRvZ2V0aGVyLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSBubyBmdW5jdGlvbmFs IGNoYW5nZXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2Jq Yy9WaWRlb0xheWVyTWFuYWdlck9iakMuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9h dmZvdW5kYXRpb24vb2JqYy9WaWRlb0xheWVyTWFuYWdlck9iakMubW06CisgICAgICAgIChXZWJD b3JlOjpWaWRlb0xheWVyTWFuYWdlck9iakM6OnNldFZpZGVvTGF5ZXIpOgorICAgICAgICAoV2Vi Q29yZTo6VmlkZW9MYXllck1hbmFnZXJPYmpDOjpkaWREZXN0cm95VmlkZW9MYXllcik6CisgICAg ICAgIChXZWJDb3JlOjpWaWRlb0xheWVyTWFuYWdlck9iakM6OnNldFZpZGVvRnVsbHNjcmVlbkxh eWVyKToKKwogMjAyMC0wOS0yNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgUkVHUkVTU0lPTiAoaU9TL1NhZmFyaSAxNCk6IE1lZGlhUmVjb3JkZXIgcHJvZHVj ZXMgaW52YWxpZCB2aWRlbyBmaWxlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvVmlkZW9MYXllck1hbmFnZXJPYmpDLmggYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9WaWRlb0xh eWVyTWFuYWdlck9iakMuaAppbmRleCBhZDlhZDZkZmU5YWVjNzAyNzczMzllOWE3M2QzY2RiYTBi NDkzNjQwLi4yMTI4NzBhODg2NDE2YWMzM2M4OTNkOTlmYWVhZTI3MmE3NTE0NThiIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9W aWRlb0xheWVyTWFuYWdlck9iakMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9hdmZvdW5kYXRpb24vb2JqYy9WaWRlb0xheWVyTWFuYWdlck9iakMuaApAQCAtNDYsMTUg KzQ2LDE2IEBAIHB1YmxpYzoKICAgICBWaWRlb0xheWVyTWFuYWdlck9iakMoY29uc3QgTG9nZ2Vy JiwgY29uc3Qgdm9pZCopOwogCiAgICAgUGxhdGZvcm1MYXllciAqdmlkZW9JbmxpbmVMYXllcigp IGNvbnN0IHsgcmV0dXJuIG1fdmlkZW9JbmxpbmVMYXllci5nZXQoKTsgfQorCiAgICAgdm9pZCBz ZXRWaWRlb0xheWVyKFBsYXRmb3JtTGF5ZXIgKiwgSW50U2l6ZSBjb250ZW50U2l6ZSk7CiAgICAg dm9pZCBkaWREZXN0cm95VmlkZW9MYXllcigpOwogCiAjaWYgRU5BQkxFKFZJREVPX1BSRVNFTlRB VElPTl9NT0RFKQogICAgIFBsYXRmb3JtTGF5ZXIgKnZpZGVvRnVsbHNjcmVlbkxheWVyKCkgY29u c3QgeyByZXR1cm4gbV92aWRlb0Z1bGxzY3JlZW5MYXllci5nZXQoKTsgfQotICAgIEZsb2F0UmVj dCB2aWRlb0Z1bGxzY3JlZW5GcmFtZSgpIGNvbnN0IHsgcmV0dXJuIG1fdmlkZW9GdWxsc2NyZWVu RnJhbWU7IH0KICAgICB2b2lkIHNldFZpZGVvRnVsbHNjcmVlbkxheWVyKFBsYXRmb3JtTGF5ZXIg KiwgV1RGOjpGdW5jdGlvbjx2b2lkKCk+JiYgY29tcGxldGlvbkhhbmRsZXIsIE5hdGl2ZUltYWdl UHRyKTsKLSAgICB2b2lkIHVwZGF0ZVZpZGVvRnVsbHNjcmVlbklubGluZUltYWdlKE5hdGl2ZUlt YWdlUHRyKTsKKyAgICBGbG9hdFJlY3QgdmlkZW9GdWxsc2NyZWVuRnJhbWUoKSBjb25zdCB7IHJl dHVybiBtX3ZpZGVvRnVsbHNjcmVlbkZyYW1lOyB9CiAgICAgdm9pZCBzZXRWaWRlb0Z1bGxzY3Jl ZW5GcmFtZShGbG9hdFJlY3QpOworICAgIHZvaWQgdXBkYXRlVmlkZW9GdWxsc2NyZWVuSW5saW5l SW1hZ2UoTmF0aXZlSW1hZ2VQdHIpOwogI2VuZGlmCiAKICAgICBib29sIHJlcXVpcmVzVGV4dFRy YWNrUmVwcmVzZW50YXRpb24oKSBjb25zdDsKQEAgLTcwLDEzICs3MSwxMyBAQCBwcml2YXRlOgog ICAgIFJlZjxjb25zdCBMb2dnZXI+IG1fbG9nZ2VyOwogICAgIGNvbnN0IHZvaWQqIG1fbG9nSWRl bnRpZmllcjsKIAotICAgIFJldGFpblB0cjxQbGF0Zm9ybUxheWVyPiBtX3RleHRUcmFja1JlcHJl c2VudGF0aW9uTGF5ZXI7CiAgICAgUmV0YWluUHRyPFdlYlZpZGVvQ29udGFpbmVyTGF5ZXI+IG1f dmlkZW9JbmxpbmVMYXllcjsKLSAgICBGbG9hdFJlY3QgbV92aWRlb0lubGluZUZyYW1lOwogI2lm IEVOQUJMRShWSURFT19QUkVTRU5UQVRJT05fTU9ERSkKICAgICBSZXRhaW5QdHI8UGxhdGZvcm1M YXllcj4gbV92aWRlb0Z1bGxzY3JlZW5MYXllcjsKICAgICBGbG9hdFJlY3QgbV92aWRlb0Z1bGxz Y3JlZW5GcmFtZTsKICNlbmRpZgorICAgIFJldGFpblB0cjxQbGF0Zm9ybUxheWVyPiBtX3RleHRU cmFja1JlcHJlc2VudGF0aW9uTGF5ZXI7CisKICAgICBSZXRhaW5QdHI8UGxhdGZvcm1MYXllcj4g bV92aWRlb0xheWVyOwogfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvVmlkZW9MYXllck1hbmFnZXJPYmpDLm1tIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvVmlkZW9MYXll ck1hbmFnZXJPYmpDLm1tCmluZGV4IDJhN2JiM2YzZTMwMGQ5NzVjZTBkNWI0M2VkYTQ2YmUzNmE3 OTFiZDEuLmQ1MGQ3MjM2OGFjZTRiNjQxOWE3NTYwYTExNGJiN2E2OTRmNzM0NTMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL1Zp ZGVvTGF5ZXJNYW5hZ2VyT2JqQy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9hdmZvdW5kYXRpb24vb2JqYy9WaWRlb0xheWVyTWFuYWdlck9iakMubW0KQEAgLTU4LDgg KzU4LDcgQEAgdm9pZCBWaWRlb0xheWVyTWFuYWdlck9iakM6OnNldFZpZGVvTGF5ZXIoUGxhdGZv cm1MYXllciAqdmlkZW9MYXllciwgSW50U2l6ZSBjb24KIAogICAgIG1fdmlkZW9JbmxpbmVMYXll ciA9IGFkb3B0TlMoW1tXZWJWaWRlb0NvbnRhaW5lckxheWVyIGFsbG9jXSBpbml0XSk7CiAgICAg W21fdmlkZW9JbmxpbmVMYXllciBzZXROYW1lOkAiV2ViVmlkZW9Db250YWluZXJMYXllciJdOwot ICAgIG1fdmlkZW9JbmxpbmVGcmFtZSA9IENHUmVjdE1ha2UoMCwgMCwgY29udGVudFNpemUud2lk dGgoKSwgY29udGVudFNpemUuaGVpZ2h0KCkpOwotICAgIFttX3ZpZGVvSW5saW5lTGF5ZXIgc2V0 RnJhbWU6bV92aWRlb0lubGluZUZyYW1lXTsKKyAgICBbbV92aWRlb0lubGluZUxheWVyIHNldEZy YW1lOkNHUmVjdE1ha2UoMCwgMCwgY29udGVudFNpemUud2lkdGgoKSwgY29udGVudFNpemUuaGVp Z2h0KCkpXTsKICAgICBbbV92aWRlb0lubGluZUxheWVyIHNldENvbnRlbnRzR3Jhdml0eTprQ0FH cmF2aXR5UmVzaXplQXNwZWN0XTsKICAgICBpZiAoUEFMOjppc0FWRm91bmRhdGlvbkZyYW1ld29y a0F2YWlsYWJsZSgpICYmIFt2aWRlb0xheWVyIGlzS2luZE9mQ2xhc3M6UEFMOjpnZXRBVlBsYXll ckxheWVyQ2xhc3MoKV0pCiAgICAgICAgIFttX3ZpZGVvSW5saW5lTGF5ZXIgc2V0UGxheWVyTGF5 ZXI6KEFWUGxheWVyTGF5ZXIgKil2aWRlb0xheWVyXTsKQEAgLTcxLDExICs3MCwyMSBAQCB2b2lk IFZpZGVvTGF5ZXJNYW5hZ2VyT2JqQzo6c2V0VmlkZW9MYXllcihQbGF0Zm9ybUxheWVyICp2aWRl b0xheWVyLCBJbnRTaXplIGNvbgogICAgIH0gZWxzZQogI2VuZGlmCiAgICAgewotICAgICAgICBb bV92aWRlb0lubGluZUxheWVyIGluc2VydFN1YmxheWVyOm1fdmlkZW9MYXllci5nZXQoKSBhdElu ZGV4OjBdOwogICAgICAgICBbbV92aWRlb0xheWVyIHNldEZyYW1lOm1fdmlkZW9JbmxpbmVMYXll ci5nZXQoKS5ib3VuZHNdOworICAgICAgICBbbV92aWRlb0lubGluZUxheWVyIGluc2VydFN1Ymxh eWVyOm1fdmlkZW9MYXllci5nZXQoKSBhdEluZGV4OjBdOwogICAgIH0KIH0KIAordm9pZCBWaWRl b0xheWVyTWFuYWdlck9iakM6OmRpZERlc3Ryb3lWaWRlb0xheWVyKCkKK3sKKyAgICBBTFdBWVNf TE9HKExPR0lERU5USUZJRVIpOworCisgICAgW21fdmlkZW9MYXllciByZW1vdmVGcm9tU3VwZXJs YXllcl07CisKKyAgICBtX3ZpZGVvSW5saW5lTGF5ZXIgPSBuaWw7CisgICAgbV92aWRlb0xheWVy ID0gbmlsOworfQorCiAjaWYgRU5BQkxFKFZJREVPX1BSRVNFTlRBVElPTl9NT0RFKQogCiB2b2lk IFZpZGVvTGF5ZXJNYW5hZ2VyT2JqQzo6dXBkYXRlVmlkZW9GdWxsc2NyZWVuSW5saW5lSW1hZ2Uo TmF0aXZlSW1hZ2VQdHIgaW1hZ2UpCkBAIC0xMDUsOCArMTE0LDggQEAgdm9pZCBWaWRlb0xheWVy TWFuYWdlck9iakM6OnNldFZpZGVvRnVsbHNjcmVlbkxheWVyKFBsYXRmb3JtTGF5ZXIgKnZpZGVv RnVsbHNjcmUKICAgICAgICAgICAgIFttX3ZpZGVvSW5saW5lTGF5ZXIgc2V0Q29udGVudHM6KF9f YnJpZGdlIGlkKWN1cnJlbnRJbWFnZS5nZXQoKV07CiAKICAgICAgICAgaWYgKG1fdmlkZW9GdWxs c2NyZWVuTGF5ZXIpIHsKLSAgICAgICAgICAgIFttX3ZpZGVvRnVsbHNjcmVlbkxheWVyIGluc2Vy dFN1YmxheWVyOm1fdmlkZW9MYXllci5nZXQoKSBhdEluZGV4OjBdOwogICAgICAgICAgICAgW21f dmlkZW9MYXllciBzZXRGcmFtZTpDR1JlY3RNYWtlKDAsIDAsIG1fdmlkZW9GdWxsc2NyZWVuRnJh bWUud2lkdGgoKSwgbV92aWRlb0Z1bGxzY3JlZW5GcmFtZS5oZWlnaHQoKSldOworICAgICAgICAg ICAgW21fdmlkZW9GdWxsc2NyZWVuTGF5ZXIgaW5zZXJ0U3VibGF5ZXI6bV92aWRlb0xheWVyLmdl dCgpIGF0SW5kZXg6MF07CiAgICAgICAgIH0gZWxzZSBpZiAobV92aWRlb0lubGluZUxheWVyKSB7 CiAgICAgICAgICAgICBbbV92aWRlb0xheWVyIHNldEZyYW1lOlttX3ZpZGVvSW5saW5lTGF5ZXIg Ym91bmRzXV07CiAgICAgICAgICAgICBbbV92aWRlb0lubGluZUxheWVyIGluc2VydFN1YmxheWVy Om1fdmlkZW9MYXllci5nZXQoKSBhdEluZGV4OjBdOwpAQCAtMTQ1LDE2ICsxNTQsNiBAQCB2b2lk IFZpZGVvTGF5ZXJNYW5hZ2VyT2JqQzo6c2V0VmlkZW9GdWxsc2NyZWVuRnJhbWUoRmxvYXRSZWN0 IHZpZGVvRnVsbHNjcmVlbkZyYQogCiAjZW5kaWYKIAotdm9pZCBWaWRlb0xheWVyTWFuYWdlck9i akM6OmRpZERlc3Ryb3lWaWRlb0xheWVyKCkKLXsKLSAgICBBTFdBWVNfTE9HKExPR0lERU5USUZJ RVIpOwotCi0gICAgW21fdmlkZW9MYXllciByZW1vdmVGcm9tU3VwZXJsYXllcl07Ci0KLSAgICBt X3ZpZGVvSW5saW5lTGF5ZXIgPSBuaWw7Ci0gICAgbV92aWRlb0xheWVyID0gbmlsOwotfQotCiBi b29sIFZpZGVvTGF5ZXJNYW5hZ2VyT2JqQzo6cmVxdWlyZXNUZXh0VHJhY2tSZXByZXNlbnRhdGlv bigpIGNvbnN0CiB7CiAjaWYgRU5BQkxFKFZJREVPX1BSRVNFTlRBVElPTl9NT0RFKQo=