216934 2020-09-24 10:10:47 -0700 CrashTracer: com.apple.WebKit.Networking in NetworkSession::firstPartyHostCNAMEDomain() code 2020-09-24 13:16:42 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney achristensen darin ddkilzer wilander oldest_to_newest 1691558 0 katherine_cheney 2020-09-24 10:10:47 -0700 This seems to be crashing at auto iterator = m_firstPartyHostCNAMEDomains.find(firstPartyHost); 1691559 1 katherine_cheney 2020-09-24 10:12:32 -0700 <rdar://problem/69216768> 1691565 2 409593 katherine_cheney 2020-09-24 10:27:14 -0700 Created attachment 409593 Patch 1691574 3 409593 achristensen 2020-09-24 10:40:49 -0700 Comment on attachment 409593 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409593&action=review > Source/WebKit/NetworkProcess/NetworkSession.cpp:300 > + if (firstPartyHost.isNull()) Alternatively you could use decltype(m_firstPartyHostCNAMEDomains)::isValidKey 1691582 4 409599 katherine_cheney 2020-09-24 10:55:34 -0700 Created attachment 409599 Patch for landing 1691584 5 katherine_cheney 2020-09-24 10:55:56 -0700 (In reply to Alex Christensen from comment #3) > Comment on attachment 409593 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409593&action=review > > > Source/WebKit/NetworkProcess/NetworkSession.cpp:300 > > + if (firstPartyHost.isNull()) > > Alternatively you could use > decltype(m_firstPartyHostCNAMEDomains)::isValidKey fancy!! 1691609 6 ews-feeder 2020-09-24 11:29:27 -0700 Committed r267540: <https://trac.webkit.org/changeset/267540> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409599. 1691628 7 409599 darin 2020-09-24 12:19:09 -0700 Comment on attachment 409599 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=409599&action=review > Source/WebKit/NetworkProcess/NetworkSession.cpp:303 > + if (!decltype(m_firstPartyHostCNAMEDomains)::isValidKey(firstPartyHost)) > + return WTF::nullopt; > + > auto iterator = m_firstPartyHostCNAMEDomains.find(firstPartyHost); I think our HashTable design is working against us here (and elsewhere) we should add a safeFind function that does this. Or rename cpntains/find/get/take/remove to fastContains/fastFind/fastGet/fastTake/fastRemove and make this check a part of the slower ones. Not sure about "fast" and "safe" in the naming, but I think there are many cases we’d be wiling to spend the extra branches checking for reserved hash table key values. It’s a trickier design question if we could do this for add/set/ensure, since we’d have to define failure behavior. 1691651 8 katherine_cheney 2020-09-24 13:16:42 -0700 (In reply to Darin Adler from comment #7) > Comment on attachment 409599 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409599&action=review > > > Source/WebKit/NetworkProcess/NetworkSession.cpp:303 > > + if (!decltype(m_firstPartyHostCNAMEDomains)::isValidKey(firstPartyHost)) > > + return WTF::nullopt; > > + > > auto iterator = m_firstPartyHostCNAMEDomains.find(firstPartyHost); > > I think our HashTable design is working against us here (and elsewhere) we > should add a safeFind function that does this. Or rename > cpntains/find/get/take/remove to > fastContains/fastFind/fastGet/fastTake/fastRemove and make this check a part > of the slower ones. Not sure about "fast" and "safe" in the naming, but I > think there are many cases we’d be wiling to spend the extra branches > checking for reserved hash table key values. > > It’s a trickier design question if we could do this for add/set/ensure, > since we’d have to define failure behavior. Good idea, we can at least do the find() case to start. Tracking in rdar://problem/69521312. 409593 2020-09-24 10:27:14 -0700 2020-09-24 10:55:32 -0700 Patch bug-216934-20200924102713.patch text/plain 1610 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI0NGI0MWExMmNkMGMzOWQw MjUwZTkwZDhlY2FiYmYxYmEzNzVkNzMuLmRlZjg2NWQ5OThlZjFmMTBkODM2Y2FlOTNhZjE1MzY0 YWQ1ZmQ0ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDktMjQgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2hUcmFjZXI6 IGNvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZyBpbiBOZXR3b3JrU2Vzc2lvbjo6Zmlyc3RQYXJ0 eUhvc3RDTkFNRURvbWFpbigpIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxNjkzNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjkyMTY3Njg+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEg bnVsbCBzdHJpbmcgY2hlY2suCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrU2Vz c2lvbi5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtTZXNzaW9uOjpmaXJzdFBhcnR5SG9z dENOQU1FRG9tYWluKToKKwogMjAyMC0wOS0yNCAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFw cGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggdGhlIGJ1aWxkIGZvciByZWNlbnQg U0RLcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Nl c3Npb24uY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrU2Vzc2lvbi5j cHAKaW5kZXggYmMyOGFjOGY0YzcwNGZhNmI3NzE0MTU4Nzc4ODhjMjg1MGM0ZDhmZC4uMDEwZTA2 YmFmMTVkMDU1YWJiNTRlMDgxZjMxZTkxM2EzY2ZjNmJmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrU2Vzc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrU2Vzc2lvbi5jcHAKQEAgLTI5Nyw2ICsyOTcsOSBAQCB2 b2lkIE5ldHdvcmtTZXNzaW9uOjpzZXRGaXJzdFBhcnR5SG9zdENOQU1FRG9tYWluKFN0cmluZyYm IGZpcnN0UGFydHlIb3N0LCBXZWJDbwogT3B0aW9uYWw8V2ViQ29yZTo6UmVnaXN0cmFibGVEb21h aW4+IE5ldHdvcmtTZXNzaW9uOjpmaXJzdFBhcnR5SG9zdENOQU1FRG9tYWluKGNvbnN0IFN0cmlu ZyYgZmlyc3RQYXJ0eUhvc3QpCiB7CiAjaWYgSEFWRShDRk5FVFdPUktfQ05BTUVfQU5EX0NPT0tJ RV9UUkFOU0ZPUk1fU1BJKQorICAgIGlmIChmaXJzdFBhcnR5SG9zdC5pc051bGwoKSkKKyAgICAg ICAgcmV0dXJuIFdURjo6bnVsbG9wdDsKKwogICAgIGF1dG8gaXRlcmF0b3IgPSBtX2ZpcnN0UGFy dHlIb3N0Q05BTUVEb21haW5zLmZpbmQoZmlyc3RQYXJ0eUhvc3QpOwogICAgIGlmIChpdGVyYXRv ciA9PSBtX2ZpcnN0UGFydHlIb3N0Q05BTUVEb21haW5zLmVuZCgpKQogICAgICAgICByZXR1cm4g V1RGOjpudWxsb3B0Owo= 409599 2020-09-24 10:55:34 -0700 2020-09-24 11:29:27 -0700 Patch for landing bug-216934-20200924105533.patch text/plain 1660 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI0NGI0MWExMmNkMGMzOWQw MjUwZTkwZDhlY2FiYmYxYmEzNzVkNzMuLjVjMTNlZDNhOGQ5MDRjY2NhZWUwYzAxY2IzYjMzMTcy OWVmMjVhNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDktMjQgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2hUcmFjZXI6 IGNvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZyBpbiBOZXR3b3JrU2Vzc2lvbjo6Zmlyc3RQYXJ0 eUhvc3RDTkFNRURvbWFpbigpIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxNjkzNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjkyMTY3Njg+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleCBDaHJpc3RlbnNlbi4KKworICAgICAgICBBZGQg YSBjaGVjayBmb3IgYSB2YWxpZCBrZXkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrU2Vzc2lvbi5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtTZXNzaW9uOjpmaXJzdFBh cnR5SG9zdENOQU1FRG9tYWluKToKKwogMjAyMC0wOS0yNCAgUnlhbiBIYWRkYWQgIDxyeWFuaGFk ZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggdGhlIGJ1aWxkIGZvciBy ZWNlbnQgU0RLcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0 d29ya1Nlc3Npb24uY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrU2Vz c2lvbi5jcHAKaW5kZXggYmMyOGFjOGY0YzcwNGZhNmI3NzE0MTU4Nzc4ODhjMjg1MGM0ZDhmZC4u ZTg3NWJiOTg0YzAxNmUxNzNjMDdiMGM4NjU4MGE2ZDA0YWRiOThkNSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrU2Vzc2lvbi5jcHAKKysrIGIvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrU2Vzc2lvbi5jcHAKQEAgLTI5Nyw2ICsyOTcs OSBAQCB2b2lkIE5ldHdvcmtTZXNzaW9uOjpzZXRGaXJzdFBhcnR5SG9zdENOQU1FRG9tYWluKFN0 cmluZyYmIGZpcnN0UGFydHlIb3N0LCBXZWJDbwogT3B0aW9uYWw8V2ViQ29yZTo6UmVnaXN0cmFi bGVEb21haW4+IE5ldHdvcmtTZXNzaW9uOjpmaXJzdFBhcnR5SG9zdENOQU1FRG9tYWluKGNvbnN0 IFN0cmluZyYgZmlyc3RQYXJ0eUhvc3QpCiB7CiAjaWYgSEFWRShDRk5FVFdPUktfQ05BTUVfQU5E X0NPT0tJRV9UUkFOU0ZPUk1fU1BJKQorICAgIGlmICghZGVjbHR5cGUobV9maXJzdFBhcnR5SG9z dENOQU1FRG9tYWlucyk6OmlzVmFsaWRLZXkoZmlyc3RQYXJ0eUhvc3QpKQorICAgICAgICByZXR1 cm4gV1RGOjpudWxsb3B0OworCiAgICAgYXV0byBpdGVyYXRvciA9IG1fZmlyc3RQYXJ0eUhvc3RD TkFNRURvbWFpbnMuZmluZChmaXJzdFBhcnR5SG9zdCk7CiAgICAgaWYgKGl0ZXJhdG9yID09IG1f Zmlyc3RQYXJ0eUhvc3RDTkFNRURvbWFpbnMuZW5kKCkpCiAgICAgICAgIHJldHVybiBXVEY6Om51 bGxvcHQ7Cg==