216893 2020-09-23 13:22:19 -0700 [MIPS] Broken build after r267371 2020-09-25 10:27:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ticaiolima webkit-unassigned aakash_jain angelos aperez darin ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1691239 0 ticaiolima 2020-09-23 13:22:19 -0700 ... 1691240 1 409497 ticaiolima 2020-09-23 13:23:36 -0700 Created attachment 409497 WIP - Patch Send patch to check EWS 1691507 2 angelos 2020-09-24 07:32:52 -0700 OK this should fix it. While the bug in LabelReference.mapChildren is obvious (it just eats up the offset when returning a new LabelReference, essentially setting it to zero), it wasn't clear to us why this bug didn't affect any of the other architectures. I've only compared with X86_64 but suspect the same explanation applies to archs other than MIPS. What happens is that the AST from the parser only contains LabelReference(label, 0) + AddImmediates and AddImmediates.fold correctly constructs a LabelReference with an offset by calling LabelReference.plusOffset. We do call mapChildren on those on X86_64, however only in the context of a call to isASTErroneous which (somewhat ironically) simply checks the existence of Error nodes and discards the rest of the transformed AST, which would have the erroneous LabelReference nodes. However, on MIPS, mapChildren gets called in the lowering stage too, specifically: getModifiedListMIPS -> assignRegistersToTemporaries -> replaceTemporariesWithRegisters -> mapChildren and there the (erroneous) result is getting used, resulting in all LabelReference nodes having an offset of zero. 1691509 3 angelos 2020-09-24 07:35:53 -0700 With regard to the second hunk of the patch, there was a minor thinko in the initial fix; we need to look up the label in the GOT, not the computed address. Now that we have a good explanation for why the LabelReference.mapChildren issue is not biting other architectures, I think this is good to go in. 1691535 4 409580 angelos 2020-09-24 08:51:24 -0700 Created attachment 409580 Patch 1691543 5 ews-feeder 2020-09-24 09:17:04 -0700 Committed r267535: <https://trac.webkit.org/changeset/267535> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409580. 1691544 6 webkit-bug-importer 2020-09-24 09:18:15 -0700 <rdar://problem/69507244> 409497 2020-09-23 13:23:36 -0700 2020-09-25 10:27:32 -0700 WIP - Patch mips.diff text/plain 1545 ticaiolima ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FzdC5yYiBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FzdC5yYgppbmRleCAwMDlmZWFjNTY0NDUu LjI5MDc5ZjM5YzAxOCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVh c20vYXN0LnJiCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FzdC5yYgpA QCAtMTE2Myw3ICsxMTYzLDkgQEAgY2xhc3MgTGFiZWxSZWZlcmVuY2UgPCBOb2RlCiAgICAgZW5k CiAgICAgCiAgICAgZGVmIG1hcENoaWxkcmVuCi0gICAgICAgIExhYmVsUmVmZXJlbmNlLm5ldyhj b2RlT3JpZ2luLCAoeWllbGQgQGxhYmVsKSkKKyAgICAgICAgcmVzdWx0ID0gTGFiZWxSZWZlcmVu Y2UubmV3KGNvZGVPcmlnaW4sICh5aWVsZCBAbGFiZWwpKQorICAgICAgICByZXN1bHQub2Zmc2V0 ID0gQG9mZnNldAorICAgICAgICByZXN1bHQKICAgICBlbmQKICAgICAKICAgICBkZWYgbmFtZQpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vbWlwcy5yYiBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIKaW5kZXggMTg1NDM1MjU0NDVi Li40MWI4YjlmYTdiOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5l YXNtL21pcHMucmIKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vbWlwcy5y YgpAQCAtMTA1MCwxMiArMTA1MCw5IEBAIGNsYXNzIEluc3RydWN0aW9uCiAgICAgICAgIHdoZW4g ImxlYWkiLCAibGVhcCIKICAgICAgICAgICAgIGlmIG9wZXJhbmRzWzBdLmlzX2E/IExhYmVsUmVm ZXJlbmNlCiAgICAgICAgICAgICAgICAgbGFiZWxSZWYgPSBvcGVyYW5kc1swXQorICAgICAgICAg ICAgICAgICRhc20ucHV0cyAibHcgI3tvcGVyYW5kc1sxXS5taXBzT3BlcmFuZH0sICVnb3QoI3ts YWJlbFJlZi5hc21MYWJlbH0pKCRncCkiCiAgICAgICAgICAgICAgICAgaWYgbGFiZWxSZWYub2Zm c2V0ID4gMAotICAgICAgICAgICAgICAgICAgICAkYXNtLnB1dHMgImxpICN7b3BlcmFuZHNbMV0u bWlwc09wZXJhbmR9LCAje2xhYmVsUmVmLmFzbUxhYmVsfSIKICAgICAgICAgICAgICAgICAgICAg JGFzbS5wdXRzICJhZGR1ICN7b3BlcmFuZHNbMV0ubWlwc09wZXJhbmR9LCAje29wZXJhbmRzWzFd Lm1pcHNPcGVyYW5kfSwgI3tsYWJlbFJlZi5vZmZzZXR9IgotICAgICAgICAgICAgICAgICAgICAk YXNtLnB1dHMgImx3ICN7b3BlcmFuZHNbMV0ubWlwc09wZXJhbmR9LCAlZ290KCN7b3BlcmFuZHNb MV0ubWlwc09wZXJhbmR9KSgkZ3ApIgotICAgICAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAg ICAgICAgICAgJGFzbS5wdXRzICJsdyAje29wZXJhbmRzWzFdLm1pcHNPcGVyYW5kfSwgJWdvdCgj e2xhYmVsUmVmLmFzbUxhYmVsfSkoJGdwKSIKICAgICAgICAgICAgICAgICBlbmQKICAgICAgICAg ICAgIGVsc2UKICAgICAgICAgICAgICAgICBvcGVyYW5kc1swXS5taXBzRW1pdExlYShvcGVyYW5k c1sxXSkK 409580 2020-09-24 08:51:24 -0700 2020-09-24 09:25:38 -0700 Patch bug-216893-20200924155122.patch text/plain 3972 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl MDJiMDBkZGE1NGJkNzBkMDA5YjRkMzdmOTMzYjRlMzkxZjNhNjdkLi5hM2E3OWFmNjU2OWZiYTFi ZTNjMDFjMzczM2NiZmRiNjE3YTRiM2NkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSw0MSBAQAorMjAyMC0wOS0yNCAgQW5nZWxvcyBPaWtvbm9tb3BvdWxvcyAgPGFuZ2Vsb3NA aWdhbGlhLmNvbT4KKworICAgICAgICBbTUlQU10gQnJva2VuIGJ1aWxkIGFmdGVyIHIyNjczNzEK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjg5Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgYWRk cmVzc2VzIHR3byBpc3N1ZXMuCisKKyAgICAgICAgRmlyc3QsIHRoZSBmaXggaW4gaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjc3MiB3YXMgbm90CisgICAgICAgIGdl dHRpbmcgZXhlcmNpc2VkLCBiZWNhdXNlIHRoZSBMYWJlbFJlZmVyZW5jZSBvZmZzZXQgd2FzIGFs d2F5cyB6ZXJvLgorCisgICAgICAgIFRoZSByZWFzb24gdGhlIG9mZnNldCB3YXMgemVybyBpcyB0 aGF0IExhYmVsUmVmZXJlbmNlLm1hcENoaWxkcmVuIHdvdWxkIGRpc2NhcmQKKyAgICAgICAgdGhl IG9mZnNldCB3aGVuIGdlbmVyYXRpbmcgYSBuZXcgTGFiZWxSZWZlcmVuY2UgdG8gd3JhcCB0aGUg TGFiZWwgcmV0dXJuZWQgYnkKKyAgICAgICAgdGhlIGNvZGUgYmxvY2sgaXQgeWllbGRlZCB0by4K KworICAgICAgICBUaGUgcmVhc29uIHRoaXMgd2FzIG9ubHkgYW4gaXNzdWUgb24gTUlQUyBpcyBi ZWNhdXNlIG9ubHkgTUlQUyB3YXMgdXNpbmcgdGhlCisgICAgICAgIHJlc3VsdCBvZiBjYWxscyB0 byBMYWJlbFJlZmVyZW5jZS5tYXBDaGlsZHJlbiAoaW4gaXRzIGxvd2VyaW5nIHBoYXNlLAorICAg ICAgICBhc3NpZ25SZWdpc3RlcnNUb1RlbXBvcmFyaWVzIC0+IHJlcGxhY2VUZW1wb3Jhcmllc1dp dGhSZWdpc3RlcnMgLT4KKyAgICAgICAgbWFwQ2hpbGRyZW4pLiBPdGhlciBhcmNocywgZS5nLiBY ODZfNjQgb25seSBjYWxsIG1hcENoaWxkcmVuIGluIGVhcmxpZXIgcGhhc2VzCisgICAgICAgIChz cGVjaWZpY2FsbHksIHN1YnNlcXVlbnQgdG8gYSBjYWxsIHRvIGlzQVNURXJyb25lb3VzKSwgaW4g d2hpY2ggdGhlIG5ldworICAgICAgICBMYWJlbFJlZmVyZW5jZXMgcmV0dXJuZWQgYnkgbWFwQ2hp bGRyZW4gYXJlIGxhdGVyIGRpc2NhcmRlZC4gRXZlbiB0aG91Z2ggQVJNCisgICAgICAgIDMyLzY0 IGNvbnRhaW5zIGluZGlyZWN0IGNhbGxzIHRvIG1hcENoaWxkcmVuLCB0aG9zZSBhcmUgbWFkZSBh ZnRlciB0aGUKKyAgICAgICAgYXJteyw2NH1Mb3dlckxhYmVsUmVmZXJlbmNlcyB0cmFuc2Zvcm1h dGlvbiB3aGljaCBkb2Vzbid0IGxlYXZlIGFueQorICAgICAgICBMYWJlbFJlZmVyZW5jZSBub2Rl cyBhcm91bmQgZm9yIC5tYXBDaGlsZHJlbiB0byBiZSBjYWxsZWQgb24uCisKKyAgICAgICAgU28g dGhpcyBpcyBub3QgYW4gaXNzdWUgZm9yIGFyY2hpdGVjdHVyZXMgb3RoZXIgdGhhbiBNSVBTIGJl Y2F1c2UKKyAgICAgICAgKGEpIEFkZEltbWVkaWF0ZXMuZm9sZCBjb3JyZWN0bHkgY29uc3RydWN0 cyBhIExhYmVsUmVmZXJlbmNlIHdpdGggYW4gb2Zmc2V0IGJ5CisgICAgICAgIGNhbGxpbmcgTGFi ZWxSZWZlcmVuY2UucGx1c09mZnNldCBhbmQKKyAgICAgICAgKGIpIHRoZXkgZG9uJ3QgY2FsbCAo YW5kIHRoZXJlZm9yZSBkb24ndCB1c2UgdGhlIHJlc3VsdCBvZikKKyAgICAgICAgTGFiZWxSZWZl cmVuY2UubWFwQ2hpbGRyZW4gaW4gdGhlaXIgbG93ZXJpbmcgY29kZS4KKworICAgICAgICBTZWNv bmQsIHRoZSBjb2RlIHdlIGdlbmVyYXRlIG5lZWRzIHRvIGxvb2sgdXAgdGhlIC9sYWJlbC8gaW4g dGhlIEdPVCwgbm90IHRoZQorICAgICAgICBjb21wdXRlZCBhZGRyZXNzLiBBZnRlciB0aGUgbG9v a3VwLCB3ZSBzaW1wbHkgbmVlZCB0byBhZGQgdGhlIG9mZnNldC4KKworICAgICAgICAqIG9mZmxp bmVhc20vYXN0LnJiOgorICAgICAgICAqIG9mZmxpbmVhc20vbWlwcy5yYjoKKwogMjAyMC0wOS0y MiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIEVu YWJsZSBJbnRsLkRhdGVUaW1lRm9ybWF0IGRheVBlcmlvZApkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXN0LnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29m ZmxpbmVhc20vYXN0LnJiCmluZGV4IDAwOWZlYWM1NjQ0NTdmY2ZjZDM0Mjg1ZWYzNGViNzFjZjY0 OWIyMWUuLjI5MDc5ZjM5YzAxODYxMjc3YjYwNDAzN2Q0MWM4MjdlMjE3ODQwZTkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FzdC5yYgorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9hc3QucmIKQEAgLTExNjMsNyArMTE2Myw5IEBAIGNs YXNzIExhYmVsUmVmZXJlbmNlIDwgTm9kZQogICAgIGVuZAogICAgIAogICAgIGRlZiBtYXBDaGls ZHJlbgotICAgICAgICBMYWJlbFJlZmVyZW5jZS5uZXcoY29kZU9yaWdpbiwgKHlpZWxkIEBsYWJl bCkpCisgICAgICAgIHJlc3VsdCA9IExhYmVsUmVmZXJlbmNlLm5ldyhjb2RlT3JpZ2luLCAoeWll bGQgQGxhYmVsKSkKKyAgICAgICAgcmVzdWx0Lm9mZnNldCA9IEBvZmZzZXQKKyAgICAgICAgcmVz dWx0CiAgICAgZW5kCiAgICAgCiAgICAgZGVmIG5hbWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2Zm bGluZWFzbS9taXBzLnJiCmluZGV4IDE4NTQzNTI1NDQ1YjM1OGRhMTllNTNkNDE0MTg4YzJkMmM2 ZDZhZDguLjQxYjhiOWZhN2I5ZDllNTMzNTY2YmYyZDBhMThlYTA4NzQ3ZjBkNzkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vbWlwcy5yYgpAQCAtMTA1MCwxMiArMTA1MCw5IEBA IGNsYXNzIEluc3RydWN0aW9uCiAgICAgICAgIHdoZW4gImxlYWkiLCAibGVhcCIKICAgICAgICAg ICAgIGlmIG9wZXJhbmRzWzBdLmlzX2E/IExhYmVsUmVmZXJlbmNlCiAgICAgICAgICAgICAgICAg bGFiZWxSZWYgPSBvcGVyYW5kc1swXQorICAgICAgICAgICAgICAgICRhc20ucHV0cyAibHcgI3tv cGVyYW5kc1sxXS5taXBzT3BlcmFuZH0sICVnb3QoI3tsYWJlbFJlZi5hc21MYWJlbH0pKCRncCki CiAgICAgICAgICAgICAgICAgaWYgbGFiZWxSZWYub2Zmc2V0ID4gMAotICAgICAgICAgICAgICAg ICAgICAkYXNtLnB1dHMgImxpICN7b3BlcmFuZHNbMV0ubWlwc09wZXJhbmR9LCAje2xhYmVsUmVm LmFzbUxhYmVsfSIKICAgICAgICAgICAgICAgICAgICAgJGFzbS5wdXRzICJhZGR1ICN7b3BlcmFu ZHNbMV0ubWlwc09wZXJhbmR9LCAje29wZXJhbmRzWzFdLm1pcHNPcGVyYW5kfSwgI3tsYWJlbFJl Zi5vZmZzZXR9IgotICAgICAgICAgICAgICAgICAgICAkYXNtLnB1dHMgImx3ICN7b3BlcmFuZHNb MV0ubWlwc09wZXJhbmR9LCAlZ290KCN7b3BlcmFuZHNbMV0ubWlwc09wZXJhbmR9KSgkZ3ApIgot ICAgICAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICAgICAgJGFzbS5wdXRzICJsdyAj e29wZXJhbmRzWzFdLm1pcHNPcGVyYW5kfSwgJWdvdCgje2xhYmVsUmVmLmFzbUxhYmVsfSkoJGdw KSIKICAgICAgICAgICAgICAgICBlbmQKICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAg ICBvcGVyYW5kc1swXS5taXBzRW1pdExlYShvcGVyYW5kc1sxXSkK