216879 2020-09-23 07:24:53 -0700 REGRESSION(r267368) [webkitpy] autoinstalled pytest raises ImportError in run-webdriver-tests 2020-09-23 08:58:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=215889 InRadar P2 Normal --- 1 lmoura lmoura aakash_jain ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1691099 0 lmoura 2020-09-23 07:24:53 -0700 After r267368, run-webdriver-tests fails with the following trace: Traceback (most recent call last): File "/app/webkit/Tools/Scripts/run-webdriver-tests", line 85, in <module> runner.run(args) File "/app/webkit/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py", line 70, in run runner_tests = [runner.collect_tests(tests) for runner in self._runners] File "/app/webkit/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py", line 51, in collect_tests executor = WebDriverSeleniumExecutor(self._driver, self._env) File "/app/webkit/Tools/Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py", line 57, in __init__ do_delayed_imports() File "/app/webkit/Tools/Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py", line 35, in do_delayed_imports import webkitpy.webdriver_tests.pytest_runner as pytest_runner File "/app/webkit/Tools/Scripts/webkitpy/webdriver_tests/pytest_runner.py", line 32, in <module> import webkitpy.thirdparty.autoinstalled.pytest File "/app/webkit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pytest.py", line 9, in <module> from _pytest.config import main, UsageError, cmdline, hookspec, hookimpl File "/app/webkit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/_pytest/config/__init__.py", line 10, in <module> import py ImportError: No module named py Likely because WebDriver's pytest relied on mozlog/mozprocess calls to `self._ensure_autoinstalled_dir_is_in_sys_path()` to inject the autoinstalled path. 1691102 1 409473 lmoura 2020-09-23 07:35:49 -0700 Created attachment 409473 Patch 1691117 2 409473 jbedard 2020-09-23 08:28:49 -0700 Comment on attachment 409473 Patch Sorry I broke this! 1691129 3 ews-feeder 2020-09-23 08:57:17 -0700 Committed r267478: <https://trac.webkit.org/changeset/267478> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409473. 1691131 4 webkit-bug-importer 2020-09-23 08:58:17 -0700 <rdar://problem/69438604> 409473 2020-09-23 07:35:49 -0700 2020-09-23 08:57:17 -0700 Patch bug-216879-20200923113547.patch text/plain 1802 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NDcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjJhNDUyMmZhZjNkZDc3NWU4ODQ3MGY0NzlmMzc4ZTJm M2IzMzNkNi4uZmQ0OTBkNGFjN2U3ZjU3YzY3ZjY4Y2I1OGNhYjEzNWE1ZGRkOTQyYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIwLTA5LTIzICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjI2NzM2OCkgW3dlYmtpdHB5XSBhdXRvaW5zdGFsbGVkIHB5dGVzdCBy YWlzZXMgSW1wb3J0RXJyb3IgaW4gcnVuLXdlYmRyaXZlci10ZXN0cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2ODc5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXV0b2luc3RhbGxlZCBweXRlc3QgcmVx dWlyZXMgc3lzLnBhdGggdG8gYmUgdXBkYXRlZCB3aXRoIHRoZSBuZXdseQorICAgICAgICBpbnN0 YWxsZWQgcGFja2FnZXMuIEJlZm9yZSByMjY3MzY4IGl0IHdvcmtlZCBiZWNhdXNlCisgICAgICAg IHdlYmRyaXZlcl93M2NfZXhlY3V0b3IucHkgYXV0b2luc3RhbGxlZCBtb3psb2cvbW96cHJvY2Vz cyB3aGljaAorICAgICAgICB1cGRhdGVkIHRoZSBzeXMucGF0aC4KKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weToKKyAgICAgICAgKEF1dG9pbnN0YWxs SW1wb3J0SG9vay5faW5zdGFsbF9weXRlc3QpOgorCiAyMDIwLTA5LTIyICBLZWl0aCBSb2xsaW4g IDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAgICAgICBVbmlmeSBkZWJ1ZyBhbmQgcmVsZWFzZSB0 YXJnZXQgYWxpYXNlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90aGlyZHBh cnR5L19faW5pdF9fLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90aGlyZHBhcnR5L19faW5p dF9fLnB5CmluZGV4IDNhMGRkYzZjMmY2Yjk3M2IyYjMzOWEwNDYwNmI3OTVlZTEzYWQxZGYuLjgy YjU0YTYyODdjODRmYTJhODJlMDI1MjEzYmU5YjdlOTRmY2E5ODkgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3RoaXJkcGFydHkvX19pbml0X18ucHkKQEAgLTE0NCw2ICsxNDQsNyBAQCBj bGFzcyBBdXRvaW5zdGFsbEltcG9ydEhvb2sob2JqZWN0KToKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICJweXRlc3QtdGltZW91dC0xLjIuMC9weXRlc3RfdGltZW91dC5weSIpCiAKICAg ICBkZWYgX2luc3RhbGxfcHl0ZXN0KHNlbGYpOgorICAgICAgICBzZWxmLl9lbnN1cmVfYXV0b2lu c3RhbGxlZF9kaXJfaXNfaW5fc3lzX3BhdGgoKQogICAgICAgICBzZWxmLl9pbnN0YWxsKCJodHRw czovL2ZpbGVzLnB5dGhvbmhvc3RlZC5vcmcvcGFja2FnZXMvOTAvZTMvZTA3NTEyN2QzOWQzNWYw OWE1MDBlYmI0YTkwYWZkMTBmOWVmMGExZDI4YTZkMDlhYmVlYzBlNDQ0ZmRkL3B5LTEuNS4yLnRh ci5neiIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAicHktMS41LjIvcHkiKQogICAg ICAgICBzZWxmLl9pbnN0YWxsKCJodHRwczovL2ZpbGVzLnB5dGhvbmhvc3RlZC5vcmcvcGFja2Fn ZXMvMTEvYmYvY2JlYjhjZGZhZmZhOWYyZWExNTRhMzBhZTMxYTlkMDRhMTIwOTMxMmUyOTE5MTM4 YjQxNzFhMWY4MTk5L3BsdWdneS0wLjYuMC50YXIuZ3oiLAo=