216875 2020-09-23 06:12:23 -0700 Root node with stateless wheel event is not always canHandleWheelEvent 2020-09-24 05:53:18 -0700 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=216609 InRadar P2 Normal --- 1 cathiechen cathiechen cmarcelo ews-watchlist fred.wang jamesr luiz simon.fraser tonikitoo webkit-bug-importer oldest_to_newest 1691085 0 cathiechen 2020-09-23 06:12:23 -0700 This bug is split from bug 216609 1691086 1 409468 cathiechen 2020-09-23 06:17:39 -0700 Created attachment 409468 Patch 1691238 2 409468 simon.fraser 2020-09-23 13:13:17 -0700 Comment on attachment 409468 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409468&action=review > Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:148 > + if (isLatchedNode() || (isRootNode() && !(wheelEvent.phase() == PlatformWheelEventPhaseNone && wheelEvent.momentumPhase() == PlatformWheelEventPhaseNone))) This should use isNonGestureEvent() 1691422 3 409468 cathiechen 2020-09-24 01:26:36 -0700 Comment on attachment 409468 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409468&action=review >> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:148 >> + if (isLatchedNode() || (isRootNode() && !(wheelEvent.phase() == PlatformWheelEventPhaseNone && wheelEvent.momentumPhase() == PlatformWheelEventPhaseNone))) > > This should use isNonGestureEvent() Done, thanks! 1691423 4 409540 cathiechen 2020-09-24 01:27:43 -0700 Created attachment 409540 Patch 1691482 5 ews-feeder 2020-09-24 05:52:40 -0700 Committed r267527: <https://trac.webkit.org/changeset/267527> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409540. 1691483 6 webkit-bug-importer 2020-09-24 05:53:18 -0700 <rdar://problem/69498046> 409468 2020-09-23 06:17:39 -0700 2020-09-24 01:27:37 -0700 Patch bug-216875-20200923211737.patch text/plain 1941 cathiechen U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGYyODkzZTE3Yjc3NGJh MzNlZTA0NWU3OWZkMDE2MjFiNDAxMTllNC4uYzM0NjU4OWQ1Y2RkMGYxYTI2ZWMxMmUzNDk4OWMx M2NjYWM1OGU1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA5LTIzICBDYXRo aWUgQ2hlbiAgPGNhdGhpZWNoZW5AaWdhbGlhLmNvbT4KKworICAgICAgICBSb290IG5vZGUgd2l0 aCBzdGF0ZWxlc3Mgd2hlZWwgZXZlbnQgaXNuJ3QgYWx3YXlzIHNjcm9sbGFibGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjg3NQorCisgICAgICAg IFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KKworICAgICAgICBSb290IG5vZGVzIGFyZSBub3Qg YWx3YXlzIGNhcGFibGUgb2YgaGFuZGxpbmcgd2hlZWwgZXZlbnQuIFdoZW4gaXQgaXMgYSBzdGF0 ZWxlc3Mgd2hlZWwgZXZlbnQgd2hpY2gKKyAgICAgICAgZG9lcyBub3QgdHJpZ2dlciBydWJiZXIt YmFuZCwgd2Ugc2hvdWxkIGNoZWNrIHRoZSBzY3JvbGwgY29udGVudCBvZiB0aGUgcm9vdCBub2Rl LgorCisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGU6OmNhbkhh bmRsZVdoZWVsRXZlbnQgY29uc3QpOiBTdGF0ZWxlc3Mgd2hlZWwgZXZlbnQKKyAgICAgICAgZG9l c24ndCB0cmlnZ2VyIHJ1YmJlci1iYW5kLCBzaG91bGQgY2hlY2sgdGhlIHNjcm9sbCBjb250ZW50 LgorCiAyMDIwLTA5LTIzICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkLCBwcm9zcGVjdGl2ZSBHVEsgYnVpbGQgZml4IGFmdGVyIHIy Njc0NDkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxp bmdUcmVlU2Nyb2xsaW5nTm9kZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9T Y3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kZS5jcHAKaW5kZXggN2JlNzVlMmUzYTg2OTE1YTE4OTQ2 Y2VlYTYyMzEyZTBjM2RhMjdkMy4uYzFhYWVmZWYxNTEzMzYxMTExNTYwNjkxZmQ2NmVmODIxNjM4 ZWUwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5n VHJlZVNjcm9sbGluZ05vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5n L1Njcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlLmNwcApAQCAtMTQ0LDkgKzE0NCwxMCBAQCBib29s IFNjcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlOjpjYW5IYW5kbGVXaGVlbEV2ZW50KGNvbnN0IFBs YXRmb3JtV2hlZWxFdmVudCYgdwogICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIC8vIFdlIGFs d2F5cyBydWJiZXItYmFuZCB0aGUgbGF0Y2hlZCBub2RlLCBvciB0aGUgcm9vdCBub2RlLgotICAg IGlmIChpc0xhdGNoZWROb2RlKCkgfHwgaXNSb290Tm9kZSgpKQorICAgIC8vIFRoZSBzdGF0ZWxl c3Mgd2hlZWwgZXZlbnQgZG9lc24ndCB0cmlnZ2VyIHJ1YmJlci1iYW5kLgorICAgIGlmIChpc0xh dGNoZWROb2RlKCkgfHwgKGlzUm9vdE5vZGUoKSAmJiAhKHdoZWVsRXZlbnQucGhhc2UoKSA9PSBQ bGF0Zm9ybVdoZWVsRXZlbnRQaGFzZU5vbmUgJiYgd2hlZWxFdmVudC5tb21lbnR1bVBoYXNlKCkg PT0gUGxhdGZvcm1XaGVlbEV2ZW50UGhhc2VOb25lKSkpCiAgICAgICAgIHJldHVybiB0cnVlOwot ICAgIAorCiAgICAgcmV0dXJuIGV2ZW50Q2FuU2Nyb2xsQ29udGVudHMod2hlZWxFdmVudCk7CiB9 CiAK 409540 2020-09-24 01:27:43 -0700 2020-09-24 05:52:41 -0700 Patch bug-216875-20200924162740.patch text/plain 1859 cathiechen U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGYyODkzZTE3Yjc3NGJh MzNlZTA0NWU3OWZkMDE2MjFiNDAxMTllNC4uYzM0NjU4OWQ1Y2RkMGYxYTI2ZWMxMmUzNDk4OWMx M2NjYWM1OGU1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA5LTIzICBDYXRo aWUgQ2hlbiAgPGNhdGhpZWNoZW5AaWdhbGlhLmNvbT4KKworICAgICAgICBSb290IG5vZGUgd2l0 aCBzdGF0ZWxlc3Mgd2hlZWwgZXZlbnQgaXNuJ3QgYWx3YXlzIHNjcm9sbGFibGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjg3NQorCisgICAgICAg IFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KKworICAgICAgICBSb290IG5vZGVzIGFyZSBub3Qg YWx3YXlzIGNhcGFibGUgb2YgaGFuZGxpbmcgd2hlZWwgZXZlbnQuIFdoZW4gaXQgaXMgYSBzdGF0 ZWxlc3Mgd2hlZWwgZXZlbnQgd2hpY2gKKyAgICAgICAgZG9lcyBub3QgdHJpZ2dlciBydWJiZXIt YmFuZCwgd2Ugc2hvdWxkIGNoZWNrIHRoZSBzY3JvbGwgY29udGVudCBvZiB0aGUgcm9vdCBub2Rl LgorCisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGU6OmNhbkhh bmRsZVdoZWVsRXZlbnQgY29uc3QpOiBTdGF0ZWxlc3Mgd2hlZWwgZXZlbnQKKyAgICAgICAgZG9l c24ndCB0cmlnZ2VyIHJ1YmJlci1iYW5kLCBzaG91bGQgY2hlY2sgdGhlIHNjcm9sbCBjb250ZW50 LgorCiAyMDIwLTA5LTIzICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkLCBwcm9zcGVjdGl2ZSBHVEsgYnVpbGQgZml4IGFmdGVyIHIy Njc0NDkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxp bmdUcmVlU2Nyb2xsaW5nTm9kZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9T Y3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kZS5jcHAKaW5kZXggN2JlNzVlMmUzYTg2OTE1YTE4OTQ2 Y2VlYTYyMzEyZTBjM2RhMjdkMy4uMDg4N2I5ZDBmZTFjNGNhYjQ0Y2RmODRmYWY3ZDU0MTE2NmM4 MjNmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5n VHJlZVNjcm9sbGluZ05vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5n L1Njcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlLmNwcApAQCAtMTQ0LDkgKzE0NCwxMCBAQCBib29s IFNjcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlOjpjYW5IYW5kbGVXaGVlbEV2ZW50KGNvbnN0IFBs YXRmb3JtV2hlZWxFdmVudCYgdwogICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIC8vIFdlIGFs d2F5cyBydWJiZXItYmFuZCB0aGUgbGF0Y2hlZCBub2RlLCBvciB0aGUgcm9vdCBub2RlLgotICAg IGlmIChpc0xhdGNoZWROb2RlKCkgfHwgaXNSb290Tm9kZSgpKQorICAgIC8vIFRoZSBzdGF0ZWxl c3Mgd2hlZWwgZXZlbnQgZG9lc24ndCB0cmlnZ2VyIHJ1YmJlci1iYW5kLgorICAgIGlmIChpc0xh dGNoZWROb2RlKCkgfHwgKGlzUm9vdE5vZGUoKSAmJiAhd2hlZWxFdmVudC5pc05vbkdlc3R1cmVF dmVudCgpKSkKICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgCisKICAgICByZXR1cm4gZXZlbnRD YW5TY3JvbGxDb250ZW50cyh3aGVlbEV2ZW50KTsKIH0KIAo=