216866 2020-09-22 19:48:59 -0700 [LFC][Floats] Remove the redundant RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled() check from FloatingState::append 2020-09-22 21:28:04 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1690998 0 zalan 2020-09-22 19:48:59 -0700 ssia 1690999 1 409446 zalan 2020-09-22 20:00:28 -0700 Created attachment 409446 Patch 1691000 2 409446 simon.fraser 2020-09-22 20:02:54 -0700 Comment on attachment 409446 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409446&action=review > Source/WebCore/layout/floats/FloatingState.cpp:68 > + ASSERT(!floatItem.floatBox() || m_floats.findMatching([&] (auto& entry) { ASSERT_IMPLIES(floatItem.floatBox(), ....) ? 1691001 3 zalan 2020-09-22 20:05:47 -0700 (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 409446 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409446&action=review > > > Source/WebCore/layout/floats/FloatingState.cpp:68 > > + ASSERT(!floatItem.floatBox() || m_floats.findMatching([&] (auto& entry) { > > ASSERT_IMPLIES(floatItem.floatBox(), ....) ? good point! 1691004 4 409447 zalan 2020-09-22 20:07:47 -0700 Created attachment 409447 Patch 1691016 5 ews-feeder 2020-09-22 20:48:26 -0700 Committed r267460: <https://trac.webkit.org/changeset/267460> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409447. 1691022 6 webkit-bug-importer 2020-09-22 21:28:04 -0700 <rdar://problem/69412318> 409446 2020-09-22 20:00:28 -0700 2020-09-22 20:07:46 -0700 Patch bug-216866-20200922200027.patch text/plain 2463 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2IyNjliZGZmYjNjOGZm YTE1YWRlNWE5NDAyYTkyMDU4YWJiN2UxZC4uZWNkZWU1OWI1ZjRhMTc5NDBiYmJhM2YwNmQ5MzIw OGFiYjFkNGZlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA5LTIyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bRmxvYXRzXSBSZW1v dmUgdGhlIHJlZHVuZGFudCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpsYXlvdXRGb3JtYXR0aW5n Q29udGV4dEludGVncmF0aW9uRW5hYmxlZCgpIGNoZWNrIGZyb20gRmxvYXRpbmdTdGF0ZTo6YXBw ZW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY4 NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg bm8tbGF5b3V0LWJveC1mb3ItdGhlLUZsb2F0SXRlbSBjb2RlcGF0aCBpcyByZXNlcnZlZCBmb3Ig dGhlIElGQyBpbnRlZ3JhdGlvbi4gVGhpcyBpcyB0ZW1wb3JhcnkgYW55d2F5LgorCisgICAgICAg ICogbGF5b3V0L2Zsb2F0cy9GbG9hdGluZ1N0YXRlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okxh eW91dDo6RmxvYXRpbmdTdGF0ZTo6YXBwZW5kKToKKwogMjAyMC0wOS0yMiAgWmFsYW4gQnVqdGFz ICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0ludGVncmF0aW9uXSBNb3ZlIFJ1 bnRpbWVFbmFibGVkRmVhdHVyZXM6OmxheW91dEZvcm1hdHRpbmdDb250ZXh0SW50ZWdyYXRpb25F bmFibGVkKCkgY2hlY2sgb3V0IGZyb20gTGluZUJ1aWxkZXI6OmNvbnN0cmFpbnRzRm9yTGluZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zsb2F0cy9GbG9hdGluZ1N0YXRlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mbG9hdHMvRmxvYXRpbmdTdGF0ZS5jcHAKaW5kZXgg ODU2Y2U1NTQ2OTY3MWJkYTNlZmMyOWVmOTBjYTYyMjM5MmZhMGNiZi4uMWRmMzAwODg4ZjVjODg4 ZTc2NTY0Njg5N2VkZWE0OTMxODU4ZWM1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2Zsb2F0cy9GbG9hdGluZ1N0YXRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv ZmxvYXRzL0Zsb2F0aW5nU3RhdGUuY3BwCkBAIC02MSwxOSArNjEsMTQgQEAgRmxvYXRpbmdTdGF0 ZTo6RmxvYXRpbmdTdGF0ZShMYXlvdXRTdGF0ZSYgbGF5b3V0U3RhdGUsIGNvbnN0IENvbnRhaW5l ckJveCYgZm9ybWEKIAogdm9pZCBGbG9hdGluZ1N0YXRlOjphcHBlbmQoRmxvYXRJdGVtIGZsb2F0 SXRlbSkKIHsKLSAgICBBU1NFUlQoaXM8Q29udGFpbmVyQm94PigqbV9mb3JtYXR0aW5nQ29udGV4 dFJvb3QpKTsKLSNpZiBBU1NFUlRfRU5BQkxFRAotICAgIGlmICghUnVudGltZUVuYWJsZWRGZWF0 dXJlczo6c2hhcmVkRmVhdHVyZXMoKS5sYXlvdXRGb3JtYXR0aW5nQ29udGV4dEludGVncmF0aW9u RW5hYmxlZCgpKSB7Ci0gICAgICAgIC8vIFRoZSBpbnRlZ3JhdGlvbiBjb2RlcGF0aCBkb2VzIG5v dCBjb25zdHJ1Y3QgYSBsYXlvdXQgYm94IGZvciB0aGUgZmxvYXQgaXRlbS4KLSAgICAgICAgQVNT RVJUKG1fZmxvYXRzLmZpbmRNYXRjaGluZyhbJl0gKGF1dG8mIGVudHJ5KSB7Ci0gICAgICAgICAg ICByZXR1cm4gZW50cnkuZmxvYXRCb3goKSA9PSBmbG9hdEl0ZW0uZmxvYXRCb3goKTsKLSAgICAg ICAgfSkgPT0gbm90Rm91bmQpOwotICAgIH0KLSNlbmRpZgotCiAgICAgaWYgKG1fZmxvYXRzLmlz RW1wdHkoKSkKICAgICAgICAgcmV0dXJuIG1fZmxvYXRzLmFwcGVuZChmbG9hdEl0ZW0pOwogCisg ICAgLy8gVGhlIGludGVncmF0aW9uIGNvZGVwYXRoIGRvZXMgbm90IGNvbnN0cnVjdCBhIGxheW91 dCBib3ggZm9yIHRoZSBmbG9hdCBpdGVtLgorICAgIEFTU0VSVCghZmxvYXRJdGVtLmZsb2F0Qm94 KCkgfHwgbV9mbG9hdHMuZmluZE1hdGNoaW5nKFsmXSAoYXV0byYgZW50cnkpIHsKKyAgICAgICAg cmV0dXJuIGVudHJ5LmZsb2F0Qm94KCkgPT0gZmxvYXRJdGVtLmZsb2F0Qm94KCk7CisgICAgfSkg PT0gbm90Rm91bmQpOworCiAgICAgYXV0byBpc0xlZnRQb3NpdGlvbmVkID0gZmxvYXRJdGVtLmlz TGVmdFBvc2l0aW9uZWQoKTsKICAgICAvLyBXaGVuIGFkZGluZyBhIG5ldyBmbG9hdCBpdGVtIHRv IHRoZSBsaXN0LCB3ZSBoYXZlIHRvIGVuc3VyZSB0aGF0IGl0IGlzIGRlZmluaXRlbHkgdGhlIGxl ZnQocmlnaHQpLW1vc3QgaXRlbS4KICAgICAvLyBOb3JtYWxseSBpdCBpcywgYnV0IG5lZ2F0aXZl IGhvcml6b250YWwgbWFyZ2lucyBjYW4gcHVzaCB0aGUgZmxvYXQgYm94IGJleW9uZCBhbm90aGVy IGZsb2F0IGJveC4K 409447 2020-09-22 20:07:47 -0700 2020-09-22 20:48:27 -0700 Patch bug-216866-20200922200746.patch text/plain 2466 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2IyNjliZGZmYjNjOGZm YTE1YWRlNWE5NDAyYTkyMDU4YWJiN2UxZC4uMzA4OTc0MzBiMTZhMWYwNDE2NzQ3YzkyNmRlNGI0 YTU2MTJiZWM0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA5LTIyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bRmxvYXRzXSBSZW1v dmUgdGhlIHJlZHVuZGFudCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpsYXlvdXRGb3JtYXR0aW5n Q29udGV4dEludGVncmF0aW9uRW5hYmxlZCgpIGNoZWNrIGZyb20gRmxvYXRpbmdTdGF0ZTo6YXBw ZW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY4 NjYKKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAgVGhlIG5v LWxheW91dC1ib3gtZm9yLXRoZS1GbG9hdEl0ZW0gY29kZXBhdGggaXMgcmVzZXJ2ZWQgZm9yIHRo ZSBJRkMgaW50ZWdyYXRpb24uIFRoaXMgaXMgdGVtcG9yYXJ5IGFueXdheS4KKworICAgICAgICAq IGxheW91dC9mbG9hdHMvRmxvYXRpbmdTdGF0ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlv dXQ6OkZsb2F0aW5nU3RhdGU6OmFwcGVuZCk6CisKIDIwMjAtMDktMjIgIFphbGFuIEJ1anRhcyAg PHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gTW92ZSBSdW50 aW1lRW5hYmxlZEZlYXR1cmVzOjpsYXlvdXRGb3JtYXR0aW5nQ29udGV4dEludGVncmF0aW9uRW5h YmxlZCgpIGNoZWNrIG91dCBmcm9tIExpbmVCdWlsZGVyOjpjb25zdHJhaW50c0ZvckxpbmUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mbG9hdHMvRmxvYXRpbmdTdGF0ZS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZmxvYXRzL0Zsb2F0aW5nU3RhdGUuY3BwCmluZGV4IDg1 NmNlNTU0Njk2NzFiZGEzZWZjMjllZjkwY2E2MjIzOTJmYTBjYmYuLmNmZjljNDA0MGJmNGY4Nzgw MzZmN2Q1MDIxMDVhY2NhMzBiNWQ5NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9mbG9hdHMvRmxvYXRpbmdTdGF0ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zs b2F0cy9GbG9hdGluZ1N0YXRlLmNwcApAQCAtNjEsMTkgKzYxLDE0IEBAIEZsb2F0aW5nU3RhdGU6 OkZsb2F0aW5nU3RhdGUoTGF5b3V0U3RhdGUmIGxheW91dFN0YXRlLCBjb25zdCBDb250YWluZXJC b3gmIGZvcm1hCiAKIHZvaWQgRmxvYXRpbmdTdGF0ZTo6YXBwZW5kKEZsb2F0SXRlbSBmbG9hdEl0 ZW0pCiB7Ci0gICAgQVNTRVJUKGlzPENvbnRhaW5lckJveD4oKm1fZm9ybWF0dGluZ0NvbnRleHRS b290KSk7Ci0jaWYgQVNTRVJUX0VOQUJMRUQKLSAgICBpZiAoIVJ1bnRpbWVFbmFibGVkRmVhdHVy ZXM6OnNoYXJlZEZlYXR1cmVzKCkubGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRJbnRlZ3JhdGlvbkVu YWJsZWQoKSkgewotICAgICAgICAvLyBUaGUgaW50ZWdyYXRpb24gY29kZXBhdGggZG9lcyBub3Qg Y29uc3RydWN0IGEgbGF5b3V0IGJveCBmb3IgdGhlIGZsb2F0IGl0ZW0uCi0gICAgICAgIEFTU0VS VChtX2Zsb2F0cy5maW5kTWF0Y2hpbmcoWyZdIChhdXRvJiBlbnRyeSkgewotICAgICAgICAgICAg cmV0dXJuIGVudHJ5LmZsb2F0Qm94KCkgPT0gZmxvYXRJdGVtLmZsb2F0Qm94KCk7Ci0gICAgICAg IH0pID09IG5vdEZvdW5kKTsKLSAgICB9Ci0jZW5kaWYKLQogICAgIGlmIChtX2Zsb2F0cy5pc0Vt cHR5KCkpCiAgICAgICAgIHJldHVybiBtX2Zsb2F0cy5hcHBlbmQoZmxvYXRJdGVtKTsKIAorICAg IC8vIFRoZSBpbnRlZ3JhdGlvbiBjb2RlcGF0aCBkb2VzIG5vdCBjb25zdHJ1Y3QgYSBsYXlvdXQg Ym94IGZvciB0aGUgZmxvYXQgaXRlbS4KKyAgICBBU1NFUlRfSU1QTElFUyhmbG9hdEl0ZW0uZmxv YXRCb3goKSwgbV9mbG9hdHMuZmluZE1hdGNoaW5nKFsmXSAoYXV0byYgZW50cnkpIHsKKyAgICAg ICAgcmV0dXJuIGVudHJ5LmZsb2F0Qm94KCkgPT0gZmxvYXRJdGVtLmZsb2F0Qm94KCk7CisgICAg fSkgPT0gbm90Rm91bmQpOworCiAgICAgYXV0byBpc0xlZnRQb3NpdGlvbmVkID0gZmxvYXRJdGVt LmlzTGVmdFBvc2l0aW9uZWQoKTsKICAgICAvLyBXaGVuIGFkZGluZyBhIG5ldyBmbG9hdCBpdGVt IHRvIHRoZSBsaXN0LCB3ZSBoYXZlIHRvIGVuc3VyZSB0aGF0IGl0IGlzIGRlZmluaXRlbHkgdGhl IGxlZnQocmlnaHQpLW1vc3QgaXRlbS4KICAgICAvLyBOb3JtYWxseSBpdCBpcywgYnV0IG5lZ2F0 aXZlIGhvcml6b250YWwgbWFyZ2lucyBjYW4gcHVzaCB0aGUgZmxvYXQgYm94IGJleW9uZCBhbm90 aGVyIGZsb2F0IGJveC4K